0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use empty() instead of comparing size() with 0.

Browse source 
Issue found by cppcheck.
This commit is contained in:
Mark de Wever 2010-01-03 18:45:12 +00:00
parent 6d7a231dac
commit 41dcb8a823
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/actions.cpp
View file

@ -604,7 +604,7 @@ int battle_context::choose_defender_weapon(const unit &attacker, const unit &def
choices.push_back(i);
}
}
if (choices.size() == 0)
if (choices.empty())
return -1;
if (choices.size() == 1)
return choices[0];
@ -692,7 +692,7 @@ int battle_context::choose_attacker_weapon(const unit &attacker, const unit &def
choices.push_back(i);
}
}
if (choices.size() == 0)
if (choices.empty())
return -1;
if (choices.size() == 1) {
*defender_weapon = choose_defender_weapon(attacker, defender, choices[0], units,
@ -1807,7 +1807,7 @@ void calculate_healing(int side, bool update_display)
healers.push_back(units.find(heal_loc->loc));
}
if (healers.size() > 0) {
if (!healers.empty()) {
DBG_NG << "Unit has " << healers.size() << " potential healers\n";
}
@ -1880,7 +1880,7 @@ void calculate_healing(int side, bool update_display)
healing = neg_max;
}
if (healers.size() > 0) {
if (!healers.empty()) {
DBG_NG << "Just before healing animations, unit has " << healers.size() << " potential healers\n";
}