0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GUI2/Styled Widget: somewhat hacky fix for widgets returning the wrong link after setting a new label

Browse source
This commit is contained in:
Charles Dang 2020-12-17 04:45:41 +11:00
parent f87a2bc4e4
commit 3dd0e32cec
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/gui/widgets/styled_widget.cpp
View file

@ -329,6 +329,15 @@ void styled_widget::set_label(const t_string& label)
set_layout_size(point());
update_canvas();
set_is_dirty(true);
// FIXME: This isn't the most elegant solution. Typically, we don't rely on the text rendering
// cache for anything except size calculations, but since we have link awareness now we need to
// update its text else `get_label_link` will return old results. I'm not actually sure why the
// results seem to only remain one invocation of `set_label` behind the current text, but that
// is what testing revealed (see https://github.com/wesnoth/wesnoth/pull/5363).
//
// -- vultraz, 2020-12-17
renderer_.set_text(label_, use_markup_);
}
void styled_widget::set_use_markup(bool use_markup)