0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add some background info regarding 2010-07-23T06:31:24Z!guillaume.melquiond@gmail.com.

Browse source
This commit is contained in:
Mark de Wever 2010-07-30 21:49:33 +00:00
parent 038bb76d15
commit 3d225ca46a
2 changed files with 41 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
src/tstring.cpp
View file

@ -53,20 +53,6 @@ size_t t_string_base::hash_value() const {
return seed;
}
#ifdef _MSC_VER
t_string_base::walker::walker(const t_string& string) :
string_(string.get().value_),
begin_(0),
end_(string_.size()),
textdomain_(),
translatable_(false)
{
if(string.get().translatable_) {
update();
}
}
#endif
t_string_base::walker::walker(const t_string_base& string) :
string_(string.value_),
begin_(0),
@ -80,6 +66,43 @@ t_string_base::walker::walker(const t_string_base& string) :
}
#ifdef _MSC_VER
/*
* From the IRC log of 23.07.2010
* 07:52 <silene> Upth: what did it break?
* 07:53 <Upth> silene: since that revision, the windows executable crashes
* immediately before loading the main menu
* 07:54 <silene> what kind of crash?
* 07:54 <Upth> assertion failed in the std::string library
* 07:54 <Upth> then "fatal error"
* 07:54 <Upth> and abnormal termination
* 07:54 <silene> which assertion?
* 07:55 <Upth> Expression: ("_Myptr + _Off <= (((_Mystring
* *)this->_Mycont)->_Myptr() + ((_Mystring *)this->_Mycont)->_Mysize) &&
* _Myptr + _Off >= ((_Mystring *)this->_Mycont)->_Myptr()", 0)
* 07:56 <shadowmaster> ugly.
* 07:57 <Upth> in the iterator += overload, called from the iterator +
* overload, called from std::basic_string::end(), called from line 409 of
* parser.cpp in write_key_val
* 07:58 <Upth> err std::basic_string::end() is called from
* t_string::walker::end(), which is called on line 409 of parser.cpp
* 07:58 <silene> that doesn't make sense; as far as i can tell it's a compiler
* bug
* 07:58 <silene> which compiler is that so that the code is made conditional
* on it?
* 07:58 <Upth> MSVC9
*/
t_string_base::walker::walker(const t_string& string) :
string_(string.get().value_),
begin_(0),
end_(string_.size()),
textdomain_(),
translatable_(false)
{
if(string.get().translatable_) {
update();
}
}
t_string_base::walker::walker(const std::string& string) :
string_(string),
begin_(0),

5
src/tstring.hpp
View file

@ -31,7 +31,10 @@ public:
public:
walker(const t_string_base& string);
#ifdef _MSC_VER
// Work around a compiler bug in MSVC 9.
/*
* Work around a compiler bug in MSVC 9 see definition for more
* information.
*/
explicit walker(const std::string&);
walker(const t_string& string);
#endif