0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix possible null pointer dereference in display::init_flags()

Browse source 
Regression from commit 69d7413a75.

Found by Coverity.
This commit is contained in:
Jyrki Vesterinen 2018-04-29 17:23:27 +03:00
parent 06ebcebed5
commit 33fa7d8b76
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/display.cpp
View file

@ -192,10 +192,7 @@ void display::init_flags()
void display::init_flags(std::size_t side_index)
{
const std::size_t num_teams = get_teams().size();
assert(flags_.size() == num_teams);
if(!dc_ || side_index >= num_teams) {
if(!dc_ || side_index >= dc_->teams().size()) {
ERR_DP << "Cannot build flag for nonexistent or unconfigured side " << (side_index + 1) << '\n';
return;
}