0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

check for "new substring of old" to reduce number of false positives

Browse source 
be aware: this can lead to real problems not found but those *should*
be (really seldom) cornercases and gettext will bark when updating the
files
This commit is contained in:
Nils Kneuper 2009-10-07 10:36:09 +00:00
parent b1db96ba95
commit 31a26f643e
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
utils/pofix.py
View file

@ -295,9 +295,12 @@ if __name__ == '__main__':
#complain loudly
print "pofix: old string\n\t\"%s\"\n equals new string\n\t\"%s\"\nexiting." % (old, new)
sys.exit(1)
#this check is problematic and breaks if 'new' is an exact substring of 'old', commenting it out for the moment
#elif new in after and old in after:
# print "pofix: %s has a msgid \n\t\"%s\"\nand a typoed version \n\t\"%s\"\nthis needs handfixing for now." % (path, old, new)
#this check is problematic and the last clause is added to prevent false
#positives in case that new is a substring of old, though this can also
#lead to "real" probs not found, the real check would be "does replacing
#old with new lead to duplicate msgids?" which is not easily done...
elif new in after and old in after and not new in old:
print "pofix: %s has a msgid \n\t\"%s\"\nand a typoed version \n\t\"%s\"\nthis needs handfixing for now." % (path, old, new)
else:
after = after.replace(old, new)
if after != before: