0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

preferences: Replace "Disable notifications" with "Desktop notifications"

Browse source 
Because inverse-logic options are evil and this was the only one in the
entire Preferences dialog anyway.
This commit is contained in:
Ignacio R. Morelle 2014-07-15 19:53:13 -04:00
parent ab37920d00
commit 2fac031356
4 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelog
View file

@ -277,6 +277,8 @@ Version 1.13.0-dev:
* Enabled action icons in the hotkey preferences dialog. * Enabled action icons in the hotkey preferences dialog.
* Fix bug #21717: "F5->reload wml tree" doesn't work in editor. * Fix bug #21717: "F5->reload wml tree" doesn't work in editor.
* Fix bug #21298: Minimap shows invisible overlays * Fix bug #21298: Minimap shows invisible overlays
* Replaced "Disable notifications" in Preferences -> Advanced with a new
"Desktop notifications" option that defaults to enabled.
Version 1.11.11: Version 1.11.11:
* Add-ons server: * Add-ons server:

6
data/advanced_preferences.cfg
View file

@ -116,10 +116,10 @@
[/advanced_preference] [/advanced_preference]
[advanced_preference] [advanced_preference]
field=disable_notifications field=desktop_notifications
name= _ "Disable notifications" name= _ "Desktop notifications"
type=boolean type=boolean
default=no default=yes
[/advanced_preference] [/advanced_preference]
[advanced_preference] [advanced_preference]

2
players_changelog
View file

@ -75,6 +75,8 @@ Version 1.13.0-dev:
* Fix bug wherein "lobby sounds" advanced preference didn't do anything for the default lobby. * Fix bug wherein "lobby sounds" advanced preference didn't do anything for the default lobby.
* Fix bug wherein dbus notifications did not have a wesnoth icon * Fix bug wherein dbus notifications did not have a wesnoth icon
* Fix bug wherein chat history synopses weren't working right in the dbus notifications * Fix bug wherein chat history synopses weren't working right in the dbus notifications
* Replaced "Disable notifications" in Preferences -> Advanced with a new
"Desktop notifications" option that defaults to enabled.
Version 1.11.11: Version 1.11.11:
* Campaigns: * Campaigns:

2
src/desktop/notifications.cpp
View file

@ -55,7 +55,7 @@ bool available() { return true; }
void send(const std::string& owner, const std::string& message, type t) void send(const std::string& owner, const std::string& message, type t)
{ {
if (preferences::get("disable_notifications", false)) { return; } if (!preferences::get("desktop_notifications", true)) { return; }
Uint8 app_state = SDL_GetAppState(); Uint8 app_state = SDL_GetAppState();