0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove incorrect moves

Browse source 
These were added by clang-tidy's autofix, which both tried to convert
the parameters to const references and std::move them. The correct
behaviour is to convert only to a const reference.
This commit is contained in:
JJ Marr 2024-12-06 00:39:05 -05:00 • committed by Charles Dang
parent e0bda68b80
commit 2e520d03a5
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/server/common/dbconn.cpp
View file

@ -588,7 +588,7 @@ bool dbconn::do_any_authors_exist(const std::string& instance_version, const std
//
void dbconn::get_complex_results(const mariadb::connection_ref& connection, rs_base& base, const std::string& sql, const sql_parameters& params)
{
mariadb::result_set_ref rslt = select(std::move(connection), sql, params);
mariadb::result_set_ref rslt = select(connection, sql, params);
base.read(rslt);
}
//
@ -596,7 +596,7 @@ void dbconn::get_complex_results(const mariadb::connection_ref& connection, rs_b
//
std::string dbconn::get_single_string(const mariadb::connection_ref& connection, const std::string& sql, const sql_parameters& params)
{
mariadb::result_set_ref rslt = select(std::move(connection), sql, params);
mariadb::result_set_ref rslt = select(connection, sql, params);
if(rslt->next())
{
return rslt->get_string(0);
@ -608,7 +608,7 @@ std::string dbconn::get_single_string(const mariadb::connection_ref& connection,
}
long dbconn::get_single_long(const mariadb::connection_ref& connection, const std::string& sql, const sql_parameters& params)
{
mariadb::result_set_ref rslt = select(std::move(connection), sql, params);
mariadb::result_set_ref rslt = select(connection, sql, params);
if(rslt->next())
{
// mariadbpp checks for strict integral equivalence, but we don't care
@ -641,7 +641,7 @@ long dbconn::get_single_long(const mariadb::connection_ref& connection, const st
}
bool dbconn::exists(const mariadb::connection_ref& connection, const std::string& sql, const sql_parameters& params)
{
mariadb::result_set_ref rslt = select(std::move(connection), sql, params);
mariadb::result_set_ref rslt = select(connection, sql, params);
return rslt->next();
}
@ -652,7 +652,7 @@ mariadb::result_set_ref dbconn::select(const mariadb::connection_ref& connection
{
try
{
mariadb::statement_ref stmt = query(std::move(connection), sql, params);
mariadb::statement_ref stmt = query(connection, sql, params);
mariadb::result_set_ref rslt = mariadb::result_set_ref(stmt->query());
return rslt;
}
@ -666,7 +666,7 @@ unsigned long long dbconn::modify(const mariadb::connection_ref& connection, con
{
try
{
mariadb::statement_ref stmt = query(std::move(connection), sql, params);
mariadb::statement_ref stmt = query(connection, sql, params);
unsigned long long count = stmt->execute();
return count;
}
@ -680,7 +680,7 @@ unsigned long long dbconn::modify_get_id(const mariadb::connection_ref& connecti
{
try
{
mariadb::statement_ref stmt = query(std::move(connection), sql, params);
mariadb::statement_ref stmt = query(connection, sql, params);
unsigned long long count = stmt->insert();
return count;
}