0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Help: fix unit type pages not showing up due to overscaling

Browse source
This commit is contained in:
Charles Dang 2024-10-04 20:26:58 -04:00
parent eccce783a9
commit 2dd27fcf8e
1 changed files with 2 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/help/help_topic_generators.cpp
View file

@ -319,24 +319,13 @@ std::string unit_topic_generator::operator()() const {
const bool has_male_portrait = !male_portrait.empty() && male_portrait != male_type.image() && male_portrait != "unit_image";
const bool has_female_portrait = !female_portrait.empty() && female_portrait != male_portrait && female_portrait != female_type.image() && female_portrait != "unit_image";
int sz = (has_male_portrait && has_female_portrait ? 300 : 400);
if (screen_width <= 1366) {
sz = (has_male_portrait && has_female_portrait ? 200 : 300);
} else if (screen_width >= 1920) {
sz = 400;
}
// without this, scaling down (SCALE_INTO below) and then scaling back up due to the pixel multiplier leads to ugly results
// can't use the preferences value since it may be different than the actual value
sz *= video::get_pixel_scale();
// TODO: figure out why the second checks don't match but the last does
if (has_male_portrait) {
ss << "<img src='" << male_portrait << "~FL(horiz)~SCALE_INTO(" << sz << ',' << sz << ")' box='no' align='right' float='yes' />";
ss << "<img src='" << male_portrait << "~FL(horiz)' box='no' align='right' float='yes' />";
}
if (has_female_portrait) {
ss << "<img src='" << female_portrait << "~FL(horiz)~SCALE_INTO(" << sz << ',' << sz << ")' box='no' align='right' float='yes' />";
ss << "<img src='" << female_portrait << "~FL(horiz)' box='no' align='right' float='yes' />";
}
// Unit Images