0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Log a console error message when a parse_error closes the help

Browse source 
Related to issue #4507, which is asking for better handling of the parse_error.
This commit doesn't improve the handling, but it will hopefully avoid anyone
spending time debugging to work out what text triggered #4507.
This commit is contained in:
Steve Cotton 2019-10-24 12:48:35 +02:00
parent de408ffab1
commit 2d9d1f405d
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/help/help.cpp
View file

@ -50,8 +50,7 @@ static lg::log_domain log_display("display");
#define WRN_DP LOG_STREAM(warn, log_display)
static lg::log_domain log_help("help");
#define WRN_HP LOG_STREAM(warn, log_help)
#define DBG_HP LOG_STREAM(debug, log_help)
#define ERR_HELP LOG_STREAM(err, log_help)
namespace help {
@ -234,11 +233,12 @@ void show_help(const section &toplevel_sec,
CVideo::delay(10);
}
}
catch (parse_error& /*e*/) {
// Disabled due to issue #2587
catch (const parse_error& e) {
ERR_HELP << _("Parse error when parsing help text:") << " " << e.message << std::endl;
#if 0
// Displaying in the UI is disabled due to issue #2587
std::stringstream msg;
msg << _("Parse error when parsing help text: ") << "'" << e.message << "'";
msg << _("Parse error when parsing help text:") << " '" << e.message << "'";
gui2::show_transient_message("", msg.str());
#endif
}