0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GUI2/Tree View Node: make use of emplace_back returning a reference

Browse source
This commit is contained in:
Charles Dang 2024-10-05 15:18:48 -04:00
parent 9dc4a94533
commit 2931816979
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/gui/widgets/tree_view_node.cpp
View file

@ -194,8 +194,7 @@ std::vector<std::shared_ptr<gui2::tree_view_node>> tree_view_node::replace_child
int width_modification = 0;
for(const auto& d : data) {
std::shared_ptr<gui2::tree_view_node> new_node = std::make_shared<tree_view_node>(id, this, get_tree_view(), d);
std::shared_ptr<gui2::tree_view_node> node = *children_.insert(children_.end(), std::move(new_node));
auto& node = children_.emplace_back(std::make_shared<tree_view_node>(id, this, get_tree_view(), d));
// NOTE: we currently don't support moving nodes between different trees, so this
// just ensures that wasn't tried. Remove this if we implement support for that.