From 1c73adb70f7c6c1e4326e23758c6e6b91833d051 Mon Sep 17 00:00:00 2001 From: Alexander van Gessel Date: Mon, 6 Nov 2017 03:40:00 +0100 Subject: [PATCH] Attempt to silence a coverity issue yet again by splitting up an expression --- src/gui/dialogs/statistics_dialog.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gui/dialogs/statistics_dialog.cpp b/src/gui/dialogs/statistics_dialog.cpp index 331d9fdc7f2..e0165563705 100644 --- a/src/gui/dialogs/statistics_dialog.cpp +++ b/src/gui/dialogs/statistics_dialog.cpp @@ -143,9 +143,10 @@ void statistics_dialog::add_damage_row( const long long dsa = shift * damage - expected; const long long dst = shift * turn_damage - turn_expected; + const long long shifted = ((expected * 20) + shift) / (2 * shift); std::ostringstream str; str << damage << " / " - << (((expected * 20) + shift) / (2 * shift)) * 0.1 + << static_cast(shifted) * 0.1 << " " // TODO: should probably make this two columns << ((dsa < 0) ^ (expected < 0) ? "" : "+") << (expected == 0 ? 0 : 100 * dsa / expected) << '%'; @@ -156,8 +157,9 @@ void statistics_dialog::add_damage_row( str.str(""); if(show_this_turn) { + const long long turn_shifted = ((turn_expected * 20) + shift) / (2 * shift); str << turn_damage << " / " - << (((turn_expected * 20) + shift) / (2 * shift)) * 0.1 + << static_cast(turn_shifted) * 0.1 << " " // TODO: should probably make this two columns << ((dst < 0) ^ (turn_expected < 0) ? "" : "+") << (turn_expected == 0 ? 0 : 100 * dst / turn_expected) << '%';