0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Eliminate some false positives.

Browse source
This commit is contained in:
Eric S. Raymond 2008-03-18 21:18:55 +00:00
parent fa5539434f
commit 1c5348cdb9
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
data/tools/wmllint
View file

@ -529,6 +529,10 @@ def validate_on_pop(tagstack, closer, filename, lineno):
# to deserialize an empty unit.
if closer == "side" and "type" not in attributes and ("no_leader" not in attributes or attributes["no_leader"] != "yes") and "multiplayer" not in ancestors:
print '"%s", line %d: [side] without type attribute' % (filename, lineno)
# This assumes that conversion will always happen in units/ files.
if "units" not in filename and closer == "unit" and "race" in attributes:
print "%s, line %d: [unit] needs hand fixup to [unit_type]" % \
(filename, lineno)
def within(tag):
"Did the specified tag lead one of our enclosing contexts?"
@ -2118,9 +2122,6 @@ if __name__ == '__main__':
line = line.replace("[unit]", "[unit_type]")
line = line.replace("[+unit]", "[+unit_type]")
line = line.replace("[/unit]", "[/unit_type]")
elif verbose > 1 and "unit]" in line and not within(("scenario","multiplayer","test","tutorial")):
print "%s, line %d: [unit] may need conversion to [unit_type]" % \
(filename, lineno)
# Handle SingleUnitWML or Standard Unit Filter or SideWML
# Also, when macro calls have description= in them, the arg is
# a SUF being passed in.