0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

less config copying when executing events.

Browse source
This commit is contained in:
gfgtdf 2016-08-08 17:35:16 +02:00
parent 7ab539fb3d
commit 18d7736190
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/game_events/handlers.cpp
View file

@ -112,9 +112,9 @@ void event_handler::disable()
*/
void event_handler::handle_event(const queued_event& event_info, handler_ptr& handler_p, game_lua_kernel & lk)
{
// We will need our config after possibly self-destructing. Make a copy now.
// TODO: instead of copying possibly huge config objects we should use shared things and only increase a refcount here.
vconfig vcfg(cfg_, true);
//prevents the code below from destroying this object, so that cfg_ is still valid when we execute the handler.
handler_ptr this_p = handler_p;
vconfig vcfg(cfg_);
if (is_menu_item_) {
DBG_NG << cfg_["name"] << " will now invoke the following command(s):\n" << cfg_;
@ -127,7 +127,6 @@ void event_handler::handle_event(const queued_event& event_info, handler_ptr& ha
// Also remove our caller's hold on us.
handler_p.reset();
}
// *WARNING*: At this point, dereferencing this could be a memory violation!
lk.run_wml_action("command", vcfg, event_info);
}