0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Suppress unchecked return warning

Browse source 
Coverity has been complaining that a few uses of show_message do not have their return value checked.

Casting to void supresses these warning be documenting the value is intentionally not  checked.

This closes

CID 1380185
CID 1380186
CID 1380258
This commit is contained in:
Gregory A Lundberg 2017-10-26 09:57:34 -05:00 • committed by Charles Dang
parent 2d0b2464d8
commit 0cb203e9c0
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/gui/dialogs/message.cpp
View file

@ -209,7 +209,7 @@ void show_error_message(CVideo& video,
bool message_use_markup)
{
LOG_STREAM(err, lg::general()) << msg << '\n';
show_message(video,
(void) show_message(video,
_("Error"),
msg,
message::ok_button,

2
src/gui/widgets/label.cpp
View file

@ -200,7 +200,7 @@ void label::signal_handler_right_button_click(const event::ui_event /* event */,
desktop::clipboard::copy_to_clipboard(link, false);
show_message(get_window()->video(), "", _("Copied link!"), dialogs::message::auto_close);
(void) show_message(get_window()->video(), "", _("Copied link!"), dialogs::message::auto_close);
handled = true;
}

2
src/menu_events.cpp
View file

@ -1370,7 +1370,7 @@ void menu_handler::do_search(const std::string& new_search)
const std::string msg = vgettext("Could not find label or unit "
"containing the string ‘$search’.",
symbols);
gui2::show_message(gui_->video(), "", msg, gui2::dialogs::message::auto_close);
(void) gui2::show_message(gui_->video(), "", msg, gui2::dialogs::message::auto_close);
}
}