0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Uncomment re-selection guard in tgroup::set_member_active

Browse source 
Without this, multiple selections could occur in the Faction Select dialog. However, somehow the
next option immediately to the disabled one gets selected instead of the first available selection
as expected. While this fixes the FLG dialog, it might have repercussions for the Create Unit dialog.

It's possible this issue has something to do with the ordering of the map. Will have to investigate
further after this.
This commit is contained in:
Charles Dang 2016-09-21 05:13:06 +11:00
parent 740acecfa5
commit 0bbcd4055e
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/gui/widgets/group.hpp
View file

@ -140,12 +140,9 @@ public:
dynamic_cast<tcontrol&>(w).set_active(active);
// Only select another member this was selected
// TODO: for some reason, this doesn't work as expected. While the button will be
// deselected, the get_active call seems to fail, leading to situations where
// no member is selected. Commenting out for now.
//if(!w.get_value_bool()) {
// return;
//}
if(!w.get_value_bool()) {
return;
}
w.set_value_bool(false);