0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Display: use split_view when parsing overlay teams

Browse source 
We have references to existing strings here. No need to make copies with `split`.
This commit is contained in:
Charles Dang 2024-09-15 12:23:02 -04:00
parent ccdc8b17f4
commit 0af60e6fcc
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/display.cpp
View file

@ -2826,10 +2826,8 @@ void display::draw_overlays_at(const map_location& loc)
}
if(dont_show_all_ && !ov.team_name.empty()) {
// dont_show_all_ imples that viewing_team() is a valid index to get_teams()
const std::string& current_team_name = viewing_team().team_name();
const std::vector<std::string>& current_team_names = utils::split(current_team_name);
const std::vector<std::string>& team_names = utils::split(ov.team_name);
const auto current_team_names = utils::split_view(viewing_team().team_name());
const auto team_names = utils::split_view(ov.team_name);
bool item_visible_for_team = std::find_first_of(team_names.begin(), team_names.end(),
current_team_names.begin(), current_team_names.end()) != team_names.end();