0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add a comment.

Browse source
This commit is contained in:
gfgtdf 2014-11-01 22:37:16 +01:00
parent cbead26ffe
commit 081cb8f6cc
1 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/server/game.hpp
View file

@ -355,7 +355,22 @@ private:
int nsides_;
bool started_;
/** The current scenario data. */
/**
The current scenario data.´
WRONG! This contains the initial state or the state from which
the game was loaded from.
Using this to make assumptions about the current gamestate is
extremely dangerous and should especially not be done for anything
that can be nodified by wml (especially by [modify_side]),
like team_name, controller ... in [side].
FIXME: move every code here that uses this object to query those
information to the clients. But note that there are some checks
(like controller == null) that are definitely needed by the server and
in this case we should try to modify the client to inform the server if
a change of those properties occur. Ofc we shouldn't update level_
then, but rather store that information in a seperate object
(like in side_controllers_).
*/
simple_wml::document level_;
/** Replay data. */