0ct0pu5/user_external
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
319 commits 5 branches 21 tags 642 KiB
Commit graph

102 commits

Author SHA1 Message Date
Jonas Sulzer
5b70ef00bb
Merge pull request #249 from nextcloud/fix/user-count 
🐛 FIX: wrong user count
 2024-07-28 10:33:01 +02:00
Jonas Sulzer
b27d85a783
Merge pull request #228 from BjoKaSH/imap_log_failure_reason 
Distinguish wrong credentials from other problems (IMAP)
 2024-04-02 11:35:38 +02:00
Jonas Sulzer
0ea46a1730
🐛 FIX: wrong user count 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2024-03-30 01:25:04 +01:00
Bjoern Kahl
69483900d1 Distinguish wrong credentials from other problems (IMAP) 
Verifying login data can fail for a number of reasons like temporary
connection failure to the IMAP server, Internal problems of the IMAP
server, or actually wrong username / password combination.

This change logs the reason for login failures, helping server admins to
diagnose login problems and better support their users.

Ideally, we would have an option to pass the reason upwards, so the
NextCloud login system can show appropriate errors to users attempting
to login.

Signed-off-by: Bjoern Kahl <mls@bjoern-kahl.de>
 2023-11-25 21:49:19 +01:00
Bjoern Kahl
8fd2a5d06a Fix out-of-bound array access (IMAP) 
The IMAP method allows user names with or without a domain part.  For
user names without a domain part, it still tries to access the (then
non-existing) domain, resulting in "Error: Undefined array key 1 at
.../nextcloud/apps/user_external/lib/IMAP.php#85" log messages.

Signed-off-by: Bjoern Kahl <mls@bjoern-kahl.de>
 2023-11-25 21:46:26 +01:00
Glandos
5e5c330a7c
Trim doesn't accept null anymore 
Fix #203 

Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-01-19 00:02:03 +01:00
Tem Ogunfiditimi
1fbc471efe
Examine error code returned by curl handle instead of return value from curl_exec. Using the return value from curl_exec resulted in failure on new mailboxes that did not contain any mail. 
Signed-off-by: Tem Ogunfiditimi <tem@episof.com>

Changed comparison to identical check

Signed-off-by: Tem Ogunfiditmi <tem@episof.com>
Signed-off-by: Tem Ogunfiditimi <tem@episof.com>
 2022-12-27 21:36:59 +01:00
John Molakvoæ
751dc7ea2a
Cs fix 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-04-15 08:18:32 +02:00
Jonas Sulzer
084bdc71bc
🐛 FIX: correct namespace 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2022-04-15 00:02:50 +02:00
Biermair Martin
990b6d73d3 migration to nextcloud app v3.0.0 
Signed-off-by: Biermair Martin <martin.biermair@wimbergerhaus.at>
 2022-04-10 10:47:18 +02:00
Ole Morten
bd610e28b5 Use new types introduced in Nextcloud 21 and bump compatibility 
Signed-off-by: Ole Morten <om@haaland.biz>
 2021-03-09 20:28:00 +01:00
Joas Schilling
5185d9efb5
Move to migrations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-30 21:39:09 +02:00
Malte Langermann
71994c6148 fix long imap login delay on mailboxes with many folders 
Signed-off-by: Malte Langermann <malte@langermann.net>
 2020-05-16 09:07:14 +02:00
bjoernv
133d3405d0 Fix for #141 
* Authorization header for OC_User_BasicAuth is now set with locally stream context instead globally with stream_context_set_default function.
* HTTP Redirects in OC_User_BasicAuth are disabled now, so authorization header can not be forwared to foreign servers.
Closes #141

Signed-off-by: Björn Voigt <bjoernv@arcor.de>
 2020-04-23 10:19:16 +02:00
Jonas Sulzer
b5799d90b8
🐛 FIX: starttls support for IMAP over curl 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2020-04-09 21:59:52 +02:00
Rachus
6659fb24b2 Fix comment for SSH module (it's not FTP) 
Signed-off-by: Sebastian Rachuj <rachus@web.de>
 2020-04-01 15:15:25 +02:00
Tim Wichmann
8d48ce91a7 Replace imap_rcube library with curl call 
This commit removes the imap_rcube library with a curl call to the imap endpoint.
Since curl is a dependency of nextcloud this should not cause any issues.

This closes #116

Signed-off-by: Tim Wichmann <tim@wichmann.online>
 2020-02-11 16:23:06 +01:00
Melvin Suter
b1032c5bb7
Fixed Login error based on bad format in command 
Signed-off-by: Melvin Suter <github@damon.ch>
 2019-10-05 18:27:57 +02:00
Mischa Siekmann
1883b0c083 Corrected indentation and changed to a more specific error message. 
Signed-off-by: Mischa Siekmann <github@gnumpi.com>
 2019-08-23 13:17:44 +02:00
Mischa Siekmann
c0abb76adf added logging of errrors for imap login 
Signed-off-by: Mischa Siekmann <github@gnumpi.com>
 2019-08-21 01:05:38 +02:00
Sebastian Sterk
5dc9b1db12 Add warning for plaintext passwords, set default password mode to secure 
Signed-off-by: Sebastian Sterk <sebastian@wiuwiu.de>
 2019-08-01 12:55:52 +02:00
Sebastian Sterk
b05e2d68b2 Add plaintext password authenticaion for prosody mysql 
Signed-off-by: Sebastian Sterk <sebastian@wiuwiu.de>
 2019-07-18 21:54:16 +02:00
violoncello.ch
e03df48300
Merge pull request #90 from nextcloud/fix/88 
🐛 FIX: variable groups not set in all cases
 2019-06-27 12:31:52 +02:00
violoncello.ch
51556d9d74
Merge pull request #91 from nextcloud/counting 
📦 NEW: support counting of total user_external users
 2019-06-27 12:31:39 +02:00
Jonas Sulzer
386ed12d2f
📖 DOC: changes to imap_rcube, so we can keep track of them 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-06-27 11:41:11 +02:00
Scott Shambarger
352dcb74a9
Fix Issue #56: Undefined Indices in Logs 
Add ssl_mode and force_caps to connection params, and correctly handle
AUTHENTICATE PLAIN in putLineC to reduce warnings in logs.

Signed-off-by: Scott Shambarger <devel@shambarger.net>
 2019-06-27 11:41:10 +02:00
Jonas Sulzer
1008d41f42
🐛 FIX: variable groups not set in some cases 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-06-27 11:40:26 +02:00
Jonas Sulzer
a1bcefa305
📦 NEW: support counting of total user_external users 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-06-27 11:39:50 +02:00
Lutz Freitag
6a246e1105
Merge pull request #82 from alejandroliu/mod_basicauth 
Address issue #58
 2019-06-07 18:22:46 +05:00
Jonas Sulzer
855886810a
🐛 FIX: make groups param for storeUser() optional 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-06-03 14:04:39 +02:00
Alejandro Liu
f3302a352c Make sure check of headers is case insensitive. 
Signed-off-by: Alejandro Liu <alejandro_liu@hotmail.com>
 2019-06-03 08:54:57 +02:00
violoncello.ch
406e41c8a2
Merge pull request #65 from lavdnone/master 
optional imap groups via domain & make domain striping optional
 2019-06-02 23:55:13 +02:00
Jonas Sulzer
8c38759958 👌 IMPROVE: make it possible to add the user to an array of groups (for later extendability e.g. #69) 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: none <vlad@teksperts.nyc>
 2019-06-02 13:49:49 -04:00
Jonas Sulzer
47ee3d61f4 🐛 FIX: creation of groups 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: none <vlad@teksperts.nyc>
 2019-06-02 13:49:49 -04:00
Jonas Sulzer
aeb4476752 👌 IMPROVE: move group creation to imap class && check for two additional parameters wheter to stripe domain and create group based on domain or not 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: none <vlad@teksperts.nyc>
 2019-06-02 13:49:49 -04:00
Jonas Sulzer
dd1d9a7e8b 👌 IMPROVE: update authors 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: none <vlad@teksperts.nyc>
 2019-06-02 13:49:49 -04:00
Lavd
b012588309 converted to getGroupManager()->createGroup from OC_DB 
Signed-off-by: none <vlad@teksperts.nyc>
 2019-06-02 13:49:49 -04:00
Lavd
00c4c02b82 Update base.php 
imap groups via domain-part

Signed-off-by: none <vlad@teksperts.nyc>
 2019-06-02 13:49:49 -04:00
violoncello.ch
ccd2b2230b
Merge pull request #74 from lephisto/master 
Fix Querybuilder to find Users that have difference uid from displayName
 2019-06-02 00:35:43 +02:00
Alejandro Liu
f03cd092fe Renaming the variable used for checs, adding more explanatory text 
Signed-off-by: Alejandro Liu <alejandro_liu@hotmail.com>
 2019-06-01 19:21:33 +02:00
Alejandro Liu
2548a592f1 Address issue #58 
Signed-off-by: Alejandro Liu <alejandro_liu@hotmail.com>
 2019-05-27 21:40:40 +02:00
Jonas Sulzer
e7b9800df8
🐛 FIX: spaces/tabs 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-05-22 21:13:18 +02:00
Jonas Sulzer
1d2a662669
✅ TEST: check if ssh2 module is installed 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-05-22 20:50:47 +02:00
Jonas Sulzer
8e1261004c
👌 IMPROVE: add SSH port as possible parameter 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-05-22 20:49:00 +02:00
Jonas Sulzer
07fddff440
📦 NEW: thanks to @DavieDavieDave (nextcloud/apps#56): SSH password authentication 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-05-22 20:17:06 +02:00
Sebastian
76189b6e3e Cleanly close imap connection 
Signed-off-by: Sebastian <bash2@momou.ch>
 2019-05-09 17:18:41 +02:00
Bastian Maeuser
01dd0357c6 Fix Querybuilder to find Users that have difference uid from displayName 
Signed-off-by: Bastian Maeuser <mephisto@mephis.to>
 2019-05-03 18:50:21 +02:00
Sebastian
104e409e83
Add Prosody XMPP MySQL authentication 
Signed-off-by: Sebastian <sebastian@wiuwiu.de>

Change class name

Signed-off-by: Sebastian <sebastian@wiuwiu.de>

add prosody to title name

Signed-off-by: Sebastian <sebastian@wiuwiu.de>

integrate nextcloud code style guidelines

Signed-off-by: Sebastian <sebastian@wiuwiu.de>

clean up

Signed-off-by: Sebastian <sebastian@wiuwiu.de>

Applied nc code style

Signed-off-by: Sebastian <sebastian@wiuwiu.de>
 2019-03-26 00:44:38 +01:00
Lutz Freitag
816ec2e3f9 basic authentication now follows redirects! 
Signed-off-by: Lutz Freitag <lutz@gottliebtfreitag.de>
 2019-03-24 19:04:46 -06:00
Jonas Sulzer
b9fa972c76
🐛 FIX: replace discouraged operators 
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
 2019-03-14 14:52:25 +01:00