Blockbase: remove unneeded margin rules (#4808)

blockbase/assets/ponyfill.css

@@ -660,11 +660,6 @@ p.has-drop-cap:not(:focus):first-letter {
 	display: none;
 }
 
-.wp-block-post-template {
-	margin-top: 0;
-	margin-bottom: 0;
-}
-
 .wp-block-post-template .wp-block-post-featured-image {
 	line-height: 0;
 }
@@ -835,7 +830,6 @@ div.wp-block-query-pagination .wp-block-query-pagination-numbers .current {
 }
 
 .wp-block-separator {
-	margin: var(--wp--custom--separator--margin);
 	opacity: var(--wp--custom--separator--opacity);
 }
 
@@ -887,7 +881,6 @@ p.wp-block-site-tagline {
 
 .wp-block-table.is-style-stripes,
 .wp-block-table {
-	margin-bottom: 1em;
 	border-bottom: none;
 }
 
@@ -909,10 +902,6 @@ p.wp-block-site-tagline {
 	text-align: var(--wp--custom--video--caption--text-align);
 }
 
-.wp-block-columns {
-	margin-bottom: unset;
-}
-
 .post-meta {
 	row-gap: var(--wp--custom--gap--baseline) !important;
 }

blockbase/sass/blocks/_columns.scss

@@ -1,6 +0,0 @@
-// TODO: This can be removed when Gutenberg no longer expresses opinion about the bottom margin of the block columns
-// or perhaps when the margins of blocks can be styled with the "style" portion of theme.json
-// See: https://github.com/WordPress/gutenberg/pull/34630
-.wp-block-columns {
-	margin-bottom: unset;
-}

blockbase/sass/blocks/_post-template.scss

@@ -1,7 +1,4 @@
-// Needed until https://github.com/WordPress/gutenberg/pull/35193 is merged.
 .wp-block-post-template {
-	margin-top: 0;
-	margin-bottom: 0;
 	// Needed until https://github.com/WordPress/gutenberg/pull/35273 is merged.
 	.wp-block-post-featured-image {
 		line-height: 0;

blockbase/sass/blocks/_separator.scss

@@ -1,5 +1,4 @@
 .wp-block-separator {
-	margin: var(--wp--custom--separator--margin); // See https://github.com/WordPress/gutenberg/pull/30609 is merged
 	opacity: var(--wp--custom--separator--opacity); // Mirror controls that Gutenberg theme.css offers: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/separator/theme.scss - See: https://github.com/WordPress/gutenberg/issues/34637
 	&:not(.is-style-wide){
 		width: var(--wp--custom--separator--width); // See https://github.com/WordPress/gutenberg/issues/34638

blockbase/sass/blocks/_table.scss

@@ -1,4 +1,3 @@
-// See https://github.com/WordPress/gutenberg/issues/31261
 .wp-block-table.is-style-stripes,
 .wp-block-table {
 	figcaption { // See https://github.com/WordPress/gutenberg/issues/34650
@@ -12,6 +11,5 @@
 		padding: calc(0.5*var(--wp--custom--gap--vertical)) calc(0.5*var(--wp--custom--gap--horizontal));
 	}
 
-	margin-bottom: 1em; // See https://github.com/WordPress/gutenberg/issues/34652
 	border-bottom: none;
 }

blockbase/sass/ponyfill.scss

@@ -29,5 +29,4 @@
 @import "blocks/file";
 @import "blocks/table";
 @import "blocks/video";
-@import "blocks/columns";
 @import "post/meta";

blockbase/theme.json

@@ -293,7 +293,6 @@
 			},
 			"separator": {
 				"opacity": 1,
-				"margin": "var(--wp--custom--gap--vertical) auto",
 				"width": "150px"
 			},
 			"table": {

geologist/theme.json

@@ -284,7 +284,6 @@
 			},
 			"separator": {
 				"opacity": 1,
-				"margin": "var(--wp--custom--gap--vertical) auto",
 				"width": "150px"
 			},
 			"table": {

mayland-blocks/theme.json

@@ -301,7 +301,6 @@
 			},
 			"separator": {
 				"opacity": 1,
-				"margin": "var(--wp--custom--gap--vertical) auto",
 				"width": "150px"
 			},
 			"table": {

quadrat/theme.json

@@ -340,7 +340,6 @@
 			},
 			"separator": {
 				"opacity": 1,
-				"margin": "var(--wp--custom--gap--vertical) auto",
 				"width": "150px"
 			},
 			"table": {

seedlet-blocks/child-theme.json

@@ -115,9 +115,6 @@
 						}
 					}
 				}
-			},
-			"separator": {
-				"margin": "calc( 9 * var(--wp--custom--gap--baseline) ) auto calc(2 * var(--wp--custom--gap--baseline) )"
 			}
 		},
 		"layout": {

seedlet-blocks/theme.json

@@ -334,7 +334,6 @@
 			},
 			"separator": {
 				"opacity": 1,
-				"margin": "calc( 9 * var(--wp--custom--gap--baseline) ) auto calc(2 * var(--wp--custom--gap--baseline) )",
 				"width": "150px"
 			},
 			"table": {

skatepark/child-theme.json

@@ -199,9 +199,6 @@
 			},
 			"line-height": {
 				"body": 1.6
-			},
-			"separator": {
-				"margin": "calc( 0.5 * var(--wp--custom--gap--vertical) ) auto"
 			}
 		},
 		"layout": {

skatepark/theme.json

@@ -336,7 +336,6 @@
 			},
 			"separator": {
 				"opacity": 1,
-				"margin": "calc( 0.5 * var(--wp--custom--gap--vertical) ) auto",
 				"width": "150px"
 			},
 			"table": {

videomaker/theme.json

@@ -295,7 +295,6 @@
 			},
 			"separator": {
 				"opacity": 1,
-				"margin": "var(--wp--custom--gap--vertical) auto",
 				"width": "150px"
 			},
 			"table": {