瀏覽代碼

fix(auth): remove extensive logs from updating transitions

Karol Sójko 1 年之前
父節點
當前提交
2a1859e4be

+ 0 - 1
packages/auth/src/Bootstrap/Container.ts

@@ -943,7 +943,6 @@ export class ContainerConfigLoader {
         new UpdateTransitionStatus(
           container.get<TransitionStatusRepositoryInterface>(TYPES.Auth_TransitionStatusRepository),
           container.get<RoleServiceInterface>(TYPES.Auth_RoleService),
-          container.get<winston.Logger>(TYPES.Auth_Logger),
         ),
       )
     container

+ 1 - 6
packages/auth/src/Domain/UseCase/UpdateTransitionStatus/UpdateTransitionStatus.spec.ts

@@ -3,19 +3,14 @@ import { RoleName, Uuid } from '@standardnotes/domain-core'
 import { RoleServiceInterface } from '../../Role/RoleServiceInterface'
 import { TransitionStatusRepositoryInterface } from '../../Transition/TransitionStatusRepositoryInterface'
 import { UpdateTransitionStatus } from './UpdateTransitionStatus'
-import { Logger } from 'winston'
 
 describe('UpdateTransitionStatus', () => {
   let transitionStatusRepository: TransitionStatusRepositoryInterface
   let roleService: RoleServiceInterface
-  let logger: Logger
 
-  const createUseCase = () => new UpdateTransitionStatus(transitionStatusRepository, roleService, logger)
+  const createUseCase = () => new UpdateTransitionStatus(transitionStatusRepository, roleService)
 
   beforeEach(() => {
-    logger = {} as jest.Mocked<Logger>
-    logger.info = jest.fn()
-
     transitionStatusRepository = {} as jest.Mocked<TransitionStatusRepositoryInterface>
     transitionStatusRepository.removeStatus = jest.fn()
     transitionStatusRepository.updateStatus = jest.fn()

+ 0 - 26
packages/auth/src/Domain/UseCase/UpdateTransitionStatus/UpdateTransitionStatus.ts

@@ -2,13 +2,11 @@ import { Result, RoleName, UseCaseInterface, Uuid } from '@standardnotes/domain-
 import { TransitionStatusRepositoryInterface } from '../../Transition/TransitionStatusRepositoryInterface'
 import { UpdateTransitionStatusDTO } from './UpdateTransitionStatusDTO'
 import { RoleServiceInterface } from '../../Role/RoleServiceInterface'
-import { Logger } from 'winston'
 
 export class UpdateTransitionStatus implements UseCaseInterface<void> {
   constructor(
     private transitionStatusRepository: TransitionStatusRepositoryInterface,
     private roleService: RoleServiceInterface,
-    private logger: Logger,
   ) {}
 
   async execute(dto: UpdateTransitionStatusDTO): Promise<Result<void>> {
@@ -30,30 +28,6 @@ export class UpdateTransitionStatus implements UseCaseInterface<void> {
       await this.roleService.addRoleToUser(userUuid, RoleName.create(RoleName.NAMES.TransitionUser).getValue())
     }
 
-    if (dto.transitionType === 'items') {
-      const itemStatuses = await this.transitionStatusRepository.getStatuses('items')
-      const itemsStartedStatusesCount = itemStatuses.filter((status) => status.status === 'STARTED').length
-      const itemsInProgressStatusesCount = itemStatuses.filter((status) => status.status === 'IN_PROGRESS').length
-      const itemsFailedStatusesCount = itemStatuses.filter((status) => status.status === 'FAILED').length
-
-      this.logger.info(
-        `[TRANSITION ${dto.transitionTimestamp}] Items transition statuses: ${itemsStartedStatusesCount} started, ${itemsInProgressStatusesCount} in progress, ${itemsFailedStatusesCount} failed`,
-      )
-    }
-
-    if (dto.transitionType === 'revisions') {
-      const revisionStatuses = await this.transitionStatusRepository.getStatuses('revisions')
-      const revisionsStartedStatusesCount = revisionStatuses.filter((status) => status.status === 'STARTED').length
-      const revisionsInProgressStatusesCount = revisionStatuses.filter(
-        (status) => status.status === 'IN_PROGRESS',
-      ).length
-      const revisionsFailedStatusesCount = revisionStatuses.filter((status) => status.status === 'FAILED').length
-
-      this.logger.info(
-        `[TRANSITION ${dto.transitionTimestamp}] Revisions transition statuses: ${revisionsStartedStatusesCount} started, ${revisionsInProgressStatusesCount} in progress, ${revisionsFailedStatusesCount} failed`,
-      )
-    }
-
     return Result.ok()
   }
 }