global variable $boxesnew was being corrupted by another function (I don't really see why its even global at this point, its also stored in the Session). Changed the name of the variable used in the offending function. The symptoms were that the folder list boxes would not be populated, errors when emptying the trash, and errors in the Folders Options.
Added paginator support for asearch
Added next/prev links in read_body to walk through search results
Added individual sort settings / mailbox
Added what I forgot to mention
exists with in_array (which returns just that boolean), and fix the
left over call to array_search to also check for NULL return.
This should fix the problems that Fredrik, me and other PHP 4.1 users
had with Marc's recent changes.
From PHP docs:
"Note: Prior to PHP 4.2.0, array_search() returns NULL on failure instead of FALSE."
select response.
* Tried to fix the broken del move next function and added a few arguments
to the dmn_expunge function because the globals scared me when I couldn't
get the job done.
scope and with register globals = on the mailbox-tree wasn't returned. We
should work on caching the mailbox-tree and rewrite the functions that make
use of the old mailbox_list function.
list.
Make use of the sorted list with id's from the session if the mailbox state
didn't change.
All performance related imap fixes were found after playing with thetereal.
If you want to try itt yourself:
tethereal -t a -ni lo -f 'port 143' -R 'imap.request'
with lo the interface.
the whole subscription list and looked up if the requested mailbox was part
of it. It's better to subscribe and surpress the NO response if already
subscribed.
when we added the INBOX response to the array at a later stage. This is
confirmed on PHP 4.1.2. The version I'm using (4.3.4) didn't had that
problem. Probably this fix us a php-bug workaround.
Added basic @package/@subpackage tags
The decode/ files were documented slightly more thoroughly, although they're almost self-explanatory anyway.
The individual functions in the functions/ files need to be documented though, and now that this commit is in, anyone willing to write docblocks for functions should get cracking ;)
the parent isn't marked as a special folder. This code forces the parents
of the special folders to also be marked as special. The rest of the subs
for the parent special should follow the movement of the parent in left_main
unsubscribed and we just add it to the list. No reason to check specificly
for LSUB "" "INBOX" or LIST "" "INBOX"
If there is no inbox then a select will produce an error message.
out of order reponses. Now it works.
In imap_mailbox te array with mailbox objects wasn't create correctly. It
contained double entries. That's fixed too.