Commit graph

2057 commits

Author SHA1 Message Date
stekkel
9694d7879b make use of new parseRFC822Address function 2004-05-26 01:18:42 +00:00
stekkel
8784e12b74 removed parseAdress routines and made it point to rfc822address.php 2004-05-26 00:36:06 +00:00
stekkel
1b23ec7e4b Code cleanup, intented to remove the parseAddress routines from
class/Rfc822Header.class.php and from imap_general.php
2004-05-26 00:35:03 +00:00
Thijs Kinkhorst
ac61dd81d2 Reset $msg on each iteration, otherwise a message with eg no subject
will take the subject from the previous message.
2004-05-25 13:47:49 +00:00
Thijs Kinkhorst
2f1cc08b0e Replace array_search that only uses a boolean to check whether the value
exists with in_array (which returns just that boolean), and fix the
left over call to array_search to also check for NULL return.
This should fix the problems that Fredrik, me and other PHP 4.1 users
had with Marc's recent changes.

From PHP docs:
"Note:  Prior to PHP 4.2.0, array_search() returns NULL on failure instead of FALSE."
2004-05-24 19:55:21 +00:00
stekkel
711ddf65f0 Fix from Seth Randall. The range was 1 to large. 2004-05-24 19:46:14 +00:00
stekkel
ca8d8b640f Set the content-type correct so we can check on multipart/mixed in
mailbox_display (printMessage).
2004-05-24 18:01:59 +00:00
Fredrik Jervfors
d8a36fc91e Missing global 2004-05-24 01:16:58 +00:00
stekkel
ed5d1bb09f Fixed XSS vulnarability spotted by "Roman Medina" after a very thorough
research of the SquirrelMail source. I was impressed.
2004-05-23 16:09:48 +00:00
stekkel
e3c519e440 cleanup up filter plugin 2004-05-23 15:38:40 +00:00
stekkel
a6aa705a09 Fix broken thread sort 2004-05-23 10:47:26 +00:00
stekkel
c27886a4eb More cleanups. 2004-05-23 08:52:39 +00:00
Fredrik Jervfors
5534ff479f Phpdocumentor update - sed is your friend for these kinds of things ;) 2004-05-22 23:46:57 +00:00
stekkel
b805bf5f1c changed naming scheme 2004-05-22 21:03:23 +00:00
stekkel
82da02623e removed debug message. fixed divide by zero warning because we now use 0
instead of 999999 as limit for the number of messages to see if we hit
show_all
2004-05-22 20:55:36 +00:00
stekkel
d91bbed263 Another big update:
1) do not do a search 1:* UID request in case we do not sort. That isn't
needed, just use a non uid fetch and request the UID together with the rest
of the headers.

2) Started on adding envelope parsing to sqimap_get_small_header list so we
can remove the imap related code from the messages class.

2) cleaned up the functions in mailbox_display, don't use trillions of
arguments when you can provide an array as well.

3) adapted right_main.php and search.php to fit the adapted functions in
mailbox_display

I hope the code makes more sense now an is easier to understand so that we
can start on separating the logic from the html output and prepare for
templates. Volunteers?
2004-05-22 20:39:10 +00:00
Fredrik Jervfors
9d4db8b166 Phpdocumentor update - sed is your friend for these kinds of things ;) 2004-05-21 23:56:53 +00:00
stekkel
01f20c33df Sigh, maybe I need sleep or so. To many bugs ... 2004-05-21 16:30:52 +00:00
stekkel
e0e3a3aed8 fix sort by internaldate if the internaldate does not have the expected
format.
2004-05-21 16:00:16 +00:00
indiri69
7df0c454dc Fix message highlighting for mailbox changes 2004-05-21 15:26:38 +00:00
stekkel
9349ee9987 More code cleanups and added a few notes/comments 2004-05-21 15:01:43 +00:00
stekkel
4b2a4469bb fix for non server side sorting on internal date
Modified the subject sort to strip out the [mailinglist] entries before we
start sorting.
2004-05-21 13:03:42 +00:00
stekkel
a291f4d213 Hmm, client side sorting on large mailboxes is so fast I didn't even noticed
that it did that by default (typo)
2004-05-21 11:30:18 +00:00
stekkel
34dffa1d9d Simplified DMN and the findPrevious and FindNext functions. 2004-05-21 11:24:07 +00:00
stekkel
8881b9eaf4 code cleanup 2 2004-05-20 23:44:15 +00:00
stekkel
ac73116f5f Code cleanup. 2004-05-20 23:20:21 +00:00
stekkel
d024fa15b0 Respect the permanentflags output. Do not show the alter flags buttons
/links if the mailbox does not allow it.
2004-05-20 16:20:42 +00:00
tokul
9de6aa7e28 phpdoc block 2004-05-20 11:55:56 +00:00
tokul
dca19f1eda aStutus -> aStatus 2004-05-20 09:46:07 +00:00
stekkel
f510138349 * Request UID and UIDVALIDITY from the status response if not available in the
select response.
* Tried to fix the broken del move next function and added a few arguments
  to the dmn_expunge function because the globals scared me when I couldn't
  get the job done.
2004-05-19 22:36:41 +00:00
tokul
0c4659baa2 Adding Basque support 2004-05-19 14:42:30 +00:00
stekkel
194b15976a due to caching the dropdown mailbox list $boxesnew was set in the global
scope and with register globals = on the mailbox-tree wasn't returned. We
should work on caching the mailbox-tree and rewrite the functions that make
use of the old mailbox_list function.
2004-05-18 16:40:00 +00:00
tokul
044e1c12c8 using case insensitive lookups that don't depend on sql server string comparison options.
mysql tested by me, postgresql tested by Patrick Welche <prlw1 at newn.cam.ac.uk>
2004-05-18 13:07:49 +00:00
tokul
eb784ac89f adding global declaration for set_my_language 2004-05-18 13:01:07 +00:00
tokul
0b0751d6b1 removing bigger decoding functions in order to reduce package size.
functions will be available in separate package.
2004-05-18 12:58:37 +00:00
stekkel
4542626296 No comments 2004-05-17 20:11:55 +00:00
stekkel
b171edd0dc temp fixes, as long as we didn't adapt our mailbox tree code, cache the
list.

Make use of the sorted list with id's from the session if the mailbox state
didn't change.

All performance related imap fixes were found after playing with thetereal.
If you want to try itt yourself:

tethereal -t a -ni lo -f 'port 143' -R 'imap.request'
with lo the interface.
2004-05-17 19:48:57 +00:00
stekkel
157a422c57 removed debug statement 2004-05-17 15:55:33 +00:00
stekkel
85bee15f35 Removed kind of insane check. The check mailbox is subscribed call retrieved
the whole subscription list and looked up if the requested mailbox was part
of it. It's better to subscribe and surpress the NO response if already
subscribed.
2004-05-17 15:45:37 +00:00
tokul
9257761c54 disabled Korean extra functions. This is not real fix. In order to fix it
the Right-Way, all extra functions have to be rewritten. Current changes
prevent insertion of 8bit headers into new emails when Korean translation
is used. I'll submit same fix to stable if nobody stops me within 24 hours.
2004-05-17 07:07:40 +00:00
tokul
90ff7fb152 making decision about conversion before actual conversion. removing old comments
about nbsp. adding header conversion if function asks for it in $decide and
conversion is possible. Fixes header conversion problems in compose. Not nice but works.
2004-05-16 13:05:36 +00:00
tokul
5b65f33a13 adding charset conversion functions. utf_8.php is taken from www.php.net samples.
Functions are needed if we want to mix forms.php and charset conversion in compose.
2004-05-16 08:43:50 +00:00
stekkel
b3634fa4bb initialize color array in case it isn't set at this stage. 2004-05-14 21:14:31 +00:00
stekkel
cc5084acf0 Removed double select call (select calls are expensive, do not do that) and
removed unneeded expunge call (don't do that expunges are expensive)
2004-05-14 19:55:10 +00:00
stekkel
f630a0daf1 second try .. 2004-05-14 19:12:53 +00:00
stekkel
1069293bcd Detect untagged BYE responses in case the connection is terminated. 2004-05-14 18:37:40 +00:00
tokul
7ef31182af cleaned tabs 2004-05-14 11:19:43 +00:00
Fredrik Jervfors
e13894b4ed This i18n string never got translated before 2004-05-13 05:48:53 +00:00
alex-brainstorm
6ea1a837c2 Use null as default value since value is tested against null. Was breaking search code. 2004-05-10 14:55:23 +00:00
tokul
097e96eba2 common functions are documented only in one backend 2004-05-10 09:56:02 +00:00