amount of calls to sq_strpos and sq_substr. Those functions did expensive
in_array calls and a few other things that only need to be done once. By
using static vars I cached the results with as result my compose screen
opens within a second again instead of 10 seconds.
config_base_location to config.php and a new option to conf.pl. This is
to prevent problems in installs where our heuristic doesn't work
correctly (#1521299, #1460675, #1110064, #1000850, #1113791)
I believe this is one of the most commonly reported issues in current
stable. That's why I've created the code to be minimally invasive: it only
allows to set the proto+host+port part, because this means all changes
can remain within get_location().
I want to backport this bugfix to stable so I appreciate any feedback
on it. And also of course if you think that this is the wrong way to
solve it :)
base_uri for redirects; reduces problems with transparent proxies
(#1488590). Also test strcasecmp on literally '0' with respect to
#1047883 although I don't think it's absolutely necessary, it's safest.
* first list defines, then functions, then run code
* move php_self() function from strings.php to global.php in order to provide
$PHP_SELF to session functions
own utf strlen implementation is removed because we need strlen, substr and
strpos implementation in order to use it correctly.
sqbodywrap function is modified to use sq_* functions instead of vanilla
string functions.
function calls that analize string in bytes ($body{$position}) are replaced
with string functions.
closes#1043576 in devel. code is not that complex in stable and it needs only
modified strlen calls.
If same code is ported to stable, it could make that bug specific to
devel branch. Devel branch needs more fixes for sqBodyWrap function. I would
like to add Eastern charset support before moving it to 1.4.5
Also remove a few more globals that were unused
Remove a few newlines at the end of files
Hopefully this will help shrink the memory footprint of SM just slightly
TODO: look at lines which are longer then the editor size and and theirfor
do not reach the code responsable for the smart wrapping of short lines.
Those lines should also be tested on first words.
converted ereg to pcre. It would be better to include function_exist('ctype_space') test
in this function. P.S. reply code is broken if message includes double quotes.
