It breaks things outside of Western Europe/US.
Changing functions to use htmlspecialchars(). It still breaks things
in compose, when is_conversion_safe($charset)=true.
at least it breaks less.
Autodetection is fixed, load of JS dependent items (like address book and
search) will be set to false if javascript_on session var is false/0.
javascript_on will ONLY be true if:
javascript_setting = 1 (ALWAYS)
javascript_setting = 2 (Autodetect, and test works)
If you change your javascript settings, javascript_on will change
immediately.
We might actually want to DISABLE Always, and have it be either Never, or autodetect.
Since Always might not always work.. :-P
Correct some mistakes (compose_in_new, resume draft, edit as new)
Centralize javascript detection in prefs.php - checkForJavascript
Move javascript_on from prefs to session - have just javascript_setting in prefs.
I've created this for another project of mine, and think they come in useful
here. They are kept simple on purpose. Advantage is less typing
[eg addHidden('startMessage', $startMessage)] and everything is encoded
automatically. Could be extended with submit/reset and other form elts
not covered yet.
whether to have the fullname, nickname, ect... returned from the addressbook to
the the compose screen, but it was not working at all. Granted we do not have
an option for this yet either, but that will follow fairly quickly.
Thanks to William Bishop
I hit this bug by coincidance and thnx to a server crash. Cyrus returned
information like UID, RFC822.SIZE, INTERNALDATE (that info is probably
cached by cyrus) correct, but an empty header. At the end of the response
there was an untagged OK response with as server message: Message <nnn> no
longer exists.
when we added the INBOX response to the array at a later stage. This is
confirmed on PHP 4.1.2. The version I'm using (4.3.4) didn't had that
problem. Probably this fix us a php-bug workaround.
(in a tabbed browser, pull up SM, then click 'Sign Out' as an "open in new tab"
then click something in the current window, you'll get an error trying to
execute unknown function do_hook on line 88 of display_messages).
So we'll just add the require, just to make sure..
sqimap_create_stream() was not as generalized as it should have been - it was still using $imap_server and $use_imap_tls, etc. Now obeying passed params as it should.
