Commit graph

454 commits

Author SHA1 Message Date
stekkel
860b3cf49a code cleanup 2002-08-30 16:42:16 +00:00
stekkel
cf3fe28bd6 fix for getEntity 2002-08-30 15:05:33 +00:00
thomppj
2692b136f3 Ok. One simple mistake... :) 2002-08-29 23:45:08 +00:00
thomppj
caeff8b548 First, more formatting conventions.
1. Wrap all operands of a complex expression with parentheses.
     For instance:
         if ($bob == 'foo' || $bob == 'bar') {
     is wrong. Do this instead:
         if (($bob == 'foo') || ($bob == 'bar')) {

  2. Carefully decide between pre and post incrementation. If it
     does not matter, always choose pre because it is technically
     more efficient. For instance:
         for ($i = 0; $i < $count; $i++) {
     is wrong. Do this instead:
         for ($i = 0; $i < $count; ++$i) {

  3. Classes should be named in style like this:
         MessageHeader
         Rfc8222Header
     etc. When there is an acronym at the beginning, treat it
     like a word - do NOT captitalize each letter of the acronym.

  4. Put each class in a seperate file named ClassName.class.php.
     Related classes can be put in one directory and then included
     in a main include file.

Second, big changes with mime.class.php here. And I don't think I broke
anything. (Sounds like famous last words, eh?)
2002-08-29 23:42:46 +00:00
indiri69
f905ffeb5e Move -1 to first section of for loop. 2002-08-28 20:38:33 +00:00
stekkel
ab66eca299 code cleanup 2002-08-28 16:35:37 +00:00
stekkel
8cece0472d added var to message-class where we put the location of the temporary
attachment name in case we use the message-object also for composing
messages. (Not finished yet but I'm working on it)
2002-08-28 16:23:25 +00:00
indiri69
ab5e17e9a9 Changed the way we handle entities in message/rfc822 types. $msg->entity_id++
would increment by 0.1 in php 4.0.4 but would increment by 1.0 in php 4.0.6.
This meant that a message/rfc822 type with only a text/plain part would label
the text/plain part entity 3.0 instead of 2.1.  This should fix that problem.
2002-08-26 22:13:56 +00:00
stekkel
8d8ad53091 fix for getFilename 2002-08-26 14:21:35 +00:00
stekkel
e4518532d4 fix for the bodystructure parser 2002-08-26 10:07:22 +00:00
indiri69
6ac50d3de5 More code cleanup 2002-08-24 21:37:52 +00:00
indiri69
2d12473e69 Code cleanup 2002-08-24 21:28:18 +00:00
indiri69
91d07bb8f4 Added argument $strict to findDisplayEntity. When false (the default) it
assume 'text/plain', 'text/html', and 'text/message' are viewable.  When
true (strict mode), it will only treat the types passed as viewable.  This
means if you pass just 'text/html' in alt_order, then it will only return
those parts that are viewable 'text/html'.
2002-08-24 19:34:57 +00:00
indiri69
f5fd7d5dbd Cleaned up parseComments so it handles comments inside of comments. Changed
a for to a foreach for simplify the clean up function.
2002-08-23 16:31:32 +00:00
stekkel
b43252a5df Bugfixes mime class. (Like I mentioned in the mail Paul) 2002-08-23 12:33:08 +00:00
indiri69
fcc5426708 Fixed a few typos, removed so trailing spaces. 2002-08-22 21:54:22 +00:00
thomppj
90fa1d7ea2 Reformatted, cleaned up, optimized, and so forth... Dang, people! Write
neat code. I removed almost 400 lines of code do to sloppy coding!
2002-08-22 20:15:13 +00:00
indiri69
ea06e59f3a Subject doesn't have comments 2002-08-22 15:14:12 +00:00
stekkel
a3aa553ca0 removed double code (sorry forgot) 2002-08-22 13:07:40 +00:00
stekkel
fdcfd2b03a added user-agent check (from Masato Japanese patches)
(this has nothing to do with Japanese, just an enhancement)
2002-08-22 12:20:48 +00:00
philippe_mingo
db3fa82a09 Indentation & Bugfix 2002-08-22 10:04:34 +00:00
stekkel
6f4e609385 added function to extract filename from an entity with error correction in
case the disposition isn't defined
2002-08-22 08:43:29 +00:00
stekkel
754582f5c3 fix for getEntity and the return of a non-object 2002-08-21 10:09:15 +00:00
indiri69
51df4b8b4f A few changes, mostly to make the code more readable. In
findAlternativeEntity we now compare current or greater best_view since
RFC2046 says we should use the LAST viewable part.
2002-08-20 21:13:45 +00:00
stekkel
a0abf08b16 1 == 1.1 => true? changed to === fixed this. 2002-08-19 14:46:25 +00:00
stekkel
9ebc41acf1 extra function for getting the disposition properties 2002-08-19 09:57:03 +00:00
stekkel
3fe11b89f6 preg_match should look at field instead of value 2002-08-19 08:21:43 +00:00
indiri69
9116ca70bc X- style headers are optional and don't us comments like other headers. So
we shouldn't parse them. (RFC 2822 Section 3.6.8)
2002-08-16 16:17:21 +00:00
stekkel
e73e21055f fix for trailing space in personal address names 2002-08-16 12:43:30 +00:00
stekkel
c075641ad5 allow_call_time_pass_reference = Off fixes 2002-08-16 10:29:06 +00:00
stekkel
0edf363ab2 fix in unfolding headerlines
(\s doesn't work in str_replace)
2002-08-13 16:49:35 +00:00
stekkel
38fdd19299 moved parse header stuff to the mime-class and some rewriting to follow
rfc2060 better
2002-08-06 22:48:18 +00:00
stekkel
160431845f remove debug message 2002-07-30 16:19:40 +00:00
stekkel
1ab14b0d55 for safety covert disposition to lowercase before we check 2002-07-30 16:04:01 +00:00
stekkel
387780e5cc whoops, missed a line. 2002-07-30 08:00:16 +00:00
stekkel
7351378c3d finddisplayentity related fix 2002-07-30 07:52:01 +00:00
stekkel
3d8ffc9c06 minor fix to in displaying attachments 2002-07-29 07:58:59 +00:00
stekkel
d464c61a4f filename fix 2002-07-25 19:37:13 +00:00
stekkel
78369fb933 fix for viewing attachments 2002-07-25 19:34:49 +00:00
stekkel
2c75ab083d typo 2002-07-25 19:32:59 +00:00
thomppj
072fc8552f Renamed class/*.class files to class/*.class.php and made modifications
throughout the SquirrelMail code to represent these changes.
2002-07-25 13:57:18 +00:00
thomppj
249135cedd Added index in class dir to avoid unwanted directory listing. Minor
formatting modification to *.class files.

NOTE: We really want these files to be called *.class.php, not just
*.class.php.
2002-07-25 13:52:13 +00:00
stekkel
db5747eb3f fix for language argument and add language class. 2002-07-22 19:59:22 +00:00
stekkel
0f75e42637 Fixed nasty bug in finding the language argument (arg3 in multipart
entities)
2002-07-19 18:27:59 +00:00
teepe
a93dce8501 fixed indentation of close tags 2002-07-14 17:04:31 +00:00
teepe
75ca3cb200 make indentation start at '' indentation. (Code elegancy not yet 100% :-( ) 2002-07-14 16:08:56 +00:00
teepe
961084aff9 * fix style closing tags (</1> should be </b> etc.)
* prevent ' style="Array"' from the html output
2002-07-14 15:09:22 +00:00
stekkel
ce1d1b9169 Added finddisplayentity functions and getattachment functions 2002-07-12 15:52:23 +00:00
stekkel
7987e94b87 added a few functions 2002-07-12 15:50:57 +00:00
stekkel
be5376fcaf class file for storing/handling html-structures. If we use this class to
store our html objects (tables etc) then we can easy make use of css with
full support of the non-css browsers.
Also very usefull for future templates.
2002-07-09 22:51:28 +00:00