瀏覽代碼

2 bugs in message_list:
- in PHP 4.1.x, the first part of in_array may not be an array. This gives a
lot of warnings in the message display. Not sure how to fix this, so just adding a
note to it now.
- initialize $aCol to empty array, not empty string, since it's expected to be
an array further down.

Thijs Kinkhorst 20 年之前
父節點
當前提交
fea1782bda
共有 1 個文件被更改,包括 2 次插入1 次删除
  1. 2 1
      templates/default/message_list.tpl

+ 2 - 1
templates/default/message_list.tpl

@@ -408,6 +408,7 @@ else
      * we have to do some php coding to display the columns in the right order
      */
     foreach ($aOrder as $iCol) {
+        // FIXME: first parameter cannot be an array in PHP < 4.2
         if (in_array($index_order_part, $show_label_columns)) {
             $sLabelStart = '<label for="msg[' . $i . ']">';
             $sLabelEnd = '</label>';
@@ -415,7 +416,7 @@ else
             $sLabelStart = '';
             $sLabelEnd = '';
         }
-        $aCol = (isset($aColumns[$iCol])) ? $aColumns[$iCol] : '';
+        $aCol = (isset($aColumns[$iCol])) ? $aColumns[$iCol] : array();
         $title  = (isset($aCol['title']))  ? $aCol['title']  : '';
         $link   = (isset($aCol['link']))   ? $aCol['link']   : '';
         $value  = (isset($aCol['value']))  ? $aCol['value']  : '';