Преглед на файлове

removing references from backend functions. lookup causes E_NOTICE in php
4.4.0, because tries to return array(). Use of references can't be explained.
Main backend class and file/ldap backends don't use refencences. If it is
used for some reason, other lookup() should have to use references too.
I suspect that reason is performance or it is relict from some different code.
PHP manual says that developers should not use references in order to increase
performance.

tokul преди 20 години
родител
ревизия
f859fe157e
променени са 1 файла, в които са добавени 3 реда и са изтрити 3 реда
  1. 3 3
      functions/abook_database.php

+ 3 - 3
functions/abook_database.php

@@ -179,7 +179,7 @@ class abook_database extends addressbook_backend {
      * @param string $expr search expression
      * @param string $expr search expression
      * @return array search results
      * @return array search results
      */
      */
-    function &search($expr) {
+    function search($expr) {
         $ret = array();
         $ret = array();
         if(!$this->open()) {
         if(!$this->open()) {
             return false;
             return false;
@@ -228,7 +228,7 @@ class abook_database extends addressbook_backend {
      * @param string $alias alias
      * @param string $alias alias
      * @return array search results
      * @return array search results
      */
      */
-    function &lookup($alias) {
+    function lookup($alias) {
         if (empty($alias)) {
         if (empty($alias)) {
             return array();
             return array();
         }
         }
@@ -266,7 +266,7 @@ class abook_database extends addressbook_backend {
      * List all addresses
      * List all addresses
      * @return array search results
      * @return array search results
      */
      */
-    function &list_addr() {
+    function list_addr() {
         $ret = array();
         $ret = array();
         if (!$this->open()) {
         if (!$this->open()) {
             return false;
             return false;