Pārlūkot izejas kodu

Updating my previous comments.

Fredrik Jervfors 17 gadi atpakaļ
vecāks
revīzija
f5d40976f3
2 mainītis faili ar 18 papildinājumiem un 9 dzēšanām
  1. 10 6
      functions/mime.php
  2. 8 3
      src/read_body.php

+ 10 - 6
functions/mime.php

@@ -359,8 +359,9 @@ function formatBody($imap_stream, $message, $color, $wrap_at, $ent_num, $id, $ma
     // workaround for not updated config.php
     // workaround for not updated config.php
     if (! isset($use_iframe)) $use_iframe = false;
     if (! isset($use_iframe)) $use_iframe = false;
 
 
-    // If there's no "view_unsafe_images" setting in the user's preferences,
-    // turn unsafe images off by default.
+    // If there's no "view_unsafe_images" variable in the URL, turn unsafe
+    // images off by default.
+    // FIXME: Update this code to use the default value FALSE.
     if( !sqgetGlobalVar('view_unsafe_images', $view_unsafe_images, SQ_GET) ) {
     if( !sqgetGlobalVar('view_unsafe_images', $view_unsafe_images, SQ_GET) ) {
         $view_unsafe_images = false;
         $view_unsafe_images = false;
     }
     }
@@ -1854,11 +1855,13 @@ function sq_fix_url($attname, &$attvalue, $message, $id, $mailbox,$sQuote = '"')
         $attvalue = trim(substr($attvalue,1,-1));
         $attvalue = trim(substr($attvalue,1,-1));
     }
     }
 
 
-    // If there's no "view_unsafe_images" setting in the user's preferences,
-    // turn unsafe images off by default.
+    // If there's no "view_unsafe_images" variable in the URL, turn unsafe
+    // images off by default.
+    // FIXME: Update this code to use the default value FALSE.
     if( !sqgetGlobalVar('view_unsafe_images', $view_unsafe_images, SQ_GET) ) {
     if( !sqgetGlobalVar('view_unsafe_images', $view_unsafe_images, SQ_GET) ) {
         $view_unsafe_images = false;
         $view_unsafe_images = false;
     }
     }
+
     $secremoveimg = '../images/' . _("sec_remove_eng.png");
     $secremoveimg = '../images/' . _("sec_remove_eng.png");
 
 
     /**
     /**
@@ -2497,8 +2500,9 @@ function magicHTML($body, $id, $message, $mailbox = 'INBOX', $take_mailto_links
             )
             )
         );
         );
 
 
-    // If there's no "view_unsafe_images" setting in the user's preferences,
-    // turn unsafe images off by default.
+    // If there's no "view_unsafe_images" variable in the URL, turn unsafe
+    // images off by default.
+    // FIXME: Update this code to use the default value FALSE.
     if( !sqgetGlobalVar('view_unsafe_images', $view_unsafe_images, SQ_GET) ) {
     if( !sqgetGlobalVar('view_unsafe_images', $view_unsafe_images, SQ_GET) ) {
         $view_unsafe_images = false;
         $view_unsafe_images = false;
     }
     }

+ 8 - 3
src/read_body.php

@@ -691,12 +691,16 @@ function formatToolbar($mailbox, $passed_id, $passed_ent_id, $message, $color) {
     // Build the printer friend link
     // Build the printer friend link
     /* hackydiehack */
     /* hackydiehack */
 
 
-    // If there's no "view_unsafe_images" setting in the user's preferences,
-    // turn unsafe images off by default.
+    // Pull "view_unsafe_images" from the URL to find out if the unsafe images
+    // should be displayed. The default is not to display unsafe images.
     if( !sqgetGlobalVar('view_unsafe_images', $view_unsafe_images, SQ_GET) ) {
     if( !sqgetGlobalVar('view_unsafe_images', $view_unsafe_images, SQ_GET) ) {
+        // If "view_unsafe_images" isn't part of the URL, default to not
+        // displaying unsafe images.
         $view_unsafe_images = false;
         $view_unsafe_images = false;
     } else {
     } else {
-        // FIXME: Do we really want to display the unsafe images regardless of the user's preferences?
+        //  If "view_unsafe_images" is part of the URL, display unsafe images
+        //  regardless of the value of the URL variable.
+        // FIXME: Do we really want to display the unsafe images regardless of the value in URL variable?
         $view_unsafe_images = true;
         $view_unsafe_images = true;
     }
     }
 
 
@@ -814,6 +818,7 @@ if(sqgetGlobalVar('view_unsafe_images', $temp)) {
 } else {
 } else {
     $view_unsafe_images = 0;
     $view_unsafe_images = 0;
 }
 }
+
 /**
 /**
  * Retrieve mailbox cache
  * Retrieve mailbox cache
  */
  */