Lots of little changes...

AUTHORS

@@ -1,20 +1,20 @@
  Developers:
  -----------
    Paul Joseph Thompson <captbunzo@squirrelmail.org>
-   Peter Hutnick <peter@hutnick.com>
-   Luke Ehresman <luke@squirrelmail.org>     http://www.css.tayloru.edu/~lehresma
-   Nathan Ehresman <nathan@squirrelmail.org> http://www.css.tayloru.edu/~nehresma
-   Gustav Foseid <gustavf@squirrelmail.org>  http://www.initio.no
-   Pål Løberg <pallo@squirrelmail.org>       http://www.initio.no
-   Shane Wilson
-   Steve Gare                                http://www.xantara.co.uk
-   Gerrit Padgham <gpadgham@commnav.com>
-   Matt Phillips <mphillip@commnav.com>
-   Lewis Bergman
-   Bryan Stalcup <bryan@stalcup.net>
+   Luke Ehresman    <luke@squirrelmail.org> http://www.css.tayloru.edu/~lehresma
    Tyler Akins
-   Philippe Mingo <philippe@squirrelmail.org>
-   Stefan Sels <sm@sels.com> http://stefan.sels.com
+   Lewis Bergman
+   Nathan Ehresman  <nathan@squirrelmail.org> http://www.css.tayloru.edu/~nehresma
+   Gustav Foseid    <gustavf@squirrelmail.org> : http://www.initio.no
+   Steve Gare       http://www.xantara.co.uk
+   Peter Hutnick    <peter@hutnick.com>
+   Pål Løberg       <pallo@squirrelmail.org> : http://www.initio.no
+   Philippe Mingo   <philippe@squirrelmail.org>
+   Gerrit Padgham   <gpadgham@commnav.com>
+   Matt Phillips    <mphillip@commnav.com>
+   Stefan Sels      <sm@sels.com> http://stefan.sels.com
+   Bryan Stalcup    <bryan@stalcup.net>
+   Shane Wilson
 
  Translations:
  -------------
@@ -61,18 +61,20 @@
  --------------------------
    i18n support:        Sergiusz Pawlowicz 
    SquirrelMail logo:   Libor Kopecky <libor@globe.cz>
-   Web Site Admin/PR:   Paul Joseph Thompson <thomppj@okstate.edu>
+   Web Site Admin/PR:   Rick Castello <rick@squirrelmail.org>
 
-   Code contributions:  Konstantin Riabitsev <graf@relhum.org>
-                        Alex Bleeker <beheer@hackers.nl>
-                        Jan-Pieter Cornet <johnpc@xs4all.nl>
-                        John Williams <jw@netpimp.com> 
-                        Ondrej Sury <ondrej@globe.cz>
-                        Damien Sandras <dsandras@acm.org>
-                        Martin Jespersen <mbj@mbj.dk>
-                        David Whittington <dwhittin@css.tayloru.edu>
-                        Many, many others...
+   Paginator Help: Charles Scheidecker
+   Other Code contributions:
+       Konstantin Riabitsev <graf@relhum.org>
+       Alex Bleeker <beheer@hackers.nl>
+       Jan-Pieter Cornet <johnpc@xs4all.nl>
+       John Williams <jw@netpimp.com> 
+       Ondrej Sury <ondrej@globe.cz>
+       Damien Sandras <dsandras@acm.org>
+       Martin Jespersen <mbj@mbj.dk>
+       David Whittington <dwhittin@css.tayloru.edu>
+       Many, many others...
 
-(We have tried to keep this up to date to give credit where it is due.
-If you feel that you have wrongfully been left off this list, contact
-<captbunzo@squirrelmail.org>)
+( We have tried to keep this up to date to give credit where it
+  is due. If you feel that you have wrongfully been left off this
+  list, contact <captbunzo@squirrelmail.org> )

functions/mailbox_display.php

@@ -673,7 +673,6 @@ function get_paginator_link
 
 /**
  * This function computes the paginator string.
- * It was derived from code contributed by Charles Scheidecker.
  */
 function get_paginator_str
 ($box, $start_msg, $end_msg, $num_msgs, $show_num, $sort) {

functions/prefs.php

@@ -3,7 +3,7 @@
 /**
  * prefs.php
  *
- * Copyright (c) 1999-2001 The SquirrelMail Development Team
+ * Copyright (c) 1999-2002 The SquirrelMail Development Team
  * Licensed under the GNU GPL. For full terms see the file COPYING.
  *
  * This contains functions for manipulating user preferences
@@ -27,6 +27,11 @@ function cachePrefValues($data_dir, $username) {
         return;
     }
 
+    /* A call to checkForPrefs here should take eliminate the need for
+    /* this to be called throughout the rest of the SquirrelMail code. 
+    checkForPrefs($data_dir, $username);
+
+    /* Calculate the filename for the user's preference file */
     $filename = getHashedFile($username, $data_dir, "$username.pref");
 
     if (!file_exists($filename)) {

plugins/mail_fetch/setup.php

@@ -211,7 +211,6 @@
 
         if( $username <> '' ) {
             // Creates the pref file if it does not exist.
-        checkForPrefs( $data_dir, $username );
             setPref( $data_dir, $username, 'mailfetch_newlog', 'on' );
         }
 
@@ -228,4 +227,4 @@
       );
    }
 
-?>
+?>

src/left_main.php

@@ -359,4 +359,4 @@ do_hook('left_main_after');
 
 echo "</BODY></HTML>\n";
 
-?>
+?>

src/load_prefs.php

@@ -38,7 +38,6 @@ require_once('../src/validate.php');
     require_once('../functions/constants.php');
       
     if (!isset($username)) { $username = ''; }
-    checkForPrefs($data_dir, $username);
 
     $chosen_theme = getPref($data_dir, $username, "chosen_theme");
     $in_ary = false;

src/redirect.php

@@ -149,9 +149,10 @@ if (isset($HTTP_ACCEPT) &&
 
 
 /* Complete autodetection of Javascript. */
-checkForPrefs($data_dir, $username);
-$javascript_setting = getPref($data_dir, $username, 'javascript_setting', SMPREF_JS_AUTODETECT);
-$js_autodetect_results = (isset($js_autodetect_results) ? $js_autodetect_results : SMPREF_JS_OFF);
+$javascript_setting = getPref
+    ($data_dir, $username, 'javascript_setting', SMPREF_JS_AUTODETECT);
+$js_autodetect_results = (isset($js_autodetect_results) ?
+    $js_autodetect_results : SMPREF_JS_OFF);
 if ($javascript_setting == SMPREF_JS_AUTODETECT) {
     if ($js_autodetect_results == SMPREF_JS_ON) {
         setPref($data_dir, $username, 'javascript_on', SMPREF_JS_ON);

src/webmail.php

@@ -26,7 +26,6 @@ $base_uri = $regs[1];
 
 session_start();
 is_logged_in();
-checkForPrefs($data_dir, $username);
 
 /*
  * We'll need this to later have a noframes version