Browse Source

moving administrator check to option block registration. reduces amount of
code loaded during plugin's init. removing trailing linefeed from auth.php

tokul 20 years ago
parent
commit
e7efa38050
2 changed files with 15 additions and 15 deletions
  1. 1 1
      plugins/administrator/auth.php
  2. 14 14
      plugins/administrator/setup.php

+ 1 - 1
plugins/administrator/auth.php

@@ -63,4 +63,4 @@ function adm_check_user() {
 function adm_array_trim(&$value,$key) {
 function adm_array_trim(&$value,$key) {
     $value=trim($value);
     $value=trim($value);
 }
 }
-?>
+?>

+ 14 - 14
plugins/administrator/setup.php

@@ -12,9 +12,6 @@
  * @subpackage administrator
  * @subpackage administrator
  */
  */
 
 
-/** @ignore */
-require_once(SM_PATH . 'plugins/administrator/auth.php');
-
 /**
 /**
  * Init the plugin
  * Init the plugin
  * @access private
  * @access private
@@ -22,10 +19,8 @@ require_once(SM_PATH . 'plugins/administrator/auth.php');
 function squirrelmail_plugin_init_administrator() {
 function squirrelmail_plugin_init_administrator() {
     global $squirrelmail_plugin_hooks;
     global $squirrelmail_plugin_hooks;
 
 
-    if ( adm_check_user() ) {
-        $squirrelmail_plugin_hooks['optpage_register_block']['administrator'] =
-                                  'squirrelmail_administrator_optpage_register_block';
-    }
+    $squirrelmail_plugin_hooks['optpage_register_block']['administrator'] =
+        'squirrelmail_administrator_optpage_register_block';
 }
 }
 
 
 /**
 /**
@@ -33,13 +28,18 @@ function squirrelmail_plugin_init_administrator() {
  * @access private
  * @access private
  */
  */
 function squirrelmail_administrator_optpage_register_block() {
 function squirrelmail_administrator_optpage_register_block() {
-    global $optpage_blocks;
+    /** add authentication functions */
+    include_once(SM_PATH . 'plugins/administrator/auth.php');
 
 
-    $optpage_blocks[] = array(
-        'name' => _("Administration"),
-        'url'  => SM_PATH . 'plugins/administrator/options.php',
-        'desc' => _("This module allows administrators to manage SquirrelMail main configuration remotely."),
-        'js'   => false
-    );
+    if ( adm_check_user() ) {
+        global $optpage_blocks;
+
+        $optpage_blocks[] = array(
+            'name' => _("Administration"),
+            'url'  => SM_PATH . 'plugins/administrator/options.php',
+            'desc' => _("This module allows administrators to manage SquirrelMail main configuration remotely."),
+            'js'   => false
+            );
+    }
 }
 }
 ?>
 ?>