Browse Source

place login form elements before login button. #1245070.
I think change was approved by Paul in plugins mailing list. If you think
that I am breaking too many things, I can revert the change.

tokul 20 years ago
parent
commit
b6800f54dd
3 changed files with 6 additions and 3 deletions
  1. 2 0
      ChangeLog
  2. 2 1
      doc/Development/plugin.txt
  3. 2 2
      src/login.php

+ 2 - 0
ChangeLog

@@ -431,6 +431,8 @@ Version 1.5.1 -- CVS
     able to convert html formated mails to different character set. Initial
     patch by Peter Draganov (#1195232). Fixed display of html formated emails
     in formatBody() function (#1258925).
+  - login_form hook changed from do_hook to concat_hook_function in order to
+    place form elements before login button (#1245070).
 
 Version 1.5.0 - 2 February 2004
 -------------------------------

+ 2 - 1
doc/Development/plugin.txt

@@ -314,7 +314,8 @@ but may be out of date soon thereafter.  You never know.  ;-)
   left_main_after                src/left_main.php               do_hook
   login_cookie                   src/login.php                   do_hook
   login_top                      src/login.php                   do_hook
-  login_form                     src/login.php                   do_hook
+  login_form                     src/login.php                   concat_hook
+    (was do_hook before 1.5.1)
   login_bottom                   src/login.php                   do_hook
 * optpage_set_loadinfo           src/options.php                 do_hook
 * optpage_loadhook_personal      src/options.php                 do_hook

+ 2 - 2
src/login.php

@@ -185,7 +185,8 @@ echo html_tag( 'table',
                                     $rcptaddress .
                                     addHidden('just_logged_in', '1'),
                                     'left', '', 'width="*"' )
-                                ) ,
+                                ) .
+                                concat_hook_function('login_form') ,
                             'center', $color[4], 'border="0" width="100%"' ) ,
                         'left', $color[4] )
                         ) .
@@ -198,7 +199,6 @@ echo html_tag( 'table',
                         'center' )
                         ) ,
                         '', $color[4], 'border="0" cellspacing="0" cellpadding="0" width="100%"' );
-do_hook('login_form');
 echo '</form>' . "\n";
 
 do_hook('login_bottom');