Browse Source

set_url_var would eat the "&" if the first url var was being changed.
Fixes #1053725

Thijs Kinkhorst 20 years ago
parent
commit
afa5c6823a
2 changed files with 7 additions and 3 deletions
  1. 4 3
      ChangeLog
  2. 3 0
      functions/html.php

+ 4 - 3
ChangeLog

@@ -155,11 +155,12 @@ Version 1.5.1 -- CVS
   - LDAP backend will use internal squirrelmail charset conversion functions
   - LDAP backend will use internal squirrelmail charset conversion functions
     instead of php xml extension. Fixes bug #655137.
     instead of php xml extension. Fixes bug #655137.
   - Added Wood theme and Silver Steel theme by Pavel Spatny and Simple Green theme
   - Added Wood theme and Silver Steel theme by Pavel Spatny and Simple Green theme
-  - Fix two time zone calculation bugs, thanks to David White
+  - Fix two time zone calculation bugs, thanks to David White. Fixes #1063879.
   - 'Priority' and 'Importance' headers are now also recognised, next to the
   - 'Priority' and 'Importance' headers are now also recognised, next to the
-    'X-Priority' header that we've supported since a long time.
+    'X-Priority' header that we've supported since a long time. Fixes #1039935.
   - Handle a reload of the signout page gracefully: do not present an error
   - Handle a reload of the signout page gracefully: do not present an error
-    about having to be logged in to be able to sign out.
+    about having to be logged in to be able to sign out. Fixes #1070069.
+  - Prevent & being eaten in set_url_var, thanks Marcin Orlowski. Fixes #1053725.
 
 
 Version 1.5.0
 Version 1.5.0
 --------------------
 --------------------

+ 3 - 0
functions/html.php

@@ -137,6 +137,9 @@ function html_tag( $tag,                // Tag to output
             } else {
             } else {
                 $rpl = '';
                 $rpl = '';
             }
             }
+            if( substr($v,-1)=='&' ) {
+                $rpl .= '&';
+            }
             $pat = "/$k=$v/";
             $pat = "/$k=$v/";
             $url = preg_replace($pat,$rpl,$url);
             $url = preg_replace($pat,$rpl,$url);
         }
         }