浏览代码

Allow prefs plugins to fetch values such as FALSE, 0, '', '0', or other values that evaluate to boolean FALSE

pdontthink 17 年之前
父节点
当前提交
4cb8795ffc
共有 1 个文件被更改,包括 3 次插入2 次删除
  1. 3 2
      functions/file_prefs.php

+ 3 - 2
functions/file_prefs.php

@@ -111,14 +111,15 @@ function getPref($data_dir, $username, $pref_name, $default = '') {
 
     $temp = array(&$username, &$pref_name);
     $result = do_hook('get_pref_override', $temp);
-    if (!$result) {
+    if (is_null($result)) {
         cachePrefValues($data_dir, $username);
         if (isset($prefs_cache[$pref_name])) {
             $result = $prefs_cache[$pref_name];
         } else {
+//FIXME: is there a justification for having two prefs hooks so close?  who uses them?
             $temp = array(&$username, &$pref_name);
             $result = do_hook('get_pref', $temp);
-            if (!$result) {
+            if (is_null($result)) {
                 $result = $default;
             }
         }