Browse Source

- Security: Possible cookie theft in src/redirect.php if
register_globals is enabled, and malicous site is running
in same domain.

jangliss 19 years ago
parent
commit
19e3a7b32a
2 changed files with 4 additions and 1 deletions
  1. 3 0
      ChangeLog
  2. 1 1
      functions/strings.php

+ 3 - 0
ChangeLog

@@ -15,6 +15,9 @@ Version 1.5.2 - CVS
   - Fixed View as HTML link so it doesn't forget it was part of a seach result.
   - Fixed View as HTML link so it doesn't forget it was part of a seach result.
   - Don't use delimiter in IMAP subscription command, when noselect folder is
   - Don't use delimiter in IMAP subscription command, when noselect folder is
     created.
     created.
+  - Security: Possible cookie theft in src/redirect.php if 
+    register_globals is enabled, and malicous site is running
+    in same domain.
   
   
 	
 	
 Version 1.5.1 (branched on 2006-02-12)
 Version 1.5.1 (branched on 2006-02-12)

+ 1 - 1
functions/strings.php

@@ -497,7 +497,7 @@ function sqm_baseuri(){
     /**
     /**
      * If it is in the session, just return it.
      * If it is in the session, just return it.
      */
      */
-    if (isset($base_uri)){
+    if (sqgetGlobalVar('base_uri',$base_uri,SQ_SESSION)){
         return $base_uri;
         return $base_uri;
     }
     }
     $dirs = array('|src/.*|', '|plugins/.*|', '|functions/.*|');
     $dirs = array('|src/.*|', '|plugins/.*|', '|functions/.*|');