0ct0pu5/siyuan
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

🎨 Clean code

Browse source
This commit is contained in:
Daniel 2024-04-16 09:01:56 +08:00
parent 26984f39df
commit 94d3ccfa9f
No known key found for this signature in database
GPG key ID: 86211BA83DF03017
12 changed files with 39 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/electron/main.js
View file

@ -713,8 +713,8 @@ app.whenReady().then(() => {
}), new MenuItem({
role: "selectAll", label: langs.selectAll
})];
const menu = Menu.buildFromTemplate(template)
menu.popup({window: BrowserWindow.fromWebContents(event.sender)})
const menu = Menu.buildFromTemplate(template);
menu.popup({window: BrowserWindow.fromWebContents(event.sender)});
});
ipcMain.on("siyuan-open-folder", (event, filePath) => {
shell.showItemInFolder(filePath);

4
app/src/boot/globalEvent/keydown.ts
View file

@ -328,7 +328,7 @@ const editKeydown = (app: App, event: KeyboardEvent) => {
srcIDs: sourceIds,
avID,
}]);
focusByRange(range)
focusByRange(range);
});
} else {
const selectElement: Element[] = [];
@ -363,7 +363,7 @@ const editKeydown = (app: App, event: KeyboardEvent) => {
srcIDs: sourceIds,
avID,
}]);
focusByRange(range)
focusByRange(range);
});
}
event.preventDefault();

2
app/src/layout/dock/util.ts
View file

@ -160,7 +160,7 @@ export const openOutline = async (protyle: IProtyle) => {
}
}), false, false);
newWnd.element.style.width = "200px";
newWnd.element.classList.remove("fn__flex-1")
newWnd.element.classList.remove("fn__flex-1");
switchWnd(newWnd, wnd);
fixWndFlex1(newWnd.parent);
saveLayout();

24
app/src/layout/util.ts
View file

@ -910,7 +910,7 @@ export const adjustLayout = (layout: Layout = window.siyuan.layout.centerLayout.
export const fixWndFlex1 = (layout: Layout) => {
if (layout.children.length < 2) {
return
return;
}
if (layout.children[layout.children.length - 2].element.classList.contains("fn__flex-1")) {
return;
@ -919,27 +919,27 @@ export const fixWndFlex1 = (layout: Layout) => {
if (index !== layout.children.length - 2) {
if (layout.direction === "lr") {
if (item.element.classList.contains("fn__flex-1")) {
item.element.style.width = item.element.clientWidth + "px"
item.element.classList.remove("fn__flex-1")
item.element.style.width = item.element.clientWidth + "px";
item.element.classList.remove("fn__flex-1");
}
} else {
if (item.element.classList.contains("fn__flex-1")) {
item.element.style.height = item.element.clientHeight + "px"
item.element.classList.remove("fn__flex-1")
item.element.style.height = item.element.clientHeight + "px";
item.element.classList.remove("fn__flex-1");
}
}
}
})
const flex1Element = layout.children[layout.children.length - 2].element
});
const flex1Element = layout.children[layout.children.length - 2].element;
if (layout.direction === "lr") {
if (flex1Element.style.width) {
flex1Element.style.width = ""
flex1Element.classList.add("fn__flex-1")
flex1Element.style.width = "";
flex1Element.classList.add("fn__flex-1");
}
} else {
if (flex1Element.style.height) {
flex1Element.style.height = ""
flex1Element.classList.add("fn__flex-1")
flex1Element.style.height = "";
flex1Element.classList.add("fn__flex-1");
}
}
}
};

4
app/src/protyle/gutter/index.ts
View file

@ -811,7 +811,7 @@ export class Gutter {
});
}
}).element);
const range = getSelection().rangeCount > 0 ? getSelection().getRangeAt(0) : undefined
const range = getSelection().rangeCount > 0 ? getSelection().getRangeAt(0) : undefined;
window.siyuan.menus.menu.append(new MenuItem({
label: window.siyuan.languages.addToDatabase,
accelerator: window.siyuan.config.keymap.general.addToDatabase.custom,
@ -1279,7 +1279,7 @@ export class Gutter {
});
}
}).element);
const range = getSelection().rangeCount > 0 ? getSelection().getRangeAt(0) : undefined
const range = getSelection().rangeCount > 0 ? getSelection().getRangeAt(0) : undefined;
window.siyuan.menus.menu.append(new MenuItem({
label: window.siyuan.languages.addToDatabase,
accelerator: window.siyuan.config.keymap.general.addToDatabase.custom,

2
app/src/protyle/header/openTitleMenu.ts
View file

@ -45,7 +45,7 @@ export const openTitleMenu = (protyle: IProtyle, position: IPosition) => {
}).element);
if (!protyle.disabled) {
window.siyuan.menus.menu.append(movePathToMenu([protyle.path]));
const range = getSelection().rangeCount > 0 ? getSelection().getRangeAt(0) : undefined
const range = getSelection().rangeCount > 0 ? getSelection().getRangeAt(0) : undefined;
window.siyuan.menus.menu.append(new MenuItem({
label: window.siyuan.languages.addToDatabase,
accelerator: window.siyuan.config.keymap.general.addToDatabase.custom,

2
app/src/protyle/render/av/cell.ts
View file

@ -589,7 +589,7 @@ export const updateCellsValue = (protyle: IProtyle, nodeElement: HTMLElement, va
return;
}
if (type === "block" && !item.dataset.detached) {
const newId = Lute.NewNodeID()
const newId = Lute.NewNodeID();
doOperations.push({
action: "unbindAttrViewBlock",
id: rowID,

18
app/src/protyle/render/av/filter.ts
View file

@ -57,17 +57,17 @@ const toggleEmpty = (element: HTMLElement, operator: string, type: TAVCol) => {
const filterSelect = (key: string) => {
window.siyuan.menus.menu.element.querySelectorAll(".b3-menu__item").forEach((item) => {
const nameElement = item.querySelector(".b3-chip.b3-chip--middle") as HTMLElement
const nameElement = item.querySelector(".b3-chip.b3-chip--middle") as HTMLElement;
if (nameElement) {
const itemName = nameElement.dataset.name.toLowerCase()
const itemName = nameElement.dataset.name.toLowerCase();
if (!key || (key.indexOf(itemName) > -1 || itemName.indexOf(key) > -1)) {
item.classList.remove("fn__none");
} else {
item.classList.add("fn__none");
}
}
})
}
});
};
export const setFilter = async (options: {
filter: IAVFilter,
@ -332,7 +332,7 @@ export const setFilter = async (options: {
type: "readonly",
label: `<input class="b3-text-field fn__block" style="margin: 4px 0" placeholder="${window.siyuan.languages.search}">`,
bind(element) {
const selectSearchElement = element.querySelector("input")
const selectSearchElement = element.querySelector("input");
selectSearchElement.addEventListener("keydown", (event: KeyboardEvent) => {
if (event.isComposing) {
return;
@ -344,18 +344,18 @@ export const setFilter = async (options: {
}
currentElement.dispatchEvent(new CustomEvent("click"));
}
})
});
selectSearchElement.addEventListener("input", (event: InputEvent) => {
if (event.isComposing) {
return;
}
filterSelect(selectSearchElement.value.toLowerCase());
})
});
selectSearchElement.addEventListener("compositionend", () => {
filterSelect(selectSearchElement.value.toLowerCase());
})
});
}
})
});
}
colData.options?.forEach((option) => {
let icon = "iconUncheck";

2
app/src/protyle/render/highlightRender.ts
View file

@ -125,7 +125,7 @@ export const highlightRender = (element: Element, cdn = Constants.PROTYLE_CDN) =
};
export const lineNumberRender = (block: HTMLElement) => {
const lineNumber = block.parentElement.getAttribute("lineNumber")
const lineNumber = block.parentElement.getAttribute("lineNumber");
if (lineNumber === "false") {
return;
}

12
app/src/protyle/upload/index.ts
View file

@ -145,20 +145,20 @@ const genUploadedLabel = (responseText: string, protyle: IProtyle) => {
});
if ((nodeElement && nodeElement.classList.contains("av"))) {
const cellElements: HTMLElement[] = []
const cellElements: HTMLElement[] = [];
nodeElement.querySelectorAll(".av__row--select:not(.av__row--header)").forEach(item => {
item.querySelectorAll(".av__cell").forEach((cellItem: HTMLElement) => {
if (getTypeByCellElement(cellItem) === "mAsset") {
cellElements.push(cellItem);
}
})
})
});
});
if (cellElements.length === 0) {
protyle.wysiwyg.element.querySelectorAll(".av__cell--active").forEach((item: HTMLElement) => {
if (getTypeByCellElement(item) === "mAsset") {
cellElements.push(item);
}
})
});
}
if (cellElements.length > 0) {
updateCellsValue(protyle, nodeElement, avAssets, cellElements);
@ -170,12 +170,12 @@ const genUploadedLabel = (responseText: string, protyle: IProtyle) => {
}
if (document.querySelector(".av__panel")) {
const cellElements: HTMLElement[] = []
const cellElements: HTMLElement[] = [];
protyle.wysiwyg.element.querySelectorAll(".av__cell--active").forEach((item: HTMLElement) => {
if (getTypeByCellElement(item) === "mAsset") {
cellElements.push(item);
}
})
});
if (cellElements.length > 0) {
const blockElement = hasClosestBlock(cellElements[0]);
if (blockElement) {

2
app/src/protyle/util/selection.ts
View file

@ -532,7 +532,7 @@ export const focusBlock = (element: Element, parentElement?: HTMLElement, toStar
range.collapse(true);
setRange = true;
} else if (type === "NodeAttributeView") {
const cursorElement = element.querySelector(".av__cursor")
const cursorElement = element.querySelector(".av__cursor");
if (cursorElement) {
range.setStart(cursorElement.firstChild, 0);
setRange = true;

2
app/src/protyle/wysiwyg/input.ts
View file

@ -20,7 +20,7 @@ export const input = async (protyle: IProtyle, blockElement: HTMLElement, range:
return;
}
if (blockElement.classList.contains("av")) {
const avCursorElement = hasClosestByClassName(range.startContainer, "av__cursor")
const avCursorElement = hasClosestByClassName(range.startContainer, "av__cursor");
if (avCursorElement) {
range.startContainer.textContent = Constants.ZWSP;
} else {