浏览代码

:art: Improve /widget search https://github.com/siyuan-note/siyuan/issues/10917

Daniel 1 年之前
父节点
当前提交
1a487c0251
共有 7 个文件被更改,包括 30 次插入39 次删除
  1. 2 2
      kernel/bazaar/icon.go
  2. 1 1
      kernel/bazaar/package.go
  3. 3 3
      kernel/bazaar/plugin.go
  4. 2 2
      kernel/bazaar/template.go
  5. 2 2
      kernel/bazaar/theme.go
  6. 2 2
      kernel/bazaar/widget.go
  7. 18 27
      kernel/model/widget.go

+ 2 - 2
kernel/bazaar/icon.go

@@ -76,7 +76,7 @@ func Icons() (icons []*Icon) {
 		icon.IconURL = util.BazaarOSSServer + "/package/" + repoURL + "/icon.png"
 		icon.Funding = repo.Package.Funding
 		icon.PreferredFunding = getPreferredFunding(icon.Funding)
-		icon.PreferredName = getPreferredName(icon.Package)
+		icon.PreferredName = GetPreferredName(icon.Package)
 		icon.PreferredDesc = getPreferredDesc(icon.Description)
 		icon.Updated = repo.Updated
 		icon.Stars = repo.Stars
@@ -140,7 +140,7 @@ func InstalledIcons() (ret []*Icon) {
 		icon.PreviewURLThumb = "/appearance/icons/" + dirName + "/preview.png"
 		icon.IconURL = "/appearance/icons/" + dirName + "/icon.png"
 		icon.PreferredFunding = getPreferredFunding(icon.Funding)
-		icon.PreferredName = getPreferredName(icon.Package)
+		icon.PreferredName = GetPreferredName(icon.Package)
 		icon.PreferredDesc = getPreferredDesc(icon.Description)
 		info, statErr := os.Stat(filepath.Join(installPath, "README.md"))
 		if nil != statErr {

+ 1 - 1
kernel/bazaar/package.go

@@ -161,7 +161,7 @@ func getPreferredReadme(readme *Readme) string {
 	return ret
 }
 
-func getPreferredName(pkg *Package) string {
+func GetPreferredName(pkg *Package) string {
 	if nil == pkg.DisplayName {
 		return pkg.Name
 	}

+ 3 - 3
kernel/bazaar/plugin.go

@@ -82,7 +82,7 @@ func Plugins(frontend string) (plugins []*Plugin) {
 		plugin.IconURL = util.BazaarOSSServer + "/package/" + repoURL + "/icon.png"
 		plugin.Funding = repo.Package.Funding
 		plugin.PreferredFunding = getPreferredFunding(plugin.Funding)
-		plugin.PreferredName = getPreferredName(plugin.Package)
+		plugin.PreferredName = GetPreferredName(plugin.Package)
 		plugin.PreferredDesc = getPreferredDesc(plugin.Description)
 		plugin.Updated = repo.Updated
 		plugin.Stars = repo.Stars
@@ -136,7 +136,7 @@ func ParseInstalledPlugin(name, frontend string) (found bool, displayName string
 		}
 
 		found = true
-		displayName = getPreferredName(plugin.Package)
+		displayName = GetPreferredName(plugin.Package)
 		incompatible = isIncompatiblePlugin(plugin, frontend)
 	}
 	return
@@ -179,7 +179,7 @@ func InstalledPlugins(frontend string, checkUpdate bool) (ret []*Plugin) {
 		plugin.PreviewURLThumb = "/plugins/" + dirName + "/preview.png"
 		plugin.IconURL = "/plugins/" + dirName + "/icon.png"
 		plugin.PreferredFunding = getPreferredFunding(plugin.Funding)
-		plugin.PreferredName = getPreferredName(plugin.Package)
+		plugin.PreferredName = GetPreferredName(plugin.Package)
 		plugin.PreferredDesc = getPreferredDesc(plugin.Description)
 		info, statErr := os.Stat(filepath.Join(installPath, "README.md"))
 		if nil != statErr {

+ 2 - 2
kernel/bazaar/template.go

@@ -78,7 +78,7 @@ func Templates() (templates []*Template) {
 		template.IconURL = util.BazaarOSSServer + "/package/" + repoURL + "/icon.png"
 		template.Funding = repo.Package.Funding
 		template.PreferredFunding = getPreferredFunding(template.Funding)
-		template.PreferredName = getPreferredName(template.Package)
+		template.PreferredName = GetPreferredName(template.Package)
 		template.PreferredDesc = getPreferredDesc(template.Description)
 		template.Updated = repo.Updated
 		template.Stars = repo.Stars
@@ -142,7 +142,7 @@ func InstalledTemplates() (ret []*Template) {
 		template.PreviewURLThumb = "/templates/" + dirName + "/preview.png"
 		template.IconURL = "/templates/" + dirName + "/icon.png"
 		template.PreferredFunding = getPreferredFunding(template.Funding)
-		template.PreferredName = getPreferredName(template.Package)
+		template.PreferredName = GetPreferredName(template.Package)
 		template.PreferredDesc = getPreferredDesc(template.Description)
 		info, statErr := os.Stat(filepath.Join(installPath, "README.md"))
 		if nil != statErr {

+ 2 - 2
kernel/bazaar/theme.go

@@ -78,7 +78,7 @@ func Themes() (ret []*Theme) {
 		theme.IconURL = util.BazaarOSSServer + "/package/" + repoURL + "/icon.png"
 		theme.Funding = repo.Package.Funding
 		theme.PreferredFunding = getPreferredFunding(theme.Funding)
-		theme.PreferredName = getPreferredName(theme.Package)
+		theme.PreferredName = GetPreferredName(theme.Package)
 		theme.PreferredDesc = getPreferredDesc(theme.Description)
 		theme.Updated = repo.Updated
 		theme.Stars = repo.Stars
@@ -142,7 +142,7 @@ func InstalledThemes() (ret []*Theme) {
 		theme.PreviewURLThumb = "/appearance/themes/" + dirName + "/preview.png"
 		theme.IconURL = "/appearance/themes/" + dirName + "/icon.png"
 		theme.PreferredFunding = getPreferredFunding(theme.Funding)
-		theme.PreferredName = getPreferredName(theme.Package)
+		theme.PreferredName = GetPreferredName(theme.Package)
 		theme.PreferredDesc = getPreferredDesc(theme.Description)
 		info, statErr := os.Stat(filepath.Join(installPath, "README.md"))
 		if nil != statErr {

+ 2 - 2
kernel/bazaar/widget.go

@@ -78,7 +78,7 @@ func Widgets() (widgets []*Widget) {
 		widget.IconURL = util.BazaarOSSServer + "/package/" + repoURL + "/icon.png"
 		widget.Funding = repo.Package.Funding
 		widget.PreferredFunding = getPreferredFunding(widget.Funding)
-		widget.PreferredName = getPreferredName(widget.Package)
+		widget.PreferredName = GetPreferredName(widget.Package)
 		widget.PreferredDesc = getPreferredDesc(widget.Description)
 		widget.Updated = repo.Updated
 		widget.Stars = repo.Stars
@@ -140,7 +140,7 @@ func InstalledWidgets() (ret []*Widget) {
 		widget.PreviewURLThumb = "/widgets/" + dirName + "/preview.png"
 		widget.IconURL = "/widgets/" + dirName + "/icon.png"
 		widget.PreferredFunding = getPreferredFunding(widget.Funding)
-		widget.PreferredName = getPreferredName(widget.Package)
+		widget.PreferredName = GetPreferredName(widget.Package)
 		widget.PreferredDesc = getPreferredDesc(widget.Description)
 		info, statErr := os.Stat(filepath.Join(installPath, "README.md"))
 		if nil != statErr {

+ 18 - 27
kernel/model/widget.go

@@ -22,54 +22,45 @@ import (
 	"strings"
 
 	"github.com/siyuan-note/logging"
-	"github.com/siyuan-note/siyuan/kernel/search"
+	"github.com/siyuan-note/siyuan/kernel/bazaar"
 	"github.com/siyuan-note/siyuan/kernel/util"
 )
 
 func SearchWidget(keyword string) (ret []*Block) {
 	ret = []*Block{}
-	widgets := filepath.Join(util.DataDir, "widgets")
-	entries, err := os.ReadDir(widgets)
+	widgetsDir := filepath.Join(util.DataDir, "widgets")
+	entries, err := os.ReadDir(widgetsDir)
 	if nil != err {
-		logging.LogErrorf("read dir [%s] failed: %s", widgets, err)
+		logging.LogErrorf("read dir [%s] failed: %s", widgetsDir, err)
 		return
 	}
 
 	k := strings.ToLower(keyword)
+	var widgets []*bazaar.Widget
 	for _, entry := range entries {
 		if !util.IsDirRegularOrSymlink(entry) {
 			continue
 		}
-
-		isWidgetDir := false
-		subEntries, readErr := os.ReadDir(filepath.Join(widgets, entry.Name()))
-		if nil != readErr {
-			logging.LogWarnf("read dir [%s] failed: %s", filepath.Join(widgets, entry.Name()), readErr)
-			continue
-		}
-		for _, subEntry := range subEntries {
-			if !subEntry.IsDir() && "widget.json" == subEntry.Name() {
-				isWidgetDir = true
-				break
-			}
-		}
-		if !isWidgetDir {
+		if strings.HasPrefix(entry.Name(), ".") {
 			continue
 		}
 
-		name := strings.ToLower(entry.Name())
-		if strings.HasPrefix(name, ".") {
+		widget, _ := bazaar.WidgetJSON(entry.Name())
+		if nil == widget {
 			continue
 		}
 
-		if strings.Contains(name, k) {
-			name = entry.Name()
-			if "" != keyword {
-				_, name = search.MarkText(entry.Name(), keyword, 32, Conf.Search.CaseSensitive)
-			}
-			b := &Block{Content: name}
-			ret = append(ret, b)
+		widgets = append(widgets, widget)
+	}
+
+	widgets = filterWidgets(widgets, k)
+	for _, widget := range widgets {
+		b := &Block{
+			Name:    bazaar.GetPreferredName(widget.Package),
+			Content: widget.Name,
 		}
+		ret = append(ret, b)
 	}
+
 	return
 }