Преглед на файлове

remove DKIM-Signature if any

Son NK преди 5 години
родител
ревизия
4799721667
променени са 2 файла, в които са добавени 4 реда и са изтрити 15 реда
  1. 4 1
      app/email_utils.py
  2. 0 14
      email_handler.py

+ 4 - 1
app/email_utils.py

@@ -163,6 +163,10 @@ def get_email_part(email_from):
 
 
 def add_dkim_signature(msg: EmailMessage, email_domain: str):
+    if msg["DKIM-Signature"]:
+        LOG.d("Remove DKIM-Signature %s", msg["DKIM-Signature"])
+        del msg["DKIM-Signature"]
+
     # Specify headers in "byte" form
     # Generate message signature
     sig = dkim.sign(
@@ -177,5 +181,4 @@ def add_dkim_signature(msg: EmailMessage, email_domain: str):
     # remove linebreaks from sig
     sig = sig.replace("\n", " ").replace("\r", "")
 
-    # Add the DKIM-Signature
     msg.add_header("DKIM-Signature", sig[len("DKIM-Signature: ") :])

+ 0 - 14
email_handler.py

@@ -169,11 +169,6 @@ class MailHandler:
                 msg, "List-Unsubscribe-Post", "List-Unsubscribe=One-Click"
             )
 
-            # remove DKIM-Signature as Postfix will add this header
-            if msg["DKIM-Signature"]:
-                LOG.d("Remove DKIM-Signature %s", msg["DKIM-Signature"])
-                del msg["DKIM-Signature"]
-
             original_subject = msg["Subject"]
             LOG.d(
                 "Forward mail from %s to %s, subject %s, mail_options %s, rcpt_options %s ",
@@ -240,15 +235,6 @@ class MailHandler:
             return "250 ignored"
 
         # todo: add DKIM-Signature for custom domain
-        # remove DKIM-Signature for custom domain
-        if not alias.endswith(EMAIL_DOMAIN) and msg["DKIM-Signature"]:
-            LOG.d(
-                "Remove DKIM-Signature %s for custom-domain alias %s",
-                msg["DKIM-Signature"],
-                alias,
-            )
-            del msg["DKIM-Signature"]
-
         # add DKIM-Signature for non-custom-domain alias
         if alias.endswith(EMAIL_DOMAIN):
             add_dkim_signature(msg, EMAIL_DOMAIN)