oidc_test.go 50 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558
  1. // Copyright (C) 2019-2023 Nicola Murino
  2. //
  3. // This program is free software: you can redistribute it and/or modify
  4. // it under the terms of the GNU Affero General Public License as published
  5. // by the Free Software Foundation, version 3.
  6. //
  7. // This program is distributed in the hope that it will be useful,
  8. // but WITHOUT ANY WARRANTY; without even the implied warranty of
  9. // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  10. // GNU Affero General Public License for more details.
  11. //
  12. // You should have received a copy of the GNU Affero General Public License
  13. // along with this program. If not, see <https://www.gnu.org/licenses/>.
  14. package httpd
  15. import (
  16. "bytes"
  17. "context"
  18. "encoding/json"
  19. "fmt"
  20. "net/http"
  21. "net/http/httptest"
  22. "net/url"
  23. "os"
  24. "path/filepath"
  25. "reflect"
  26. "runtime"
  27. "testing"
  28. "time"
  29. "unsafe"
  30. "github.com/coreos/go-oidc/v3/oidc"
  31. "github.com/go-chi/jwtauth/v5"
  32. "github.com/lestrrat-go/jwx/v2/jwa"
  33. "github.com/rs/xid"
  34. "github.com/sftpgo/sdk"
  35. "github.com/stretchr/testify/assert"
  36. "github.com/stretchr/testify/require"
  37. "golang.org/x/oauth2"
  38. "github.com/drakkan/sftpgo/v2/internal/common"
  39. "github.com/drakkan/sftpgo/v2/internal/dataprovider"
  40. "github.com/drakkan/sftpgo/v2/internal/kms"
  41. "github.com/drakkan/sftpgo/v2/internal/util"
  42. "github.com/drakkan/sftpgo/v2/internal/vfs"
  43. )
  44. const (
  45. oidcMockAddr = "127.0.0.1:11111"
  46. )
  47. type mockTokenSource struct {
  48. token *oauth2.Token
  49. err error
  50. }
  51. func (t *mockTokenSource) Token() (*oauth2.Token, error) {
  52. return t.token, t.err
  53. }
  54. type mockOAuth2Config struct {
  55. tokenSource *mockTokenSource
  56. authCodeURL string
  57. token *oauth2.Token
  58. err error
  59. }
  60. func (c *mockOAuth2Config) AuthCodeURL(state string, opts ...oauth2.AuthCodeOption) string {
  61. return c.authCodeURL
  62. }
  63. func (c *mockOAuth2Config) Exchange(ctx context.Context, code string, opts ...oauth2.AuthCodeOption) (*oauth2.Token, error) {
  64. return c.token, c.err
  65. }
  66. func (c *mockOAuth2Config) TokenSource(ctx context.Context, t *oauth2.Token) oauth2.TokenSource {
  67. return c.tokenSource
  68. }
  69. type mockOIDCVerifier struct {
  70. token *oidc.IDToken
  71. err error
  72. }
  73. func (v *mockOIDCVerifier) Verify(ctx context.Context, rawIDToken string) (*oidc.IDToken, error) {
  74. return v.token, v.err
  75. }
  76. // hack because the field is unexported
  77. func setIDTokenClaims(idToken *oidc.IDToken, claims []byte) {
  78. pointerVal := reflect.ValueOf(idToken)
  79. val := reflect.Indirect(pointerVal)
  80. member := val.FieldByName("claims")
  81. ptr := unsafe.Pointer(member.UnsafeAddr())
  82. realPtr := (*[]byte)(ptr)
  83. *realPtr = claims
  84. }
  85. func TestOIDCInitialization(t *testing.T) {
  86. config := OIDC{}
  87. err := config.initialize()
  88. assert.NoError(t, err)
  89. config = OIDC{
  90. ClientID: "sftpgo-client",
  91. ClientSecret: "jRsmE0SWnuZjP7djBqNq0mrf8QN77j2c",
  92. ConfigURL: fmt.Sprintf("http://%v/", oidcMockAddr),
  93. RedirectBaseURL: "http://127.0.0.1:8081/",
  94. UsernameField: "preferred_username",
  95. RoleField: "sftpgo_role",
  96. }
  97. err = config.initialize()
  98. if assert.Error(t, err) {
  99. assert.Contains(t, err.Error(), "oidc: required scope \"openid\" is not set")
  100. }
  101. config.Scopes = []string{oidc.ScopeOpenID}
  102. err = config.initialize()
  103. if assert.Error(t, err) {
  104. assert.Contains(t, err.Error(), "oidc: unable to initialize provider")
  105. }
  106. config.ConfigURL = fmt.Sprintf("http://%v/auth/realms/sftpgo", oidcMockAddr)
  107. err = config.initialize()
  108. assert.NoError(t, err)
  109. assert.Equal(t, "http://127.0.0.1:8081"+webOIDCRedirectPath, config.getRedirectURL())
  110. }
  111. func TestOIDCLoginLogout(t *testing.T) {
  112. oidcMgr, ok := oidcMgr.(*memoryOIDCManager)
  113. require.True(t, ok)
  114. server := getTestOIDCServer()
  115. err := server.binding.OIDC.initialize()
  116. assert.NoError(t, err)
  117. server.initializeRouter()
  118. rr := httptest.NewRecorder()
  119. r, err := http.NewRequest(http.MethodGet, webOIDCRedirectPath, nil)
  120. assert.NoError(t, err)
  121. server.router.ServeHTTP(rr, r)
  122. assert.Equal(t, http.StatusBadRequest, rr.Code)
  123. assert.Contains(t, rr.Body.String(), "Authentication state did not match")
  124. expiredAuthReq := oidcPendingAuth{
  125. State: xid.New().String(),
  126. Nonce: xid.New().String(),
  127. Audience: tokenAudienceWebClient,
  128. IssuedAt: util.GetTimeAsMsSinceEpoch(time.Now().Add(-10 * time.Minute)),
  129. }
  130. oidcMgr.addPendingAuth(expiredAuthReq)
  131. rr = httptest.NewRecorder()
  132. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+expiredAuthReq.State, nil)
  133. assert.NoError(t, err)
  134. server.router.ServeHTTP(rr, r)
  135. assert.Equal(t, http.StatusBadRequest, rr.Code)
  136. assert.Contains(t, rr.Body.String(), "Authentication state did not match")
  137. oidcMgr.removePendingAuth(expiredAuthReq.State)
  138. server.binding.OIDC.oauth2Config = &mockOAuth2Config{
  139. tokenSource: &mockTokenSource{},
  140. authCodeURL: webOIDCRedirectPath,
  141. err: common.ErrGenericFailure,
  142. }
  143. server.binding.OIDC.verifier = &mockOIDCVerifier{
  144. err: common.ErrGenericFailure,
  145. }
  146. rr = httptest.NewRecorder()
  147. r, err = http.NewRequest(http.MethodGet, webAdminOIDCLoginPath, nil)
  148. assert.NoError(t, err)
  149. server.router.ServeHTTP(rr, r)
  150. assert.Equal(t, http.StatusFound, rr.Code)
  151. assert.Equal(t, webOIDCRedirectPath, rr.Header().Get("Location"))
  152. require.Len(t, oidcMgr.pendingAuths, 1)
  153. var state string
  154. for k := range oidcMgr.pendingAuths {
  155. state = k
  156. }
  157. rr = httptest.NewRecorder()
  158. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+state, nil)
  159. assert.NoError(t, err)
  160. server.router.ServeHTTP(rr, r)
  161. assert.Equal(t, http.StatusFound, rr.Code)
  162. assert.Equal(t, webAdminLoginPath, rr.Header().Get("Location"))
  163. require.Len(t, oidcMgr.pendingAuths, 0)
  164. rr = httptest.NewRecorder()
  165. r, err = http.NewRequest(http.MethodGet, webAdminLoginPath, nil)
  166. assert.NoError(t, err)
  167. server.router.ServeHTTP(rr, r)
  168. assert.Equal(t, http.StatusOK, rr.Code)
  169. // now the same for the web client
  170. rr = httptest.NewRecorder()
  171. r, err = http.NewRequest(http.MethodGet, webClientOIDCLoginPath, nil)
  172. assert.NoError(t, err)
  173. server.router.ServeHTTP(rr, r)
  174. assert.Equal(t, http.StatusFound, rr.Code)
  175. assert.Equal(t, webOIDCRedirectPath, rr.Header().Get("Location"))
  176. require.Len(t, oidcMgr.pendingAuths, 1)
  177. for k := range oidcMgr.pendingAuths {
  178. state = k
  179. }
  180. rr = httptest.NewRecorder()
  181. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+state, nil)
  182. assert.NoError(t, err)
  183. server.router.ServeHTTP(rr, r)
  184. assert.Equal(t, http.StatusFound, rr.Code)
  185. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  186. require.Len(t, oidcMgr.pendingAuths, 0)
  187. rr = httptest.NewRecorder()
  188. r, err = http.NewRequest(http.MethodGet, webClientLoginPath, nil)
  189. assert.NoError(t, err)
  190. server.router.ServeHTTP(rr, r)
  191. assert.Equal(t, http.StatusOK, rr.Code)
  192. // now return an OAuth2 token without the id_token
  193. server.binding.OIDC.oauth2Config = &mockOAuth2Config{
  194. tokenSource: &mockTokenSource{},
  195. authCodeURL: webOIDCRedirectPath,
  196. token: &oauth2.Token{
  197. AccessToken: "123",
  198. Expiry: time.Now().Add(5 * time.Minute),
  199. },
  200. err: nil,
  201. }
  202. authReq := newOIDCPendingAuth(tokenAudienceWebClient)
  203. oidcMgr.addPendingAuth(authReq)
  204. rr = httptest.NewRecorder()
  205. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  206. assert.NoError(t, err)
  207. server.router.ServeHTTP(rr, r)
  208. assert.Equal(t, http.StatusFound, rr.Code)
  209. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  210. require.Len(t, oidcMgr.pendingAuths, 0)
  211. // now fail to verify the id token
  212. token := &oauth2.Token{
  213. AccessToken: "123",
  214. Expiry: time.Now().Add(5 * time.Minute),
  215. }
  216. token = token.WithExtra(map[string]any{
  217. "id_token": "id_token_val",
  218. })
  219. server.binding.OIDC.oauth2Config = &mockOAuth2Config{
  220. tokenSource: &mockTokenSource{},
  221. authCodeURL: webOIDCRedirectPath,
  222. token: token,
  223. err: nil,
  224. }
  225. authReq = newOIDCPendingAuth(tokenAudienceWebClient)
  226. oidcMgr.addPendingAuth(authReq)
  227. rr = httptest.NewRecorder()
  228. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  229. assert.NoError(t, err)
  230. server.router.ServeHTTP(rr, r)
  231. assert.Equal(t, http.StatusFound, rr.Code)
  232. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  233. require.Len(t, oidcMgr.pendingAuths, 0)
  234. // id token nonce does not match
  235. server.binding.OIDC.verifier = &mockOIDCVerifier{
  236. err: nil,
  237. token: &oidc.IDToken{},
  238. }
  239. authReq = newOIDCPendingAuth(tokenAudienceWebClient)
  240. oidcMgr.addPendingAuth(authReq)
  241. rr = httptest.NewRecorder()
  242. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  243. assert.NoError(t, err)
  244. server.router.ServeHTTP(rr, r)
  245. assert.Equal(t, http.StatusFound, rr.Code)
  246. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  247. require.Len(t, oidcMgr.pendingAuths, 0)
  248. // null id token claims
  249. authReq = newOIDCPendingAuth(tokenAudienceWebClient)
  250. oidcMgr.addPendingAuth(authReq)
  251. server.binding.OIDC.verifier = &mockOIDCVerifier{
  252. err: nil,
  253. token: &oidc.IDToken{
  254. Nonce: authReq.Nonce,
  255. },
  256. }
  257. rr = httptest.NewRecorder()
  258. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  259. assert.NoError(t, err)
  260. server.router.ServeHTTP(rr, r)
  261. assert.Equal(t, http.StatusFound, rr.Code)
  262. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  263. require.Len(t, oidcMgr.pendingAuths, 0)
  264. // invalid id token claims (no username)
  265. authReq = newOIDCPendingAuth(tokenAudienceWebClient)
  266. oidcMgr.addPendingAuth(authReq)
  267. idToken := &oidc.IDToken{
  268. Nonce: authReq.Nonce,
  269. Expiry: time.Now().Add(5 * time.Minute),
  270. }
  271. setIDTokenClaims(idToken, []byte(`{"aud": "my_client_id"}`))
  272. server.binding.OIDC.verifier = &mockOIDCVerifier{
  273. err: nil,
  274. token: idToken,
  275. }
  276. rr = httptest.NewRecorder()
  277. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  278. assert.NoError(t, err)
  279. server.router.ServeHTTP(rr, r)
  280. assert.Equal(t, http.StatusFound, rr.Code)
  281. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  282. require.Len(t, oidcMgr.pendingAuths, 0)
  283. // invalid audience
  284. authReq = newOIDCPendingAuth(tokenAudienceWebClient)
  285. oidcMgr.addPendingAuth(authReq)
  286. idToken = &oidc.IDToken{
  287. Nonce: authReq.Nonce,
  288. Expiry: time.Now().Add(5 * time.Minute),
  289. }
  290. setIDTokenClaims(idToken, []byte(`{"preferred_username":"test","sftpgo_role":"admin"}`))
  291. server.binding.OIDC.verifier = &mockOIDCVerifier{
  292. err: nil,
  293. token: idToken,
  294. }
  295. rr = httptest.NewRecorder()
  296. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  297. assert.NoError(t, err)
  298. server.router.ServeHTTP(rr, r)
  299. assert.Equal(t, http.StatusFound, rr.Code)
  300. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  301. require.Len(t, oidcMgr.pendingAuths, 0)
  302. // invalid audience
  303. authReq = newOIDCPendingAuth(tokenAudienceWebAdmin)
  304. oidcMgr.addPendingAuth(authReq)
  305. idToken = &oidc.IDToken{
  306. Nonce: authReq.Nonce,
  307. Expiry: time.Now().Add(5 * time.Minute),
  308. }
  309. setIDTokenClaims(idToken, []byte(`{"preferred_username":"test"}`))
  310. server.binding.OIDC.verifier = &mockOIDCVerifier{
  311. err: nil,
  312. token: idToken,
  313. }
  314. rr = httptest.NewRecorder()
  315. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  316. assert.NoError(t, err)
  317. server.router.ServeHTTP(rr, r)
  318. assert.Equal(t, http.StatusFound, rr.Code)
  319. assert.Equal(t, webAdminLoginPath, rr.Header().Get("Location"))
  320. require.Len(t, oidcMgr.pendingAuths, 0)
  321. // mapped user not found
  322. authReq = newOIDCPendingAuth(tokenAudienceWebAdmin)
  323. oidcMgr.addPendingAuth(authReq)
  324. idToken = &oidc.IDToken{
  325. Nonce: authReq.Nonce,
  326. Expiry: time.Now().Add(5 * time.Minute),
  327. }
  328. setIDTokenClaims(idToken, []byte(`{"preferred_username":"test","sftpgo_role":"admin"}`))
  329. server.binding.OIDC.verifier = &mockOIDCVerifier{
  330. err: nil,
  331. token: idToken,
  332. }
  333. rr = httptest.NewRecorder()
  334. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  335. assert.NoError(t, err)
  336. server.router.ServeHTTP(rr, r)
  337. assert.Equal(t, http.StatusFound, rr.Code)
  338. assert.Equal(t, webAdminLoginPath, rr.Header().Get("Location"))
  339. require.Len(t, oidcMgr.pendingAuths, 0)
  340. // admin login ok
  341. authReq = newOIDCPendingAuth(tokenAudienceWebAdmin)
  342. oidcMgr.addPendingAuth(authReq)
  343. idToken = &oidc.IDToken{
  344. Nonce: authReq.Nonce,
  345. Expiry: time.Now().Add(5 * time.Minute),
  346. }
  347. setIDTokenClaims(idToken, []byte(`{"preferred_username":"admin","sftpgo_role":"admin","sid":"sid123"}`))
  348. server.binding.OIDC.verifier = &mockOIDCVerifier{
  349. err: nil,
  350. token: idToken,
  351. }
  352. rr = httptest.NewRecorder()
  353. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  354. assert.NoError(t, err)
  355. server.router.ServeHTTP(rr, r)
  356. assert.Equal(t, http.StatusFound, rr.Code)
  357. assert.Equal(t, webUsersPath, rr.Header().Get("Location"))
  358. require.Len(t, oidcMgr.pendingAuths, 0)
  359. require.Len(t, oidcMgr.tokens, 1)
  360. // admin profile is not available
  361. var tokenCookie string
  362. for k := range oidcMgr.tokens {
  363. tokenCookie = k
  364. }
  365. oidcToken, err := oidcMgr.getToken(tokenCookie)
  366. assert.NoError(t, err)
  367. assert.Equal(t, "sid123", oidcToken.SessionID)
  368. assert.True(t, oidcToken.isAdmin())
  369. assert.False(t, oidcToken.isExpired())
  370. rr = httptest.NewRecorder()
  371. r, err = http.NewRequest(http.MethodGet, webAdminProfilePath, nil)
  372. assert.NoError(t, err)
  373. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, tokenCookie))
  374. server.router.ServeHTTP(rr, r)
  375. assert.Equal(t, http.StatusForbidden, rr.Code)
  376. // the admin can access the allowed pages
  377. rr = httptest.NewRecorder()
  378. r, err = http.NewRequest(http.MethodGet, webUsersPath, nil)
  379. assert.NoError(t, err)
  380. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, tokenCookie))
  381. server.router.ServeHTTP(rr, r)
  382. assert.Equal(t, http.StatusOK, rr.Code)
  383. // try with an invalid cookie
  384. rr = httptest.NewRecorder()
  385. r, err = http.NewRequest(http.MethodGet, webUsersPath, nil)
  386. assert.NoError(t, err)
  387. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, xid.New().String()))
  388. server.router.ServeHTTP(rr, r)
  389. assert.Equal(t, http.StatusFound, rr.Code)
  390. assert.Equal(t, webAdminLoginPath, rr.Header().Get("Location"))
  391. // Web Client is not available with an admin token
  392. rr = httptest.NewRecorder()
  393. r, err = http.NewRequest(http.MethodGet, webClientFilesPath, nil)
  394. assert.NoError(t, err)
  395. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, tokenCookie))
  396. server.router.ServeHTTP(rr, r)
  397. assert.Equal(t, http.StatusFound, rr.Code)
  398. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  399. // logout the admin user
  400. rr = httptest.NewRecorder()
  401. r, err = http.NewRequest(http.MethodGet, webLogoutPath, nil)
  402. assert.NoError(t, err)
  403. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, tokenCookie))
  404. server.router.ServeHTTP(rr, r)
  405. assert.Equal(t, http.StatusFound, rr.Code)
  406. assert.Equal(t, webAdminLoginPath, rr.Header().Get("Location"))
  407. require.Len(t, oidcMgr.pendingAuths, 0)
  408. require.Len(t, oidcMgr.tokens, 0)
  409. // now login and logout a user
  410. username := "test_oidc_user"
  411. user := dataprovider.User{
  412. BaseUser: sdk.BaseUser{
  413. Username: username,
  414. Password: "pwd",
  415. HomeDir: filepath.Join(os.TempDir(), username),
  416. Status: 1,
  417. Permissions: map[string][]string{
  418. "/": {dataprovider.PermAny},
  419. },
  420. },
  421. Filters: dataprovider.UserFilters{
  422. BaseUserFilters: sdk.BaseUserFilters{
  423. WebClient: []string{sdk.WebClientSharesDisabled},
  424. },
  425. },
  426. }
  427. err = dataprovider.AddUser(&user, "", "", "")
  428. assert.NoError(t, err)
  429. authReq = newOIDCPendingAuth(tokenAudienceWebClient)
  430. oidcMgr.addPendingAuth(authReq)
  431. idToken = &oidc.IDToken{
  432. Nonce: authReq.Nonce,
  433. Expiry: time.Now().Add(5 * time.Minute),
  434. }
  435. setIDTokenClaims(idToken, []byte(`{"preferred_username":"test_oidc_user"}`))
  436. server.binding.OIDC.verifier = &mockOIDCVerifier{
  437. err: nil,
  438. token: idToken,
  439. }
  440. rr = httptest.NewRecorder()
  441. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  442. assert.NoError(t, err)
  443. server.router.ServeHTTP(rr, r)
  444. assert.Equal(t, http.StatusFound, rr.Code)
  445. assert.Equal(t, webClientFilesPath, rr.Header().Get("Location"))
  446. require.Len(t, oidcMgr.pendingAuths, 0)
  447. require.Len(t, oidcMgr.tokens, 1)
  448. // user profile is not available
  449. for k := range oidcMgr.tokens {
  450. tokenCookie = k
  451. }
  452. oidcToken, err = oidcMgr.getToken(tokenCookie)
  453. assert.NoError(t, err)
  454. assert.Empty(t, oidcToken.SessionID)
  455. assert.False(t, oidcToken.isAdmin())
  456. assert.False(t, oidcToken.isExpired())
  457. if assert.Len(t, oidcToken.Permissions, 1) {
  458. assert.Equal(t, sdk.WebClientSharesDisabled, oidcToken.Permissions[0])
  459. }
  460. rr = httptest.NewRecorder()
  461. r, err = http.NewRequest(http.MethodGet, webClientProfilePath, nil)
  462. assert.NoError(t, err)
  463. r.RequestURI = webClientProfilePath
  464. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, tokenCookie))
  465. server.router.ServeHTTP(rr, r)
  466. assert.Equal(t, http.StatusOK, rr.Code)
  467. // the user can access the allowed pages
  468. rr = httptest.NewRecorder()
  469. r, err = http.NewRequest(http.MethodGet, webClientFilesPath, nil)
  470. assert.NoError(t, err)
  471. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, tokenCookie))
  472. server.router.ServeHTTP(rr, r)
  473. assert.Equal(t, http.StatusOK, rr.Code)
  474. // try with an invalid cookie
  475. rr = httptest.NewRecorder()
  476. r, err = http.NewRequest(http.MethodGet, webClientFilesPath, nil)
  477. assert.NoError(t, err)
  478. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, xid.New().String()))
  479. server.router.ServeHTTP(rr, r)
  480. assert.Equal(t, http.StatusFound, rr.Code)
  481. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  482. // Web Admin is not available with a client cookie
  483. rr = httptest.NewRecorder()
  484. r, err = http.NewRequest(http.MethodGet, webUsersPath, nil)
  485. assert.NoError(t, err)
  486. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, tokenCookie))
  487. server.router.ServeHTTP(rr, r)
  488. assert.Equal(t, http.StatusFound, rr.Code)
  489. assert.Equal(t, webAdminLoginPath, rr.Header().Get("Location"))
  490. // logout the user
  491. rr = httptest.NewRecorder()
  492. r, err = http.NewRequest(http.MethodGet, webClientLogoutPath, nil)
  493. assert.NoError(t, err)
  494. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, tokenCookie))
  495. server.router.ServeHTTP(rr, r)
  496. assert.Equal(t, http.StatusFound, rr.Code)
  497. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  498. require.Len(t, oidcMgr.pendingAuths, 0)
  499. require.Len(t, oidcMgr.tokens, 0)
  500. err = os.RemoveAll(user.GetHomeDir())
  501. assert.NoError(t, err)
  502. err = dataprovider.DeleteUser(username, "", "", "")
  503. assert.NoError(t, err)
  504. }
  505. func TestOIDCRefreshToken(t *testing.T) {
  506. oidcMgr, ok := oidcMgr.(*memoryOIDCManager)
  507. require.True(t, ok)
  508. r, err := http.NewRequest(http.MethodGet, webUsersPath, nil)
  509. assert.NoError(t, err)
  510. token := oidcToken{
  511. Cookie: xid.New().String(),
  512. AccessToken: xid.New().String(),
  513. TokenType: "Bearer",
  514. ExpiresAt: util.GetTimeAsMsSinceEpoch(time.Now().Add(-1 * time.Minute)),
  515. Nonce: xid.New().String(),
  516. Role: adminRoleFieldValue,
  517. Username: defaultAdminUsername,
  518. }
  519. config := mockOAuth2Config{
  520. tokenSource: &mockTokenSource{
  521. err: common.ErrGenericFailure,
  522. },
  523. }
  524. verifier := mockOIDCVerifier{
  525. err: common.ErrGenericFailure,
  526. }
  527. err = token.refresh(&config, &verifier, r)
  528. if assert.Error(t, err) {
  529. assert.Contains(t, err.Error(), "refresh token not set")
  530. }
  531. token.RefreshToken = xid.New().String()
  532. err = token.refresh(&config, &verifier, r)
  533. assert.ErrorIs(t, err, common.ErrGenericFailure)
  534. newToken := &oauth2.Token{
  535. AccessToken: xid.New().String(),
  536. RefreshToken: xid.New().String(),
  537. Expiry: time.Now().Add(5 * time.Minute),
  538. }
  539. config = mockOAuth2Config{
  540. tokenSource: &mockTokenSource{
  541. token: newToken,
  542. },
  543. }
  544. verifier = mockOIDCVerifier{
  545. token: &oidc.IDToken{},
  546. }
  547. err = token.refresh(&config, &verifier, r)
  548. if assert.Error(t, err) {
  549. assert.Contains(t, err.Error(), "the refreshed token has no id token")
  550. }
  551. newToken = newToken.WithExtra(map[string]any{
  552. "id_token": "id_token_val",
  553. })
  554. newToken.Expiry = time.Time{}
  555. config = mockOAuth2Config{
  556. tokenSource: &mockTokenSource{
  557. token: newToken,
  558. },
  559. }
  560. verifier = mockOIDCVerifier{
  561. err: common.ErrGenericFailure,
  562. }
  563. err = token.refresh(&config, &verifier, r)
  564. assert.ErrorIs(t, err, common.ErrGenericFailure)
  565. newToken = newToken.WithExtra(map[string]any{
  566. "id_token": "id_token_val",
  567. })
  568. newToken.Expiry = time.Now().Add(5 * time.Minute)
  569. config = mockOAuth2Config{
  570. tokenSource: &mockTokenSource{
  571. token: newToken,
  572. },
  573. }
  574. verifier = mockOIDCVerifier{
  575. token: &oidc.IDToken{},
  576. }
  577. err = token.refresh(&config, &verifier, r)
  578. if assert.Error(t, err) {
  579. assert.Contains(t, err.Error(), "the refreshed token nonce mismatch")
  580. }
  581. verifier = mockOIDCVerifier{
  582. token: &oidc.IDToken{
  583. Nonce: token.Nonce,
  584. },
  585. }
  586. err = token.refresh(&config, &verifier, r)
  587. if assert.Error(t, err) {
  588. assert.Contains(t, err.Error(), "oidc: claims not set")
  589. }
  590. idToken := &oidc.IDToken{
  591. Nonce: token.Nonce,
  592. }
  593. setIDTokenClaims(idToken, []byte(`{"sid":"id_token_sid"}`))
  594. verifier = mockOIDCVerifier{
  595. token: idToken,
  596. }
  597. err = token.refresh(&config, &verifier, r)
  598. assert.NoError(t, err)
  599. assert.Len(t, token.Permissions, 1)
  600. token.Role = nil
  601. // user does not exist
  602. err = token.refresh(&config, &verifier, r)
  603. assert.Error(t, err)
  604. require.Len(t, oidcMgr.tokens, 1)
  605. oidcMgr.removeToken(token.Cookie)
  606. require.Len(t, oidcMgr.tokens, 0)
  607. }
  608. func TestOIDCRefreshUser(t *testing.T) {
  609. token := oidcToken{
  610. Cookie: xid.New().String(),
  611. AccessToken: xid.New().String(),
  612. TokenType: "Bearer",
  613. ExpiresAt: util.GetTimeAsMsSinceEpoch(time.Now().Add(1 * time.Minute)),
  614. Nonce: xid.New().String(),
  615. Role: adminRoleFieldValue,
  616. Username: "missing username",
  617. }
  618. r, err := http.NewRequest(http.MethodGet, webUsersPath, nil)
  619. assert.NoError(t, err)
  620. err = token.refreshUser(r)
  621. assert.Error(t, err)
  622. admin := dataprovider.Admin{
  623. Username: "test_oidc_admin_refresh",
  624. Password: "p",
  625. Permissions: []string{dataprovider.PermAdminAny},
  626. Status: 0,
  627. Filters: dataprovider.AdminFilters{
  628. Preferences: dataprovider.AdminPreferences{
  629. HideUserPageSections: 1 + 2 + 4,
  630. },
  631. },
  632. }
  633. err = dataprovider.AddAdmin(&admin, "", "", "")
  634. assert.NoError(t, err)
  635. token.Username = admin.Username
  636. err = token.refreshUser(r)
  637. if assert.Error(t, err) {
  638. assert.Contains(t, err.Error(), "is disabled")
  639. }
  640. admin.Status = 1
  641. err = dataprovider.UpdateAdmin(&admin, "", "", "")
  642. assert.NoError(t, err)
  643. err = token.refreshUser(r)
  644. assert.NoError(t, err)
  645. assert.Equal(t, admin.Permissions, token.Permissions)
  646. assert.Equal(t, admin.Filters.Preferences.HideUserPageSections, token.HideUserPageSections)
  647. err = dataprovider.DeleteAdmin(admin.Username, "", "", "")
  648. assert.NoError(t, err)
  649. username := "test_oidc_user_refresh_token"
  650. user := dataprovider.User{
  651. BaseUser: sdk.BaseUser{
  652. Username: username,
  653. Password: "p",
  654. HomeDir: filepath.Join(os.TempDir(), username),
  655. Status: 0,
  656. Permissions: map[string][]string{
  657. "/": {dataprovider.PermAny},
  658. },
  659. },
  660. Filters: dataprovider.UserFilters{
  661. BaseUserFilters: sdk.BaseUserFilters{
  662. DeniedProtocols: []string{common.ProtocolHTTP},
  663. WebClient: []string{sdk.WebClientSharesDisabled, sdk.WebClientWriteDisabled},
  664. },
  665. },
  666. }
  667. err = dataprovider.AddUser(&user, "", "", "")
  668. assert.NoError(t, err)
  669. r, err = http.NewRequest(http.MethodGet, webClientFilesPath, nil)
  670. assert.NoError(t, err)
  671. token.Role = nil
  672. token.Username = username
  673. assert.False(t, token.isAdmin())
  674. err = token.refreshUser(r)
  675. if assert.Error(t, err) {
  676. assert.Contains(t, err.Error(), "is disabled")
  677. }
  678. user, err = dataprovider.UserExists(username, "")
  679. assert.NoError(t, err)
  680. user.Status = 1
  681. err = dataprovider.UpdateUser(&user, "", "", "")
  682. assert.NoError(t, err)
  683. err = token.refreshUser(r)
  684. if assert.Error(t, err) {
  685. assert.Contains(t, err.Error(), "protocol HTTP is not allowed")
  686. }
  687. user.Filters.DeniedProtocols = []string{common.ProtocolFTP}
  688. err = dataprovider.UpdateUser(&user, "", "", "")
  689. assert.NoError(t, err)
  690. err = token.refreshUser(r)
  691. assert.NoError(t, err)
  692. assert.Equal(t, user.Filters.WebClient, token.Permissions)
  693. err = dataprovider.DeleteUser(username, "", "", "")
  694. assert.NoError(t, err)
  695. }
  696. func TestValidateOIDCToken(t *testing.T) {
  697. oidcMgr, ok := oidcMgr.(*memoryOIDCManager)
  698. require.True(t, ok)
  699. server := getTestOIDCServer()
  700. err := server.binding.OIDC.initialize()
  701. assert.NoError(t, err)
  702. server.initializeRouter()
  703. rr := httptest.NewRecorder()
  704. r, err := http.NewRequest(http.MethodGet, webClientLogoutPath, nil)
  705. assert.NoError(t, err)
  706. _, err = server.validateOIDCToken(rr, r, false)
  707. assert.ErrorIs(t, err, errInvalidToken)
  708. // expired token and refresh error
  709. server.binding.OIDC.oauth2Config = &mockOAuth2Config{
  710. tokenSource: &mockTokenSource{
  711. err: common.ErrGenericFailure,
  712. },
  713. }
  714. token := oidcToken{
  715. Cookie: xid.New().String(),
  716. AccessToken: xid.New().String(),
  717. ExpiresAt: util.GetTimeAsMsSinceEpoch(time.Now().Add(-2 * time.Minute)),
  718. }
  719. oidcMgr.addToken(token)
  720. rr = httptest.NewRecorder()
  721. r, err = http.NewRequest(http.MethodGet, webClientLogoutPath, nil)
  722. assert.NoError(t, err)
  723. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, token.Cookie))
  724. _, err = server.validateOIDCToken(rr, r, false)
  725. assert.ErrorIs(t, err, errInvalidToken)
  726. oidcMgr.removeToken(token.Cookie)
  727. assert.Len(t, oidcMgr.tokens, 0)
  728. server.tokenAuth = jwtauth.New("PS256", util.GenerateRandomBytes(32), nil)
  729. token = oidcToken{
  730. Cookie: xid.New().String(),
  731. AccessToken: xid.New().String(),
  732. }
  733. oidcMgr.addToken(token)
  734. rr = httptest.NewRecorder()
  735. r, err = http.NewRequest(http.MethodGet, webClientLogoutPath, nil)
  736. assert.NoError(t, err)
  737. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, token.Cookie))
  738. server.router.ServeHTTP(rr, r)
  739. assert.Equal(t, http.StatusFound, rr.Code)
  740. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  741. oidcMgr.removeToken(token.Cookie)
  742. assert.Len(t, oidcMgr.tokens, 0)
  743. token = oidcToken{
  744. Cookie: xid.New().String(),
  745. AccessToken: xid.New().String(),
  746. Role: "admin",
  747. }
  748. oidcMgr.addToken(token)
  749. rr = httptest.NewRecorder()
  750. r, err = http.NewRequest(http.MethodGet, webLogoutPath, nil)
  751. assert.NoError(t, err)
  752. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, token.Cookie))
  753. server.router.ServeHTTP(rr, r)
  754. assert.Equal(t, http.StatusFound, rr.Code)
  755. assert.Equal(t, webAdminLoginPath, rr.Header().Get("Location"))
  756. oidcMgr.removeToken(token.Cookie)
  757. assert.Len(t, oidcMgr.tokens, 0)
  758. }
  759. func TestSkipOIDCAuth(t *testing.T) {
  760. server := getTestOIDCServer()
  761. err := server.binding.OIDC.initialize()
  762. assert.NoError(t, err)
  763. server.initializeRouter()
  764. jwtTokenClaims := jwtTokenClaims{
  765. Username: "user",
  766. }
  767. _, tokenString, err := jwtTokenClaims.createToken(server.tokenAuth, tokenAudienceWebClient, "")
  768. assert.NoError(t, err)
  769. rr := httptest.NewRecorder()
  770. r, err := http.NewRequest(http.MethodGet, webClientLogoutPath, nil)
  771. assert.NoError(t, err)
  772. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", jwtCookieKey, tokenString))
  773. server.router.ServeHTTP(rr, r)
  774. assert.Equal(t, http.StatusFound, rr.Code)
  775. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  776. }
  777. func TestOIDCLogoutErrors(t *testing.T) {
  778. server := getTestOIDCServer()
  779. assert.Empty(t, server.binding.OIDC.providerLogoutURL)
  780. server.logoutFromOIDCOP("")
  781. server.binding.OIDC.providerLogoutURL = "http://foo\x7f.com/"
  782. server.doOIDCFromLogout("")
  783. server.binding.OIDC.providerLogoutURL = "http://127.0.0.1:11234"
  784. server.doOIDCFromLogout("")
  785. }
  786. func TestOIDCToken(t *testing.T) {
  787. admin := dataprovider.Admin{
  788. Username: "test_oidc_admin",
  789. Password: "p",
  790. Permissions: []string{dataprovider.PermAdminAny},
  791. Status: 0,
  792. }
  793. err := dataprovider.AddAdmin(&admin, "", "", "")
  794. assert.NoError(t, err)
  795. token := oidcToken{
  796. Username: admin.Username,
  797. Role: "admin",
  798. }
  799. req, err := http.NewRequest(http.MethodGet, webUsersPath, nil)
  800. assert.NoError(t, err)
  801. err = token.getUser(req)
  802. if assert.Error(t, err) {
  803. assert.Contains(t, err.Error(), "is disabled")
  804. }
  805. err = dataprovider.DeleteAdmin(admin.Username, "", "", "")
  806. assert.NoError(t, err)
  807. username := "test_oidc_user"
  808. token.Username = username
  809. token.Role = ""
  810. err = token.getUser(req)
  811. if assert.Error(t, err) {
  812. assert.ErrorIs(t, err, util.ErrNotFound)
  813. }
  814. user := dataprovider.User{
  815. BaseUser: sdk.BaseUser{
  816. Username: username,
  817. Password: "p",
  818. HomeDir: filepath.Join(os.TempDir(), username),
  819. Status: 0,
  820. Permissions: map[string][]string{
  821. "/": {dataprovider.PermAny},
  822. },
  823. },
  824. Filters: dataprovider.UserFilters{
  825. BaseUserFilters: sdk.BaseUserFilters{
  826. DeniedProtocols: []string{common.ProtocolHTTP},
  827. },
  828. },
  829. }
  830. err = dataprovider.AddUser(&user, "", "", "")
  831. assert.NoError(t, err)
  832. err = token.getUser(req)
  833. if assert.Error(t, err) {
  834. assert.Contains(t, err.Error(), "is disabled")
  835. }
  836. user, err = dataprovider.UserExists(username, "")
  837. assert.NoError(t, err)
  838. user.Status = 1
  839. user.Password = "np"
  840. err = dataprovider.UpdateUser(&user, "", "", "")
  841. assert.NoError(t, err)
  842. err = token.getUser(req)
  843. if assert.Error(t, err) {
  844. assert.Contains(t, err.Error(), "protocol HTTP is not allowed")
  845. }
  846. user.Filters.DeniedProtocols = nil
  847. user.FsConfig.Provider = sdk.SFTPFilesystemProvider
  848. user.FsConfig.SFTPConfig = vfs.SFTPFsConfig{
  849. BaseSFTPFsConfig: sdk.BaseSFTPFsConfig{
  850. Endpoint: "127.0.0.1:8022",
  851. Username: username,
  852. },
  853. Password: kms.NewPlainSecret("np"),
  854. }
  855. err = dataprovider.UpdateUser(&user, "", "", "")
  856. assert.NoError(t, err)
  857. err = token.getUser(req)
  858. if assert.Error(t, err) {
  859. assert.Contains(t, err.Error(), "SFTP loop")
  860. }
  861. common.Config.PostConnectHook = fmt.Sprintf("http://%v/404", oidcMockAddr)
  862. err = token.getUser(req)
  863. if assert.Error(t, err) {
  864. assert.Contains(t, err.Error(), "access denied")
  865. }
  866. common.Config.PostConnectHook = ""
  867. err = os.RemoveAll(user.GetHomeDir())
  868. assert.NoError(t, err)
  869. err = dataprovider.DeleteUser(username, "", "", "")
  870. assert.NoError(t, err)
  871. }
  872. func TestOIDCImplicitRoles(t *testing.T) {
  873. oidcMgr, ok := oidcMgr.(*memoryOIDCManager)
  874. require.True(t, ok)
  875. server := getTestOIDCServer()
  876. server.binding.OIDC.ImplicitRoles = true
  877. err := server.binding.OIDC.initialize()
  878. assert.NoError(t, err)
  879. server.initializeRouter()
  880. authReq := newOIDCPendingAuth(tokenAudienceWebAdmin)
  881. oidcMgr.addPendingAuth(authReq)
  882. token := &oauth2.Token{
  883. AccessToken: "1234",
  884. Expiry: time.Now().Add(5 * time.Minute),
  885. }
  886. token = token.WithExtra(map[string]any{
  887. "id_token": "id_token_val",
  888. })
  889. server.binding.OIDC.oauth2Config = &mockOAuth2Config{
  890. tokenSource: &mockTokenSource{},
  891. authCodeURL: webOIDCRedirectPath,
  892. token: token,
  893. }
  894. idToken := &oidc.IDToken{
  895. Nonce: authReq.Nonce,
  896. Expiry: time.Now().Add(5 * time.Minute),
  897. }
  898. setIDTokenClaims(idToken, []byte(`{"preferred_username":"admin","sid":"sid456"}`))
  899. server.binding.OIDC.verifier = &mockOIDCVerifier{
  900. err: nil,
  901. token: idToken,
  902. }
  903. rr := httptest.NewRecorder()
  904. r, err := http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  905. assert.NoError(t, err)
  906. server.router.ServeHTTP(rr, r)
  907. assert.Equal(t, http.StatusFound, rr.Code)
  908. assert.Equal(t, webUsersPath, rr.Header().Get("Location"))
  909. require.Len(t, oidcMgr.pendingAuths, 0)
  910. require.Len(t, oidcMgr.tokens, 1)
  911. var tokenCookie string
  912. for k := range oidcMgr.tokens {
  913. tokenCookie = k
  914. }
  915. // Web Client is not available with an admin token
  916. rr = httptest.NewRecorder()
  917. r, err = http.NewRequest(http.MethodGet, webClientFilesPath, nil)
  918. assert.NoError(t, err)
  919. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, tokenCookie))
  920. server.router.ServeHTTP(rr, r)
  921. assert.Equal(t, http.StatusFound, rr.Code)
  922. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  923. // logout the admin user
  924. rr = httptest.NewRecorder()
  925. r, err = http.NewRequest(http.MethodGet, webLogoutPath, nil)
  926. assert.NoError(t, err)
  927. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, tokenCookie))
  928. server.router.ServeHTTP(rr, r)
  929. assert.Equal(t, http.StatusFound, rr.Code)
  930. assert.Equal(t, webAdminLoginPath, rr.Header().Get("Location"))
  931. require.Len(t, oidcMgr.pendingAuths, 0)
  932. require.Len(t, oidcMgr.tokens, 0)
  933. // now login and logout a user
  934. username := "test_oidc_implicit_user"
  935. user := dataprovider.User{
  936. BaseUser: sdk.BaseUser{
  937. Username: username,
  938. Password: "pwd",
  939. HomeDir: filepath.Join(os.TempDir(), username),
  940. Status: 1,
  941. Permissions: map[string][]string{
  942. "/": {dataprovider.PermAny},
  943. },
  944. },
  945. Filters: dataprovider.UserFilters{
  946. BaseUserFilters: sdk.BaseUserFilters{
  947. WebClient: []string{sdk.WebClientSharesDisabled},
  948. },
  949. },
  950. }
  951. err = dataprovider.AddUser(&user, "", "", "")
  952. assert.NoError(t, err)
  953. authReq = newOIDCPendingAuth(tokenAudienceWebClient)
  954. oidcMgr.addPendingAuth(authReq)
  955. idToken = &oidc.IDToken{
  956. Nonce: authReq.Nonce,
  957. Expiry: time.Now().Add(5 * time.Minute),
  958. }
  959. setIDTokenClaims(idToken, []byte(`{"preferred_username":"test_oidc_implicit_user"}`))
  960. server.binding.OIDC.verifier = &mockOIDCVerifier{
  961. err: nil,
  962. token: idToken,
  963. }
  964. rr = httptest.NewRecorder()
  965. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  966. assert.NoError(t, err)
  967. server.router.ServeHTTP(rr, r)
  968. assert.Equal(t, http.StatusFound, rr.Code)
  969. assert.Equal(t, webClientFilesPath, rr.Header().Get("Location"))
  970. require.Len(t, oidcMgr.pendingAuths, 0)
  971. require.Len(t, oidcMgr.tokens, 1)
  972. for k := range oidcMgr.tokens {
  973. tokenCookie = k
  974. }
  975. rr = httptest.NewRecorder()
  976. r, err = http.NewRequest(http.MethodGet, webClientLogoutPath, nil)
  977. assert.NoError(t, err)
  978. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, tokenCookie))
  979. server.router.ServeHTTP(rr, r)
  980. assert.Equal(t, http.StatusFound, rr.Code)
  981. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  982. require.Len(t, oidcMgr.pendingAuths, 0)
  983. require.Len(t, oidcMgr.tokens, 0)
  984. err = os.RemoveAll(user.GetHomeDir())
  985. assert.NoError(t, err)
  986. err = dataprovider.DeleteUser(username, "", "", "")
  987. assert.NoError(t, err)
  988. }
  989. func TestMemoryOIDCManager(t *testing.T) {
  990. oidcMgr, ok := oidcMgr.(*memoryOIDCManager)
  991. require.True(t, ok)
  992. require.Len(t, oidcMgr.pendingAuths, 0)
  993. authReq := newOIDCPendingAuth(tokenAudienceWebAdmin)
  994. oidcMgr.addPendingAuth(authReq)
  995. require.Len(t, oidcMgr.pendingAuths, 1)
  996. _, err := oidcMgr.getPendingAuth(authReq.State)
  997. assert.NoError(t, err)
  998. oidcMgr.removePendingAuth(authReq.State)
  999. require.Len(t, oidcMgr.pendingAuths, 0)
  1000. authReq.IssuedAt = util.GetTimeAsMsSinceEpoch(time.Now().Add(-61 * time.Second))
  1001. oidcMgr.addPendingAuth(authReq)
  1002. require.Len(t, oidcMgr.pendingAuths, 1)
  1003. _, err = oidcMgr.getPendingAuth(authReq.State)
  1004. if assert.Error(t, err) {
  1005. assert.Contains(t, err.Error(), "too old")
  1006. }
  1007. oidcMgr.cleanup()
  1008. require.Len(t, oidcMgr.pendingAuths, 0)
  1009. token := oidcToken{
  1010. AccessToken: xid.New().String(),
  1011. Nonce: xid.New().String(),
  1012. SessionID: xid.New().String(),
  1013. Cookie: xid.New().String(),
  1014. Username: xid.New().String(),
  1015. Role: "admin",
  1016. Permissions: []string{dataprovider.PermAdminAny},
  1017. }
  1018. require.Len(t, oidcMgr.tokens, 0)
  1019. oidcMgr.addToken(token)
  1020. require.Len(t, oidcMgr.tokens, 1)
  1021. _, err = oidcMgr.getToken(xid.New().String())
  1022. assert.Error(t, err)
  1023. storedToken, err := oidcMgr.getToken(token.Cookie)
  1024. assert.NoError(t, err)
  1025. token.UsedAt = 0 // ensure we don't modify the stored token
  1026. assert.Greater(t, storedToken.UsedAt, int64(0))
  1027. token.UsedAt = storedToken.UsedAt
  1028. assert.Equal(t, token, storedToken)
  1029. // the usage will not be updated, it is recent
  1030. oidcMgr.updateTokenUsage(storedToken)
  1031. storedToken, err = oidcMgr.getToken(token.Cookie)
  1032. assert.NoError(t, err)
  1033. assert.Equal(t, token, storedToken)
  1034. usedAt := util.GetTimeAsMsSinceEpoch(time.Now().Add(-5 * time.Minute))
  1035. storedToken.UsedAt = usedAt
  1036. oidcMgr.tokens[token.Cookie] = storedToken
  1037. storedToken, err = oidcMgr.getToken(token.Cookie)
  1038. assert.NoError(t, err)
  1039. assert.Equal(t, usedAt, storedToken.UsedAt)
  1040. token.UsedAt = storedToken.UsedAt
  1041. assert.Equal(t, token, storedToken)
  1042. oidcMgr.updateTokenUsage(storedToken)
  1043. storedToken, err = oidcMgr.getToken(token.Cookie)
  1044. assert.NoError(t, err)
  1045. assert.Greater(t, storedToken.UsedAt, usedAt)
  1046. token.UsedAt = storedToken.UsedAt
  1047. assert.Equal(t, token, storedToken)
  1048. storedToken.UsedAt = util.GetTimeAsMsSinceEpoch(time.Now()) - tokenDeleteInterval - 1
  1049. oidcMgr.tokens[token.Cookie] = storedToken
  1050. storedToken, err = oidcMgr.getToken(token.Cookie)
  1051. if assert.Error(t, err) {
  1052. assert.Contains(t, err.Error(), "token is too old")
  1053. }
  1054. oidcMgr.removeToken(xid.New().String())
  1055. require.Len(t, oidcMgr.tokens, 1)
  1056. oidcMgr.removeToken(token.Cookie)
  1057. require.Len(t, oidcMgr.tokens, 0)
  1058. oidcMgr.addToken(token)
  1059. usedAt = util.GetTimeAsMsSinceEpoch(time.Now().Add(-6 * time.Hour))
  1060. token.UsedAt = usedAt
  1061. oidcMgr.tokens[token.Cookie] = token
  1062. newToken := oidcToken{
  1063. Cookie: xid.New().String(),
  1064. }
  1065. oidcMgr.addToken(newToken)
  1066. oidcMgr.cleanup()
  1067. require.Len(t, oidcMgr.tokens, 1)
  1068. _, err = oidcMgr.getToken(token.Cookie)
  1069. assert.Error(t, err)
  1070. _, err = oidcMgr.getToken(newToken.Cookie)
  1071. assert.NoError(t, err)
  1072. oidcMgr.removeToken(newToken.Cookie)
  1073. require.Len(t, oidcMgr.tokens, 0)
  1074. }
  1075. func TestOIDCPreLoginHook(t *testing.T) {
  1076. if runtime.GOOS == osWindows {
  1077. t.Skip("this test is not available on Windows")
  1078. }
  1079. oidcMgr, ok := oidcMgr.(*memoryOIDCManager)
  1080. require.True(t, ok)
  1081. username := "test_oidc_user_prelogin"
  1082. u := dataprovider.User{
  1083. BaseUser: sdk.BaseUser{
  1084. Username: username,
  1085. HomeDir: filepath.Join(os.TempDir(), username),
  1086. Status: 1,
  1087. Permissions: map[string][]string{
  1088. "/": {dataprovider.PermAny},
  1089. },
  1090. },
  1091. }
  1092. preLoginPath := filepath.Join(os.TempDir(), "prelogin.sh")
  1093. providerConf := dataprovider.GetProviderConfig()
  1094. err := dataprovider.Close()
  1095. assert.NoError(t, err)
  1096. err = os.WriteFile(preLoginPath, getPreLoginScriptContent(u, false), os.ModePerm)
  1097. assert.NoError(t, err)
  1098. newProviderConf := providerConf
  1099. newProviderConf.PreLoginHook = preLoginPath
  1100. err = dataprovider.Initialize(newProviderConf, configDir, true)
  1101. assert.NoError(t, err)
  1102. server := getTestOIDCServer()
  1103. server.binding.OIDC.CustomFields = []string{"field1", "field2"}
  1104. err = server.binding.OIDC.initialize()
  1105. assert.NoError(t, err)
  1106. server.initializeRouter()
  1107. _, err = dataprovider.UserExists(username, "")
  1108. assert.ErrorIs(t, err, util.ErrNotFound)
  1109. // now login with OIDC
  1110. authReq := newOIDCPendingAuth(tokenAudienceWebClient)
  1111. oidcMgr.addPendingAuth(authReq)
  1112. token := &oauth2.Token{
  1113. AccessToken: "1234",
  1114. Expiry: time.Now().Add(5 * time.Minute),
  1115. }
  1116. token = token.WithExtra(map[string]any{
  1117. "id_token": "id_token_val",
  1118. })
  1119. server.binding.OIDC.oauth2Config = &mockOAuth2Config{
  1120. tokenSource: &mockTokenSource{},
  1121. authCodeURL: webOIDCRedirectPath,
  1122. token: token,
  1123. }
  1124. idToken := &oidc.IDToken{
  1125. Nonce: authReq.Nonce,
  1126. Expiry: time.Now().Add(5 * time.Minute),
  1127. }
  1128. setIDTokenClaims(idToken, []byte(`{"preferred_username":"`+username+`"}`))
  1129. server.binding.OIDC.verifier = &mockOIDCVerifier{
  1130. err: nil,
  1131. token: idToken,
  1132. }
  1133. rr := httptest.NewRecorder()
  1134. r, err := http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  1135. assert.NoError(t, err)
  1136. server.router.ServeHTTP(rr, r)
  1137. assert.Equal(t, http.StatusFound, rr.Code)
  1138. assert.Equal(t, webClientFilesPath, rr.Header().Get("Location"))
  1139. _, err = dataprovider.UserExists(username, "")
  1140. assert.NoError(t, err)
  1141. err = dataprovider.DeleteUser(username, "", "", "")
  1142. assert.NoError(t, err)
  1143. err = os.RemoveAll(u.HomeDir)
  1144. assert.NoError(t, err)
  1145. err = os.WriteFile(preLoginPath, getPreLoginScriptContent(u, true), os.ModePerm)
  1146. assert.NoError(t, err)
  1147. authReq = newOIDCPendingAuth(tokenAudienceWebClient)
  1148. oidcMgr.addPendingAuth(authReq)
  1149. idToken = &oidc.IDToken{
  1150. Nonce: authReq.Nonce,
  1151. Expiry: time.Now().Add(5 * time.Minute),
  1152. }
  1153. setIDTokenClaims(idToken, []byte(`{"preferred_username":"`+username+`","field1":"value1","field2":"value2","field3":"value3"}`))
  1154. server.binding.OIDC.verifier = &mockOIDCVerifier{
  1155. err: nil,
  1156. token: idToken,
  1157. }
  1158. rr = httptest.NewRecorder()
  1159. r, err = http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  1160. assert.NoError(t, err)
  1161. server.router.ServeHTTP(rr, r)
  1162. assert.Equal(t, http.StatusFound, rr.Code)
  1163. assert.Equal(t, webClientLoginPath, rr.Header().Get("Location"))
  1164. _, err = dataprovider.UserExists(username, "")
  1165. assert.ErrorIs(t, err, util.ErrNotFound)
  1166. if assert.Len(t, oidcMgr.tokens, 1) {
  1167. for k := range oidcMgr.tokens {
  1168. oidcMgr.removeToken(k)
  1169. }
  1170. }
  1171. require.Len(t, oidcMgr.pendingAuths, 0)
  1172. require.Len(t, oidcMgr.tokens, 0)
  1173. err = dataprovider.Close()
  1174. assert.NoError(t, err)
  1175. err = dataprovider.Initialize(providerConf, configDir, true)
  1176. assert.NoError(t, err)
  1177. err = os.Remove(preLoginPath)
  1178. assert.NoError(t, err)
  1179. }
  1180. func TestOIDCIsAdmin(t *testing.T) {
  1181. type test struct {
  1182. input any
  1183. want bool
  1184. }
  1185. emptySlice := make([]any, 0)
  1186. tests := []test{
  1187. {input: "admin", want: true},
  1188. {input: append(emptySlice, "admin"), want: true},
  1189. {input: append(emptySlice, "user", "admin"), want: true},
  1190. {input: "user", want: false},
  1191. {input: emptySlice, want: false},
  1192. {input: append(emptySlice, 1), want: false},
  1193. {input: 1, want: false},
  1194. {input: nil, want: false},
  1195. {input: map[string]string{"admin": "admin"}, want: false},
  1196. }
  1197. for _, tc := range tests {
  1198. token := oidcToken{
  1199. Role: tc.input,
  1200. }
  1201. assert.Equal(t, tc.want, token.isAdmin(), "%v should return %t", tc.input, tc.want)
  1202. }
  1203. }
  1204. func TestParseAdminRole(t *testing.T) {
  1205. claims := make(map[string]any)
  1206. rawClaims := []byte(`{
  1207. "sub": "35666371",
  1208. "email": "example@example.com",
  1209. "preferred_username": "Sally",
  1210. "name": "Sally Tyler",
  1211. "updated_at": "2018-04-13T22:08:45Z",
  1212. "given_name": "Sally",
  1213. "family_name": "Tyler",
  1214. "params": {
  1215. "sftpgo_role": "admin",
  1216. "subparams": {
  1217. "sftpgo_role": "admin",
  1218. "inner": {
  1219. "sftpgo_role": ["user","admin"]
  1220. }
  1221. }
  1222. },
  1223. "at_hash": "lPLhxI2wjEndc-WfyroDZA",
  1224. "rt_hash": "mCmxPtA04N-55AxlEUbq-A",
  1225. "aud": "78d1d040-20c9-0136-5146-067351775fae92920",
  1226. "exp": 1523664997,
  1227. "iat": 1523657797
  1228. }`)
  1229. err := json.Unmarshal(rawClaims, &claims)
  1230. assert.NoError(t, err)
  1231. type test struct {
  1232. input string
  1233. want bool
  1234. }
  1235. tests := []test{
  1236. {input: "sftpgo_role", want: false},
  1237. {input: "params.sftpgo_role", want: true},
  1238. {input: "params.subparams.sftpgo_role", want: true},
  1239. {input: "params.subparams.inner.sftpgo_role", want: true},
  1240. {input: "email", want: false},
  1241. {input: "missing", want: false},
  1242. {input: "params.email", want: false},
  1243. {input: "missing.sftpgo_role", want: false},
  1244. {input: "params", want: false},
  1245. {input: "params.subparams.inner.sftpgo_role.missing", want: false},
  1246. }
  1247. for _, tc := range tests {
  1248. token := oidcToken{}
  1249. token.getRoleFromField(claims, tc.input)
  1250. assert.Equal(t, tc.want, token.isAdmin(), "%q should return %t", tc.input, tc.want)
  1251. }
  1252. }
  1253. func TestOIDCWithLoginFormsDisabled(t *testing.T) {
  1254. oidcMgr, ok := oidcMgr.(*memoryOIDCManager)
  1255. require.True(t, ok)
  1256. server := getTestOIDCServer()
  1257. server.binding.OIDC.ImplicitRoles = true
  1258. server.binding.EnabledLoginMethods = 3
  1259. server.binding.EnableWebAdmin = true
  1260. server.binding.EnableWebClient = true
  1261. err := server.binding.OIDC.initialize()
  1262. assert.NoError(t, err)
  1263. server.initializeRouter()
  1264. // login with an admin user
  1265. authReq := newOIDCPendingAuth(tokenAudienceWebAdmin)
  1266. oidcMgr.addPendingAuth(authReq)
  1267. token := &oauth2.Token{
  1268. AccessToken: "1234",
  1269. Expiry: time.Now().Add(5 * time.Minute),
  1270. }
  1271. token = token.WithExtra(map[string]any{
  1272. "id_token": "id_token_val",
  1273. })
  1274. server.binding.OIDC.oauth2Config = &mockOAuth2Config{
  1275. tokenSource: &mockTokenSource{},
  1276. authCodeURL: webOIDCRedirectPath,
  1277. token: token,
  1278. }
  1279. idToken := &oidc.IDToken{
  1280. Nonce: authReq.Nonce,
  1281. Expiry: time.Now().Add(5 * time.Minute),
  1282. }
  1283. setIDTokenClaims(idToken, []byte(`{"preferred_username":"admin","sid":"sid456"}`))
  1284. server.binding.OIDC.verifier = &mockOIDCVerifier{
  1285. err: nil,
  1286. token: idToken,
  1287. }
  1288. rr := httptest.NewRecorder()
  1289. r, err := http.NewRequest(http.MethodGet, webOIDCRedirectPath+"?state="+authReq.State, nil)
  1290. assert.NoError(t, err)
  1291. server.router.ServeHTTP(rr, r)
  1292. assert.Equal(t, http.StatusFound, rr.Code)
  1293. assert.Equal(t, webUsersPath, rr.Header().Get("Location"))
  1294. var tokenCookie string
  1295. for k := range oidcMgr.tokens {
  1296. tokenCookie = k
  1297. }
  1298. // we should be able to create admins without setting a password
  1299. if csrfTokenAuth == nil {
  1300. csrfTokenAuth = jwtauth.New(jwa.HS256.String(), util.GenerateRandomBytes(32), nil)
  1301. }
  1302. adminUsername := "testAdmin"
  1303. form := make(url.Values)
  1304. form.Set(csrfFormToken, createCSRFToken(""))
  1305. form.Set("username", adminUsername)
  1306. form.Set("password", "")
  1307. form.Set("status", "1")
  1308. form.Set("permissions", "*")
  1309. rr = httptest.NewRecorder()
  1310. r, err = http.NewRequest(http.MethodPost, webAdminPath, bytes.NewBuffer([]byte(form.Encode())))
  1311. assert.NoError(t, err)
  1312. r.Header.Set("Cookie", fmt.Sprintf("%v=%v", oidcCookieKey, tokenCookie))
  1313. r.Header.Set("Content-Type", "application/x-www-form-urlencoded")
  1314. server.router.ServeHTTP(rr, r)
  1315. assert.Equal(t, http.StatusSeeOther, rr.Code)
  1316. _, err = dataprovider.AdminExists(adminUsername)
  1317. assert.NoError(t, err)
  1318. err = dataprovider.DeleteAdmin(adminUsername, "", "", "")
  1319. assert.NoError(t, err)
  1320. // login and password related routes are disabled
  1321. rr = httptest.NewRecorder()
  1322. r, err = http.NewRequest(http.MethodPost, webAdminLoginPath, nil)
  1323. assert.NoError(t, err)
  1324. server.router.ServeHTTP(rr, r)
  1325. assert.Equal(t, http.StatusMethodNotAllowed, rr.Code)
  1326. rr = httptest.NewRecorder()
  1327. r, err = http.NewRequest(http.MethodPost, webAdminTwoFactorPath, nil)
  1328. assert.NoError(t, err)
  1329. server.router.ServeHTTP(rr, r)
  1330. assert.Equal(t, http.StatusNotFound, rr.Code)
  1331. rr = httptest.NewRecorder()
  1332. r, err = http.NewRequest(http.MethodPost, webClientLoginPath, nil)
  1333. assert.NoError(t, err)
  1334. server.router.ServeHTTP(rr, r)
  1335. assert.Equal(t, http.StatusMethodNotAllowed, rr.Code)
  1336. rr = httptest.NewRecorder()
  1337. r, err = http.NewRequest(http.MethodPost, webClientForgotPwdPath, nil)
  1338. assert.NoError(t, err)
  1339. server.router.ServeHTTP(rr, r)
  1340. assert.Equal(t, http.StatusNotFound, rr.Code)
  1341. }
  1342. func TestDbOIDCManager(t *testing.T) {
  1343. if !isSharedProviderSupported() {
  1344. t.Skip("this test it is not available with this provider")
  1345. }
  1346. mgr := newOIDCManager(1)
  1347. pendingAuth := newOIDCPendingAuth(tokenAudienceWebAdmin)
  1348. mgr.addPendingAuth(pendingAuth)
  1349. authReq, err := mgr.getPendingAuth(pendingAuth.State)
  1350. assert.NoError(t, err)
  1351. assert.Equal(t, pendingAuth, authReq)
  1352. pendingAuth.IssuedAt = util.GetTimeAsMsSinceEpoch(time.Now().Add(-24 * time.Hour))
  1353. mgr.addPendingAuth(pendingAuth)
  1354. _, err = mgr.getPendingAuth(pendingAuth.State)
  1355. if assert.Error(t, err) {
  1356. assert.Contains(t, err.Error(), "auth request is too old")
  1357. }
  1358. mgr.removePendingAuth(pendingAuth.State)
  1359. _, err = mgr.getPendingAuth(pendingAuth.State)
  1360. if assert.Error(t, err) {
  1361. assert.Contains(t, err.Error(), "unable to get the auth request for the specified state")
  1362. }
  1363. mgr.addPendingAuth(pendingAuth)
  1364. _, err = mgr.getPendingAuth(pendingAuth.State)
  1365. if assert.Error(t, err) {
  1366. assert.Contains(t, err.Error(), "auth request is too old")
  1367. }
  1368. mgr.cleanup()
  1369. _, err = mgr.getPendingAuth(pendingAuth.State)
  1370. if assert.Error(t, err) {
  1371. assert.Contains(t, err.Error(), "unable to get the auth request for the specified state")
  1372. }
  1373. token := oidcToken{
  1374. Cookie: xid.New().String(),
  1375. AccessToken: xid.New().String(),
  1376. TokenType: "Bearer",
  1377. RefreshToken: xid.New().String(),
  1378. ExpiresAt: util.GetTimeAsMsSinceEpoch(time.Now().Add(-2 * time.Minute)),
  1379. SessionID: xid.New().String(),
  1380. IDToken: xid.New().String(),
  1381. Nonce: xid.New().String(),
  1382. Username: xid.New().String(),
  1383. Permissions: []string{dataprovider.PermAdminAny},
  1384. Role: "admin",
  1385. }
  1386. mgr.addToken(token)
  1387. tokenGet, err := mgr.getToken(token.Cookie)
  1388. assert.NoError(t, err)
  1389. assert.Greater(t, tokenGet.UsedAt, int64(0))
  1390. token.UsedAt = tokenGet.UsedAt
  1391. assert.Equal(t, token, tokenGet)
  1392. time.Sleep(100 * time.Millisecond)
  1393. mgr.updateTokenUsage(token)
  1394. // no change
  1395. tokenGet, err = mgr.getToken(token.Cookie)
  1396. assert.NoError(t, err)
  1397. assert.Equal(t, token.UsedAt, tokenGet.UsedAt)
  1398. tokenGet.UsedAt = util.GetTimeAsMsSinceEpoch(time.Now().Add(-24 * time.Hour))
  1399. tokenGet.RefreshToken = xid.New().String()
  1400. mgr.updateTokenUsage(tokenGet)
  1401. tokenGet, err = mgr.getToken(token.Cookie)
  1402. assert.NoError(t, err)
  1403. assert.NotEmpty(t, tokenGet.RefreshToken)
  1404. assert.NotEqual(t, token.RefreshToken, tokenGet.RefreshToken)
  1405. assert.Greater(t, tokenGet.UsedAt, token.UsedAt)
  1406. mgr.removeToken(token.Cookie)
  1407. tokenGet, err = mgr.getToken(token.Cookie)
  1408. if assert.Error(t, err) {
  1409. assert.Contains(t, err.Error(), "unable to get the token for the specified session")
  1410. }
  1411. // add an expired token
  1412. token.UsedAt = util.GetTimeAsMsSinceEpoch(time.Now().Add(-24 * time.Hour))
  1413. session := dataprovider.Session{
  1414. Key: token.Cookie,
  1415. Data: token,
  1416. Type: dataprovider.SessionTypeOIDCToken,
  1417. Timestamp: token.UsedAt + tokenDeleteInterval,
  1418. }
  1419. err = dataprovider.AddSharedSession(session)
  1420. assert.NoError(t, err)
  1421. _, err = mgr.getToken(token.Cookie)
  1422. if assert.Error(t, err) {
  1423. assert.Contains(t, err.Error(), "token is too old")
  1424. }
  1425. mgr.cleanup()
  1426. _, err = mgr.getToken(token.Cookie)
  1427. if assert.Error(t, err) {
  1428. assert.Contains(t, err.Error(), "unable to get the token for the specified session")
  1429. }
  1430. // adding a session without a key should fail
  1431. session.Key = ""
  1432. err = dataprovider.AddSharedSession(session)
  1433. if assert.Error(t, err) {
  1434. assert.Contains(t, err.Error(), "unable to save a session with an empty key")
  1435. }
  1436. session.Key = xid.New().String()
  1437. session.Type = 1000
  1438. err = dataprovider.AddSharedSession(session)
  1439. if assert.Error(t, err) {
  1440. assert.Contains(t, err.Error(), "invalid session type")
  1441. }
  1442. dbMgr, ok := mgr.(*dbOIDCManager)
  1443. if assert.True(t, ok) {
  1444. _, err = dbMgr.decodePendingAuthData(2)
  1445. assert.Error(t, err)
  1446. _, err = dbMgr.decodeTokenData(true)
  1447. assert.Error(t, err)
  1448. }
  1449. }
  1450. func getTestOIDCServer() *httpdServer {
  1451. return &httpdServer{
  1452. binding: Binding{
  1453. OIDC: OIDC{
  1454. ClientID: "sftpgo-client",
  1455. ClientSecret: "jRsmE0SWnuZjP7djBqNq0mrf8QN77j2c",
  1456. ConfigURL: fmt.Sprintf("http://%v/auth/realms/sftpgo", oidcMockAddr),
  1457. RedirectBaseURL: "http://127.0.0.1:8081/",
  1458. UsernameField: "preferred_username",
  1459. RoleField: "sftpgo_role",
  1460. ImplicitRoles: false,
  1461. Scopes: []string{oidc.ScopeOpenID, "profile", "email"},
  1462. CustomFields: nil,
  1463. Debug: true,
  1464. },
  1465. },
  1466. enableWebAdmin: true,
  1467. enableWebClient: true,
  1468. }
  1469. }
  1470. func getPreLoginScriptContent(user dataprovider.User, nonJSONResponse bool) []byte {
  1471. content := []byte("#!/bin/sh\n\n")
  1472. if nonJSONResponse {
  1473. content = append(content, []byte("echo 'text response'\n")...)
  1474. return content
  1475. }
  1476. if len(user.Username) > 0 {
  1477. u, _ := json.Marshal(user)
  1478. content = append(content, []byte(fmt.Sprintf("echo '%v'\n", string(u)))...)
  1479. }
  1480. return content
  1481. }