internal_test.go 65 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227
  1. // Copyright (C) 2019-2022 Nicola Murino
  2. //
  3. // This program is free software: you can redistribute it and/or modify
  4. // it under the terms of the GNU Affero General Public License as published
  5. // by the Free Software Foundation, version 3.
  6. //
  7. // This program is distributed in the hope that it will be useful,
  8. // but WITHOUT ANY WARRANTY; without even the implied warranty of
  9. // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  10. // GNU Affero General Public License for more details.
  11. //
  12. // You should have received a copy of the GNU Affero General Public License
  13. // along with this program. If not, see <https://www.gnu.org/licenses/>.
  14. package sftpd
  15. import (
  16. "bytes"
  17. "errors"
  18. "fmt"
  19. "io"
  20. "net"
  21. "os"
  22. "path/filepath"
  23. "runtime"
  24. "testing"
  25. "time"
  26. "github.com/eikenb/pipeat"
  27. "github.com/pkg/sftp"
  28. "github.com/rs/xid"
  29. "github.com/sftpgo/sdk"
  30. "github.com/stretchr/testify/assert"
  31. "github.com/stretchr/testify/require"
  32. "golang.org/x/crypto/ssh"
  33. "github.com/drakkan/sftpgo/v2/internal/common"
  34. "github.com/drakkan/sftpgo/v2/internal/dataprovider"
  35. "github.com/drakkan/sftpgo/v2/internal/kms"
  36. "github.com/drakkan/sftpgo/v2/internal/util"
  37. "github.com/drakkan/sftpgo/v2/internal/vfs"
  38. )
  39. const (
  40. osWindows = "windows"
  41. )
  42. var (
  43. configDir = filepath.Join(".", "..", "..")
  44. )
  45. type MockChannel struct {
  46. Buffer *bytes.Buffer
  47. StdErrBuffer *bytes.Buffer
  48. ReadError error
  49. WriteError error
  50. ShortWriteErr bool
  51. }
  52. func (c *MockChannel) Read(data []byte) (int, error) {
  53. if c.ReadError != nil {
  54. return 0, c.ReadError
  55. }
  56. return c.Buffer.Read(data)
  57. }
  58. func (c *MockChannel) Write(data []byte) (int, error) {
  59. if c.WriteError != nil {
  60. return 0, c.WriteError
  61. }
  62. if c.ShortWriteErr {
  63. return 0, nil
  64. }
  65. return c.Buffer.Write(data)
  66. }
  67. func (c *MockChannel) Close() error {
  68. return nil
  69. }
  70. func (c *MockChannel) CloseWrite() error {
  71. return nil
  72. }
  73. func (c *MockChannel) SendRequest(name string, wantReply bool, payload []byte) (bool, error) {
  74. return true, nil
  75. }
  76. func (c *MockChannel) Stderr() io.ReadWriter {
  77. return c.StdErrBuffer
  78. }
  79. // MockOsFs mockable OsFs
  80. type MockOsFs struct {
  81. vfs.Fs
  82. err error
  83. statErr error
  84. isAtomicUploadSupported bool
  85. }
  86. // Name returns the name for the Fs implementation
  87. func (fs MockOsFs) Name() string {
  88. return "mockOsFs"
  89. }
  90. // IsUploadResumeSupported returns true if resuming uploads is supported
  91. func (MockOsFs) IsUploadResumeSupported() bool {
  92. return false
  93. }
  94. // IsAtomicUploadSupported returns true if atomic upload is supported
  95. func (fs MockOsFs) IsAtomicUploadSupported() bool {
  96. return fs.isAtomicUploadSupported
  97. }
  98. // Stat returns a FileInfo describing the named file
  99. func (fs MockOsFs) Stat(name string) (os.FileInfo, error) {
  100. if fs.statErr != nil {
  101. return nil, fs.statErr
  102. }
  103. return os.Stat(name)
  104. }
  105. // Lstat returns a FileInfo describing the named file
  106. func (fs MockOsFs) Lstat(name string) (os.FileInfo, error) {
  107. if fs.statErr != nil {
  108. return nil, fs.statErr
  109. }
  110. return os.Lstat(name)
  111. }
  112. // Remove removes the named file or (empty) directory.
  113. func (fs MockOsFs) Remove(name string, isDir bool) error {
  114. if fs.err != nil {
  115. return fs.err
  116. }
  117. return os.Remove(name)
  118. }
  119. // Rename renames (moves) source to target
  120. func (fs MockOsFs) Rename(source, target string) error {
  121. if fs.err != nil {
  122. return fs.err
  123. }
  124. return os.Rename(source, target)
  125. }
  126. func newMockOsFs(err, statErr error, atomicUpload bool, connectionID, rootDir string) vfs.Fs {
  127. return &MockOsFs{
  128. Fs: vfs.NewOsFs(connectionID, rootDir, ""),
  129. err: err,
  130. statErr: statErr,
  131. isAtomicUploadSupported: atomicUpload,
  132. }
  133. }
  134. func TestRemoveNonexistentQuotaScan(t *testing.T) {
  135. assert.False(t, common.QuotaScans.RemoveUserQuotaScan("username"))
  136. }
  137. func TestGetOSOpenFlags(t *testing.T) {
  138. var flags sftp.FileOpenFlags
  139. flags.Write = true
  140. flags.Excl = true
  141. osFlags := getOSOpenFlags(flags)
  142. assert.NotEqual(t, 0, osFlags&os.O_WRONLY)
  143. assert.NotEqual(t, 0, osFlags&os.O_EXCL)
  144. flags.Append = true
  145. // append flag should be ignored to allow resume
  146. assert.NotEqual(t, 0, osFlags&os.O_WRONLY)
  147. assert.NotEqual(t, 0, osFlags&os.O_EXCL)
  148. }
  149. func TestUploadResumeInvalidOffset(t *testing.T) {
  150. testfile := "testfile" //nolint:goconst
  151. file, err := os.Create(testfile)
  152. assert.NoError(t, err)
  153. user := dataprovider.User{
  154. BaseUser: sdk.BaseUser{
  155. Username: "testuser",
  156. },
  157. }
  158. fs := vfs.NewOsFs("", os.TempDir(), "")
  159. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", user)
  160. baseTransfer := common.NewBaseTransfer(file, conn, nil, file.Name(), file.Name(), testfile,
  161. common.TransferUpload, 10, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  162. transfer := newTransfer(baseTransfer, nil, nil, nil)
  163. _, err = transfer.WriteAt([]byte("test"), 0)
  164. assert.Error(t, err, "upload with invalid offset must fail")
  165. if assert.Error(t, transfer.ErrTransfer) {
  166. assert.EqualError(t, err, transfer.ErrTransfer.Error())
  167. assert.Contains(t, transfer.ErrTransfer.Error(), "invalid write offset")
  168. }
  169. err = transfer.Close()
  170. if assert.Error(t, err) {
  171. assert.ErrorIs(t, err, sftp.ErrSSHFxFailure)
  172. }
  173. err = os.Remove(testfile)
  174. assert.NoError(t, err)
  175. }
  176. func TestReadWriteErrors(t *testing.T) {
  177. testfile := "testfile"
  178. file, err := os.Create(testfile)
  179. assert.NoError(t, err)
  180. user := dataprovider.User{
  181. BaseUser: sdk.BaseUser{
  182. Username: "testuser",
  183. },
  184. }
  185. fs := vfs.NewOsFs("", os.TempDir(), "")
  186. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", user)
  187. baseTransfer := common.NewBaseTransfer(file, conn, nil, file.Name(), file.Name(), testfile, common.TransferDownload,
  188. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  189. transfer := newTransfer(baseTransfer, nil, nil, nil)
  190. err = file.Close()
  191. assert.NoError(t, err)
  192. _, err = transfer.WriteAt([]byte("test"), 0)
  193. assert.Error(t, err, "writing to closed file must fail")
  194. buf := make([]byte, 32768)
  195. _, err = transfer.ReadAt(buf, 0)
  196. assert.Error(t, err, "reading from a closed file must fail")
  197. err = transfer.Close()
  198. assert.Error(t, err)
  199. r, _, err := pipeat.Pipe()
  200. assert.NoError(t, err)
  201. baseTransfer = common.NewBaseTransfer(nil, conn, nil, file.Name(), file.Name(), testfile, common.TransferDownload,
  202. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  203. transfer = newTransfer(baseTransfer, nil, r, nil)
  204. err = transfer.Close()
  205. assert.NoError(t, err)
  206. _, err = transfer.ReadAt(buf, 0)
  207. assert.Error(t, err, "reading from a closed pipe must fail")
  208. r, w, err := pipeat.Pipe()
  209. assert.NoError(t, err)
  210. pipeWriter := vfs.NewPipeWriter(w)
  211. baseTransfer = common.NewBaseTransfer(nil, conn, nil, file.Name(), file.Name(), testfile, common.TransferDownload,
  212. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  213. transfer = newTransfer(baseTransfer, pipeWriter, nil, nil)
  214. err = r.Close()
  215. assert.NoError(t, err)
  216. errFake := fmt.Errorf("fake upload error")
  217. go func() {
  218. time.Sleep(100 * time.Millisecond)
  219. pipeWriter.Done(errFake)
  220. }()
  221. err = transfer.closeIO()
  222. assert.EqualError(t, err, errFake.Error())
  223. _, err = transfer.WriteAt([]byte("test"), 0)
  224. assert.Error(t, err, "writing to closed pipe must fail")
  225. err = transfer.BaseTransfer.Close()
  226. assert.EqualError(t, err, errFake.Error())
  227. err = os.Remove(testfile)
  228. assert.NoError(t, err)
  229. assert.Len(t, conn.GetTransfers(), 0)
  230. }
  231. func TestUnsupportedListOP(t *testing.T) {
  232. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", dataprovider.User{})
  233. sftpConn := Connection{
  234. BaseConnection: conn,
  235. }
  236. request := sftp.NewRequest("Unsupported", "")
  237. _, err := sftpConn.Filelist(request)
  238. assert.EqualError(t, err, sftp.ErrSSHFxOpUnsupported.Error())
  239. }
  240. func TestTransferCancelFn(t *testing.T) {
  241. testfile := "testfile"
  242. file, err := os.Create(testfile)
  243. assert.NoError(t, err)
  244. isCancelled := false
  245. cancelFn := func() {
  246. isCancelled = true
  247. }
  248. user := dataprovider.User{
  249. BaseUser: sdk.BaseUser{
  250. Username: "testuser",
  251. },
  252. }
  253. fs := vfs.NewOsFs("", os.TempDir(), "")
  254. conn := common.NewBaseConnection("", common.ProtocolSFTP, "", "", user)
  255. baseTransfer := common.NewBaseTransfer(file, conn, cancelFn, file.Name(), file.Name(), testfile, common.TransferDownload,
  256. 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  257. transfer := newTransfer(baseTransfer, nil, nil, nil)
  258. errFake := errors.New("fake error, this will trigger cancelFn")
  259. transfer.TransferError(errFake)
  260. err = transfer.Close()
  261. if assert.Error(t, err) {
  262. assert.ErrorIs(t, err, sftp.ErrSSHFxFailure)
  263. }
  264. if assert.Error(t, transfer.ErrTransfer) {
  265. assert.EqualError(t, transfer.ErrTransfer, errFake.Error())
  266. }
  267. assert.True(t, isCancelled, "cancelFn not called!")
  268. err = os.Remove(testfile)
  269. assert.NoError(t, err)
  270. }
  271. func TestUploadFiles(t *testing.T) {
  272. common.Config.UploadMode = common.UploadModeAtomic
  273. fs := vfs.NewOsFs("123", os.TempDir(), "")
  274. u := dataprovider.User{}
  275. c := Connection{
  276. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", u),
  277. }
  278. var flags sftp.FileOpenFlags
  279. flags.Write = true
  280. flags.Trunc = true
  281. _, err := c.handleSFTPUploadToExistingFile(fs, flags, "missing_path", "other_missing_path", 0, "/missing_path", nil)
  282. assert.Error(t, err, "upload to existing file must fail if one or both paths are invalid")
  283. common.Config.UploadMode = common.UploadModeStandard
  284. _, err = c.handleSFTPUploadToExistingFile(fs, flags, "missing_path", "other_missing_path", 0, "/missing_path", nil)
  285. assert.Error(t, err, "upload to existing file must fail if one or both paths are invalid")
  286. missingFile := "missing/relative/file.txt"
  287. if runtime.GOOS == osWindows {
  288. missingFile = "missing\\relative\\file.txt"
  289. }
  290. _, err = c.handleSFTPUploadToNewFile(fs, flags, ".", missingFile, "/missing", nil)
  291. assert.Error(t, err, "upload new file in missing path must fail")
  292. fs = newMockOsFs(nil, nil, false, "123", os.TempDir())
  293. f, err := os.CreateTemp("", "temp")
  294. assert.NoError(t, err)
  295. err = f.Close()
  296. assert.NoError(t, err)
  297. tr, err := c.handleSFTPUploadToExistingFile(fs, flags, f.Name(), f.Name(), 123, f.Name(), nil)
  298. if assert.NoError(t, err) {
  299. transfer := tr.(*transfer)
  300. transfers := c.GetTransfers()
  301. if assert.Equal(t, 1, len(transfers)) {
  302. assert.Equal(t, transfers[0].ID, transfer.GetID())
  303. assert.Equal(t, int64(123), transfer.InitialSize)
  304. err = transfer.Close()
  305. assert.NoError(t, err)
  306. assert.Equal(t, 0, len(c.GetTransfers()))
  307. }
  308. }
  309. err = os.Remove(f.Name())
  310. assert.NoError(t, err)
  311. common.Config.UploadMode = common.UploadModeAtomicWithResume
  312. }
  313. func TestWithInvalidHome(t *testing.T) {
  314. u := dataprovider.User{}
  315. u.HomeDir = "home_rel_path" //nolint:goconst
  316. _, err := loginUser(&u, dataprovider.LoginMethodPassword, "", nil)
  317. assert.Error(t, err, "login a user with an invalid home_dir must fail")
  318. u.HomeDir = os.TempDir()
  319. fs, err := u.GetFilesystem("123")
  320. assert.NoError(t, err)
  321. c := Connection{
  322. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", u),
  323. }
  324. _, err = fs.ResolvePath("../upper_path")
  325. assert.Error(t, err, "tested path is not a home subdir")
  326. _, err = c.StatVFS(&sftp.Request{
  327. Method: "StatVFS",
  328. Filepath: "../unresolvable-path",
  329. })
  330. assert.Error(t, err)
  331. }
  332. func TestResolveWithRootDir(t *testing.T) {
  333. u := dataprovider.User{}
  334. if runtime.GOOS == osWindows {
  335. u.HomeDir = "C:\\"
  336. } else {
  337. u.HomeDir = "/"
  338. }
  339. fs, err := u.GetFilesystem("")
  340. assert.NoError(t, err)
  341. rel, err := filepath.Rel(u.HomeDir, os.TempDir())
  342. assert.NoError(t, err)
  343. p, err := fs.ResolvePath(rel)
  344. assert.NoError(t, err, "path %v", p)
  345. }
  346. func TestSFTPGetUsedQuota(t *testing.T) {
  347. u := dataprovider.User{}
  348. u.HomeDir = "home_rel_path"
  349. u.Username = "test_invalid_user"
  350. u.QuotaSize = 4096
  351. u.QuotaFiles = 1
  352. u.Permissions = make(map[string][]string)
  353. u.Permissions["/"] = []string{dataprovider.PermAny}
  354. connection := Connection{
  355. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", u),
  356. }
  357. quotaResult, _ := connection.HasSpace(false, false, "/")
  358. assert.False(t, quotaResult.HasSpace)
  359. }
  360. func TestSupportedSSHCommands(t *testing.T) {
  361. cmds := GetSupportedSSHCommands()
  362. assert.Equal(t, len(supportedSSHCommands), len(cmds))
  363. for _, c := range cmds {
  364. assert.True(t, util.Contains(supportedSSHCommands, c))
  365. }
  366. }
  367. func TestSSHCommandPath(t *testing.T) {
  368. buf := make([]byte, 65535)
  369. stdErrBuf := make([]byte, 65535)
  370. mockSSHChannel := MockChannel{
  371. Buffer: bytes.NewBuffer(buf),
  372. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  373. ReadError: nil,
  374. }
  375. connection := &Connection{
  376. channel: &mockSSHChannel,
  377. BaseConnection: common.NewBaseConnection("", common.ProtocolSSH, "", "", dataprovider.User{}),
  378. }
  379. sshCommand := sshCommand{
  380. command: "test",
  381. connection: connection,
  382. args: []string{},
  383. }
  384. assert.Equal(t, "", sshCommand.getDestPath())
  385. sshCommand.args = []string{"-t", "/tmp/../path"}
  386. assert.Equal(t, "/path", sshCommand.getDestPath())
  387. sshCommand.args = []string{"-t", "/tmp/"}
  388. assert.Equal(t, "/tmp/", sshCommand.getDestPath())
  389. sshCommand.args = []string{"-t", "tmp/"}
  390. assert.Equal(t, "/tmp/", sshCommand.getDestPath())
  391. sshCommand.args = []string{"-t", "/tmp/../../../path"}
  392. assert.Equal(t, "/path", sshCommand.getDestPath())
  393. sshCommand.args = []string{"-t", ".."}
  394. assert.Equal(t, "/", sshCommand.getDestPath())
  395. sshCommand.args = []string{"-t", "."}
  396. assert.Equal(t, "/", sshCommand.getDestPath())
  397. sshCommand.args = []string{"-t", "//"}
  398. assert.Equal(t, "/", sshCommand.getDestPath())
  399. sshCommand.args = []string{"-t", "../.."}
  400. assert.Equal(t, "/", sshCommand.getDestPath())
  401. sshCommand.args = []string{"-t", "/.."}
  402. assert.Equal(t, "/", sshCommand.getDestPath())
  403. sshCommand.args = []string{"-f", "/a space.txt"}
  404. assert.Equal(t, "/a space.txt", sshCommand.getDestPath())
  405. }
  406. func TestSSHParseCommandPayload(t *testing.T) {
  407. cmd := "command -a -f /ab\\ à/some\\ spaces\\ \\ \\(\\).txt"
  408. name, args, _ := parseCommandPayload(cmd)
  409. assert.Equal(t, "command", name)
  410. assert.Equal(t, 3, len(args))
  411. assert.Equal(t, "/ab à/some spaces ().txt", args[2])
  412. _, _, err := parseCommandPayload("")
  413. assert.Error(t, err, "parsing invalid command must fail")
  414. }
  415. func TestSSHCommandErrors(t *testing.T) {
  416. buf := make([]byte, 65535)
  417. stdErrBuf := make([]byte, 65535)
  418. readErr := fmt.Errorf("test read error")
  419. mockSSHChannel := MockChannel{
  420. Buffer: bytes.NewBuffer(buf),
  421. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  422. ReadError: readErr,
  423. }
  424. server, client := net.Pipe()
  425. defer func() {
  426. err := server.Close()
  427. assert.NoError(t, err)
  428. }()
  429. defer func() {
  430. err := client.Close()
  431. assert.NoError(t, err)
  432. }()
  433. user := dataprovider.User{}
  434. user.Permissions = map[string][]string{
  435. "/": {dataprovider.PermAny},
  436. }
  437. connection := Connection{
  438. BaseConnection: common.NewBaseConnection("", common.ProtocolSSH, "", "", user),
  439. channel: &mockSSHChannel,
  440. }
  441. cmd := sshCommand{
  442. command: "md5sum",
  443. connection: &connection,
  444. args: []string{},
  445. }
  446. err := cmd.handle()
  447. assert.Error(t, err, "ssh command must fail, we are sending a fake error")
  448. cmd = sshCommand{
  449. command: "md5sum",
  450. connection: &connection,
  451. args: []string{"/../../test_file_ftp.dat"},
  452. }
  453. err = cmd.handle()
  454. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  455. cmd = sshCommand{
  456. command: "git-receive-pack",
  457. connection: &connection,
  458. args: []string{"/../../testrepo"},
  459. }
  460. err = cmd.handle()
  461. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  462. user = dataprovider.User{}
  463. user.Permissions = map[string][]string{
  464. "/": {dataprovider.PermAny},
  465. }
  466. user.HomeDir = filepath.Clean(os.TempDir())
  467. user.QuotaFiles = 1
  468. user.UsedQuotaFiles = 2
  469. cmd.connection.User = user
  470. _, err = cmd.connection.User.GetFilesystem("123")
  471. assert.NoError(t, err)
  472. err = cmd.handle()
  473. assert.EqualError(t, err, common.ErrQuotaExceeded.Error())
  474. cmd.connection.User.QuotaFiles = 0
  475. cmd.connection.User.UsedQuotaFiles = 0
  476. cmd.connection.User.Permissions = make(map[string][]string)
  477. cmd.connection.User.Permissions["/"] = []string{dataprovider.PermListItems}
  478. err = cmd.handle()
  479. assert.EqualError(t, err, common.ErrPermissionDenied.Error())
  480. cmd.connection.User.Permissions["/"] = []string{dataprovider.PermAny}
  481. cmd.command = "invalid_command"
  482. command, err := cmd.getSystemCommand()
  483. assert.NoError(t, err)
  484. err = cmd.executeSystemCommand(command)
  485. assert.Error(t, err, "invalid command must fail")
  486. command, err = cmd.getSystemCommand()
  487. assert.NoError(t, err)
  488. _, err = command.cmd.StderrPipe()
  489. assert.NoError(t, err)
  490. err = cmd.executeSystemCommand(command)
  491. assert.Error(t, err, "command must fail, pipe was already assigned")
  492. err = cmd.executeSystemCommand(command)
  493. assert.Error(t, err, "command must fail, pipe was already assigned")
  494. command, err = cmd.getSystemCommand()
  495. assert.NoError(t, err)
  496. _, err = command.cmd.StdoutPipe()
  497. assert.NoError(t, err)
  498. err = cmd.executeSystemCommand(command)
  499. assert.Error(t, err, "command must fail, pipe was already assigned")
  500. cmd = sshCommand{
  501. command: "sftpgo-remove",
  502. connection: &connection,
  503. args: []string{"/../../src"},
  504. }
  505. err = cmd.handle()
  506. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  507. cmd = sshCommand{
  508. command: "sftpgo-copy",
  509. connection: &connection,
  510. args: []string{"/../../test_src", "."},
  511. }
  512. err = cmd.handle()
  513. assert.Error(t, err, "ssh command must fail, we are requesting an invalid path")
  514. cmd.connection.User.HomeDir = filepath.Clean(os.TempDir())
  515. cmd = sshCommand{
  516. command: "sftpgo-copy",
  517. connection: &connection,
  518. args: []string{"src", "dst"},
  519. }
  520. cmd.connection.User.Permissions = make(map[string][]string)
  521. cmd.connection.User.Permissions["/"] = []string{dataprovider.PermAny}
  522. common.WaitForTransfers(1)
  523. _, err = cmd.getSystemCommand()
  524. if assert.Error(t, err) {
  525. assert.Contains(t, err.Error(), common.ErrShuttingDown.Error())
  526. }
  527. err = common.Initialize(common.Config, 0)
  528. assert.NoError(t, err)
  529. }
  530. func TestCommandsWithExtensionsFilter(t *testing.T) {
  531. buf := make([]byte, 65535)
  532. stdErrBuf := make([]byte, 65535)
  533. mockSSHChannel := MockChannel{
  534. Buffer: bytes.NewBuffer(buf),
  535. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  536. }
  537. server, client := net.Pipe()
  538. defer server.Close()
  539. defer client.Close()
  540. user := dataprovider.User{
  541. BaseUser: sdk.BaseUser{
  542. Username: "test",
  543. HomeDir: os.TempDir(),
  544. Status: 1,
  545. },
  546. }
  547. user.Filters.FilePatterns = []sdk.PatternsFilter{
  548. {
  549. Path: "/subdir",
  550. AllowedPatterns: []string{".jpg"},
  551. DeniedPatterns: []string{},
  552. },
  553. }
  554. connection := &Connection{
  555. BaseConnection: common.NewBaseConnection("", common.ProtocolSSH, "", "", user),
  556. channel: &mockSSHChannel,
  557. }
  558. cmd := sshCommand{
  559. command: "md5sum",
  560. connection: connection,
  561. args: []string{"subdir/test.png"},
  562. }
  563. err := cmd.handleHashCommands()
  564. assert.EqualError(t, err, common.ErrPermissionDenied.Error())
  565. cmd = sshCommand{
  566. command: "rsync",
  567. connection: connection,
  568. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  569. }
  570. _, err = cmd.getSystemCommand()
  571. assert.EqualError(t, err, errUnsupportedConfig.Error())
  572. cmd = sshCommand{
  573. command: "git-receive-pack",
  574. connection: connection,
  575. args: []string{"/subdir"},
  576. }
  577. _, err = cmd.getSystemCommand()
  578. assert.EqualError(t, err, errUnsupportedConfig.Error())
  579. cmd = sshCommand{
  580. command: "git-receive-pack",
  581. connection: connection,
  582. args: []string{"/subdir/dir"},
  583. }
  584. _, err = cmd.getSystemCommand()
  585. assert.EqualError(t, err, errUnsupportedConfig.Error())
  586. cmd = sshCommand{
  587. command: "git-receive-pack",
  588. connection: connection,
  589. args: []string{"/adir/subdir"},
  590. }
  591. _, err = cmd.getSystemCommand()
  592. assert.NoError(t, err)
  593. }
  594. func TestSSHCommandsRemoteFs(t *testing.T) {
  595. buf := make([]byte, 65535)
  596. stdErrBuf := make([]byte, 65535)
  597. mockSSHChannel := MockChannel{
  598. Buffer: bytes.NewBuffer(buf),
  599. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  600. }
  601. user := dataprovider.User{}
  602. user.FsConfig = vfs.Filesystem{
  603. Provider: sdk.S3FilesystemProvider,
  604. S3Config: vfs.S3FsConfig{
  605. BaseS3FsConfig: sdk.BaseS3FsConfig{
  606. Bucket: "s3bucket",
  607. Endpoint: "endpoint",
  608. Region: "eu-west-1",
  609. },
  610. },
  611. }
  612. connection := &Connection{
  613. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  614. channel: &mockSSHChannel,
  615. }
  616. cmd := sshCommand{
  617. command: "md5sum",
  618. connection: connection,
  619. args: []string{},
  620. }
  621. command, err := cmd.getSystemCommand()
  622. assert.NoError(t, err)
  623. err = cmd.executeSystemCommand(command)
  624. assert.Error(t, err, "command must fail for a non local filesystem")
  625. cmd = sshCommand{
  626. command: "sftpgo-copy",
  627. connection: connection,
  628. args: []string{},
  629. }
  630. err = cmd.handleSFTPGoCopy()
  631. assert.Error(t, err)
  632. cmd = sshCommand{
  633. command: "sftpgo-remove",
  634. connection: connection,
  635. args: []string{},
  636. }
  637. err = cmd.handleSFTPGoRemove()
  638. assert.Error(t, err)
  639. }
  640. func TestSSHCmdGetFsErrors(t *testing.T) {
  641. buf := make([]byte, 65535)
  642. stdErrBuf := make([]byte, 65535)
  643. mockSSHChannel := MockChannel{
  644. Buffer: bytes.NewBuffer(buf),
  645. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  646. }
  647. user := dataprovider.User{
  648. BaseUser: sdk.BaseUser{
  649. HomeDir: "relative path",
  650. },
  651. }
  652. user.Permissions = map[string][]string{}
  653. user.Permissions["/"] = []string{dataprovider.PermAny}
  654. connection := &Connection{
  655. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  656. channel: &mockSSHChannel,
  657. }
  658. cmd := sshCommand{
  659. command: "sftpgo-remove",
  660. connection: connection,
  661. args: []string{"path"},
  662. }
  663. err := cmd.handleSFTPGoRemove()
  664. assert.Error(t, err)
  665. cmd = sshCommand{
  666. command: "sftpgo-copy",
  667. connection: connection,
  668. args: []string{"path1", "path2"},
  669. }
  670. err = cmd.handleSFTPGoCopy()
  671. assert.Error(t, err)
  672. err = os.RemoveAll(user.GetHomeDir())
  673. assert.NoError(t, err)
  674. }
  675. func TestGitVirtualFolders(t *testing.T) {
  676. permissions := make(map[string][]string)
  677. permissions["/"] = []string{dataprovider.PermAny}
  678. user := dataprovider.User{
  679. BaseUser: sdk.BaseUser{
  680. Permissions: permissions,
  681. HomeDir: os.TempDir(),
  682. },
  683. }
  684. conn := &Connection{
  685. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  686. }
  687. cmd := sshCommand{
  688. command: "git-receive-pack",
  689. connection: conn,
  690. args: []string{"/vdir"},
  691. }
  692. cmd.connection.User.VirtualFolders = append(cmd.connection.User.VirtualFolders, vfs.VirtualFolder{
  693. BaseVirtualFolder: vfs.BaseVirtualFolder{
  694. MappedPath: os.TempDir(),
  695. },
  696. VirtualPath: "/vdir",
  697. })
  698. _, err := cmd.getSystemCommand()
  699. assert.NoError(t, err)
  700. cmd.args = []string{"/"}
  701. _, err = cmd.getSystemCommand()
  702. assert.EqualError(t, err, errUnsupportedConfig.Error())
  703. cmd.args = []string{"/vdir1"}
  704. _, err = cmd.getSystemCommand()
  705. assert.NoError(t, err)
  706. cmd.connection.User.VirtualFolders = nil
  707. cmd.connection.User.VirtualFolders = append(cmd.connection.User.VirtualFolders, vfs.VirtualFolder{
  708. BaseVirtualFolder: vfs.BaseVirtualFolder{
  709. MappedPath: os.TempDir(),
  710. },
  711. VirtualPath: "/vdir",
  712. })
  713. cmd.args = []string{"/vdir/subdir"}
  714. _, err = cmd.getSystemCommand()
  715. assert.NoError(t, err)
  716. cmd.args = []string{"/adir/subdir"}
  717. _, err = cmd.getSystemCommand()
  718. assert.NoError(t, err)
  719. }
  720. func TestRsyncOptions(t *testing.T) {
  721. permissions := make(map[string][]string)
  722. permissions["/"] = []string{dataprovider.PermAny}
  723. user := dataprovider.User{
  724. BaseUser: sdk.BaseUser{
  725. Permissions: permissions,
  726. HomeDir: os.TempDir(),
  727. },
  728. }
  729. conn := &Connection{
  730. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  731. }
  732. sshCmd := sshCommand{
  733. command: "rsync",
  734. connection: conn,
  735. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  736. }
  737. cmd, err := sshCmd.getSystemCommand()
  738. assert.NoError(t, err)
  739. assert.True(t, util.Contains(cmd.cmd.Args, "--safe-links"),
  740. "--safe-links must be added if the user has the create symlinks permission")
  741. permissions["/"] = []string{dataprovider.PermDownload, dataprovider.PermUpload, dataprovider.PermCreateDirs,
  742. dataprovider.PermListItems, dataprovider.PermOverwrite, dataprovider.PermDelete, dataprovider.PermRename}
  743. user.Permissions = permissions
  744. conn = &Connection{
  745. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  746. }
  747. sshCmd = sshCommand{
  748. command: "rsync",
  749. connection: conn,
  750. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  751. }
  752. cmd, err = sshCmd.getSystemCommand()
  753. assert.NoError(t, err)
  754. assert.True(t, util.Contains(cmd.cmd.Args, "--munge-links"),
  755. "--munge-links must be added if the user has the create symlinks permission")
  756. sshCmd.connection.User.VirtualFolders = append(sshCmd.connection.User.VirtualFolders, vfs.VirtualFolder{
  757. BaseVirtualFolder: vfs.BaseVirtualFolder{
  758. MappedPath: os.TempDir(),
  759. },
  760. VirtualPath: "/vdir",
  761. })
  762. _, err = sshCmd.getSystemCommand()
  763. assert.EqualError(t, err, errUnsupportedConfig.Error())
  764. }
  765. func TestSystemCommandSizeForPath(t *testing.T) {
  766. permissions := make(map[string][]string)
  767. permissions["/"] = []string{dataprovider.PermAny}
  768. user := dataprovider.User{
  769. BaseUser: sdk.BaseUser{
  770. Permissions: permissions,
  771. HomeDir: os.TempDir(),
  772. },
  773. }
  774. fs, err := user.GetFilesystem("123")
  775. assert.NoError(t, err)
  776. conn := &Connection{
  777. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  778. }
  779. sshCmd := sshCommand{
  780. command: "rsync",
  781. connection: conn,
  782. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  783. }
  784. _, _, err = sshCmd.getSizeForPath(fs, "missing path")
  785. assert.NoError(t, err)
  786. testDir := filepath.Join(os.TempDir(), "dir")
  787. err = os.MkdirAll(testDir, os.ModePerm)
  788. assert.NoError(t, err)
  789. testFile := filepath.Join(testDir, "testfile")
  790. err = os.WriteFile(testFile, []byte("test content"), os.ModePerm)
  791. assert.NoError(t, err)
  792. err = os.Symlink(testFile, testFile+".link")
  793. assert.NoError(t, err)
  794. numFiles, size, err := sshCmd.getSizeForPath(fs, testFile+".link")
  795. assert.NoError(t, err)
  796. assert.Equal(t, 0, numFiles)
  797. assert.Equal(t, int64(0), size)
  798. numFiles, size, err = sshCmd.getSizeForPath(fs, testFile)
  799. assert.NoError(t, err)
  800. assert.Equal(t, 1, numFiles)
  801. assert.Equal(t, int64(12), size)
  802. if runtime.GOOS != osWindows {
  803. err = os.Chmod(testDir, 0001)
  804. assert.NoError(t, err)
  805. _, _, err = sshCmd.getSizeForPath(fs, testFile)
  806. assert.Error(t, err)
  807. err = os.Chmod(testDir, os.ModePerm)
  808. assert.NoError(t, err)
  809. }
  810. err = os.RemoveAll(testDir)
  811. assert.NoError(t, err)
  812. }
  813. func TestSystemCommandErrors(t *testing.T) {
  814. buf := make([]byte, 65535)
  815. stdErrBuf := make([]byte, 65535)
  816. readErr := fmt.Errorf("test read error")
  817. writeErr := fmt.Errorf("test write error")
  818. mockSSHChannel := MockChannel{
  819. Buffer: bytes.NewBuffer(buf),
  820. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  821. ReadError: nil,
  822. WriteError: writeErr,
  823. }
  824. permissions := make(map[string][]string)
  825. permissions["/"] = []string{dataprovider.PermAny}
  826. homeDir := filepath.Join(os.TempDir(), "adir")
  827. err := os.MkdirAll(homeDir, os.ModePerm)
  828. assert.NoError(t, err)
  829. err = os.WriteFile(filepath.Join(homeDir, "afile"), []byte("content"), os.ModePerm)
  830. assert.NoError(t, err)
  831. user := dataprovider.User{
  832. BaseUser: sdk.BaseUser{
  833. Permissions: permissions,
  834. HomeDir: homeDir,
  835. },
  836. }
  837. fs, err := user.GetFilesystem("123")
  838. assert.NoError(t, err)
  839. connection := &Connection{
  840. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  841. channel: &mockSSHChannel,
  842. }
  843. var sshCmd sshCommand
  844. if runtime.GOOS == osWindows {
  845. sshCmd = sshCommand{
  846. command: "dir",
  847. connection: connection,
  848. args: []string{"/"},
  849. }
  850. } else {
  851. sshCmd = sshCommand{
  852. command: "ls",
  853. connection: connection,
  854. args: []string{"/"},
  855. }
  856. }
  857. systemCmd, err := sshCmd.getSystemCommand()
  858. assert.NoError(t, err)
  859. systemCmd.cmd.Dir = os.TempDir()
  860. // FIXME: the command completes but the fake client is unable to read the response
  861. // no error is reported in this case. We can see that the expected code is executed
  862. // reading the test coverage
  863. sshCmd.executeSystemCommand(systemCmd) //nolint:errcheck
  864. mockSSHChannel = MockChannel{
  865. Buffer: bytes.NewBuffer(buf),
  866. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  867. ReadError: readErr,
  868. WriteError: nil,
  869. }
  870. sshCmd.connection.channel = &mockSSHChannel
  871. baseTransfer := common.NewBaseTransfer(nil, sshCmd.connection.BaseConnection, nil, "", "", "",
  872. common.TransferUpload, 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  873. transfer := newTransfer(baseTransfer, nil, nil, nil)
  874. destBuff := make([]byte, 65535)
  875. dst := bytes.NewBuffer(destBuff)
  876. _, err = transfer.copyFromReaderToWriter(dst, sshCmd.connection.channel)
  877. assert.EqualError(t, err, readErr.Error())
  878. mockSSHChannel = MockChannel{
  879. Buffer: bytes.NewBuffer(buf),
  880. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  881. ReadError: nil,
  882. WriteError: nil,
  883. }
  884. sshCmd.connection.channel = &mockSSHChannel
  885. transfer.MaxWriteSize = 1
  886. _, err = transfer.copyFromReaderToWriter(dst, sshCmd.connection.channel)
  887. assert.True(t, transfer.Connection.IsQuotaExceededError(err))
  888. mockSSHChannel = MockChannel{
  889. Buffer: bytes.NewBuffer(buf),
  890. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  891. ReadError: nil,
  892. WriteError: nil,
  893. ShortWriteErr: true,
  894. }
  895. sshCmd.connection.channel = &mockSSHChannel
  896. _, err = transfer.copyFromReaderToWriter(sshCmd.connection.channel, dst)
  897. assert.EqualError(t, err, io.ErrShortWrite.Error())
  898. transfer.MaxWriteSize = -1
  899. _, err = transfer.copyFromReaderToWriter(sshCmd.connection.channel, dst)
  900. assert.True(t, transfer.Connection.IsQuotaExceededError(err))
  901. baseTransfer = common.NewBaseTransfer(nil, sshCmd.connection.BaseConnection, nil, "", "", "",
  902. common.TransferDownload, 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{
  903. AllowedDLSize: 1,
  904. })
  905. transfer = newTransfer(baseTransfer, nil, nil, nil)
  906. mockSSHChannel = MockChannel{
  907. Buffer: bytes.NewBuffer(buf),
  908. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  909. ReadError: nil,
  910. WriteError: nil,
  911. }
  912. sshCmd.connection.channel = &mockSSHChannel
  913. _, err = transfer.copyFromReaderToWriter(dst, sshCmd.connection.channel)
  914. if assert.Error(t, err) {
  915. assert.Contains(t, err.Error(), common.ErrReadQuotaExceeded.Error())
  916. }
  917. err = os.RemoveAll(homeDir)
  918. assert.NoError(t, err)
  919. }
  920. func TestCommandGetFsError(t *testing.T) {
  921. user := dataprovider.User{
  922. FsConfig: vfs.Filesystem{
  923. Provider: sdk.CryptedFilesystemProvider,
  924. },
  925. }
  926. conn := &Connection{
  927. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  928. }
  929. sshCmd := sshCommand{
  930. command: "rsync",
  931. connection: conn,
  932. args: []string{"--server", "-vlogDtprze.iLsfxC", ".", "/"},
  933. }
  934. _, err := sshCmd.getSystemCommand()
  935. assert.Error(t, err)
  936. buf := make([]byte, 65535)
  937. stdErrBuf := make([]byte, 65535)
  938. mockSSHChannel := MockChannel{
  939. Buffer: bytes.NewBuffer(buf),
  940. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  941. ReadError: nil,
  942. }
  943. conn = &Connection{
  944. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", user),
  945. channel: &mockSSHChannel,
  946. }
  947. scpCommand := scpCommand{
  948. sshCommand: sshCommand{
  949. command: "scp",
  950. connection: conn,
  951. args: []string{"-t", "/tmp"},
  952. },
  953. }
  954. err = scpCommand.handleRecursiveUpload()
  955. assert.Error(t, err)
  956. err = scpCommand.handleDownload("")
  957. assert.Error(t, err)
  958. }
  959. func TestGetConnectionInfo(t *testing.T) {
  960. c := common.ConnectionStatus{
  961. Username: "test_user",
  962. ConnectionID: "123",
  963. ClientVersion: "client",
  964. RemoteAddress: "127.0.0.1:1234",
  965. Protocol: common.ProtocolSSH,
  966. Command: "sha1sum /test_file_ftp.dat",
  967. }
  968. info := c.GetConnectionInfo()
  969. assert.Contains(t, info, "sha1sum /test_file_ftp.dat")
  970. }
  971. func TestSCPFileMode(t *testing.T) {
  972. mode := getFileModeAsString(0, true)
  973. assert.Equal(t, "0755", mode)
  974. mode = getFileModeAsString(0700, true)
  975. assert.Equal(t, "0700", mode)
  976. mode = getFileModeAsString(0750, true)
  977. assert.Equal(t, "0750", mode)
  978. mode = getFileModeAsString(0777, true)
  979. assert.Equal(t, "0777", mode)
  980. mode = getFileModeAsString(0640, false)
  981. assert.Equal(t, "0640", mode)
  982. mode = getFileModeAsString(0600, false)
  983. assert.Equal(t, "0600", mode)
  984. mode = getFileModeAsString(0, false)
  985. assert.Equal(t, "0644", mode)
  986. fileMode := uint32(0777)
  987. fileMode = fileMode | uint32(os.ModeSetgid)
  988. fileMode = fileMode | uint32(os.ModeSetuid)
  989. fileMode = fileMode | uint32(os.ModeSticky)
  990. mode = getFileModeAsString(os.FileMode(fileMode), false)
  991. assert.Equal(t, "7777", mode)
  992. fileMode = uint32(0644)
  993. fileMode = fileMode | uint32(os.ModeSetgid)
  994. mode = getFileModeAsString(os.FileMode(fileMode), false)
  995. assert.Equal(t, "4644", mode)
  996. fileMode = uint32(0600)
  997. fileMode = fileMode | uint32(os.ModeSetuid)
  998. mode = getFileModeAsString(os.FileMode(fileMode), false)
  999. assert.Equal(t, "2600", mode)
  1000. fileMode = uint32(0044)
  1001. fileMode = fileMode | uint32(os.ModeSticky)
  1002. mode = getFileModeAsString(os.FileMode(fileMode), false)
  1003. assert.Equal(t, "1044", mode)
  1004. }
  1005. func TestSCPUploadError(t *testing.T) {
  1006. buf := make([]byte, 65535)
  1007. stdErrBuf := make([]byte, 65535)
  1008. writeErr := fmt.Errorf("test write error")
  1009. mockSSHChannel := MockChannel{
  1010. Buffer: bytes.NewBuffer(buf),
  1011. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1012. ReadError: nil,
  1013. WriteError: writeErr,
  1014. }
  1015. user := dataprovider.User{
  1016. BaseUser: sdk.BaseUser{
  1017. HomeDir: filepath.Join(os.TempDir()),
  1018. Permissions: make(map[string][]string),
  1019. },
  1020. }
  1021. user.Permissions["/"] = []string{dataprovider.PermAny}
  1022. connection := &Connection{
  1023. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  1024. channel: &mockSSHChannel,
  1025. }
  1026. scpCommand := scpCommand{
  1027. sshCommand: sshCommand{
  1028. command: "scp",
  1029. connection: connection,
  1030. args: []string{"-t", "/"},
  1031. },
  1032. }
  1033. err := scpCommand.handle()
  1034. assert.EqualError(t, err, writeErr.Error())
  1035. mockSSHChannel = MockChannel{
  1036. Buffer: bytes.NewBuffer([]byte("D0755 0 testdir\n")),
  1037. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1038. ReadError: nil,
  1039. WriteError: writeErr,
  1040. }
  1041. err = scpCommand.handleRecursiveUpload()
  1042. assert.EqualError(t, err, writeErr.Error())
  1043. mockSSHChannel = MockChannel{
  1044. Buffer: bytes.NewBuffer([]byte("D0755 a testdir\n")),
  1045. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1046. ReadError: nil,
  1047. WriteError: nil,
  1048. }
  1049. err = scpCommand.handleRecursiveUpload()
  1050. assert.Error(t, err)
  1051. }
  1052. func TestSCPInvalidEndDir(t *testing.T) {
  1053. stdErrBuf := make([]byte, 65535)
  1054. mockSSHChannel := MockChannel{
  1055. Buffer: bytes.NewBuffer([]byte("E\n")),
  1056. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1057. }
  1058. connection := &Connection{
  1059. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", dataprovider.User{
  1060. BaseUser: sdk.BaseUser{
  1061. HomeDir: os.TempDir(),
  1062. },
  1063. }),
  1064. channel: &mockSSHChannel,
  1065. }
  1066. scpCommand := scpCommand{
  1067. sshCommand: sshCommand{
  1068. command: "scp",
  1069. connection: connection,
  1070. args: []string{"-t", "/tmp"},
  1071. },
  1072. }
  1073. err := scpCommand.handleRecursiveUpload()
  1074. assert.EqualError(t, err, "unacceptable end dir command")
  1075. }
  1076. func TestSCPParseUploadMessage(t *testing.T) {
  1077. buf := make([]byte, 65535)
  1078. stdErrBuf := make([]byte, 65535)
  1079. mockSSHChannel := MockChannel{
  1080. Buffer: bytes.NewBuffer(buf),
  1081. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1082. ReadError: nil,
  1083. }
  1084. fs := vfs.NewOsFs("", os.TempDir(), "")
  1085. connection := &Connection{
  1086. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", dataprovider.User{
  1087. BaseUser: sdk.BaseUser{
  1088. HomeDir: os.TempDir(),
  1089. },
  1090. }),
  1091. channel: &mockSSHChannel,
  1092. }
  1093. scpCommand := scpCommand{
  1094. sshCommand: sshCommand{
  1095. command: "scp",
  1096. connection: connection,
  1097. args: []string{"-t", "/tmp"},
  1098. },
  1099. }
  1100. _, _, err := scpCommand.parseUploadMessage(fs, "invalid")
  1101. assert.Error(t, err, "parsing invalid upload message must fail")
  1102. _, _, err = scpCommand.parseUploadMessage(fs, "D0755 0")
  1103. assert.Error(t, err, "parsing incomplete upload message must fail")
  1104. _, _, err = scpCommand.parseUploadMessage(fs, "D0755 invalidsize testdir")
  1105. assert.Error(t, err, "parsing upload message with invalid size must fail")
  1106. _, _, err = scpCommand.parseUploadMessage(fs, "D0755 0 ")
  1107. assert.Error(t, err, "parsing upload message with invalid name must fail")
  1108. }
  1109. func TestSCPProtocolMessages(t *testing.T) {
  1110. buf := make([]byte, 65535)
  1111. stdErrBuf := make([]byte, 65535)
  1112. readErr := fmt.Errorf("test read error")
  1113. writeErr := fmt.Errorf("test write error")
  1114. mockSSHChannel := MockChannel{
  1115. Buffer: bytes.NewBuffer(buf),
  1116. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1117. ReadError: readErr,
  1118. WriteError: writeErr,
  1119. }
  1120. connection := &Connection{
  1121. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1122. channel: &mockSSHChannel,
  1123. }
  1124. scpCommand := scpCommand{
  1125. sshCommand: sshCommand{
  1126. command: "scp",
  1127. connection: connection,
  1128. args: []string{"-t", "/tmp"},
  1129. },
  1130. }
  1131. _, err := scpCommand.readProtocolMessage()
  1132. assert.EqualError(t, err, readErr.Error())
  1133. err = scpCommand.sendConfirmationMessage()
  1134. assert.EqualError(t, err, writeErr.Error())
  1135. err = scpCommand.sendProtocolMessage("E\n")
  1136. assert.EqualError(t, err, writeErr.Error())
  1137. _, err = scpCommand.getNextUploadProtocolMessage()
  1138. assert.EqualError(t, err, readErr.Error())
  1139. mockSSHChannel = MockChannel{
  1140. Buffer: bytes.NewBuffer([]byte("T1183832947 0 1183833773 0\n")),
  1141. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1142. ReadError: nil,
  1143. WriteError: writeErr,
  1144. }
  1145. scpCommand.connection.channel = &mockSSHChannel
  1146. _, err = scpCommand.getNextUploadProtocolMessage()
  1147. assert.EqualError(t, err, writeErr.Error())
  1148. respBuffer := []byte{0x02}
  1149. protocolErrorMsg := "protocol error msg"
  1150. respBuffer = append(respBuffer, protocolErrorMsg...)
  1151. respBuffer = append(respBuffer, 0x0A)
  1152. mockSSHChannel = MockChannel{
  1153. Buffer: bytes.NewBuffer(respBuffer),
  1154. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1155. ReadError: nil,
  1156. WriteError: nil,
  1157. }
  1158. scpCommand.connection.channel = &mockSSHChannel
  1159. err = scpCommand.readConfirmationMessage()
  1160. if assert.Error(t, err) {
  1161. assert.Equal(t, protocolErrorMsg, err.Error())
  1162. }
  1163. }
  1164. func TestSCPTestDownloadProtocolMessages(t *testing.T) {
  1165. buf := make([]byte, 65535)
  1166. stdErrBuf := make([]byte, 65535)
  1167. readErr := fmt.Errorf("test read error")
  1168. writeErr := fmt.Errorf("test write error")
  1169. mockSSHChannel := MockChannel{
  1170. Buffer: bytes.NewBuffer(buf),
  1171. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1172. ReadError: readErr,
  1173. WriteError: writeErr,
  1174. }
  1175. connection := &Connection{
  1176. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1177. channel: &mockSSHChannel,
  1178. }
  1179. scpCommand := scpCommand{
  1180. sshCommand: sshCommand{
  1181. command: "scp",
  1182. connection: connection,
  1183. args: []string{"-f", "-p", "/tmp"},
  1184. },
  1185. }
  1186. path := "testDir"
  1187. err := os.Mkdir(path, os.ModePerm)
  1188. assert.NoError(t, err)
  1189. stat, err := os.Stat(path)
  1190. assert.NoError(t, err)
  1191. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1192. assert.EqualError(t, err, writeErr.Error())
  1193. mockSSHChannel = MockChannel{
  1194. Buffer: bytes.NewBuffer(buf),
  1195. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1196. ReadError: readErr,
  1197. WriteError: nil,
  1198. }
  1199. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1200. assert.EqualError(t, err, readErr.Error())
  1201. mockSSHChannel = MockChannel{
  1202. Buffer: bytes.NewBuffer(buf),
  1203. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1204. ReadError: readErr,
  1205. WriteError: writeErr,
  1206. }
  1207. scpCommand.args = []string{"-f", "/tmp"}
  1208. scpCommand.connection.channel = &mockSSHChannel
  1209. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1210. assert.EqualError(t, err, writeErr.Error())
  1211. mockSSHChannel = MockChannel{
  1212. Buffer: bytes.NewBuffer(buf),
  1213. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1214. ReadError: readErr,
  1215. WriteError: nil,
  1216. }
  1217. scpCommand.connection.channel = &mockSSHChannel
  1218. err = scpCommand.sendDownloadProtocolMessages(path, stat)
  1219. assert.EqualError(t, err, readErr.Error())
  1220. err = os.Remove(path)
  1221. assert.NoError(t, err)
  1222. }
  1223. func TestSCPCommandHandleErrors(t *testing.T) {
  1224. buf := make([]byte, 65535)
  1225. stdErrBuf := make([]byte, 65535)
  1226. readErr := fmt.Errorf("test read error")
  1227. writeErr := fmt.Errorf("test write error")
  1228. mockSSHChannel := MockChannel{
  1229. Buffer: bytes.NewBuffer(buf),
  1230. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1231. ReadError: readErr,
  1232. WriteError: writeErr,
  1233. }
  1234. server, client := net.Pipe()
  1235. defer func() {
  1236. err := server.Close()
  1237. assert.NoError(t, err)
  1238. }()
  1239. defer func() {
  1240. err := client.Close()
  1241. assert.NoError(t, err)
  1242. }()
  1243. connection := &Connection{
  1244. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1245. channel: &mockSSHChannel,
  1246. }
  1247. scpCommand := scpCommand{
  1248. sshCommand: sshCommand{
  1249. command: "scp",
  1250. connection: connection,
  1251. args: []string{"-f", "/tmp"},
  1252. },
  1253. }
  1254. err := scpCommand.handle()
  1255. assert.EqualError(t, err, readErr.Error())
  1256. scpCommand.args = []string{"-i", "/tmp"}
  1257. err = scpCommand.handle()
  1258. assert.Error(t, err, "invalid scp command must fail")
  1259. }
  1260. func TestSCPErrorsMockFs(t *testing.T) {
  1261. errFake := errors.New("fake error")
  1262. u := dataprovider.User{}
  1263. u.Username = "test"
  1264. u.Permissions = make(map[string][]string)
  1265. u.Permissions["/"] = []string{dataprovider.PermAny}
  1266. u.HomeDir = os.TempDir()
  1267. buf := make([]byte, 65535)
  1268. stdErrBuf := make([]byte, 65535)
  1269. mockSSHChannel := MockChannel{
  1270. Buffer: bytes.NewBuffer(buf),
  1271. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1272. }
  1273. server, client := net.Pipe()
  1274. defer func() {
  1275. err := server.Close()
  1276. assert.NoError(t, err)
  1277. }()
  1278. defer func() {
  1279. err := client.Close()
  1280. assert.NoError(t, err)
  1281. }()
  1282. connection := &Connection{
  1283. channel: &mockSSHChannel,
  1284. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", u),
  1285. }
  1286. scpCommand := scpCommand{
  1287. sshCommand: sshCommand{
  1288. command: "scp",
  1289. connection: connection,
  1290. args: []string{"-r", "-t", "/tmp"},
  1291. },
  1292. }
  1293. testfile := filepath.Join(u.HomeDir, "testfile")
  1294. err := os.WriteFile(testfile, []byte("test"), os.ModePerm)
  1295. assert.NoError(t, err)
  1296. fs := newMockOsFs(errFake, nil, true, "123", os.TempDir())
  1297. err = scpCommand.handleUploadFile(fs, testfile, testfile, 0, false, 4, "/testfile")
  1298. assert.NoError(t, err)
  1299. err = os.Remove(testfile)
  1300. assert.NoError(t, err)
  1301. }
  1302. func TestSCPRecursiveDownloadErrors(t *testing.T) {
  1303. buf := make([]byte, 65535)
  1304. stdErrBuf := make([]byte, 65535)
  1305. readErr := fmt.Errorf("test read error")
  1306. writeErr := fmt.Errorf("test write error")
  1307. mockSSHChannel := MockChannel{
  1308. Buffer: bytes.NewBuffer(buf),
  1309. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1310. ReadError: readErr,
  1311. WriteError: writeErr,
  1312. }
  1313. server, client := net.Pipe()
  1314. defer func() {
  1315. err := server.Close()
  1316. assert.NoError(t, err)
  1317. }()
  1318. defer func() {
  1319. err := client.Close()
  1320. assert.NoError(t, err)
  1321. }()
  1322. fs := vfs.NewOsFs("123", os.TempDir(), "")
  1323. connection := &Connection{
  1324. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{
  1325. BaseUser: sdk.BaseUser{
  1326. HomeDir: os.TempDir(),
  1327. },
  1328. }),
  1329. channel: &mockSSHChannel,
  1330. }
  1331. scpCommand := scpCommand{
  1332. sshCommand: sshCommand{
  1333. command: "scp",
  1334. connection: connection,
  1335. args: []string{"-r", "-f", "/tmp"},
  1336. },
  1337. }
  1338. path := "testDir"
  1339. err := os.Mkdir(path, os.ModePerm)
  1340. assert.NoError(t, err)
  1341. stat, err := os.Stat(path)
  1342. assert.NoError(t, err)
  1343. err = scpCommand.handleRecursiveDownload(fs, "invalid_dir", "invalid_dir", stat)
  1344. assert.EqualError(t, err, writeErr.Error())
  1345. mockSSHChannel = MockChannel{
  1346. Buffer: bytes.NewBuffer(buf),
  1347. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1348. ReadError: nil,
  1349. WriteError: nil,
  1350. }
  1351. scpCommand.connection.channel = &mockSSHChannel
  1352. err = scpCommand.handleRecursiveDownload(fs, "invalid_dir", "invalid_dir", stat)
  1353. assert.Error(t, err, "recursive upload download must fail for a non existing dir")
  1354. err = os.Remove(path)
  1355. assert.NoError(t, err)
  1356. }
  1357. func TestSCPRecursiveUploadErrors(t *testing.T) {
  1358. buf := make([]byte, 65535)
  1359. stdErrBuf := make([]byte, 65535)
  1360. readErr := fmt.Errorf("test read error")
  1361. writeErr := fmt.Errorf("test write error")
  1362. mockSSHChannel := MockChannel{
  1363. Buffer: bytes.NewBuffer(buf),
  1364. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1365. ReadError: readErr,
  1366. WriteError: writeErr,
  1367. }
  1368. connection := &Connection{
  1369. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{}),
  1370. channel: &mockSSHChannel,
  1371. }
  1372. scpCommand := scpCommand{
  1373. sshCommand: sshCommand{
  1374. command: "scp",
  1375. connection: connection,
  1376. args: []string{"-r", "-t", "/tmp"},
  1377. },
  1378. }
  1379. err := scpCommand.handleRecursiveUpload()
  1380. assert.Error(t, err, "recursive upload must fail, we send a fake error message")
  1381. mockSSHChannel = MockChannel{
  1382. Buffer: bytes.NewBuffer(buf),
  1383. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1384. ReadError: readErr,
  1385. WriteError: nil,
  1386. }
  1387. scpCommand.connection.channel = &mockSSHChannel
  1388. err = scpCommand.handleRecursiveUpload()
  1389. assert.Error(t, err, "recursive upload must fail, we send a fake error message")
  1390. }
  1391. func TestSCPCreateDirs(t *testing.T) {
  1392. buf := make([]byte, 65535)
  1393. stdErrBuf := make([]byte, 65535)
  1394. u := dataprovider.User{}
  1395. u.HomeDir = "home_rel_path"
  1396. u.Username = "test"
  1397. u.Permissions = make(map[string][]string)
  1398. u.Permissions["/"] = []string{dataprovider.PermAny}
  1399. mockSSHChannel := MockChannel{
  1400. Buffer: bytes.NewBuffer(buf),
  1401. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1402. ReadError: nil,
  1403. WriteError: nil,
  1404. }
  1405. fs, err := u.GetFilesystem("123")
  1406. assert.NoError(t, err)
  1407. connection := &Connection{
  1408. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", u),
  1409. channel: &mockSSHChannel,
  1410. }
  1411. scpCommand := scpCommand{
  1412. sshCommand: sshCommand{
  1413. command: "scp",
  1414. connection: connection,
  1415. args: []string{"-r", "-t", "/tmp"},
  1416. },
  1417. }
  1418. err = scpCommand.handleCreateDir(fs, "invalid_dir")
  1419. assert.Error(t, err, "create invalid dir must fail")
  1420. }
  1421. func TestSCPDownloadFileData(t *testing.T) {
  1422. testfile := "testfile"
  1423. buf := make([]byte, 65535)
  1424. readErr := fmt.Errorf("test read error")
  1425. writeErr := fmt.Errorf("test write error")
  1426. stdErrBuf := make([]byte, 65535)
  1427. mockSSHChannelReadErr := MockChannel{
  1428. Buffer: bytes.NewBuffer(buf),
  1429. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1430. ReadError: readErr,
  1431. WriteError: nil,
  1432. }
  1433. mockSSHChannelWriteErr := MockChannel{
  1434. Buffer: bytes.NewBuffer(buf),
  1435. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1436. ReadError: nil,
  1437. WriteError: writeErr,
  1438. }
  1439. fs := vfs.NewOsFs("", os.TempDir(), "")
  1440. connection := &Connection{
  1441. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", dataprovider.User{BaseUser: sdk.BaseUser{HomeDir: os.TempDir()}}),
  1442. channel: &mockSSHChannelReadErr,
  1443. }
  1444. scpCommand := scpCommand{
  1445. sshCommand: sshCommand{
  1446. command: "scp",
  1447. connection: connection,
  1448. args: []string{"-r", "-f", "/tmp"},
  1449. },
  1450. }
  1451. err := os.WriteFile(testfile, []byte("test"), os.ModePerm)
  1452. assert.NoError(t, err)
  1453. stat, err := os.Stat(testfile)
  1454. assert.NoError(t, err)
  1455. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1456. assert.EqualError(t, err, readErr.Error())
  1457. scpCommand.connection.channel = &mockSSHChannelWriteErr
  1458. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1459. assert.EqualError(t, err, writeErr.Error())
  1460. scpCommand.args = []string{"-r", "-p", "-f", "/tmp"}
  1461. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1462. assert.EqualError(t, err, writeErr.Error())
  1463. scpCommand.connection.channel = &mockSSHChannelReadErr
  1464. err = scpCommand.sendDownloadFileData(fs, testfile, stat, nil)
  1465. assert.EqualError(t, err, readErr.Error())
  1466. err = os.Remove(testfile)
  1467. assert.NoError(t, err)
  1468. }
  1469. func TestSCPUploadFiledata(t *testing.T) {
  1470. testfile := "testfile"
  1471. buf := make([]byte, 65535)
  1472. stdErrBuf := make([]byte, 65535)
  1473. readErr := fmt.Errorf("test read error")
  1474. writeErr := fmt.Errorf("test write error")
  1475. mockSSHChannel := MockChannel{
  1476. Buffer: bytes.NewBuffer(buf),
  1477. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1478. ReadError: readErr,
  1479. WriteError: writeErr,
  1480. }
  1481. user := dataprovider.User{
  1482. BaseUser: sdk.BaseUser{
  1483. Username: "testuser",
  1484. },
  1485. }
  1486. fs := vfs.NewOsFs("", os.TempDir(), "")
  1487. connection := &Connection{
  1488. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", user),
  1489. channel: &mockSSHChannel,
  1490. }
  1491. scpCommand := scpCommand{
  1492. sshCommand: sshCommand{
  1493. command: "scp",
  1494. connection: connection,
  1495. args: []string{"-r", "-t", "/tmp"},
  1496. },
  1497. }
  1498. file, err := os.Create(testfile)
  1499. assert.NoError(t, err)
  1500. baseTransfer := common.NewBaseTransfer(file, scpCommand.connection.BaseConnection, nil, file.Name(), file.Name(),
  1501. "/"+testfile, common.TransferDownload, 0, 0, 0, 0, true, fs, dataprovider.TransferQuota{})
  1502. transfer := newTransfer(baseTransfer, nil, nil, nil)
  1503. err = scpCommand.getUploadFileData(2, transfer)
  1504. assert.Error(t, err, "upload must fail, we send a fake write error message")
  1505. mockSSHChannel = MockChannel{
  1506. Buffer: bytes.NewBuffer(buf),
  1507. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1508. ReadError: readErr,
  1509. WriteError: nil,
  1510. }
  1511. scpCommand.connection.channel = &mockSSHChannel
  1512. file, err = os.Create(testfile)
  1513. assert.NoError(t, err)
  1514. transfer.File = file
  1515. transfer.isFinished = false
  1516. transfer.Connection.AddTransfer(transfer)
  1517. err = scpCommand.getUploadFileData(2, transfer)
  1518. assert.Error(t, err, "upload must fail, we send a fake read error message")
  1519. respBuffer := []byte("12")
  1520. respBuffer = append(respBuffer, 0x02)
  1521. mockSSHChannel = MockChannel{
  1522. Buffer: bytes.NewBuffer(respBuffer),
  1523. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1524. ReadError: nil,
  1525. WriteError: nil,
  1526. }
  1527. scpCommand.connection.channel = &mockSSHChannel
  1528. file, err = os.Create(testfile)
  1529. assert.NoError(t, err)
  1530. baseTransfer.File = file
  1531. transfer = newTransfer(baseTransfer, nil, nil, nil)
  1532. transfer.Connection.AddTransfer(transfer)
  1533. err = scpCommand.getUploadFileData(2, transfer)
  1534. assert.Error(t, err, "upload must fail, we have not enough data to read")
  1535. // the file is already closed so we have an error on trasfer closing
  1536. mockSSHChannel = MockChannel{
  1537. Buffer: bytes.NewBuffer(buf),
  1538. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1539. ReadError: nil,
  1540. WriteError: nil,
  1541. }
  1542. transfer.Connection.AddTransfer(transfer)
  1543. err = scpCommand.getUploadFileData(0, transfer)
  1544. if assert.Error(t, err) {
  1545. assert.EqualError(t, err, common.ErrTransferClosed.Error())
  1546. }
  1547. mockSSHChannel = MockChannel{
  1548. Buffer: bytes.NewBuffer(buf),
  1549. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1550. ReadError: nil,
  1551. WriteError: nil,
  1552. }
  1553. transfer.Connection.AddTransfer(transfer)
  1554. err = scpCommand.getUploadFileData(2, transfer)
  1555. assert.True(t, errors.Is(err, os.ErrClosed))
  1556. err = os.Remove(testfile)
  1557. assert.NoError(t, err)
  1558. }
  1559. func TestUploadError(t *testing.T) {
  1560. common.Config.UploadMode = common.UploadModeAtomic
  1561. user := dataprovider.User{
  1562. BaseUser: sdk.BaseUser{
  1563. Username: "testuser",
  1564. },
  1565. }
  1566. fs := vfs.NewOsFs("", os.TempDir(), "")
  1567. connection := &Connection{
  1568. BaseConnection: common.NewBaseConnection("", common.ProtocolSCP, "", "", user),
  1569. }
  1570. testfile := "testfile"
  1571. fileTempName := "temptestfile"
  1572. file, err := os.Create(fileTempName)
  1573. assert.NoError(t, err)
  1574. baseTransfer := common.NewBaseTransfer(file, connection.BaseConnection, nil, testfile, file.Name(),
  1575. testfile, common.TransferUpload, 0, 0, 0, 0, true, fs, dataprovider.TransferQuota{})
  1576. transfer := newTransfer(baseTransfer, nil, nil, nil)
  1577. errFake := errors.New("fake error")
  1578. transfer.TransferError(errFake)
  1579. err = transfer.Close()
  1580. if assert.Error(t, err) {
  1581. assert.EqualError(t, err, common.ErrGenericFailure.Error())
  1582. }
  1583. if assert.Error(t, transfer.ErrTransfer) {
  1584. assert.EqualError(t, transfer.ErrTransfer, errFake.Error())
  1585. }
  1586. assert.Equal(t, int64(0), transfer.BytesReceived.Load())
  1587. assert.NoFileExists(t, testfile)
  1588. assert.NoFileExists(t, fileTempName)
  1589. common.Config.UploadMode = common.UploadModeAtomicWithResume
  1590. }
  1591. func TestTransferFailingReader(t *testing.T) {
  1592. user := dataprovider.User{
  1593. BaseUser: sdk.BaseUser{
  1594. Username: "testuser",
  1595. HomeDir: os.TempDir(),
  1596. },
  1597. FsConfig: vfs.Filesystem{
  1598. Provider: sdk.CryptedFilesystemProvider,
  1599. CryptConfig: vfs.CryptFsConfig{
  1600. Passphrase: kms.NewPlainSecret("crypt secret"),
  1601. },
  1602. },
  1603. }
  1604. user.Permissions = make(map[string][]string)
  1605. user.Permissions["/"] = []string{dataprovider.PermAny}
  1606. fs := newMockOsFs(nil, nil, true, "", os.TempDir())
  1607. connection := &Connection{
  1608. BaseConnection: common.NewBaseConnection("", common.ProtocolSFTP, "", "", user),
  1609. }
  1610. request := sftp.NewRequest("Open", "afile.txt")
  1611. request.Flags = 27 // read,write,create,truncate
  1612. transfer, err := connection.handleFilewrite(request)
  1613. require.NoError(t, err)
  1614. buf := make([]byte, 32)
  1615. _, err = transfer.ReadAt(buf, 0)
  1616. assert.EqualError(t, err, sftp.ErrSSHFxOpUnsupported.Error())
  1617. if c, ok := transfer.(io.Closer); ok {
  1618. err = c.Close()
  1619. assert.NoError(t, err)
  1620. }
  1621. fsPath := filepath.Join(os.TempDir(), "afile.txt")
  1622. r, _, err := pipeat.Pipe()
  1623. assert.NoError(t, err)
  1624. baseTransfer := common.NewBaseTransfer(nil, connection.BaseConnection, nil, fsPath, fsPath, filepath.Base(fsPath),
  1625. common.TransferUpload, 0, 0, 0, 0, false, fs, dataprovider.TransferQuota{})
  1626. errRead := errors.New("read is not allowed")
  1627. tr := newTransfer(baseTransfer, nil, r, errRead)
  1628. _, err = tr.ReadAt(buf, 0)
  1629. assert.EqualError(t, err, errRead.Error())
  1630. err = tr.Close()
  1631. assert.NoError(t, err)
  1632. tr = newTransfer(baseTransfer, nil, nil, errRead)
  1633. _, err = tr.ReadAt(buf, 0)
  1634. assert.EqualError(t, err, errRead.Error())
  1635. err = tr.Close()
  1636. assert.NoError(t, err)
  1637. err = os.Remove(fsPath)
  1638. assert.NoError(t, err)
  1639. assert.Len(t, connection.GetTransfers(), 0)
  1640. }
  1641. func TestConnectionStatusStruct(t *testing.T) {
  1642. var transfers []common.ConnectionTransfer
  1643. transferUL := common.ConnectionTransfer{
  1644. OperationType: "upload",
  1645. StartTime: util.GetTimeAsMsSinceEpoch(time.Now()),
  1646. Size: 123,
  1647. VirtualPath: "/test.upload",
  1648. }
  1649. transferDL := common.ConnectionTransfer{
  1650. OperationType: "download",
  1651. StartTime: util.GetTimeAsMsSinceEpoch(time.Now()),
  1652. Size: 123,
  1653. VirtualPath: "/test.download",
  1654. }
  1655. transfers = append(transfers, transferUL)
  1656. transfers = append(transfers, transferDL)
  1657. c := common.ConnectionStatus{
  1658. Username: "test",
  1659. ConnectionID: "123",
  1660. ClientVersion: "fakeClient-1.0.0",
  1661. RemoteAddress: "127.0.0.1:1234",
  1662. ConnectionTime: util.GetTimeAsMsSinceEpoch(time.Now()),
  1663. LastActivity: util.GetTimeAsMsSinceEpoch(time.Now()),
  1664. Protocol: "SFTP",
  1665. Transfers: transfers,
  1666. }
  1667. durationString := c.GetConnectionDuration()
  1668. assert.NotEqual(t, 0, len(durationString))
  1669. transfersString := c.GetTransfersAsString()
  1670. assert.NotEqual(t, 0, len(transfersString))
  1671. connInfo := c.GetConnectionInfo()
  1672. assert.NotEqual(t, 0, len(connInfo))
  1673. }
  1674. func TestSupportedSecurityOptions(t *testing.T) {
  1675. c := Configuration{
  1676. KexAlgorithms: supportedKexAlgos,
  1677. MACs: supportedMACs,
  1678. Ciphers: supportedCiphers,
  1679. }
  1680. serverConfig := &ssh.ServerConfig{}
  1681. err := c.configureSecurityOptions(serverConfig)
  1682. assert.NoError(t, err)
  1683. assert.Equal(t, supportedCiphers, serverConfig.Ciphers)
  1684. assert.Equal(t, supportedMACs, serverConfig.MACs)
  1685. assert.Equal(t, supportedKexAlgos, serverConfig.KeyExchanges)
  1686. c.KexAlgorithms = append(c.KexAlgorithms, "not a kex")
  1687. err = c.configureSecurityOptions(serverConfig)
  1688. assert.Error(t, err)
  1689. c.KexAlgorithms = supportedKexAlgos
  1690. c.MACs = []string{
  1691. " hmac-sha2-256-etm@openssh.com ", "hmac-sha2-256",
  1692. " hmac-sha2-512-etm@openssh.com", "hmac-sha2-512 ",
  1693. "hmac-sha1 ", " hmac-sha1-96",
  1694. }
  1695. err = c.configureSecurityOptions(serverConfig)
  1696. assert.NoError(t, err)
  1697. assert.Equal(t, supportedCiphers, serverConfig.Ciphers)
  1698. assert.Equal(t, supportedMACs, serverConfig.MACs)
  1699. assert.Equal(t, supportedKexAlgos, serverConfig.KeyExchanges)
  1700. }
  1701. func TestLoadModuli(t *testing.T) {
  1702. dhGEXSha1 := "diffie-hellman-group-exchange-sha1"
  1703. dhGEXSha256 := "diffie-hellman-group-exchange-sha256"
  1704. c := Configuration{}
  1705. c.Moduli = []string{".", "missing file"}
  1706. err := c.loadModuli(configDir)
  1707. assert.Error(t, err)
  1708. assert.NotContains(t, supportedKexAlgos, dhGEXSha1)
  1709. assert.NotContains(t, supportedKexAlgos, dhGEXSha256)
  1710. assert.Len(t, supportedKexAlgos, 10)
  1711. moduli := []byte("20220414072358 2 6 100 2047 5 F19C2D09AD49978F8A0C1B84168A4011A26F9CD516815934764A319FDC5975FA514AAF11B747D8CA6B3919532BEFB68FA118079473895674F3770F71FBB742F176883841EB3DE679BEF53C6AFE437A662F228B03C1E34B5A0D3909F608CEAA16C1F8131DE11E67878EFD918A89205E5E4DE323054010CA4711F25D466BB7727A016DD3F9F53BDBCE093055A4F2497ADEFB5A2500F9C5C3B0BCD88C6489F4C1CBC7CFB67BA6EABA0195794E4188CE9060F431041AD52FB9BAC4DF7FA536F585FBE67746CD57BFAD67567E9706C24D95C49BE95B759657C6BB5151E2AEA32F4CD557C40298A5C402101520EE8AAB8DFEED6FFC11AAF8036D6345923CFB5D1B922F")
  1712. moduliFile := filepath.Join(os.TempDir(), "moduli")
  1713. err = os.WriteFile(moduliFile, moduli, 0600)
  1714. assert.NoError(t, err)
  1715. c.Moduli = []string{moduliFile}
  1716. err = c.loadModuli(configDir)
  1717. assert.NoError(t, err)
  1718. assert.Contains(t, supportedKexAlgos, dhGEXSha1)
  1719. assert.Contains(t, supportedKexAlgos, dhGEXSha256)
  1720. assert.Len(t, supportedKexAlgos, 12)
  1721. err = os.Remove(moduliFile)
  1722. assert.NoError(t, err)
  1723. }
  1724. func TestLoadHostKeys(t *testing.T) {
  1725. serverConfig := &ssh.ServerConfig{}
  1726. c := Configuration{}
  1727. c.HostKeys = []string{".", "missing file"}
  1728. err := c.checkAndLoadHostKeys(configDir, serverConfig)
  1729. assert.Error(t, err)
  1730. testfile := filepath.Join(os.TempDir(), "invalidkey")
  1731. err = os.WriteFile(testfile, []byte("some bytes"), os.ModePerm)
  1732. assert.NoError(t, err)
  1733. c.HostKeys = []string{testfile}
  1734. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1735. assert.Error(t, err)
  1736. err = os.Remove(testfile)
  1737. assert.NoError(t, err)
  1738. keysDir := filepath.Join(os.TempDir(), "keys")
  1739. err = os.MkdirAll(keysDir, os.ModePerm)
  1740. assert.NoError(t, err)
  1741. rsaKeyName := filepath.Join(keysDir, defaultPrivateRSAKeyName)
  1742. ecdsaKeyName := filepath.Join(keysDir, defaultPrivateECDSAKeyName)
  1743. ed25519KeyName := filepath.Join(keysDir, defaultPrivateEd25519KeyName)
  1744. nonDefaultKeyName := filepath.Join(keysDir, "akey")
  1745. c.HostKeys = []string{nonDefaultKeyName, rsaKeyName, ecdsaKeyName, ed25519KeyName}
  1746. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1747. assert.Error(t, err)
  1748. assert.FileExists(t, rsaKeyName)
  1749. assert.FileExists(t, ecdsaKeyName)
  1750. assert.FileExists(t, ed25519KeyName)
  1751. assert.NoFileExists(t, nonDefaultKeyName)
  1752. err = os.Remove(rsaKeyName)
  1753. assert.NoError(t, err)
  1754. err = os.Remove(ecdsaKeyName)
  1755. assert.NoError(t, err)
  1756. err = os.Remove(ed25519KeyName)
  1757. assert.NoError(t, err)
  1758. if runtime.GOOS != osWindows {
  1759. err = os.Chmod(keysDir, 0551)
  1760. assert.NoError(t, err)
  1761. c.HostKeys = nil
  1762. err = c.checkAndLoadHostKeys(keysDir, serverConfig)
  1763. assert.Error(t, err)
  1764. c.HostKeys = []string{rsaKeyName, ecdsaKeyName}
  1765. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1766. assert.Error(t, err)
  1767. c.HostKeys = []string{ecdsaKeyName, rsaKeyName}
  1768. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1769. assert.Error(t, err)
  1770. c.HostKeys = []string{ed25519KeyName}
  1771. err = c.checkAndLoadHostKeys(configDir, serverConfig)
  1772. assert.Error(t, err)
  1773. err = os.Chmod(keysDir, 0755)
  1774. assert.NoError(t, err)
  1775. }
  1776. err = os.RemoveAll(keysDir)
  1777. assert.NoError(t, err)
  1778. }
  1779. func TestCertCheckerInitErrors(t *testing.T) {
  1780. c := Configuration{}
  1781. c.TrustedUserCAKeys = []string{".", "missing file"}
  1782. err := c.initializeCertChecker("")
  1783. assert.Error(t, err)
  1784. testfile := filepath.Join(os.TempDir(), "invalidkey")
  1785. err = os.WriteFile(testfile, []byte("some bytes"), os.ModePerm)
  1786. assert.NoError(t, err)
  1787. c.TrustedUserCAKeys = []string{testfile}
  1788. err = c.initializeCertChecker("")
  1789. assert.Error(t, err)
  1790. err = os.Remove(testfile)
  1791. assert.NoError(t, err)
  1792. }
  1793. func TestSFTPSubSystem(t *testing.T) {
  1794. permissions := make(map[string][]string)
  1795. permissions["/"] = []string{dataprovider.PermAny}
  1796. user := &dataprovider.User{
  1797. BaseUser: sdk.BaseUser{
  1798. Permissions: permissions,
  1799. HomeDir: os.TempDir(),
  1800. },
  1801. }
  1802. user.FsConfig.Provider = sdk.AzureBlobFilesystemProvider
  1803. err := ServeSubSystemConnection(user, "connID", nil, nil)
  1804. assert.Error(t, err)
  1805. user.FsConfig.Provider = sdk.LocalFilesystemProvider
  1806. buf := make([]byte, 0, 4096)
  1807. stdErrBuf := make([]byte, 0, 4096)
  1808. mockSSHChannel := &MockChannel{
  1809. Buffer: bytes.NewBuffer(buf),
  1810. StdErrBuffer: bytes.NewBuffer(stdErrBuf),
  1811. }
  1812. // this is 327680 and it will result in packet too long error
  1813. _, err = mockSSHChannel.Write([]byte{0x00, 0x05, 0x00, 0x00, 0x00, 0x00})
  1814. assert.NoError(t, err)
  1815. err = ServeSubSystemConnection(user, "id", mockSSHChannel, mockSSHChannel)
  1816. assert.EqualError(t, err, "packet too long")
  1817. subsystemChannel := newSubsystemChannel(mockSSHChannel, mockSSHChannel)
  1818. n, err := subsystemChannel.Write([]byte{0x00})
  1819. assert.NoError(t, err)
  1820. assert.Equal(t, n, 1)
  1821. err = subsystemChannel.Close()
  1822. assert.NoError(t, err)
  1823. }
  1824. func TestRecoverer(t *testing.T) {
  1825. c := Configuration{}
  1826. c.AcceptInboundConnection(nil, nil)
  1827. connID := "connectionID"
  1828. connection := &Connection{
  1829. BaseConnection: common.NewBaseConnection(connID, common.ProtocolSFTP, "", "", dataprovider.User{}),
  1830. }
  1831. c.handleSftpConnection(nil, connection)
  1832. sshCmd := sshCommand{
  1833. command: "cd",
  1834. connection: connection,
  1835. }
  1836. err := sshCmd.handle()
  1837. assert.EqualError(t, err, common.ErrGenericFailure.Error())
  1838. scpCmd := scpCommand{
  1839. sshCommand: sshCommand{
  1840. command: "scp",
  1841. connection: connection,
  1842. },
  1843. }
  1844. err = scpCmd.handle()
  1845. assert.EqualError(t, err, common.ErrGenericFailure.Error())
  1846. assert.Len(t, common.Connections.GetStats(""), 0)
  1847. }
  1848. func TestListernerAcceptErrors(t *testing.T) {
  1849. errFake := errors.New("a fake error")
  1850. listener := newFakeListener(errFake)
  1851. c := Configuration{}
  1852. err := c.serve(listener, nil)
  1853. require.EqualError(t, err, errFake.Error())
  1854. err = listener.Close()
  1855. require.NoError(t, err)
  1856. errNetFake := &fakeNetError{error: errFake}
  1857. listener = newFakeListener(errNetFake)
  1858. err = c.serve(listener, nil)
  1859. require.EqualError(t, err, errFake.Error())
  1860. err = listener.Close()
  1861. require.NoError(t, err)
  1862. }
  1863. type fakeNetError struct {
  1864. error
  1865. count int
  1866. }
  1867. func (e *fakeNetError) Timeout() bool {
  1868. return false
  1869. }
  1870. func (e *fakeNetError) Temporary() bool {
  1871. e.count++
  1872. return e.count < 10
  1873. }
  1874. func (e *fakeNetError) Error() string {
  1875. return e.error.Error()
  1876. }
  1877. type fakeListener struct {
  1878. server net.Conn
  1879. client net.Conn
  1880. err error
  1881. }
  1882. func (l *fakeListener) Accept() (net.Conn, error) {
  1883. return l.client, l.err
  1884. }
  1885. func (l *fakeListener) Close() error {
  1886. errClient := l.client.Close()
  1887. errServer := l.server.Close()
  1888. if errServer != nil {
  1889. return errServer
  1890. }
  1891. return errClient
  1892. }
  1893. func (l *fakeListener) Addr() net.Addr {
  1894. return l.server.LocalAddr()
  1895. }
  1896. func newFakeListener(err error) net.Listener {
  1897. server, client := net.Pipe()
  1898. return &fakeListener{
  1899. server: server,
  1900. client: client,
  1901. err: err,
  1902. }
  1903. }
  1904. func TestFolderPrefix(t *testing.T) {
  1905. c := Configuration{
  1906. FolderPrefix: "files",
  1907. }
  1908. c.checkFolderPrefix()
  1909. assert.Equal(t, "/files", c.FolderPrefix)
  1910. c.FolderPrefix = ""
  1911. c.checkFolderPrefix()
  1912. assert.Empty(t, c.FolderPrefix)
  1913. c.FolderPrefix = "/"
  1914. c.checkFolderPrefix()
  1915. assert.Empty(t, c.FolderPrefix)
  1916. c.FolderPrefix = "/."
  1917. c.checkFolderPrefix()
  1918. assert.Empty(t, c.FolderPrefix)
  1919. c.FolderPrefix = "."
  1920. c.checkFolderPrefix()
  1921. assert.Empty(t, c.FolderPrefix)
  1922. c.FolderPrefix = ".."
  1923. c.checkFolderPrefix()
  1924. assert.Empty(t, c.FolderPrefix)
  1925. }
  1926. func TestLoadRevokedUserCertsFile(t *testing.T) {
  1927. r := revokedCertificates{
  1928. certs: map[string]bool{},
  1929. }
  1930. err := r.load()
  1931. assert.NoError(t, err)
  1932. r.filePath = filepath.Join(os.TempDir(), "sub", "testrevoked")
  1933. err = os.MkdirAll(filepath.Dir(r.filePath), os.ModePerm)
  1934. assert.NoError(t, err)
  1935. err = os.WriteFile(r.filePath, []byte(`no json`), 0644)
  1936. assert.NoError(t, err)
  1937. err = r.load()
  1938. assert.Error(t, err)
  1939. r.filePath = filepath.Dir(r.filePath)
  1940. err = r.load()
  1941. assert.Error(t, err)
  1942. err = os.RemoveAll(r.filePath)
  1943. assert.NoError(t, err)
  1944. }
  1945. func TestMaxUserSessions(t *testing.T) {
  1946. connection := &Connection{
  1947. BaseConnection: common.NewBaseConnection(xid.New().String(), common.ProtocolSFTP, "", "", dataprovider.User{
  1948. BaseUser: sdk.BaseUser{
  1949. Username: "user_max_sessions",
  1950. HomeDir: filepath.Clean(os.TempDir()),
  1951. MaxSessions: 1,
  1952. },
  1953. }),
  1954. }
  1955. err := common.Connections.Add(connection)
  1956. assert.NoError(t, err)
  1957. c := Configuration{}
  1958. c.handleSftpConnection(nil, connection)
  1959. sshCmd := sshCommand{
  1960. command: "cd",
  1961. connection: connection,
  1962. }
  1963. err = sshCmd.handle()
  1964. if assert.Error(t, err) {
  1965. assert.Contains(t, err.Error(), "too many open sessions")
  1966. }
  1967. scpCmd := scpCommand{
  1968. sshCommand: sshCommand{
  1969. command: "scp",
  1970. connection: connection,
  1971. },
  1972. }
  1973. err = scpCmd.handle()
  1974. if assert.Error(t, err) {
  1975. assert.Contains(t, err.Error(), "too many open sessions")
  1976. }
  1977. err = ServeSubSystemConnection(&connection.User, connection.ID, nil, nil)
  1978. if assert.Error(t, err) {
  1979. assert.Contains(t, err.Error(), "too many open sessions")
  1980. }
  1981. common.Connections.Remove(connection.GetID())
  1982. assert.Len(t, common.Connections.GetStats(""), 0)
  1983. }
  1984. func TestCanReadSymlink(t *testing.T) {
  1985. connection := &Connection{
  1986. BaseConnection: common.NewBaseConnection(xid.New().String(), common.ProtocolSFTP, "", "", dataprovider.User{
  1987. BaseUser: sdk.BaseUser{
  1988. Username: "user_can_read_symlink",
  1989. HomeDir: filepath.Clean(os.TempDir()),
  1990. Permissions: map[string][]string{
  1991. "/": {dataprovider.PermAny},
  1992. "/sub": {dataprovider.PermUpload},
  1993. },
  1994. },
  1995. Filters: dataprovider.UserFilters{
  1996. BaseUserFilters: sdk.BaseUserFilters{
  1997. FilePatterns: []sdk.PatternsFilter{
  1998. {
  1999. Path: "/denied",
  2000. DeniedPatterns: []string{"*.txt"},
  2001. DenyPolicy: sdk.DenyPolicyHide,
  2002. },
  2003. },
  2004. },
  2005. },
  2006. }),
  2007. }
  2008. err := connection.canReadLink("/sub/link")
  2009. assert.ErrorIs(t, err, sftp.ErrSSHFxPermissionDenied)
  2010. err = connection.canReadLink("/denied/file.txt")
  2011. assert.ErrorIs(t, err, sftp.ErrSSHFxNoSuchFile)
  2012. }