0ct0pu5/photoprism
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Auth: Improve oidc tests #782

Browse source
This commit is contained in:
Timo Volkmann 2021-09-20 19:15:59 +02:00
parent 24f6041a76
commit 5bac7ba11d
1 changed files with 16 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
internal/api/auth_test.go
View file

@ -1,6 +1,7 @@
package api
import (
"github.com/photoprism/photoprism/internal/httpclient"
"net/http"
"strings"
"testing"
@ -21,20 +22,21 @@ func TestAuthEndpoints(t *testing.T) {
// Step 1b: Redirect user agent to OP and save state cookie
l := r.Header().Get("Location")
log.Debug("Requesting AuthCode from OP: ", l)
cookie := r.Header().Get("Set-Cookie")
log.Debug("Cookie: ", cookie)
cookies := r.Header().Values("Set-Cookie")
log.Debug("Cookies: ", cookies)
assert.Contains(t, l, "authorize")
var l2 string
cl := &http.Client{
CheckRedirect: func(req *http.Request, via []*http.Request) error {
if strings.Contains(req.URL.String(), "localhost") {
l2 = req.URL.RequestURI()
return http.ErrUseLastResponse
}
return nil
},
var l2 string
cl := httpclient.Client(true)
cl.CheckRedirect = func(req *http.Request, via []*http.Request) error {
if strings.Contains(req.URL.String(), "localhost") {
l2 = req.URL.RequestURI()
return http.ErrUseLastResponse
}
return nil
}
_, err := cl.Get(l)
if err != nil {
t.Error(err)
@ -45,11 +47,12 @@ func TestAuthEndpoints(t *testing.T) {
// Step 2a: OP redirects user agent back to PhotoPrism
// Step 2b: PhotoPrism redeems AuthCode and fetches tokens from OP
log.Debug("Redeem AuthCode...")
r3 := PerformRequestWithCookie(app, http.MethodGet, l2, cookie)
r3 := PerformRequestWithCookie(app, http.MethodGet, l2, strings.Join(cookies, "; "))
assert.Equal(t, r3.Code, http.StatusOK)
assert.Equal(t, http.StatusOK, r3.Code)
log.Debug("Successful")
})
t.Run("oidc authentication: missing cookie", func(t *testing.T) {
app, router, _ := NewApiTest()
AuthEndpoints(router)