docker_cli_commit_test.go 6.2 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180
  1. package main
  2. import (
  3. "strings"
  4. "testing"
  5. "github.com/docker/docker/api/types/versions"
  6. "github.com/docker/docker/integration-cli/cli"
  7. "gotest.tools/v3/assert"
  8. "gotest.tools/v3/skip"
  9. )
  10. type DockerCLICommitSuite struct {
  11. ds *DockerSuite
  12. }
  13. func (s *DockerCLICommitSuite) TearDownTest(c *testing.T) {
  14. s.ds.TearDownTest(c)
  15. }
  16. func (s *DockerCLICommitSuite) OnTimeout(c *testing.T) {
  17. s.ds.OnTimeout(c)
  18. }
  19. func (s *DockerCLICommitSuite) TestCommitAfterContainerIsDone(c *testing.T) {
  20. skip.If(c, RuntimeIsWindowsContainerd(), "FIXME: Broken on Windows + containerd combination")
  21. out := cli.DockerCmd(c, "run", "-i", "-a", "stdin", "busybox", "echo", "foo").Combined()
  22. cleanedContainerID := strings.TrimSpace(out)
  23. cli.DockerCmd(c, "wait", cleanedContainerID)
  24. out = cli.DockerCmd(c, "commit", cleanedContainerID).Combined()
  25. cleanedImageID := strings.TrimSpace(out)
  26. cli.DockerCmd(c, "inspect", cleanedImageID)
  27. }
  28. func (s *DockerCLICommitSuite) TestCommitWithoutPause(c *testing.T) {
  29. testRequires(c, DaemonIsLinux)
  30. out, _ := dockerCmd(c, "run", "-i", "-a", "stdin", "busybox", "echo", "foo")
  31. cleanedContainerID := strings.TrimSpace(out)
  32. dockerCmd(c, "wait", cleanedContainerID)
  33. out, _ = dockerCmd(c, "commit", "-p=false", cleanedContainerID)
  34. cleanedImageID := strings.TrimSpace(out)
  35. dockerCmd(c, "inspect", cleanedImageID)
  36. }
  37. // TestCommitPausedContainer tests that a paused container is not unpaused after being committed
  38. func (s *DockerCLICommitSuite) TestCommitPausedContainer(c *testing.T) {
  39. testRequires(c, DaemonIsLinux)
  40. out, _ := dockerCmd(c, "run", "-i", "-d", "busybox")
  41. cleanedContainerID := strings.TrimSpace(out)
  42. dockerCmd(c, "pause", cleanedContainerID)
  43. dockerCmd(c, "commit", cleanedContainerID)
  44. out = inspectField(c, cleanedContainerID, "State.Paused")
  45. // commit should not unpause a paused container
  46. assert.Assert(c, strings.Contains(out, "true"))
  47. }
  48. func (s *DockerCLICommitSuite) TestCommitNewFile(c *testing.T) {
  49. dockerCmd(c, "run", "--name", "committer", "busybox", "/bin/sh", "-c", "echo koye > /foo")
  50. imageID, _ := dockerCmd(c, "commit", "committer")
  51. imageID = strings.TrimSpace(imageID)
  52. out, _ := dockerCmd(c, "run", imageID, "cat", "/foo")
  53. actual := strings.TrimSpace(out)
  54. assert.Equal(c, actual, "koye")
  55. }
  56. func (s *DockerCLICommitSuite) TestCommitHardlink(c *testing.T) {
  57. testRequires(c, DaemonIsLinux)
  58. firstOutput, _ := dockerCmd(c, "run", "-t", "--name", "hardlinks", "busybox", "sh", "-c", "touch file1 && ln file1 file2 && ls -di file1 file2")
  59. chunks := strings.Split(strings.TrimSpace(firstOutput), " ")
  60. inode := chunks[0]
  61. chunks = strings.SplitAfterN(strings.TrimSpace(firstOutput), " ", 2)
  62. assert.Assert(c, strings.Contains(chunks[1], chunks[0]), "Failed to create hardlink in a container. Expected to find %q in %q", inode, chunks[1:])
  63. imageID, _ := dockerCmd(c, "commit", "hardlinks", "hardlinks")
  64. imageID = strings.TrimSpace(imageID)
  65. secondOutput, _ := dockerCmd(c, "run", "-t", imageID, "ls", "-di", "file1", "file2")
  66. chunks = strings.Split(strings.TrimSpace(secondOutput), " ")
  67. inode = chunks[0]
  68. chunks = strings.SplitAfterN(strings.TrimSpace(secondOutput), " ", 2)
  69. assert.Assert(c, strings.Contains(chunks[1], chunks[0]), "Failed to create hardlink in a container. Expected to find %q in %q", inode, chunks[1:])
  70. }
  71. func (s *DockerCLICommitSuite) TestCommitTTY(c *testing.T) {
  72. dockerCmd(c, "run", "-t", "--name", "tty", "busybox", "/bin/ls")
  73. imageID, _ := dockerCmd(c, "commit", "tty", "ttytest")
  74. imageID = strings.TrimSpace(imageID)
  75. dockerCmd(c, "run", imageID, "/bin/ls")
  76. }
  77. func (s *DockerCLICommitSuite) TestCommitWithHostBindMount(c *testing.T) {
  78. testRequires(c, DaemonIsLinux)
  79. dockerCmd(c, "run", "--name", "bind-commit", "-v", "/dev/null:/winning", "busybox", "true")
  80. imageID, _ := dockerCmd(c, "commit", "bind-commit", "bindtest")
  81. imageID = strings.TrimSpace(imageID)
  82. dockerCmd(c, "run", imageID, "true")
  83. }
  84. func (s *DockerCLICommitSuite) TestCommitChange(c *testing.T) {
  85. dockerCmd(c, "run", "--name", "test", "busybox", "true")
  86. imageID, _ := dockerCmd(c, "commit",
  87. "--change", "EXPOSE 8080",
  88. "--change", "ENV DEBUG true",
  89. "--change", "ENV test 1",
  90. "--change", "ENV PATH /foo",
  91. "--change", "LABEL foo bar",
  92. "--change", "CMD [\"/bin/sh\"]",
  93. "--change", "WORKDIR /opt",
  94. "--change", "ENTRYPOINT [\"/bin/sh\"]",
  95. "--change", "USER testuser",
  96. "--change", "VOLUME /var/lib/docker",
  97. "--change", "ONBUILD /usr/local/bin/python-build --dir /app/src",
  98. "test", "test-commit")
  99. imageID = strings.TrimSpace(imageID)
  100. expectedEnv := "[DEBUG=true test=1 PATH=/foo]"
  101. // bug fixed in 1.36, add min APi >= 1.36 requirement
  102. // PR record https://github.com/moby/moby/pull/35582
  103. if versions.GreaterThan(testEnv.DaemonAPIVersion(), "1.35") && testEnv.OSType != "windows" {
  104. // The ordering here is due to `PATH` being overridden from the container's
  105. // ENV. On windows, the container doesn't have a `PATH` ENV variable so
  106. // the ordering is the same as the cli.
  107. expectedEnv = "[PATH=/foo DEBUG=true test=1]"
  108. }
  109. prefix, slash := getPrefixAndSlashFromDaemonPlatform()
  110. prefix = strings.ToUpper(prefix) // Force C: as that's how WORKDIR is normalized on Windows
  111. expected := map[string]string{
  112. "Config.ExposedPorts": "map[8080/tcp:{}]",
  113. "Config.Env": expectedEnv,
  114. "Config.Labels": "map[foo:bar]",
  115. "Config.Cmd": "[/bin/sh]",
  116. "Config.WorkingDir": prefix + slash + "opt",
  117. "Config.Entrypoint": "[/bin/sh]",
  118. "Config.User": "testuser",
  119. "Config.Volumes": "map[/var/lib/docker:{}]",
  120. "Config.OnBuild": "[/usr/local/bin/python-build --dir /app/src]",
  121. }
  122. for conf, value := range expected {
  123. res := inspectField(c, imageID, conf)
  124. if res != value {
  125. c.Errorf("%s('%s'), expected %s", conf, res, value)
  126. }
  127. }
  128. }
  129. func (s *DockerCLICommitSuite) TestCommitChangeLabels(c *testing.T) {
  130. dockerCmd(c, "run", "--name", "test", "--label", "some=label", "busybox", "true")
  131. imageID, _ := dockerCmd(c, "commit",
  132. "--change", "LABEL some=label2",
  133. "test", "test-commit")
  134. imageID = strings.TrimSpace(imageID)
  135. assert.Equal(c, inspectField(c, imageID, "Config.Labels"), "map[some:label2]")
  136. // check that container labels didn't change
  137. assert.Equal(c, inspectField(c, "test", "Config.Labels"), "map[some:label]")
  138. }