123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238 |
- package main
- import (
- "archive/tar"
- "bytes"
- "context"
- "encoding/json"
- "fmt"
- "io"
- "net/http"
- "os"
- "path/filepath"
- "regexp"
- "runtime"
- "strings"
- "testing"
- "time"
- "github.com/docker/docker/api/types"
- "github.com/docker/docker/api/types/container"
- "github.com/docker/docker/api/types/mount"
- "github.com/docker/docker/api/types/network"
- "github.com/docker/docker/api/types/versions"
- "github.com/docker/docker/client"
- dconfig "github.com/docker/docker/daemon/config"
- "github.com/docker/docker/errdefs"
- "github.com/docker/docker/integration-cli/cli"
- "github.com/docker/docker/integration-cli/cli/build"
- "github.com/docker/docker/pkg/ioutils"
- "github.com/docker/docker/pkg/stringid"
- "github.com/docker/docker/testutil/request"
- "github.com/docker/docker/volume"
- "github.com/docker/go-connections/nat"
- "gotest.tools/v3/assert"
- is "gotest.tools/v3/assert/cmp"
- "gotest.tools/v3/poll"
- )
- func (s *DockerAPISuite) TestContainerAPIGetAll(c *testing.T) {
- startCount := getContainerCount(c)
- name := "getall"
- dockerCmd(c, "run", "--name", name, "busybox", "true")
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- options := types.ContainerListOptions{
- All: true,
- }
- containers, err := cli.ContainerList(context.Background(), options)
- assert.NilError(c, err)
- assert.Equal(c, len(containers), startCount+1)
- actual := containers[0].Names[0]
- assert.Equal(c, actual, "/"+name)
- }
- // regression test for empty json field being omitted #13691
- func (s *DockerAPISuite) TestContainerAPIGetJSONNoFieldsOmitted(c *testing.T) {
- startCount := getContainerCount(c)
- dockerCmd(c, "run", "busybox", "true")
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- options := types.ContainerListOptions{
- All: true,
- }
- containers, err := cli.ContainerList(context.Background(), options)
- assert.NilError(c, err)
- assert.Equal(c, len(containers), startCount+1)
- actual := fmt.Sprintf("%+v", containers[0])
- // empty Labels field triggered this bug, make sense to check for everything
- // cause even Ports for instance can trigger this bug
- // better safe than sorry..
- fields := []string{
- "ID",
- "Names",
- "Image",
- "Command",
- "Created",
- "Ports",
- "Labels",
- "Status",
- "NetworkSettings",
- }
- // decoding into types.Container do not work since it eventually unmarshal
- // and empty field to an empty go map, so we just check for a string
- for _, f := range fields {
- if !strings.Contains(actual, f) {
- c.Fatalf("Field %s is missing and it shouldn't", f)
- }
- }
- }
- func (s *DockerAPISuite) TestContainerAPIGetExport(c *testing.T) {
- // Not supported on Windows as Windows does not support docker export
- testRequires(c, DaemonIsLinux)
- name := "exportcontainer"
- dockerCmd(c, "run", "--name", name, "busybox", "touch", "/test")
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- body, err := cli.ContainerExport(context.Background(), name)
- assert.NilError(c, err)
- defer body.Close()
- found := false
- for tarReader := tar.NewReader(body); ; {
- h, err := tarReader.Next()
- if err != nil && err == io.EOF {
- break
- }
- if h.Name == "test" {
- found = true
- break
- }
- }
- assert.Assert(c, found, "The created test file has not been found in the exported image")
- }
- func (s *DockerAPISuite) TestContainerAPIGetChanges(c *testing.T) {
- // Not supported on Windows as Windows does not support docker diff (/containers/name/changes)
- testRequires(c, DaemonIsLinux)
- name := "changescontainer"
- dockerCmd(c, "run", "--name", name, "busybox", "rm", "/etc/passwd")
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- changes, err := cli.ContainerDiff(context.Background(), name)
- assert.NilError(c, err)
- // Check the changelog for removal of /etc/passwd
- success := false
- for _, elem := range changes {
- if elem.Path == "/etc/passwd" && elem.Kind == 2 {
- success = true
- }
- }
- assert.Assert(c, success, "/etc/passwd has been removed but is not present in the diff")
- }
- func (s *DockerAPISuite) TestGetContainerStats(c *testing.T) {
- var (
- name = "statscontainer"
- )
- runSleepingContainer(c, "--name", name)
- type b struct {
- stats types.ContainerStats
- err error
- }
- bc := make(chan b, 1)
- go func() {
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- stats, err := cli.ContainerStats(context.Background(), name, true)
- assert.NilError(c, err)
- bc <- b{stats, err}
- }()
- // allow some time to stream the stats from the container
- time.Sleep(4 * time.Second)
- dockerCmd(c, "rm", "-f", name)
- // collect the results from the stats stream or timeout and fail
- // if the stream was not disconnected.
- select {
- case <-time.After(2 * time.Second):
- c.Fatal("stream was not closed after container was removed")
- case sr := <-bc:
- dec := json.NewDecoder(sr.stats.Body)
- defer sr.stats.Body.Close()
- var s *types.Stats
- // decode only one object from the stream
- assert.NilError(c, dec.Decode(&s))
- }
- }
- func (s *DockerAPISuite) TestGetContainerStatsRmRunning(c *testing.T) {
- out := runSleepingContainer(c)
- id := strings.TrimSpace(out)
- buf := &ChannelBuffer{C: make(chan []byte, 1)}
- defer buf.Close()
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- stats, err := cli.ContainerStats(context.Background(), id, true)
- assert.NilError(c, err)
- defer stats.Body.Close()
- chErr := make(chan error, 1)
- go func() {
- _, err = io.Copy(buf, stats.Body)
- chErr <- err
- }()
- b := make([]byte, 32)
- // make sure we've got some stats
- _, err = buf.ReadTimeout(b, 2*time.Second)
- assert.NilError(c, err)
- // Now remove without `-f` and make sure we are still pulling stats
- _, _, err = dockerCmdWithError("rm", id)
- assert.Assert(c, err != nil, "rm should have failed but didn't")
- _, err = buf.ReadTimeout(b, 2*time.Second)
- assert.NilError(c, err)
- dockerCmd(c, "rm", "-f", id)
- assert.Assert(c, <-chErr == nil)
- }
- // ChannelBuffer holds a chan of byte array that can be populate in a goroutine.
- type ChannelBuffer struct {
- C chan []byte
- }
- // Write implements Writer.
- func (c *ChannelBuffer) Write(b []byte) (int, error) {
- c.C <- b
- return len(b), nil
- }
- // Close closes the go channel.
- func (c *ChannelBuffer) Close() error {
- close(c.C)
- return nil
- }
- // ReadTimeout reads the content of the channel in the specified byte array with
- // the specified duration as timeout.
- func (c *ChannelBuffer) ReadTimeout(p []byte, n time.Duration) (int, error) {
- select {
- case b := <-c.C:
- return copy(p[0:], b), nil
- case <-time.After(n):
- return -1, fmt.Errorf("timeout reading from channel")
- }
- }
- // regression test for gh13421
- // previous test was just checking one stat entry so it didn't fail (stats with
- // stream false always return one stat)
- func (s *DockerAPISuite) TestGetContainerStatsStream(c *testing.T) {
- name := "statscontainer"
- runSleepingContainer(c, "--name", name)
- type b struct {
- stats types.ContainerStats
- err error
- }
- bc := make(chan b, 1)
- go func() {
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- stats, err := cli.ContainerStats(context.Background(), name, true)
- assert.NilError(c, err)
- bc <- b{stats, err}
- }()
- // allow some time to stream the stats from the container
- time.Sleep(4 * time.Second)
- dockerCmd(c, "rm", "-f", name)
- // collect the results from the stats stream or timeout and fail
- // if the stream was not disconnected.
- select {
- case <-time.After(2 * time.Second):
- c.Fatal("stream was not closed after container was removed")
- case sr := <-bc:
- b, err := io.ReadAll(sr.stats.Body)
- defer sr.stats.Body.Close()
- assert.NilError(c, err)
- s := string(b)
- // count occurrences of "read" of types.Stats
- if l := strings.Count(s, "read"); l < 2 {
- c.Fatalf("Expected more than one stat streamed, got %d", l)
- }
- }
- }
- func (s *DockerAPISuite) TestGetContainerStatsNoStream(c *testing.T) {
- name := "statscontainer"
- runSleepingContainer(c, "--name", name)
- type b struct {
- stats types.ContainerStats
- err error
- }
- bc := make(chan b, 1)
- go func() {
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- stats, err := cli.ContainerStats(context.Background(), name, false)
- assert.NilError(c, err)
- bc <- b{stats, err}
- }()
- // allow some time to stream the stats from the container
- time.Sleep(4 * time.Second)
- dockerCmd(c, "rm", "-f", name)
- // collect the results from the stats stream or timeout and fail
- // if the stream was not disconnected.
- select {
- case <-time.After(2 * time.Second):
- c.Fatal("stream was not closed after container was removed")
- case sr := <-bc:
- b, err := io.ReadAll(sr.stats.Body)
- defer sr.stats.Body.Close()
- assert.NilError(c, err)
- s := string(b)
- // count occurrences of `"read"` of types.Stats
- assert.Assert(c, strings.Count(s, `"read"`) == 1, "Expected only one stat streamed, got %d", strings.Count(s, `"read"`))
- }
- }
- func (s *DockerAPISuite) TestGetStoppedContainerStats(c *testing.T) {
- name := "statscontainer"
- dockerCmd(c, "create", "--name", name, "busybox", "ps")
- chResp := make(chan error, 1)
- // We expect an immediate response, but if it's not immediate, the test would hang, so put it in a goroutine
- // below we'll check this on a timeout.
- go func() {
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- resp, err := cli.ContainerStats(context.Background(), name, false)
- assert.NilError(c, err)
- defer resp.Body.Close()
- chResp <- err
- }()
- select {
- case err := <-chResp:
- assert.NilError(c, err)
- case <-time.After(10 * time.Second):
- c.Fatal("timeout waiting for stats response for stopped container")
- }
- }
- func (s *DockerAPISuite) TestContainerAPIPause(c *testing.T) {
- // Problematic on Windows as Windows does not support pause
- testRequires(c, DaemonIsLinux)
- getPaused := func(c *testing.T) []string {
- return strings.Fields(cli.DockerCmd(c, "ps", "-f", "status=paused", "-q", "-a").Combined())
- }
- out := cli.DockerCmd(c, "run", "-d", "busybox", "sleep", "30").Combined()
- ContainerID := strings.TrimSpace(out)
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerPause(context.Background(), ContainerID)
- assert.NilError(c, err)
- pausedContainers := getPaused(c)
- if len(pausedContainers) != 1 || stringid.TruncateID(ContainerID) != pausedContainers[0] {
- c.Fatalf("there should be one paused container and not %d", len(pausedContainers))
- }
- err = cli.ContainerUnpause(context.Background(), ContainerID)
- assert.NilError(c, err)
- pausedContainers = getPaused(c)
- assert.Equal(c, len(pausedContainers), 0, "There should be no paused container.")
- }
- func (s *DockerAPISuite) TestContainerAPITop(c *testing.T) {
- testRequires(c, DaemonIsLinux)
- out, _ := dockerCmd(c, "run", "-d", "busybox", "/bin/sh", "-c", "top && true")
- id := strings.TrimSpace(out)
- assert.NilError(c, waitRun(id))
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- // sort by comm[andline] to make sure order stays the same in case of PID rollover
- top, err := cli.ContainerTop(context.Background(), id, []string{"aux", "--sort=comm"})
- assert.NilError(c, err)
- assert.Equal(c, len(top.Titles), 11, fmt.Sprintf("expected 11 titles, found %d: %v", len(top.Titles), top.Titles))
- if top.Titles[0] != "USER" || top.Titles[10] != "COMMAND" {
- c.Fatalf("expected `USER` at `Titles[0]` and `COMMAND` at Titles[10]: %v", top.Titles)
- }
- assert.Equal(c, len(top.Processes), 2, fmt.Sprintf("expected 2 processes, found %d: %v", len(top.Processes), top.Processes))
- assert.Equal(c, top.Processes[0][10], "/bin/sh -c top && true")
- assert.Equal(c, top.Processes[1][10], "top")
- }
- func (s *DockerAPISuite) TestContainerAPITopWindows(c *testing.T) {
- testRequires(c, DaemonIsWindows)
- out := runSleepingContainer(c, "-d")
- id := strings.TrimSpace(out)
- assert.NilError(c, waitRun(id))
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- top, err := cli.ContainerTop(context.Background(), id, nil)
- assert.NilError(c, err)
- assert.Equal(c, len(top.Titles), 4, "expected 4 titles, found %d: %v", len(top.Titles), top.Titles)
- if top.Titles[0] != "Name" || top.Titles[3] != "Private Working Set" {
- c.Fatalf("expected `Name` at `Titles[0]` and `Private Working Set` at Titles[3]: %v", top.Titles)
- }
- assert.Assert(c, len(top.Processes) >= 2, "expected at least 2 processes, found %d: %v", len(top.Processes), top.Processes)
- foundProcess := false
- expectedProcess := "busybox.exe"
- for _, process := range top.Processes {
- if process[0] == expectedProcess {
- foundProcess = true
- break
- }
- }
- assert.Assert(c, foundProcess, "expected to find %s: %v", expectedProcess, top.Processes)
- }
- func (s *DockerAPISuite) TestContainerAPICommit(c *testing.T) {
- cName := "testapicommit"
- dockerCmd(c, "run", "--name="+cName, "busybox", "/bin/sh", "-c", "touch /test")
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- options := types.ContainerCommitOptions{
- Reference: "testcontainerapicommit:testtag",
- }
- img, err := cli.ContainerCommit(context.Background(), cName, options)
- assert.NilError(c, err)
- cmd := inspectField(c, img.ID, "Config.Cmd")
- assert.Equal(c, cmd, "[/bin/sh -c touch /test]", fmt.Sprintf("got wrong Cmd from commit: %q", cmd))
- // sanity check, make sure the image is what we think it is
- dockerCmd(c, "run", img.ID, "ls", "/test")
- }
- func (s *DockerAPISuite) TestContainerAPICommitWithLabelInConfig(c *testing.T) {
- cName := "testapicommitwithconfig"
- dockerCmd(c, "run", "--name="+cName, "busybox", "/bin/sh", "-c", "touch /test")
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- config := container.Config{
- Labels: map[string]string{"key1": "value1", "key2": "value2"}}
- options := types.ContainerCommitOptions{
- Reference: "testcontainerapicommitwithconfig",
- Config: &config,
- }
- img, err := cli.ContainerCommit(context.Background(), cName, options)
- assert.NilError(c, err)
- label1 := inspectFieldMap(c, img.ID, "Config.Labels", "key1")
- assert.Equal(c, label1, "value1")
- label2 := inspectFieldMap(c, img.ID, "Config.Labels", "key2")
- assert.Equal(c, label2, "value2")
- cmd := inspectField(c, img.ID, "Config.Cmd")
- assert.Equal(c, cmd, "[/bin/sh -c touch /test]", fmt.Sprintf("got wrong Cmd from commit: %q", cmd))
- // sanity check, make sure the image is what we think it is
- dockerCmd(c, "run", img.ID, "ls", "/test")
- }
- func (s *DockerAPISuite) TestContainerAPIBadPort(c *testing.T) {
- // TODO Windows to Windows CI - Port this test
- testRequires(c, DaemonIsLinux)
- config := container.Config{
- Image: "busybox",
- Cmd: []string{"/bin/sh", "-c", "echo test"},
- }
- hostConfig := container.HostConfig{
- PortBindings: nat.PortMap{
- "8080/tcp": []nat.PortBinding{
- {
- HostIP: "",
- HostPort: "aa80"},
- },
- },
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- _, err = cli.ContainerCreate(context.Background(), &config, &hostConfig, &network.NetworkingConfig{}, nil, "")
- assert.ErrorContains(c, err, `invalid port specification: "aa80"`)
- }
- func (s *DockerAPISuite) TestContainerAPICreate(c *testing.T) {
- config := container.Config{
- Image: "busybox",
- Cmd: []string{"/bin/sh", "-c", "touch /test && ls /test"},
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- container, err := cli.ContainerCreate(context.Background(), &config, &container.HostConfig{}, &network.NetworkingConfig{}, nil, "")
- assert.NilError(c, err)
- out, _ := dockerCmd(c, "start", "-a", container.ID)
- assert.Equal(c, strings.TrimSpace(out), "/test")
- }
- func (s *DockerAPISuite) TestContainerAPICreateEmptyConfig(c *testing.T) {
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- _, err = cli.ContainerCreate(context.Background(), &container.Config{}, &container.HostConfig{}, &network.NetworkingConfig{}, nil, "")
- expected := "No command specified"
- assert.ErrorContains(c, err, expected)
- }
- func (s *DockerAPISuite) TestContainerAPICreateMultipleNetworksConfig(c *testing.T) {
- // Container creation must fail if client specified configurations for more than one network
- config := container.Config{
- Image: "busybox",
- }
- networkingConfig := network.NetworkingConfig{
- EndpointsConfig: map[string]*network.EndpointSettings{
- "net1": {},
- "net2": {},
- "net3": {},
- },
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- _, err = cli.ContainerCreate(context.Background(), &config, &container.HostConfig{}, &networkingConfig, nil, "")
- msg := err.Error()
- // network name order in error message is not deterministic
- assert.Assert(c, strings.Contains(msg, "Container cannot be connected to network endpoints"))
- assert.Assert(c, strings.Contains(msg, "net1"))
- assert.Assert(c, strings.Contains(msg, "net2"))
- assert.Assert(c, strings.Contains(msg, "net3"))
- }
- func (s *DockerAPISuite) TestContainerAPICreateBridgeNetworkMode(c *testing.T) {
- // Windows does not support bridge
- testRequires(c, DaemonIsLinux)
- UtilCreateNetworkMode(c, "bridge")
- }
- func (s *DockerAPISuite) TestContainerAPICreateOtherNetworkModes(c *testing.T) {
- // Windows does not support these network modes
- testRequires(c, DaemonIsLinux, NotUserNamespace)
- UtilCreateNetworkMode(c, "host")
- UtilCreateNetworkMode(c, "container:web1")
- }
- func UtilCreateNetworkMode(c *testing.T, networkMode container.NetworkMode) {
- config := container.Config{
- Image: "busybox",
- }
- hostConfig := container.HostConfig{
- NetworkMode: networkMode,
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- container, err := cli.ContainerCreate(context.Background(), &config, &hostConfig, &network.NetworkingConfig{}, nil, "")
- assert.NilError(c, err)
- containerJSON, err := cli.ContainerInspect(context.Background(), container.ID)
- assert.NilError(c, err)
- assert.Equal(c, containerJSON.HostConfig.NetworkMode, networkMode, "Mismatched NetworkMode")
- }
- func (s *DockerAPISuite) TestContainerAPICreateWithCpuSharesCpuset(c *testing.T) {
- // TODO Windows to Windows CI. The CpuShares part could be ported.
- testRequires(c, DaemonIsLinux)
- config := container.Config{
- Image: "busybox",
- }
- hostConfig := container.HostConfig{
- Resources: container.Resources{
- CPUShares: 512,
- CpusetCpus: "0",
- },
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- container, err := cli.ContainerCreate(context.Background(), &config, &hostConfig, &network.NetworkingConfig{}, nil, "")
- assert.NilError(c, err)
- containerJSON, err := cli.ContainerInspect(context.Background(), container.ID)
- assert.NilError(c, err)
- out := inspectField(c, containerJSON.ID, "HostConfig.CpuShares")
- assert.Equal(c, out, "512")
- outCpuset := inspectField(c, containerJSON.ID, "HostConfig.CpusetCpus")
- assert.Equal(c, outCpuset, "0")
- }
- func (s *DockerAPISuite) TestContainerAPIVerifyHeader(c *testing.T) {
- config := map[string]interface{}{
- "Image": "busybox",
- }
- create := func(ct string) (*http.Response, io.ReadCloser, error) {
- jsonData := bytes.NewBuffer(nil)
- assert.Assert(c, json.NewEncoder(jsonData).Encode(config) == nil)
- return request.Post("/containers/create", request.RawContent(io.NopCloser(jsonData)), request.ContentType(ct))
- }
- // Try with no content-type
- res, body, err := create("")
- assert.NilError(c, err)
- // todo: we need to figure out a better way to compare between dockerd versions
- // comparing between daemon API version is not precise.
- if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
- assert.Equal(c, res.StatusCode, http.StatusBadRequest)
- } else {
- assert.Assert(c, res.StatusCode != http.StatusOK)
- }
- body.Close()
- // Try with wrong content-type
- res, body, err = create("application/xml")
- assert.NilError(c, err)
- if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
- assert.Equal(c, res.StatusCode, http.StatusBadRequest)
- } else {
- assert.Assert(c, res.StatusCode != http.StatusOK)
- }
- body.Close()
- // now application/json
- res, body, err = create("application/json")
- assert.NilError(c, err)
- assert.Equal(c, res.StatusCode, http.StatusCreated)
- body.Close()
- }
- // Issue 14230. daemon should return 500 for invalid port syntax
- func (s *DockerAPISuite) TestContainerAPIInvalidPortSyntax(c *testing.T) {
- config := `{
- "Image": "busybox",
- "HostConfig": {
- "NetworkMode": "default",
- "PortBindings": {
- "19039;1230": [
- {}
- ]
- }
- }
- }`
- res, body, err := request.Post("/containers/create", request.RawString(config), request.JSON)
- assert.NilError(c, err)
- if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
- assert.Equal(c, res.StatusCode, http.StatusBadRequest)
- } else {
- assert.Assert(c, res.StatusCode != http.StatusOK)
- }
- b, err := request.ReadBody(body)
- assert.NilError(c, err)
- assert.Assert(c, strings.Contains(string(b[:]), "invalid port"))
- }
- func (s *DockerAPISuite) TestContainerAPIRestartPolicyInvalidPolicyName(c *testing.T) {
- config := `{
- "Image": "busybox",
- "HostConfig": {
- "RestartPolicy": {
- "Name": "something",
- "MaximumRetryCount": 0
- }
- }
- }`
- res, body, err := request.Post("/containers/create", request.RawString(config), request.JSON)
- assert.NilError(c, err)
- if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
- assert.Equal(c, res.StatusCode, http.StatusBadRequest)
- } else {
- assert.Assert(c, res.StatusCode != http.StatusOK)
- }
- b, err := request.ReadBody(body)
- assert.NilError(c, err)
- assert.Assert(c, strings.Contains(string(b[:]), "invalid restart policy"))
- }
- func (s *DockerAPISuite) TestContainerAPIRestartPolicyRetryMismatch(c *testing.T) {
- config := `{
- "Image": "busybox",
- "HostConfig": {
- "RestartPolicy": {
- "Name": "always",
- "MaximumRetryCount": 2
- }
- }
- }`
- res, body, err := request.Post("/containers/create", request.RawString(config), request.JSON)
- assert.NilError(c, err)
- if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
- assert.Equal(c, res.StatusCode, http.StatusBadRequest)
- } else {
- assert.Assert(c, res.StatusCode != http.StatusOK)
- }
- b, err := request.ReadBody(body)
- assert.NilError(c, err)
- assert.Assert(c, strings.Contains(string(b[:]), "maximum retry count cannot be used with restart policy"))
- }
- func (s *DockerAPISuite) TestContainerAPIRestartPolicyNegativeRetryCount(c *testing.T) {
- config := `{
- "Image": "busybox",
- "HostConfig": {
- "RestartPolicy": {
- "Name": "on-failure",
- "MaximumRetryCount": -2
- }
- }
- }`
- res, body, err := request.Post("/containers/create", request.RawString(config), request.JSON)
- assert.NilError(c, err)
- if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
- assert.Equal(c, res.StatusCode, http.StatusBadRequest)
- } else {
- assert.Assert(c, res.StatusCode != http.StatusOK)
- }
- b, err := request.ReadBody(body)
- assert.NilError(c, err)
- assert.Assert(c, strings.Contains(string(b[:]), "maximum retry count cannot be negative"))
- }
- func (s *DockerAPISuite) TestContainerAPIRestartPolicyDefaultRetryCount(c *testing.T) {
- config := `{
- "Image": "busybox",
- "HostConfig": {
- "RestartPolicy": {
- "Name": "on-failure",
- "MaximumRetryCount": 0
- }
- }
- }`
- res, _, err := request.Post("/containers/create", request.RawString(config), request.JSON)
- assert.NilError(c, err)
- assert.Equal(c, res.StatusCode, http.StatusCreated)
- }
- // Issue 7941 - test to make sure a "null" in JSON is just ignored.
- // W/o this fix a null in JSON would be parsed into a string var as "null"
- func (s *DockerAPISuite) TestContainerAPIPostCreateNull(c *testing.T) {
- config := `{
- "Hostname":"",
- "Domainname":"",
- "Memory":0,
- "MemorySwap":0,
- "CpuShares":0,
- "Cpuset":null,
- "AttachStdin":true,
- "AttachStdout":true,
- "AttachStderr":true,
- "ExposedPorts":{},
- "Tty":true,
- "OpenStdin":true,
- "StdinOnce":true,
- "Env":[],
- "Cmd":"ls",
- "Image":"busybox",
- "Volumes":{},
- "WorkingDir":"",
- "Entrypoint":null,
- "NetworkDisabled":false,
- "OnBuild":null}`
- res, body, err := request.Post("/containers/create", request.RawString(config), request.JSON)
- assert.NilError(c, err)
- assert.Equal(c, res.StatusCode, http.StatusCreated)
- b, err := request.ReadBody(body)
- assert.NilError(c, err)
- type createResp struct {
- ID string
- }
- var container createResp
- assert.Assert(c, json.Unmarshal(b, &container) == nil)
- out := inspectField(c, container.ID, "HostConfig.CpusetCpus")
- assert.Equal(c, out, "")
- outMemory := inspectField(c, container.ID, "HostConfig.Memory")
- assert.Equal(c, outMemory, "0")
- outMemorySwap := inspectField(c, container.ID, "HostConfig.MemorySwap")
- assert.Equal(c, outMemorySwap, "0")
- }
- func (s *DockerAPISuite) TestCreateWithTooLowMemoryLimit(c *testing.T) {
- // TODO Windows: Port once memory is supported
- testRequires(c, DaemonIsLinux)
- config := `{
- "Image": "busybox",
- "Cmd": "ls",
- "OpenStdin": true,
- "CpuShares": 100,
- "Memory": 524287
- }`
- res, body, err := request.Post("/containers/create", request.RawString(config), request.JSON)
- assert.NilError(c, err)
- b, err2 := request.ReadBody(body)
- assert.Assert(c, err2 == nil)
- if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
- assert.Equal(c, res.StatusCode, http.StatusBadRequest)
- } else {
- assert.Assert(c, res.StatusCode != http.StatusOK)
- }
- assert.Assert(c, strings.Contains(string(b), "Minimum memory limit allowed is 6MB"))
- }
- func (s *DockerAPISuite) TestContainerAPIRename(c *testing.T) {
- out, _ := dockerCmd(c, "run", "--name", "TestContainerAPIRename", "-d", "busybox", "sh")
- containerID := strings.TrimSpace(out)
- newName := "TestContainerAPIRenameNew"
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerRename(context.Background(), containerID, newName)
- assert.NilError(c, err)
- name := inspectField(c, containerID, "Name")
- assert.Equal(c, name, "/"+newName, "Failed to rename container")
- }
- func (s *DockerAPISuite) TestContainerAPIKill(c *testing.T) {
- name := "test-api-kill"
- runSleepingContainer(c, "-i", "--name", name)
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerKill(context.Background(), name, "SIGKILL")
- assert.NilError(c, err)
- state := inspectField(c, name, "State.Running")
- assert.Equal(c, state, "false", fmt.Sprintf("got wrong State from container %s: %q", name, state))
- }
- func (s *DockerAPISuite) TestContainerAPIRestart(c *testing.T) {
- name := "test-api-restart"
- runSleepingContainer(c, "-di", "--name", name)
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- timeout := 1
- err = cli.ContainerRestart(context.Background(), name, container.StopOptions{Timeout: &timeout})
- assert.NilError(c, err)
- assert.Assert(c, waitInspect(name, "{{ .State.Restarting }} {{ .State.Running }}", "false true", 15*time.Second) == nil)
- }
- func (s *DockerAPISuite) TestContainerAPIRestartNotimeoutParam(c *testing.T) {
- name := "test-api-restart-no-timeout-param"
- out := runSleepingContainer(c, "-di", "--name", name)
- id := strings.TrimSpace(out)
- assert.NilError(c, waitRun(id))
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerRestart(context.Background(), name, container.StopOptions{})
- assert.NilError(c, err)
- assert.Assert(c, waitInspect(name, "{{ .State.Restarting }} {{ .State.Running }}", "false true", 15*time.Second) == nil)
- }
- func (s *DockerAPISuite) TestContainerAPIStart(c *testing.T) {
- name := "testing-start"
- config := container.Config{
- Image: "busybox",
- Cmd: append([]string{"/bin/sh", "-c"}, sleepCommandForDaemonPlatform()...),
- OpenStdin: true,
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- _, err = cli.ContainerCreate(context.Background(), &config, &container.HostConfig{}, &network.NetworkingConfig{}, nil, name)
- assert.NilError(c, err)
- err = cli.ContainerStart(context.Background(), name, types.ContainerStartOptions{})
- assert.NilError(c, err)
- // second call to start should give 304
- // maybe add ContainerStartWithRaw to test it
- err = cli.ContainerStart(context.Background(), name, types.ContainerStartOptions{})
- assert.NilError(c, err)
- // TODO(tibor): figure out why this doesn't work on windows
- }
- func (s *DockerAPISuite) TestContainerAPIStop(c *testing.T) {
- name := "test-api-stop"
- runSleepingContainer(c, "-i", "--name", name)
- timeout := 30
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerStop(context.Background(), name, container.StopOptions{
- Timeout: &timeout,
- })
- assert.NilError(c, err)
- assert.Assert(c, waitInspect(name, "{{ .State.Running }}", "false", 60*time.Second) == nil)
- // second call to start should give 304
- // maybe add ContainerStartWithRaw to test it
- err = cli.ContainerStop(context.Background(), name, container.StopOptions{
- Timeout: &timeout,
- })
- assert.NilError(c, err)
- }
- func (s *DockerAPISuite) TestContainerAPIWait(c *testing.T) {
- name := "test-api-wait"
- sleepCmd := "/bin/sleep"
- if testEnv.OSType == "windows" {
- sleepCmd = "sleep"
- }
- dockerCmd(c, "run", "--name", name, "busybox", sleepCmd, "2")
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- waitResC, errC := cli.ContainerWait(context.Background(), name, "")
- select {
- case err = <-errC:
- assert.NilError(c, err)
- case waitRes := <-waitResC:
- assert.Equal(c, waitRes.StatusCode, int64(0))
- }
- }
- func (s *DockerAPISuite) TestContainerAPICopyNotExistsAnyMore(c *testing.T) {
- name := "test-container-api-copy"
- dockerCmd(c, "run", "--name", name, "busybox", "touch", "/test.txt")
- postData := types.CopyConfig{
- Resource: "/test.txt",
- }
- // no copy in client/
- res, _, err := request.Post("/containers/"+name+"/copy", request.JSONBody(postData))
- assert.NilError(c, err)
- assert.Equal(c, res.StatusCode, http.StatusNotFound)
- }
- func (s *DockerAPISuite) TestContainerAPICopyPre124(c *testing.T) {
- testRequires(c, DaemonIsLinux) // Windows only supports 1.25 or later
- name := "test-container-api-copy"
- dockerCmd(c, "run", "--name", name, "busybox", "touch", "/test.txt")
- postData := types.CopyConfig{
- Resource: "/test.txt",
- }
- res, body, err := request.Post("/v1.23/containers/"+name+"/copy", request.JSONBody(postData))
- assert.NilError(c, err)
- assert.Equal(c, res.StatusCode, http.StatusOK)
- found := false
- for tarReader := tar.NewReader(body); ; {
- h, err := tarReader.Next()
- if err != nil {
- if err == io.EOF {
- break
- }
- c.Fatal(err)
- }
- if h.Name == "test.txt" {
- found = true
- break
- }
- }
- assert.Assert(c, found)
- }
- func (s *DockerAPISuite) TestContainerAPICopyResourcePathEmptyPre124(c *testing.T) {
- testRequires(c, DaemonIsLinux) // Windows only supports 1.25 or later
- name := "test-container-api-copy-resource-empty"
- dockerCmd(c, "run", "--name", name, "busybox", "touch", "/test.txt")
- postData := types.CopyConfig{
- Resource: "",
- }
- res, body, err := request.Post("/v1.23/containers/"+name+"/copy", request.JSONBody(postData))
- assert.NilError(c, err)
- if versions.GreaterThanOrEqualTo(testEnv.DaemonAPIVersion(), "1.32") {
- assert.Equal(c, res.StatusCode, http.StatusBadRequest)
- } else {
- assert.Assert(c, res.StatusCode != http.StatusOK)
- }
- b, err := request.ReadBody(body)
- assert.NilError(c, err)
- assert.Assert(c, is.Regexp("^Path cannot be empty\n$", string(b)))
- }
- func (s *DockerAPISuite) TestContainerAPICopyResourcePathNotFoundPre124(c *testing.T) {
- testRequires(c, DaemonIsLinux) // Windows only supports 1.25 or later
- name := "test-container-api-copy-resource-not-found"
- dockerCmd(c, "run", "--name", name, "busybox")
- postData := types.CopyConfig{
- Resource: "/notexist",
- }
- res, body, err := request.Post("/v1.23/containers/"+name+"/copy", request.JSONBody(postData))
- assert.NilError(c, err)
- if versions.LessThan(testEnv.DaemonAPIVersion(), "1.32") {
- assert.Equal(c, res.StatusCode, http.StatusInternalServerError)
- } else {
- assert.Equal(c, res.StatusCode, http.StatusNotFound)
- }
- b, err := request.ReadBody(body)
- assert.NilError(c, err)
- assert.Assert(c, is.Regexp("^Could not find the file /notexist in container "+name+"\n$", string(b)))
- }
- func (s *DockerAPISuite) TestContainerAPICopyContainerNotFoundPr124(c *testing.T) {
- testRequires(c, DaemonIsLinux) // Windows only supports 1.25 or later
- postData := types.CopyConfig{
- Resource: "/something",
- }
- res, _, err := request.Post("/v1.23/containers/notexists/copy", request.JSONBody(postData))
- assert.NilError(c, err)
- assert.Equal(c, res.StatusCode, http.StatusNotFound)
- }
- func (s *DockerAPISuite) TestContainerAPIDelete(c *testing.T) {
- out := runSleepingContainer(c)
- id := strings.TrimSpace(out)
- assert.NilError(c, waitRun(id))
- dockerCmd(c, "stop", id)
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerRemove(context.Background(), id, types.ContainerRemoveOptions{})
- assert.NilError(c, err)
- }
- func (s *DockerAPISuite) TestContainerAPIDeleteNotExist(c *testing.T) {
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerRemove(context.Background(), "doesnotexist", types.ContainerRemoveOptions{})
- assert.ErrorContains(c, err, "No such container: doesnotexist")
- }
- func (s *DockerAPISuite) TestContainerAPIDeleteForce(c *testing.T) {
- out := runSleepingContainer(c)
- id := strings.TrimSpace(out)
- assert.NilError(c, waitRun(id))
- removeOptions := types.ContainerRemoveOptions{
- Force: true,
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerRemove(context.Background(), id, removeOptions)
- assert.NilError(c, err)
- }
- func (s *DockerAPISuite) TestContainerAPIDeleteRemoveLinks(c *testing.T) {
- // Windows does not support links
- testRequires(c, DaemonIsLinux)
- out, _ := dockerCmd(c, "run", "-d", "--name", "tlink1", "busybox", "top")
- id := strings.TrimSpace(out)
- assert.NilError(c, waitRun(id))
- out, _ = dockerCmd(c, "run", "--link", "tlink1:tlink1", "--name", "tlink2", "-d", "busybox", "top")
- id2 := strings.TrimSpace(out)
- assert.Assert(c, waitRun(id2) == nil)
- links := inspectFieldJSON(c, id2, "HostConfig.Links")
- assert.Equal(c, links, "[\"/tlink1:/tlink2/tlink1\"]", "expected to have links between containers")
- removeOptions := types.ContainerRemoveOptions{
- RemoveLinks: true,
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerRemove(context.Background(), "tlink2/tlink1", removeOptions)
- assert.NilError(c, err)
- linksPostRm := inspectFieldJSON(c, id2, "HostConfig.Links")
- assert.Equal(c, linksPostRm, "null", "call to api deleteContainer links should have removed the specified links")
- }
- func (s *DockerAPISuite) TestContainerAPIDeleteConflict(c *testing.T) {
- out := runSleepingContainer(c)
- id := strings.TrimSpace(out)
- assert.NilError(c, waitRun(id))
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerRemove(context.Background(), id, types.ContainerRemoveOptions{})
- expected := "cannot remove a running container"
- assert.ErrorContains(c, err, expected)
- }
- func (s *DockerAPISuite) TestContainerAPIDeleteRemoveVolume(c *testing.T) {
- testRequires(c, testEnv.IsLocalDaemon)
- vol := "/testvolume"
- if testEnv.OSType == "windows" {
- vol = `c:\testvolume`
- }
- out := runSleepingContainer(c, "-v", vol)
- id := strings.TrimSpace(out)
- assert.NilError(c, waitRun(id))
- source, err := inspectMountSourceField(id, vol)
- assert.NilError(c, err)
- _, err = os.Stat(source)
- assert.NilError(c, err)
- removeOptions := types.ContainerRemoveOptions{
- Force: true,
- RemoveVolumes: true,
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerRemove(context.Background(), id, removeOptions)
- assert.NilError(c, err)
- _, err = os.Stat(source)
- assert.Assert(c, os.IsNotExist(err), "expected to get ErrNotExist error, got %v", err)
- }
- // Regression test for https://github.com/docker/docker/issues/6231
- func (s *DockerAPISuite) TestContainerAPIChunkedEncoding(c *testing.T) {
- config := map[string]interface{}{
- "Image": "busybox",
- "Cmd": append([]string{"/bin/sh", "-c"}, sleepCommandForDaemonPlatform()...),
- "OpenStdin": true,
- }
- resp, _, err := request.Post("/containers/create", request.JSONBody(config), request.With(func(req *http.Request) error {
- // This is a cheat to make the http request do chunked encoding
- // Otherwise (just setting the Content-Encoding to chunked) net/http will overwrite
- // https://golang.org/src/pkg/net/http/request.go?s=11980:12172
- req.ContentLength = -1
- return nil
- }))
- assert.Assert(c, err == nil, "error creating container with chunked encoding")
- defer resp.Body.Close()
- assert.Equal(c, resp.StatusCode, http.StatusCreated)
- }
- func (s *DockerAPISuite) TestContainerAPIPostContainerStop(c *testing.T) {
- out := runSleepingContainer(c)
- containerID := strings.TrimSpace(out)
- assert.Assert(c, waitRun(containerID) == nil)
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerStop(context.Background(), containerID, container.StopOptions{})
- assert.NilError(c, err)
- assert.Assert(c, waitInspect(containerID, "{{ .State.Running }}", "false", 60*time.Second) == nil)
- }
- // #14170
- func (s *DockerAPISuite) TestPostContainerAPICreateWithStringOrSliceEntrypoint(c *testing.T) {
- config := container.Config{
- Image: "busybox",
- Entrypoint: []string{"echo"},
- Cmd: []string{"hello", "world"},
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- _, err = cli.ContainerCreate(context.Background(), &config, &container.HostConfig{}, &network.NetworkingConfig{}, nil, "echotest")
- assert.NilError(c, err)
- out, _ := dockerCmd(c, "start", "-a", "echotest")
- assert.Equal(c, strings.TrimSpace(out), "hello world")
- config2 := struct {
- Image string
- Entrypoint string
- Cmd []string
- }{"busybox", "echo", []string{"hello", "world"}}
- _, _, err = request.Post("/containers/create?name=echotest2", request.JSONBody(config2))
- assert.NilError(c, err)
- out, _ = dockerCmd(c, "start", "-a", "echotest2")
- assert.Equal(c, strings.TrimSpace(out), "hello world")
- }
- // #14170
- func (s *DockerAPISuite) TestPostContainersCreateWithStringOrSliceCmd(c *testing.T) {
- config := container.Config{
- Image: "busybox",
- Cmd: []string{"echo", "hello", "world"},
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- _, err = cli.ContainerCreate(context.Background(), &config, &container.HostConfig{}, &network.NetworkingConfig{}, nil, "echotest")
- assert.NilError(c, err)
- out, _ := dockerCmd(c, "start", "-a", "echotest")
- assert.Equal(c, strings.TrimSpace(out), "hello world")
- config2 := struct {
- Image string
- Entrypoint string
- Cmd string
- }{"busybox", "echo", "hello world"}
- _, _, err = request.Post("/containers/create?name=echotest2", request.JSONBody(config2))
- assert.NilError(c, err)
- out, _ = dockerCmd(c, "start", "-a", "echotest2")
- assert.Equal(c, strings.TrimSpace(out), "hello world")
- }
- // regression #14318
- // for backward compatibility testing with and without CAP_ prefix
- // and with upper and lowercase
- func (s *DockerAPISuite) TestPostContainersCreateWithStringOrSliceCapAddDrop(c *testing.T) {
- // Windows doesn't support CapAdd/CapDrop
- testRequires(c, DaemonIsLinux)
- config := struct {
- Image string
- CapAdd string
- CapDrop string
- }{"busybox", "NET_ADMIN", "cap_sys_admin"}
- res, _, err := request.Post("/containers/create?name=capaddtest0", request.JSONBody(config))
- assert.NilError(c, err)
- assert.Equal(c, res.StatusCode, http.StatusCreated)
- config2 := container.Config{
- Image: "busybox",
- }
- hostConfig := container.HostConfig{
- CapAdd: []string{"net_admin", "SYS_ADMIN"},
- CapDrop: []string{"SETGID", "CAP_SETPCAP"},
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- _, err = cli.ContainerCreate(context.Background(), &config2, &hostConfig, &network.NetworkingConfig{}, nil, "capaddtest1")
- assert.NilError(c, err)
- }
- // #14915
- func (s *DockerAPISuite) TestContainerAPICreateNoHostConfig118(c *testing.T) {
- testRequires(c, DaemonIsLinux) // Windows only support 1.25 or later
- config := container.Config{
- Image: "busybox",
- }
- cli, err := client.NewClientWithOpts(client.FromEnv, client.WithVersion("v1.18"))
- assert.NilError(c, err)
- _, err = cli.ContainerCreate(context.Background(), &config, &container.HostConfig{}, &network.NetworkingConfig{}, nil, "")
- assert.NilError(c, err)
- }
- // Ensure an error occurs when you have a container read-only rootfs but you
- // extract an archive to a symlink in a writable volume which points to a
- // directory outside of the volume.
- func (s *DockerAPISuite) TestPutContainerArchiveErrSymlinkInVolumeToReadOnlyRootfs(c *testing.T) {
- // Windows does not support read-only rootfs
- // Requires local volume mount bind.
- // --read-only + userns has remount issues
- testRequires(c, testEnv.IsLocalDaemon, NotUserNamespace, DaemonIsLinux)
- testVol := getTestDir(c, "test-put-container-archive-err-symlink-in-volume-to-read-only-rootfs-")
- defer os.RemoveAll(testVol)
- makeTestContentInDir(c, testVol)
- cID := makeTestContainer(c, testContainerOptions{
- readOnly: true,
- volumes: defaultVolumes(testVol), // Our bind mount is at /vol2
- })
- // Attempt to extract to a symlink in the volume which points to a
- // directory outside the volume. This should cause an error because the
- // rootfs is read-only.
- cli, err := client.NewClientWithOpts(client.FromEnv, client.WithVersion("v1.20"))
- assert.NilError(c, err)
- err = cli.CopyToContainer(context.Background(), cID, "/vol2/symlinkToAbsDir", nil, types.CopyToContainerOptions{})
- assert.ErrorContains(c, err, "container rootfs is marked read-only")
- }
- func (s *DockerAPISuite) TestPostContainersCreateWithWrongCpusetValues(c *testing.T) {
- // Not supported on Windows
- testRequires(c, DaemonIsLinux)
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- config := container.Config{
- Image: "busybox",
- }
- hostConfig1 := container.HostConfig{
- Resources: container.Resources{
- CpusetCpus: "1-42,,",
- },
- }
- name := "wrong-cpuset-cpus"
- _, err = cli.ContainerCreate(context.Background(), &config, &hostConfig1, &network.NetworkingConfig{}, nil, name)
- expected := "Invalid value 1-42,, for cpuset cpus"
- assert.ErrorContains(c, err, expected)
- hostConfig2 := container.HostConfig{
- Resources: container.Resources{
- CpusetMems: "42-3,1--",
- },
- }
- name = "wrong-cpuset-mems"
- _, err = cli.ContainerCreate(context.Background(), &config, &hostConfig2, &network.NetworkingConfig{}, nil, name)
- expected = "Invalid value 42-3,1-- for cpuset mems"
- assert.ErrorContains(c, err, expected)
- }
- func (s *DockerAPISuite) TestPostContainersCreateShmSizeNegative(c *testing.T) {
- // ShmSize is not supported on Windows
- testRequires(c, DaemonIsLinux)
- config := container.Config{
- Image: "busybox",
- }
- hostConfig := container.HostConfig{
- ShmSize: -1,
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- _, err = cli.ContainerCreate(context.Background(), &config, &hostConfig, &network.NetworkingConfig{}, nil, "")
- assert.ErrorContains(c, err, "SHM size can not be less than 0")
- }
- func (s *DockerAPISuite) TestPostContainersCreateShmSizeHostConfigOmitted(c *testing.T) {
- // ShmSize is not supported on Windows
- testRequires(c, DaemonIsLinux)
- config := container.Config{
- Image: "busybox",
- Cmd: []string{"mount"},
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- container, err := cli.ContainerCreate(context.Background(), &config, &container.HostConfig{}, &network.NetworkingConfig{}, nil, "")
- assert.NilError(c, err)
- containerJSON, err := cli.ContainerInspect(context.Background(), container.ID)
- assert.NilError(c, err)
- assert.Equal(c, containerJSON.HostConfig.ShmSize, dconfig.DefaultShmSize)
- out, _ := dockerCmd(c, "start", "-i", containerJSON.ID)
- shmRegexp := regexp.MustCompile(`shm on /dev/shm type tmpfs(.*)size=65536k`)
- if !shmRegexp.MatchString(out) {
- c.Fatalf("Expected shm of 64MB in mount command, got %v", out)
- }
- }
- func (s *DockerAPISuite) TestPostContainersCreateShmSizeOmitted(c *testing.T) {
- // ShmSize is not supported on Windows
- testRequires(c, DaemonIsLinux)
- config := container.Config{
- Image: "busybox",
- Cmd: []string{"mount"},
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- container, err := cli.ContainerCreate(context.Background(), &config, &container.HostConfig{}, &network.NetworkingConfig{}, nil, "")
- assert.NilError(c, err)
- containerJSON, err := cli.ContainerInspect(context.Background(), container.ID)
- assert.NilError(c, err)
- assert.Equal(c, containerJSON.HostConfig.ShmSize, int64(67108864))
- out, _ := dockerCmd(c, "start", "-i", containerJSON.ID)
- shmRegexp := regexp.MustCompile(`shm on /dev/shm type tmpfs(.*)size=65536k`)
- if !shmRegexp.MatchString(out) {
- c.Fatalf("Expected shm of 64MB in mount command, got %v", out)
- }
- }
- func (s *DockerAPISuite) TestPostContainersCreateWithShmSize(c *testing.T) {
- // ShmSize is not supported on Windows
- testRequires(c, DaemonIsLinux)
- config := container.Config{
- Image: "busybox",
- Cmd: []string{"mount"},
- }
- hostConfig := container.HostConfig{
- ShmSize: 1073741824,
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- container, err := cli.ContainerCreate(context.Background(), &config, &hostConfig, &network.NetworkingConfig{}, nil, "")
- assert.NilError(c, err)
- containerJSON, err := cli.ContainerInspect(context.Background(), container.ID)
- assert.NilError(c, err)
- assert.Equal(c, containerJSON.HostConfig.ShmSize, int64(1073741824))
- out, _ := dockerCmd(c, "start", "-i", containerJSON.ID)
- shmRegex := regexp.MustCompile(`shm on /dev/shm type tmpfs(.*)size=1048576k`)
- if !shmRegex.MatchString(out) {
- c.Fatalf("Expected shm of 1GB in mount command, got %v", out)
- }
- }
- func (s *DockerAPISuite) TestPostContainersCreateMemorySwappinessHostConfigOmitted(c *testing.T) {
- // Swappiness is not supported on Windows
- testRequires(c, DaemonIsLinux)
- config := container.Config{
- Image: "busybox",
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- container, err := cli.ContainerCreate(context.Background(), &config, &container.HostConfig{}, &network.NetworkingConfig{}, nil, "")
- assert.NilError(c, err)
- containerJSON, err := cli.ContainerInspect(context.Background(), container.ID)
- assert.NilError(c, err)
- if versions.LessThan(testEnv.DaemonAPIVersion(), "1.31") {
- assert.Equal(c, *containerJSON.HostConfig.MemorySwappiness, int64(-1))
- } else {
- assert.Assert(c, containerJSON.HostConfig.MemorySwappiness == nil)
- }
- }
- // check validation is done daemon side and not only in cli
- func (s *DockerAPISuite) TestPostContainersCreateWithOomScoreAdjInvalidRange(c *testing.T) {
- // OomScoreAdj is not supported on Windows
- testRequires(c, DaemonIsLinux)
- config := container.Config{
- Image: "busybox",
- }
- hostConfig := container.HostConfig{
- OomScoreAdj: 1001,
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- name := "oomscoreadj-over"
- _, err = cli.ContainerCreate(context.Background(), &config, &hostConfig, &network.NetworkingConfig{}, nil, name)
- expected := "Invalid value 1001, range for oom score adj is [-1000, 1000]"
- assert.ErrorContains(c, err, expected)
- hostConfig = container.HostConfig{
- OomScoreAdj: -1001,
- }
- name = "oomscoreadj-low"
- _, err = cli.ContainerCreate(context.Background(), &config, &hostConfig, &network.NetworkingConfig{}, nil, name)
- expected = "Invalid value -1001, range for oom score adj is [-1000, 1000]"
- assert.ErrorContains(c, err, expected)
- }
- // test case for #22210 where an empty container name caused panic.
- func (s *DockerAPISuite) TestContainerAPIDeleteWithEmptyName(c *testing.T) {
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- err = cli.ContainerRemove(context.Background(), "", types.ContainerRemoveOptions{})
- assert.Check(c, errdefs.IsNotFound(err))
- }
- func (s *DockerAPISuite) TestContainerAPIStatsWithNetworkDisabled(c *testing.T) {
- // Problematic on Windows as Windows does not support stats
- testRequires(c, DaemonIsLinux)
- name := "testing-network-disabled"
- config := container.Config{
- Image: "busybox",
- Cmd: []string{"top"},
- NetworkDisabled: true,
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- _, err = cli.ContainerCreate(context.Background(), &config, &container.HostConfig{}, &network.NetworkingConfig{}, nil, name)
- assert.NilError(c, err)
- err = cli.ContainerStart(context.Background(), name, types.ContainerStartOptions{})
- assert.NilError(c, err)
- assert.Assert(c, waitRun(name) == nil)
- type b struct {
- stats types.ContainerStats
- err error
- }
- bc := make(chan b, 1)
- go func() {
- stats, err := cli.ContainerStats(context.Background(), name, false)
- bc <- b{stats, err}
- }()
- // allow some time to stream the stats from the container
- time.Sleep(4 * time.Second)
- dockerCmd(c, "rm", "-f", name)
- // collect the results from the stats stream or timeout and fail
- // if the stream was not disconnected.
- select {
- case <-time.After(2 * time.Second):
- c.Fatal("stream was not closed after container was removed")
- case sr := <-bc:
- assert.Assert(c, sr.err == nil)
- sr.stats.Body.Close()
- }
- }
- func (s *DockerAPISuite) TestContainersAPICreateMountsValidation(c *testing.T) {
- type testCase struct {
- config container.Config
- hostConfig container.HostConfig
- msg string
- }
- prefix, slash := getPrefixAndSlashFromDaemonPlatform()
- destPath := prefix + slash + "foo"
- notExistPath := prefix + slash + "notexist"
- cases := []testCase{
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{{
- Type: "notreal",
- Target: destPath,
- },
- },
- },
- msg: "mount type unknown",
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{{
- Type: "bind"}}},
- msg: "Target must not be empty",
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{{
- Type: "bind",
- Target: destPath}}},
- msg: "Source must not be empty",
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{{
- Type: "bind",
- Source: notExistPath,
- Target: destPath}}},
- msg: "source path does not exist",
- // FIXME(vdemeester) fails into e2e, migrate to integration/container anyway
- // msg: "source path does not exist: " + notExistPath,
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{{
- Type: "volume"}}},
- msg: "Target must not be empty",
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{{
- Type: "volume",
- Source: "hello",
- Target: destPath}}},
- msg: "",
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{{
- Type: "volume",
- Source: "hello2",
- Target: destPath,
- VolumeOptions: &mount.VolumeOptions{
- DriverConfig: &mount.Driver{
- Name: "local"}}}}},
- msg: "",
- },
- }
- if testEnv.IsLocalDaemon() {
- tmpDir, err := ioutils.TempDir("", "test-mounts-api")
- assert.NilError(c, err)
- defer os.RemoveAll(tmpDir)
- cases = append(cases, []testCase{
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{{
- Type: "bind",
- Source: tmpDir,
- Target: destPath}}},
- msg: "",
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{{
- Type: "bind",
- Source: tmpDir,
- Target: destPath,
- VolumeOptions: &mount.VolumeOptions{}}}},
- msg: "VolumeOptions must not be specified",
- },
- }...)
- }
- if DaemonIsWindows() {
- cases = append(cases, []testCase{
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{
- {
- Type: "volume",
- Source: "not-supported-on-windows",
- Target: destPath,
- VolumeOptions: &mount.VolumeOptions{
- DriverConfig: &mount.Driver{
- Name: "local",
- Options: map[string]string{"type": "tmpfs"},
- },
- },
- },
- },
- },
- msg: `options are not supported on this platform`,
- },
- }...)
- }
- if DaemonIsLinux() {
- cases = append(cases, []testCase{
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{
- {
- Type: "volume",
- Source: "missing-device-opt",
- Target: destPath,
- VolumeOptions: &mount.VolumeOptions{
- DriverConfig: &mount.Driver{
- Name: "local",
- Options: map[string]string{"foobar": "foobaz"},
- },
- },
- },
- },
- },
- msg: `invalid option: "foobar"`,
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{
- {
- Type: "volume",
- Source: "missing-device-opt",
- Target: destPath,
- VolumeOptions: &mount.VolumeOptions{
- DriverConfig: &mount.Driver{
- Name: "local",
- Options: map[string]string{"type": "tmpfs"},
- },
- },
- },
- },
- },
- msg: `missing required option: "device"`,
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{
- {
- Type: "volume",
- Source: "missing-type-opt",
- Target: destPath,
- VolumeOptions: &mount.VolumeOptions{
- DriverConfig: &mount.Driver{
- Name: "local",
- Options: map[string]string{"device": "tmpfs"},
- },
- },
- },
- },
- },
- msg: `missing required option: "type"`,
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{
- {
- Type: "volume",
- Source: "hello4",
- Target: destPath,
- VolumeOptions: &mount.VolumeOptions{
- DriverConfig: &mount.Driver{
- Name: "local",
- Options: map[string]string{"o": "size=1", "type": "tmpfs", "device": "tmpfs"},
- },
- },
- },
- },
- },
- msg: "",
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{{
- Type: "tmpfs",
- Target: destPath}}},
- msg: "",
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{{
- Type: "tmpfs",
- Target: destPath,
- TmpfsOptions: &mount.TmpfsOptions{
- SizeBytes: 4096 * 1024,
- Mode: 0700,
- }}}},
- msg: "",
- },
- {
- config: container.Config{
- Image: "busybox",
- },
- hostConfig: container.HostConfig{
- Mounts: []mount.Mount{{
- Type: "tmpfs",
- Source: "/shouldnotbespecified",
- Target: destPath}}},
- msg: "Source must not be specified",
- },
- }...)
- }
- apiClient, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer apiClient.Close()
- // TODO add checks for statuscode returned by API
- for i, x := range cases {
- x := x
- c.Run(fmt.Sprintf("case %d", i), func(c *testing.T) {
- _, err = apiClient.ContainerCreate(context.Background(), &x.config, &x.hostConfig, &network.NetworkingConfig{}, nil, "")
- if len(x.msg) > 0 {
- assert.ErrorContains(c, err, x.msg, "%v", cases[i].config)
- } else {
- assert.NilError(c, err)
- }
- })
- }
- }
- func (s *DockerAPISuite) TestContainerAPICreateMountsBindRead(c *testing.T) {
- testRequires(c, NotUserNamespace, testEnv.IsLocalDaemon)
- // also with data in the host side
- prefix, slash := getPrefixAndSlashFromDaemonPlatform()
- destPath := prefix + slash + "foo"
- tmpDir, err := os.MkdirTemp("", "test-mounts-api-bind")
- assert.NilError(c, err)
- defer os.RemoveAll(tmpDir)
- err = os.WriteFile(filepath.Join(tmpDir, "bar"), []byte("hello"), 0666)
- assert.NilError(c, err)
- config := container.Config{
- Image: "busybox",
- Cmd: []string{"/bin/sh", "-c", "cat /foo/bar"},
- }
- hostConfig := container.HostConfig{
- Mounts: []mount.Mount{
- {Type: "bind", Source: tmpDir, Target: destPath},
- },
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- _, err = cli.ContainerCreate(context.Background(), &config, &hostConfig, &network.NetworkingConfig{}, nil, "test")
- assert.NilError(c, err)
- out, _ := dockerCmd(c, "start", "-a", "test")
- assert.Equal(c, out, "hello")
- }
- // Test Mounts comes out as expected for the MountPoint
- func (s *DockerAPISuite) TestContainersAPICreateMountsCreate(c *testing.T) {
- prefix, slash := getPrefixAndSlashFromDaemonPlatform()
- destPath := prefix + slash + "foo"
- var (
- testImg string
- )
- if testEnv.OSType != "windows" {
- testImg = "test-mount-config"
- buildImageSuccessfully(c, testImg, build.WithDockerfile(`
- FROM busybox
- RUN mkdir `+destPath+` && touch `+destPath+slash+`bar
- CMD cat `+destPath+slash+`bar
- `))
- } else {
- testImg = "busybox"
- }
- type testCase struct {
- spec mount.Mount
- expected types.MountPoint
- }
- var selinuxSharedLabel string
- // this test label was added after a bug fix in 1.32, thus add requirements min API >= 1.32
- // for the sake of making test pass in earlier versions
- // bug fixed in https://github.com/moby/moby/pull/34684
- if !versions.LessThan(testEnv.DaemonAPIVersion(), "1.32") {
- if runtime.GOOS == "linux" {
- selinuxSharedLabel = "z"
- }
- }
- cases := []testCase{
- // use literal strings here for `Type` instead of the defined constants in the volume package to keep this honest
- // Validation of the actual `Mount` struct is done in another test is not needed here
- {
- spec: mount.Mount{Type: "volume", Target: destPath},
- expected: types.MountPoint{Driver: volume.DefaultDriverName, Type: "volume", RW: true, Destination: destPath, Mode: selinuxSharedLabel},
- },
- {
- spec: mount.Mount{Type: "volume", Target: destPath + slash},
- expected: types.MountPoint{Driver: volume.DefaultDriverName, Type: "volume", RW: true, Destination: destPath, Mode: selinuxSharedLabel},
- },
- {
- spec: mount.Mount{Type: "volume", Target: destPath, Source: "test1"},
- expected: types.MountPoint{Type: "volume", Name: "test1", RW: true, Destination: destPath, Mode: selinuxSharedLabel},
- },
- {
- spec: mount.Mount{Type: "volume", Target: destPath, ReadOnly: true, Source: "test2"},
- expected: types.MountPoint{Type: "volume", Name: "test2", RW: false, Destination: destPath, Mode: selinuxSharedLabel},
- },
- {
- spec: mount.Mount{Type: "volume", Target: destPath, Source: "test3", VolumeOptions: &mount.VolumeOptions{DriverConfig: &mount.Driver{Name: volume.DefaultDriverName}}},
- expected: types.MountPoint{Driver: volume.DefaultDriverName, Type: "volume", Name: "test3", RW: true, Destination: destPath, Mode: selinuxSharedLabel},
- },
- }
- if testEnv.IsLocalDaemon() {
- // setup temp dir for testing binds
- tmpDir1, err := os.MkdirTemp("", "test-mounts-api-1")
- assert.NilError(c, err)
- defer os.RemoveAll(tmpDir1)
- cases = append(cases, []testCase{
- {
- spec: mount.Mount{
- Type: "bind",
- Source: tmpDir1,
- Target: destPath,
- },
- expected: types.MountPoint{
- Type: "bind",
- RW: true,
- Destination: destPath,
- Source: tmpDir1,
- },
- },
- {
- spec: mount.Mount{Type: "bind", Source: tmpDir1, Target: destPath, ReadOnly: true},
- expected: types.MountPoint{Type: "bind", RW: false, Destination: destPath, Source: tmpDir1},
- },
- }...)
- // for modes only supported on Linux
- if DaemonIsLinux() {
- tmpDir3, err := ioutils.TempDir("", "test-mounts-api-3")
- assert.NilError(c, err)
- defer os.RemoveAll(tmpDir3)
- assert.Assert(c, mountWrapper(tmpDir3, tmpDir3, "none", "bind,shared") == nil)
- cases = append(cases, []testCase{
- {
- spec: mount.Mount{Type: "bind", Source: tmpDir3, Target: destPath},
- expected: types.MountPoint{Type: "bind", RW: true, Destination: destPath, Source: tmpDir3},
- },
- {
- spec: mount.Mount{Type: "bind", Source: tmpDir3, Target: destPath, ReadOnly: true},
- expected: types.MountPoint{Type: "bind", RW: false, Destination: destPath, Source: tmpDir3},
- },
- {
- spec: mount.Mount{Type: "bind", Source: tmpDir3, Target: destPath, ReadOnly: true, BindOptions: &mount.BindOptions{Propagation: "shared"}},
- expected: types.MountPoint{Type: "bind", RW: false, Destination: destPath, Source: tmpDir3, Propagation: "shared"},
- },
- }...)
- }
- }
- if testEnv.OSType != "windows" { // Windows does not support volume populate
- cases = append(cases, []testCase{
- {
- spec: mount.Mount{Type: "volume", Target: destPath, VolumeOptions: &mount.VolumeOptions{NoCopy: true}},
- expected: types.MountPoint{Driver: volume.DefaultDriverName, Type: "volume", RW: true, Destination: destPath, Mode: selinuxSharedLabel},
- },
- {
- spec: mount.Mount{Type: "volume", Target: destPath + slash, VolumeOptions: &mount.VolumeOptions{NoCopy: true}},
- expected: types.MountPoint{Driver: volume.DefaultDriverName, Type: "volume", RW: true, Destination: destPath, Mode: selinuxSharedLabel},
- },
- {
- spec: mount.Mount{Type: "volume", Target: destPath, Source: "test4", VolumeOptions: &mount.VolumeOptions{NoCopy: true}},
- expected: types.MountPoint{Type: "volume", Name: "test4", RW: true, Destination: destPath, Mode: selinuxSharedLabel},
- },
- {
- spec: mount.Mount{Type: "volume", Target: destPath, Source: "test5", ReadOnly: true, VolumeOptions: &mount.VolumeOptions{NoCopy: true}},
- expected: types.MountPoint{Type: "volume", Name: "test5", RW: false, Destination: destPath, Mode: selinuxSharedLabel},
- },
- }...)
- }
- ctx := context.Background()
- apiclient := testEnv.APIClient()
- for i, x := range cases {
- x := x
- c.Run(fmt.Sprintf("%d config: %v", i, x.spec), func(c *testing.T) {
- container, err := apiclient.ContainerCreate(
- ctx,
- &container.Config{Image: testImg},
- &container.HostConfig{Mounts: []mount.Mount{x.spec}},
- &network.NetworkingConfig{},
- nil,
- "")
- assert.NilError(c, err)
- containerInspect, err := apiclient.ContainerInspect(ctx, container.ID)
- assert.NilError(c, err)
- mps := containerInspect.Mounts
- assert.Assert(c, is.Len(mps, 1))
- mountPoint := mps[0]
- if x.expected.Source != "" {
- assert.Check(c, is.Equal(x.expected.Source, mountPoint.Source))
- }
- if x.expected.Name != "" {
- assert.Check(c, is.Equal(x.expected.Name, mountPoint.Name))
- }
- if x.expected.Driver != "" {
- assert.Check(c, is.Equal(x.expected.Driver, mountPoint.Driver))
- }
- if x.expected.Propagation != "" {
- assert.Check(c, is.Equal(x.expected.Propagation, mountPoint.Propagation))
- }
- assert.Check(c, is.Equal(x.expected.RW, mountPoint.RW))
- assert.Check(c, is.Equal(x.expected.Type, mountPoint.Type))
- assert.Check(c, is.Equal(x.expected.Mode, mountPoint.Mode))
- assert.Check(c, is.Equal(x.expected.Destination, mountPoint.Destination))
- err = apiclient.ContainerStart(ctx, container.ID, types.ContainerStartOptions{})
- assert.NilError(c, err)
- poll.WaitOn(c, containerExit(apiclient, container.ID), poll.WithDelay(time.Second))
- err = apiclient.ContainerRemove(ctx, container.ID, types.ContainerRemoveOptions{
- RemoveVolumes: true,
- Force: true,
- })
- assert.NilError(c, err)
- switch {
- // Named volumes still exist after the container is removed
- case x.spec.Type == "volume" && len(x.spec.Source) > 0:
- _, err := apiclient.VolumeInspect(ctx, mountPoint.Name)
- assert.NilError(c, err)
- // Bind mounts are never removed with the container
- case x.spec.Type == "bind":
- // anonymous volumes are removed
- default:
- _, err := apiclient.VolumeInspect(ctx, mountPoint.Name)
- assert.Check(c, client.IsErrNotFound(err))
- }
- })
- }
- }
- func containerExit(apiclient client.APIClient, name string) func(poll.LogT) poll.Result {
- return func(logT poll.LogT) poll.Result {
- container, err := apiclient.ContainerInspect(context.Background(), name)
- if err != nil {
- return poll.Error(err)
- }
- switch container.State.Status {
- case "created", "running":
- return poll.Continue("container %s is %s, waiting for exit", name, container.State.Status)
- }
- return poll.Success()
- }
- }
- func (s *DockerAPISuite) TestContainersAPICreateMountsTmpfs(c *testing.T) {
- testRequires(c, DaemonIsLinux)
- type testCase struct {
- cfg mount.Mount
- expectedOptions []string
- }
- target := "/foo"
- cases := []testCase{
- {
- cfg: mount.Mount{
- Type: "tmpfs",
- Target: target},
- expectedOptions: []string{"rw", "nosuid", "nodev", "noexec", "relatime"},
- },
- {
- cfg: mount.Mount{
- Type: "tmpfs",
- Target: target,
- TmpfsOptions: &mount.TmpfsOptions{
- SizeBytes: 4096 * 1024, Mode: 0700}},
- expectedOptions: []string{"rw", "nosuid", "nodev", "noexec", "relatime", "size=4096k", "mode=700"},
- },
- }
- cli, err := client.NewClientWithOpts(client.FromEnv)
- assert.NilError(c, err)
- defer cli.Close()
- config := container.Config{
- Image: "busybox",
- Cmd: []string{"/bin/sh", "-c", fmt.Sprintf("mount | grep 'tmpfs on %s'", target)},
- }
- for i, x := range cases {
- cName := fmt.Sprintf("test-tmpfs-%d", i)
- hostConfig := container.HostConfig{
- Mounts: []mount.Mount{x.cfg},
- }
- _, err = cli.ContainerCreate(context.Background(), &config, &hostConfig, &network.NetworkingConfig{}, nil, cName)
- assert.NilError(c, err)
- out, _ := dockerCmd(c, "start", "-a", cName)
- for _, option := range x.expectedOptions {
- assert.Assert(c, strings.Contains(out, option))
- }
- }
- }
- // Regression test for #33334
- // Makes sure that when a container which has a custom stop signal + restart=always
- // gets killed (with SIGKILL) by the kill API, that the restart policy is cancelled.
- func (s *DockerAPISuite) TestContainerKillCustomStopSignal(c *testing.T) {
- id := strings.TrimSpace(runSleepingContainer(c, "--stop-signal=SIGTERM", "--restart=always"))
- res, _, err := request.Post("/containers/" + id + "/kill")
- assert.NilError(c, err)
- defer res.Body.Close()
- b, err := io.ReadAll(res.Body)
- assert.NilError(c, err)
- assert.Equal(c, res.StatusCode, http.StatusNoContent, string(b))
- err = waitInspect(id, "{{.State.Running}} {{.State.Restarting}}", "false false", 30*time.Second)
- assert.NilError(c, err)
- }
|