docker_cli_build_test.go 51 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876
  1. package main
  2. import (
  3. "archive/tar"
  4. "fmt"
  5. "io/ioutil"
  6. "os"
  7. "os/exec"
  8. "path/filepath"
  9. "strings"
  10. "testing"
  11. "time"
  12. "github.com/docker/docker/archive"
  13. )
  14. func TestBuildCacheADD(t *testing.T) {
  15. name := "testbuildtwoimageswithadd"
  16. defer deleteImages(name)
  17. server, err := fakeStorage(map[string]string{
  18. "robots.txt": "hello",
  19. "index.html": "world",
  20. })
  21. if err != nil {
  22. t.Fatal(err)
  23. }
  24. defer server.Close()
  25. if _, err := buildImage(name,
  26. fmt.Sprintf(`FROM scratch
  27. ADD %s/robots.txt /`, server.URL),
  28. true); err != nil {
  29. t.Fatal(err)
  30. }
  31. out, _, err := buildImageWithOut(name,
  32. fmt.Sprintf(`FROM scratch
  33. ADD %s/index.html /`, server.URL),
  34. true)
  35. if err != nil {
  36. t.Fatal(err)
  37. }
  38. if strings.Contains(out, "Using cache") {
  39. t.Fatal("2nd build used cache on ADD, it shouldn't")
  40. }
  41. logDone("build - build two images with remote ADD")
  42. }
  43. func TestBuildSixtySteps(t *testing.T) {
  44. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildSixtySteps")
  45. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "foobuildsixtysteps", ".")
  46. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  47. if err != nil || exitCode != 0 {
  48. t.Fatal("failed to build the image")
  49. }
  50. deleteImages("foobuildsixtysteps")
  51. logDone("build - build an image with sixty build steps")
  52. }
  53. func TestAddSingleFileToRoot(t *testing.T) {
  54. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd", "SingleFileToRoot")
  55. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  56. if err != nil {
  57. t.Fatal(err)
  58. }
  59. f.Close()
  60. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", ".")
  61. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  62. if err != nil || exitCode != 0 {
  63. t.Fatal("failed to build the image")
  64. }
  65. deleteImages("testaddimg")
  66. logDone("build - add single file to root")
  67. }
  68. // Issue #3960: "ADD src ." hangs
  69. func TestAddSingleFileToWorkdir(t *testing.T) {
  70. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd", "SingleFileToWorkdir")
  71. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  72. if err != nil {
  73. t.Fatal(err)
  74. }
  75. f.Close()
  76. buildCmd := exec.Command(dockerBinary, "build", "-t", "testaddimg", ".")
  77. buildCmd.Dir = buildDirectory
  78. done := make(chan error)
  79. go func() {
  80. out, exitCode, err := runCommandWithOutput(buildCmd)
  81. if err != nil || exitCode != 0 {
  82. done <- fmt.Errorf("build failed to complete: %s %v", out, err)
  83. return
  84. }
  85. done <- nil
  86. }()
  87. select {
  88. case <-time.After(5 * time.Second):
  89. if err := buildCmd.Process.Kill(); err != nil {
  90. fmt.Printf("could not kill build (pid=%d): %v\n", buildCmd.Process.Pid, err)
  91. }
  92. t.Fatal("build timed out")
  93. case err := <-done:
  94. if err != nil {
  95. t.Fatal(err)
  96. }
  97. }
  98. deleteImages("testaddimg")
  99. logDone("build - add single file to workdir")
  100. }
  101. func TestAddSingleFileToExistDir(t *testing.T) {
  102. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
  103. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "SingleFileToExistDir")
  104. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  105. if err != nil || exitCode != 0 {
  106. t.Fatal("failed to build the image")
  107. }
  108. deleteImages("testaddimg")
  109. logDone("build - add single file to existing dir")
  110. }
  111. func TestAddSingleFileToNonExistDir(t *testing.T) {
  112. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
  113. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "SingleFileToNonExistDir")
  114. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  115. if err != nil || exitCode != 0 {
  116. t.Fatal("failed to build the image")
  117. }
  118. deleteImages("testaddimg")
  119. logDone("build - add single file to non-existing dir")
  120. }
  121. func TestAddDirContentToRoot(t *testing.T) {
  122. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
  123. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "DirContentToRoot")
  124. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  125. if err != nil || exitCode != 0 {
  126. t.Fatal("failed to build the image")
  127. }
  128. deleteImages("testaddimg")
  129. logDone("build - add directory contents to root")
  130. }
  131. func TestAddDirContentToExistDir(t *testing.T) {
  132. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
  133. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "DirContentToExistDir")
  134. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  135. if err != nil || exitCode != 0 {
  136. t.Fatal("failed to build the image")
  137. }
  138. deleteImages("testaddimg")
  139. logDone("build - add directory contents to existing dir")
  140. }
  141. func TestAddWholeDirToRoot(t *testing.T) {
  142. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd", "WholeDirToRoot")
  143. test_dir := filepath.Join(buildDirectory, "test_dir")
  144. if err := os.MkdirAll(test_dir, 0755); err != nil {
  145. t.Fatal(err)
  146. }
  147. f, err := os.OpenFile(filepath.Join(test_dir, "test_file"), os.O_CREATE, 0644)
  148. if err != nil {
  149. t.Fatal(err)
  150. }
  151. f.Close()
  152. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", ".")
  153. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  154. if err != nil || exitCode != 0 {
  155. t.Fatal("failed to build the image")
  156. }
  157. deleteImages("testaddimg")
  158. logDone("build - add whole directory to root")
  159. }
  160. func TestAddEtcToRoot(t *testing.T) {
  161. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
  162. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "EtcToRoot")
  163. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  164. if err != nil || exitCode != 0 {
  165. t.Fatal("failed to build the image")
  166. }
  167. deleteImages("testaddimg")
  168. logDone("build - add etc directory to root")
  169. }
  170. func TestCopySingleFileToRoot(t *testing.T) {
  171. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", "SingleFileToRoot")
  172. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  173. if err != nil {
  174. t.Fatal(err)
  175. }
  176. f.Close()
  177. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", ".")
  178. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  179. if err != nil || exitCode != 0 {
  180. t.Fatal("failed to build the image")
  181. }
  182. deleteImages("testcopyimg")
  183. logDone("build - copy single file to root")
  184. }
  185. // Issue #3960: "ADD src ." hangs - adapted for COPY
  186. func TestCopySingleFileToWorkdir(t *testing.T) {
  187. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", "SingleFileToWorkdir")
  188. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  189. if err != nil {
  190. t.Fatal(err)
  191. }
  192. f.Close()
  193. buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", ".")
  194. buildCmd.Dir = buildDirectory
  195. done := make(chan error)
  196. go func() {
  197. out, exitCode, err := runCommandWithOutput(buildCmd)
  198. if err != nil || exitCode != 0 {
  199. done <- fmt.Errorf("build failed to complete: %s %v", out, err)
  200. return
  201. }
  202. done <- nil
  203. }()
  204. select {
  205. case <-time.After(5 * time.Second):
  206. if err := buildCmd.Process.Kill(); err != nil {
  207. fmt.Printf("could not kill build (pid=%d): %v\n", buildCmd.Process.Pid, err)
  208. }
  209. t.Fatal("build timed out")
  210. case err := <-done:
  211. if err != nil {
  212. t.Fatal(err)
  213. }
  214. }
  215. deleteImages("testcopyimg")
  216. logDone("build - copy single file to workdir")
  217. }
  218. func TestCopySingleFileToExistDir(t *testing.T) {
  219. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  220. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "SingleFileToExistDir")
  221. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  222. if err != nil || exitCode != 0 {
  223. t.Fatal("failed to build the image")
  224. }
  225. deleteImages("testcopyimg")
  226. logDone("build - add single file to existing dir")
  227. }
  228. func TestCopySingleFileToNonExistDir(t *testing.T) {
  229. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  230. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "SingleFileToNonExistDir")
  231. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  232. if err != nil || exitCode != 0 {
  233. t.Fatal("failed to build the image")
  234. }
  235. deleteImages("testcopyimg")
  236. logDone("build - copy single file to non-existing dir")
  237. }
  238. func TestCopyDirContentToRoot(t *testing.T) {
  239. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  240. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "DirContentToRoot")
  241. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  242. if err != nil || exitCode != 0 {
  243. t.Fatal("failed to build the image")
  244. }
  245. deleteImages("testcopyimg")
  246. logDone("build - copy directory contents to root")
  247. }
  248. func TestCopyDirContentToExistDir(t *testing.T) {
  249. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  250. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "DirContentToExistDir")
  251. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  252. if err != nil || exitCode != 0 {
  253. t.Fatal("failed to build the image")
  254. }
  255. deleteImages("testcopyimg")
  256. logDone("build - copy directory contents to existing dir")
  257. }
  258. func TestCopyWholeDirToRoot(t *testing.T) {
  259. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", "WholeDirToRoot")
  260. test_dir := filepath.Join(buildDirectory, "test_dir")
  261. if err := os.MkdirAll(test_dir, 0755); err != nil {
  262. t.Fatal(err)
  263. }
  264. f, err := os.OpenFile(filepath.Join(test_dir, "test_file"), os.O_CREATE, 0644)
  265. if err != nil {
  266. t.Fatal(err)
  267. }
  268. f.Close()
  269. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", ".")
  270. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  271. if err != nil || exitCode != 0 {
  272. t.Fatal("failed to build the image")
  273. }
  274. deleteImages("testcopyimg")
  275. logDone("build - copy whole directory to root")
  276. }
  277. func TestCopyEtcToRoot(t *testing.T) {
  278. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  279. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "EtcToRoot")
  280. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  281. if err != nil || exitCode != 0 {
  282. t.Fatal("failed to build the image")
  283. }
  284. deleteImages("testcopyimg")
  285. logDone("build - copy etc directory to root")
  286. }
  287. func TestCopyDisallowRemote(t *testing.T) {
  288. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  289. buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", "DisallowRemote")
  290. buildCmd.Dir = buildDirectory
  291. out, exitCode, err := runCommandWithOutput(buildCmd)
  292. if err == nil || exitCode == 0 {
  293. t.Fatalf("building the image should've failed; output: %s", out)
  294. }
  295. deleteImages("testcopyimg")
  296. logDone("build - copy - disallow copy from remote")
  297. }
  298. // Issue #5270 - ensure we throw a better error than "unexpected EOF"
  299. // when we can't access files in the context.
  300. func TestBuildWithInaccessibleFilesInContext(t *testing.T) {
  301. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildWithInaccessibleFilesInContext")
  302. {
  303. // This is used to ensure we detect inaccessible files early during build in the cli client
  304. pathToInaccessibleFileBuildDirectory := filepath.Join(buildDirectory, "inaccessiblefile")
  305. pathToFileWithoutReadAccess := filepath.Join(pathToInaccessibleFileBuildDirectory, "fileWithoutReadAccess")
  306. err := os.Chown(pathToFileWithoutReadAccess, 0, 0)
  307. errorOut(err, t, fmt.Sprintf("failed to chown file to root: %s", err))
  308. err = os.Chmod(pathToFileWithoutReadAccess, 0700)
  309. errorOut(err, t, fmt.Sprintf("failed to chmod file to 700: %s", err))
  310. buildCommandStatement := fmt.Sprintf("%s build -t inaccessiblefiles .", dockerBinary)
  311. buildCmd := exec.Command("su", "unprivilegeduser", "-c", buildCommandStatement)
  312. buildCmd.Dir = pathToInaccessibleFileBuildDirectory
  313. out, exitCode, err := runCommandWithOutput(buildCmd)
  314. if err == nil || exitCode == 0 {
  315. t.Fatalf("build should have failed: %s %s", err, out)
  316. }
  317. // check if we've detected the failure before we started building
  318. if !strings.Contains(out, "no permission to read from ") {
  319. t.Fatalf("output should've contained the string: no permission to read from but contained: %s", out)
  320. }
  321. if !strings.Contains(out, "Error checking context is accessible") {
  322. t.Fatalf("output should've contained the string: Error checking context is accessible")
  323. }
  324. }
  325. {
  326. // This is used to ensure we detect inaccessible directories early during build in the cli client
  327. pathToInaccessibleDirectoryBuildDirectory := filepath.Join(buildDirectory, "inaccessibledirectory")
  328. pathToDirectoryWithoutReadAccess := filepath.Join(pathToInaccessibleDirectoryBuildDirectory, "directoryWeCantStat")
  329. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  330. err := os.Chown(pathToDirectoryWithoutReadAccess, 0, 0)
  331. errorOut(err, t, fmt.Sprintf("failed to chown directory to root: %s", err))
  332. err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444)
  333. errorOut(err, t, fmt.Sprintf("failed to chmod directory to 755: %s", err))
  334. err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700)
  335. errorOut(err, t, fmt.Sprintf("failed to chmod file to 444: %s", err))
  336. buildCommandStatement := fmt.Sprintf("%s build -t inaccessiblefiles .", dockerBinary)
  337. buildCmd := exec.Command("su", "unprivilegeduser", "-c", buildCommandStatement)
  338. buildCmd.Dir = pathToInaccessibleDirectoryBuildDirectory
  339. out, exitCode, err := runCommandWithOutput(buildCmd)
  340. if err == nil || exitCode == 0 {
  341. t.Fatalf("build should have failed: %s %s", err, out)
  342. }
  343. // check if we've detected the failure before we started building
  344. if !strings.Contains(out, "can't stat") {
  345. t.Fatalf("output should've contained the string: can't access %s", out)
  346. }
  347. if !strings.Contains(out, "Error checking context is accessible") {
  348. t.Fatalf("output should've contained the string: Error checking context is accessible")
  349. }
  350. }
  351. {
  352. // This is used to ensure we don't follow links when checking if everything in the context is accessible
  353. // This test doesn't require that we run commands as an unprivileged user
  354. pathToDirectoryWhichContainsLinks := filepath.Join(buildDirectory, "linksdirectory")
  355. out, exitCode, err := dockerCmdInDir(t, pathToDirectoryWhichContainsLinks, "build", "-t", "testlinksok", ".")
  356. if err != nil || exitCode != 0 {
  357. t.Fatalf("build should have worked: %s %s", err, out)
  358. }
  359. deleteImages("testlinksok")
  360. }
  361. {
  362. // This is used to ensure we don't try to add inaccessible files when they are ignored by a .dockerignore pattern
  363. pathToInaccessibleDirectoryBuildDirectory := filepath.Join(buildDirectory, "ignoredinaccessible")
  364. pathToDirectoryWithoutReadAccess := filepath.Join(pathToInaccessibleDirectoryBuildDirectory, "directoryWeCantStat")
  365. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  366. err := os.Chown(pathToDirectoryWithoutReadAccess, 0, 0)
  367. errorOut(err, t, fmt.Sprintf("failed to chown directory to root: %s", err))
  368. err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444)
  369. errorOut(err, t, fmt.Sprintf("failed to chmod directory to 755: %s", err))
  370. err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700)
  371. errorOut(err, t, fmt.Sprintf("failed to chmod file to 444: %s", err))
  372. buildCommandStatement := fmt.Sprintf("%s build -t ignoredinaccessible .", dockerBinary)
  373. buildCmd := exec.Command("su", "unprivilegeduser", "-c", buildCommandStatement)
  374. buildCmd.Dir = pathToInaccessibleDirectoryBuildDirectory
  375. out, exitCode, err := runCommandWithOutput(buildCmd)
  376. if err != nil || exitCode != 0 {
  377. t.Fatalf("build should have worked: %s %s", err, out)
  378. }
  379. deleteImages("ignoredinaccessible")
  380. }
  381. deleteImages("inaccessiblefiles")
  382. logDone("build - ADD from context with inaccessible files must fail")
  383. logDone("build - ADD from context with accessible links must work")
  384. logDone("build - ADD from context with ignored inaccessible files must work")
  385. }
  386. func TestBuildForceRm(t *testing.T) {
  387. containerCountBefore, err := getContainerCount()
  388. if err != nil {
  389. t.Fatalf("failed to get the container count: %s", err)
  390. }
  391. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildForceRm")
  392. buildCmd := exec.Command(dockerBinary, "build", "--force-rm", ".")
  393. buildCmd.Dir = buildDirectory
  394. _, exitCode, err := runCommandWithOutput(buildCmd)
  395. if err == nil || exitCode == 0 {
  396. t.Fatal("failed to build the image")
  397. }
  398. containerCountAfter, err := getContainerCount()
  399. if err != nil {
  400. t.Fatalf("failed to get the container count: %s", err)
  401. }
  402. if containerCountBefore != containerCountAfter {
  403. t.Fatalf("--force-rm shouldn't have left containers behind")
  404. }
  405. logDone("build - ensure --force-rm doesn't leave containers behind")
  406. }
  407. func TestBuildRm(t *testing.T) {
  408. {
  409. containerCountBefore, err := getContainerCount()
  410. if err != nil {
  411. t.Fatalf("failed to get the container count: %s", err)
  412. }
  413. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm")
  414. _, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "--rm", "-t", "testbuildrm", ".")
  415. if err != nil || exitCode != 0 {
  416. t.Fatal("failed to build the image")
  417. }
  418. containerCountAfter, err := getContainerCount()
  419. if err != nil {
  420. t.Fatalf("failed to get the container count: %s", err)
  421. }
  422. if containerCountBefore != containerCountAfter {
  423. t.Fatalf("-rm shouldn't have left containers behind")
  424. }
  425. deleteImages("testbuildrm")
  426. }
  427. {
  428. containerCountBefore, err := getContainerCount()
  429. if err != nil {
  430. t.Fatalf("failed to get the container count: %s", err)
  431. }
  432. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm")
  433. _, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testbuildrm", ".")
  434. if err != nil || exitCode != 0 {
  435. t.Fatal("failed to build the image")
  436. }
  437. containerCountAfter, err := getContainerCount()
  438. if err != nil {
  439. t.Fatalf("failed to get the container count: %s", err)
  440. }
  441. if containerCountBefore != containerCountAfter {
  442. t.Fatalf("--rm shouldn't have left containers behind")
  443. }
  444. deleteImages("testbuildrm")
  445. }
  446. {
  447. containerCountBefore, err := getContainerCount()
  448. if err != nil {
  449. t.Fatalf("failed to get the container count: %s", err)
  450. }
  451. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm")
  452. _, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "--rm=false", "-t", "testbuildrm", ".")
  453. if err != nil || exitCode != 0 {
  454. t.Fatal("failed to build the image")
  455. }
  456. containerCountAfter, err := getContainerCount()
  457. if err != nil {
  458. t.Fatalf("failed to get the container count: %s", err)
  459. }
  460. if containerCountBefore == containerCountAfter {
  461. t.Fatalf("--rm=false should have left containers behind")
  462. }
  463. deleteAllContainers()
  464. deleteImages("testbuildrm")
  465. }
  466. logDone("build - ensure --rm doesn't leave containers behind and that --rm=true is the default")
  467. logDone("build - ensure --rm=false overrides the default")
  468. }
  469. func TestBuildWithVolumes(t *testing.T) {
  470. var (
  471. result map[string]map[string]struct{}
  472. name = "testbuildvolumes"
  473. emptyMap = make(map[string]struct{})
  474. expected = map[string]map[string]struct{}{"/test1": emptyMap, "/test2": emptyMap}
  475. )
  476. defer deleteImages(name)
  477. _, err := buildImage(name,
  478. `FROM scratch
  479. VOLUME /test1
  480. VOLUME /test2`,
  481. true)
  482. if err != nil {
  483. t.Fatal(err)
  484. }
  485. res, err := inspectFieldJSON(name, "Config.Volumes")
  486. if err != nil {
  487. t.Fatal(err)
  488. }
  489. err = unmarshalJSON([]byte(res), &result)
  490. if err != nil {
  491. t.Fatal(err)
  492. }
  493. equal := deepEqual(&expected, &result)
  494. if !equal {
  495. t.Fatalf("Volumes %s, expected %s", result, expected)
  496. }
  497. logDone("build - with volumes")
  498. }
  499. func TestBuildMaintainer(t *testing.T) {
  500. name := "testbuildmaintainer"
  501. expected := "dockerio"
  502. defer deleteImages(name)
  503. _, err := buildImage(name,
  504. `FROM scratch
  505. MAINTAINER dockerio`,
  506. true)
  507. if err != nil {
  508. t.Fatal(err)
  509. }
  510. res, err := inspectField(name, "Author")
  511. if err != nil {
  512. t.Fatal(err)
  513. }
  514. if res != expected {
  515. t.Fatalf("Maintainer %s, expected %s", res, expected)
  516. }
  517. logDone("build - maintainer")
  518. }
  519. func TestBuildUser(t *testing.T) {
  520. name := "testbuilduser"
  521. expected := "dockerio"
  522. defer deleteImages(name)
  523. _, err := buildImage(name,
  524. `FROM busybox
  525. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  526. USER dockerio
  527. RUN [ $(whoami) = 'dockerio' ]`,
  528. true)
  529. if err != nil {
  530. t.Fatal(err)
  531. }
  532. res, err := inspectField(name, "Config.User")
  533. if err != nil {
  534. t.Fatal(err)
  535. }
  536. if res != expected {
  537. t.Fatalf("User %s, expected %s", res, expected)
  538. }
  539. logDone("build - user")
  540. }
  541. func TestBuildRelativeWorkdir(t *testing.T) {
  542. name := "testbuildrelativeworkdir"
  543. expected := "/test2/test3"
  544. defer deleteImages(name)
  545. _, err := buildImage(name,
  546. `FROM busybox
  547. RUN [ "$PWD" = '/' ]
  548. WORKDIR test1
  549. RUN [ "$PWD" = '/test1' ]
  550. WORKDIR /test2
  551. RUN [ "$PWD" = '/test2' ]
  552. WORKDIR test3
  553. RUN [ "$PWD" = '/test2/test3' ]`,
  554. true)
  555. if err != nil {
  556. t.Fatal(err)
  557. }
  558. res, err := inspectField(name, "Config.WorkingDir")
  559. if err != nil {
  560. t.Fatal(err)
  561. }
  562. if res != expected {
  563. t.Fatalf("Workdir %s, expected %s", res, expected)
  564. }
  565. logDone("build - relative workdir")
  566. }
  567. func TestBuildEnv(t *testing.T) {
  568. name := "testbuildenv"
  569. expected := "[PATH=/test:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PORT=2375]"
  570. defer deleteImages(name)
  571. _, err := buildImage(name,
  572. `FROM busybox
  573. ENV PATH /test:$PATH
  574. ENV PORT 2375
  575. RUN [ $(env | grep PORT) = 'PORT=2375' ]`,
  576. true)
  577. if err != nil {
  578. t.Fatal(err)
  579. }
  580. res, err := inspectField(name, "Config.Env")
  581. if err != nil {
  582. t.Fatal(err)
  583. }
  584. if res != expected {
  585. t.Fatalf("Env %s, expected %s", res, expected)
  586. }
  587. logDone("build - env")
  588. }
  589. func TestBuildCmd(t *testing.T) {
  590. name := "testbuildcmd"
  591. expected := "[/bin/echo Hello World]"
  592. defer deleteImages(name)
  593. _, err := buildImage(name,
  594. `FROM scratch
  595. CMD ["/bin/echo", "Hello World"]`,
  596. true)
  597. if err != nil {
  598. t.Fatal(err)
  599. }
  600. res, err := inspectField(name, "Config.Cmd")
  601. if err != nil {
  602. t.Fatal(err)
  603. }
  604. if res != expected {
  605. t.Fatalf("Cmd %s, expected %s", res, expected)
  606. }
  607. logDone("build - cmd")
  608. }
  609. func TestBuildExpose(t *testing.T) {
  610. name := "testbuildexpose"
  611. expected := "map[2375/tcp:map[]]"
  612. defer deleteImages(name)
  613. _, err := buildImage(name,
  614. `FROM scratch
  615. EXPOSE 2375`,
  616. true)
  617. if err != nil {
  618. t.Fatal(err)
  619. }
  620. res, err := inspectField(name, "Config.ExposedPorts")
  621. if err != nil {
  622. t.Fatal(err)
  623. }
  624. if res != expected {
  625. t.Fatalf("Exposed ports %s, expected %s", res, expected)
  626. }
  627. logDone("build - expose")
  628. }
  629. func TestBuildEntrypoint(t *testing.T) {
  630. name := "testbuildentrypoint"
  631. expected := "[/bin/echo]"
  632. defer deleteImages(name)
  633. _, err := buildImage(name,
  634. `FROM scratch
  635. ENTRYPOINT ["/bin/echo"]`,
  636. true)
  637. if err != nil {
  638. t.Fatal(err)
  639. }
  640. res, err := inspectField(name, "Config.Entrypoint")
  641. if err != nil {
  642. t.Fatal(err)
  643. }
  644. if res != expected {
  645. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  646. }
  647. logDone("build - entrypoint")
  648. }
  649. // #6445 ensure ONBUILD triggers aren't committed to grandchildren
  650. func TestBuildOnBuildLimitedInheritence(t *testing.T) {
  651. var (
  652. out2, out3 string
  653. )
  654. {
  655. name1 := "testonbuildtrigger1"
  656. dockerfile1 := `
  657. FROM busybox
  658. RUN echo "GRANDPARENT"
  659. ONBUILD RUN echo "ONBUILD PARENT"
  660. `
  661. ctx, err := fakeContext(dockerfile1, nil)
  662. if err != nil {
  663. t.Fatal(err)
  664. }
  665. out1, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name1, ".")
  666. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out1, err))
  667. defer deleteImages(name1)
  668. }
  669. {
  670. name2 := "testonbuildtrigger2"
  671. dockerfile2 := `
  672. FROM testonbuildtrigger1
  673. `
  674. ctx, err := fakeContext(dockerfile2, nil)
  675. if err != nil {
  676. t.Fatal(err)
  677. }
  678. out2, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name2, ".")
  679. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out2, err))
  680. defer deleteImages(name2)
  681. }
  682. {
  683. name3 := "testonbuildtrigger3"
  684. dockerfile3 := `
  685. FROM testonbuildtrigger2
  686. `
  687. ctx, err := fakeContext(dockerfile3, nil)
  688. if err != nil {
  689. t.Fatal(err)
  690. }
  691. out3, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name3, ".")
  692. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out3, err))
  693. defer deleteImages(name3)
  694. }
  695. // ONBUILD should be run in second build.
  696. if !strings.Contains(out2, "ONBUILD PARENT") {
  697. t.Fatalf("ONBUILD instruction did not run in child of ONBUILD parent")
  698. }
  699. // ONBUILD should *not* be run in third build.
  700. if strings.Contains(out3, "ONBUILD PARENT") {
  701. t.Fatalf("ONBUILD instruction ran in grandchild of ONBUILD parent")
  702. }
  703. logDone("build - onbuild")
  704. }
  705. func TestBuildWithCache(t *testing.T) {
  706. name := "testbuildwithcache"
  707. defer deleteImages(name)
  708. id1, err := buildImage(name,
  709. `FROM scratch
  710. MAINTAINER dockerio
  711. EXPOSE 5432
  712. ENTRYPOINT ["/bin/echo"]`,
  713. true)
  714. if err != nil {
  715. t.Fatal(err)
  716. }
  717. id2, err := buildImage(name,
  718. `FROM scratch
  719. MAINTAINER dockerio
  720. EXPOSE 5432
  721. ENTRYPOINT ["/bin/echo"]`,
  722. true)
  723. if err != nil {
  724. t.Fatal(err)
  725. }
  726. if id1 != id2 {
  727. t.Fatal("The cache should have been used but hasn't.")
  728. }
  729. logDone("build - with cache")
  730. }
  731. func TestBuildWithoutCache(t *testing.T) {
  732. name := "testbuildwithoutcache"
  733. defer deleteImages(name)
  734. id1, err := buildImage(name,
  735. `FROM scratch
  736. MAINTAINER dockerio
  737. EXPOSE 5432
  738. ENTRYPOINT ["/bin/echo"]`,
  739. true)
  740. if err != nil {
  741. t.Fatal(err)
  742. }
  743. id2, err := buildImage(name,
  744. `FROM scratch
  745. MAINTAINER dockerio
  746. EXPOSE 5432
  747. ENTRYPOINT ["/bin/echo"]`,
  748. false)
  749. if err != nil {
  750. t.Fatal(err)
  751. }
  752. if id1 == id2 {
  753. t.Fatal("The cache should have been invalided but hasn't.")
  754. }
  755. logDone("build - without cache")
  756. }
  757. func TestBuildADDLocalFileWithCache(t *testing.T) {
  758. name := "testbuildaddlocalfilewithcache"
  759. defer deleteImages(name)
  760. dockerfile := `
  761. FROM busybox
  762. MAINTAINER dockerio
  763. ADD foo /usr/lib/bla/bar
  764. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  765. ctx, err := fakeContext(dockerfile, map[string]string{
  766. "foo": "hello",
  767. })
  768. defer ctx.Close()
  769. if err != nil {
  770. t.Fatal(err)
  771. }
  772. id1, err := buildImageFromContext(name, ctx, true)
  773. if err != nil {
  774. t.Fatal(err)
  775. }
  776. id2, err := buildImageFromContext(name, ctx, true)
  777. if err != nil {
  778. t.Fatal(err)
  779. }
  780. if id1 != id2 {
  781. t.Fatal("The cache should have been used but hasn't.")
  782. }
  783. logDone("build - add local file with cache")
  784. }
  785. func TestBuildADDLocalFileWithoutCache(t *testing.T) {
  786. name := "testbuildaddlocalfilewithoutcache"
  787. defer deleteImages(name)
  788. dockerfile := `
  789. FROM busybox
  790. MAINTAINER dockerio
  791. ADD foo /usr/lib/bla/bar
  792. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  793. ctx, err := fakeContext(dockerfile, map[string]string{
  794. "foo": "hello",
  795. })
  796. defer ctx.Close()
  797. if err != nil {
  798. t.Fatal(err)
  799. }
  800. id1, err := buildImageFromContext(name, ctx, true)
  801. if err != nil {
  802. t.Fatal(err)
  803. }
  804. id2, err := buildImageFromContext(name, ctx, false)
  805. if err != nil {
  806. t.Fatal(err)
  807. }
  808. if id1 == id2 {
  809. t.Fatal("The cache should have been invalided but hasn't.")
  810. }
  811. logDone("build - add local file without cache")
  812. }
  813. func TestBuildADDCurrentDirWithCache(t *testing.T) {
  814. name := "testbuildaddcurrentdirwithcache"
  815. defer deleteImages(name)
  816. dockerfile := `
  817. FROM scratch
  818. MAINTAINER dockerio
  819. ADD . /usr/lib/bla`
  820. ctx, err := fakeContext(dockerfile, map[string]string{
  821. "foo": "hello",
  822. })
  823. defer ctx.Close()
  824. if err != nil {
  825. t.Fatal(err)
  826. }
  827. id1, err := buildImageFromContext(name, ctx, true)
  828. if err != nil {
  829. t.Fatal(err)
  830. }
  831. // Check that adding file invalidate cache of "ADD ."
  832. if err := ctx.Add("bar", "hello2"); err != nil {
  833. t.Fatal(err)
  834. }
  835. id2, err := buildImageFromContext(name, ctx, true)
  836. if err != nil {
  837. t.Fatal(err)
  838. }
  839. if id1 == id2 {
  840. t.Fatal("The cache should have been invalided but hasn't.")
  841. }
  842. // Check that changing file invalidate cache of "ADD ."
  843. if err := ctx.Add("foo", "hello1"); err != nil {
  844. t.Fatal(err)
  845. }
  846. id3, err := buildImageFromContext(name, ctx, true)
  847. if err != nil {
  848. t.Fatal(err)
  849. }
  850. if id2 == id3 {
  851. t.Fatal("The cache should have been invalided but hasn't.")
  852. }
  853. // Check that changing file to same content invalidate cache of "ADD ."
  854. time.Sleep(1 * time.Second) // wait second because of mtime precision
  855. if err := ctx.Add("foo", "hello1"); err != nil {
  856. t.Fatal(err)
  857. }
  858. id4, err := buildImageFromContext(name, ctx, true)
  859. if err != nil {
  860. t.Fatal(err)
  861. }
  862. if id3 == id4 {
  863. t.Fatal("The cache should have been invalided but hasn't.")
  864. }
  865. id5, err := buildImageFromContext(name, ctx, true)
  866. if err != nil {
  867. t.Fatal(err)
  868. }
  869. if id4 != id5 {
  870. t.Fatal("The cache should have been used but hasn't.")
  871. }
  872. logDone("build - add current directory with cache")
  873. }
  874. func TestBuildADDCurrentDirWithoutCache(t *testing.T) {
  875. name := "testbuildaddcurrentdirwithoutcache"
  876. defer deleteImages(name)
  877. dockerfile := `
  878. FROM scratch
  879. MAINTAINER dockerio
  880. ADD . /usr/lib/bla`
  881. ctx, err := fakeContext(dockerfile, map[string]string{
  882. "foo": "hello",
  883. })
  884. defer ctx.Close()
  885. if err != nil {
  886. t.Fatal(err)
  887. }
  888. id1, err := buildImageFromContext(name, ctx, true)
  889. if err != nil {
  890. t.Fatal(err)
  891. }
  892. id2, err := buildImageFromContext(name, ctx, false)
  893. if err != nil {
  894. t.Fatal(err)
  895. }
  896. if id1 == id2 {
  897. t.Fatal("The cache should have been invalided but hasn't.")
  898. }
  899. logDone("build - add current directory without cache")
  900. }
  901. func TestBuildADDRemoteFileWithCache(t *testing.T) {
  902. name := "testbuildaddremotefilewithcache"
  903. defer deleteImages(name)
  904. server, err := fakeStorage(map[string]string{
  905. "baz": "hello",
  906. })
  907. if err != nil {
  908. t.Fatal(err)
  909. }
  910. defer server.Close()
  911. id1, err := buildImage(name,
  912. fmt.Sprintf(`FROM scratch
  913. MAINTAINER dockerio
  914. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  915. true)
  916. if err != nil {
  917. t.Fatal(err)
  918. }
  919. id2, err := buildImage(name,
  920. fmt.Sprintf(`FROM scratch
  921. MAINTAINER dockerio
  922. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  923. true)
  924. if err != nil {
  925. t.Fatal(err)
  926. }
  927. if id1 != id2 {
  928. t.Fatal("The cache should have been used but hasn't.")
  929. }
  930. logDone("build - add remote file with cache")
  931. }
  932. func TestBuildADDRemoteFileWithoutCache(t *testing.T) {
  933. name := "testbuildaddremotefilewithoutcache"
  934. defer deleteImages(name)
  935. server, err := fakeStorage(map[string]string{
  936. "baz": "hello",
  937. })
  938. if err != nil {
  939. t.Fatal(err)
  940. }
  941. defer server.Close()
  942. id1, err := buildImage(name,
  943. fmt.Sprintf(`FROM scratch
  944. MAINTAINER dockerio
  945. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  946. true)
  947. if err != nil {
  948. t.Fatal(err)
  949. }
  950. id2, err := buildImage(name,
  951. fmt.Sprintf(`FROM scratch
  952. MAINTAINER dockerio
  953. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  954. false)
  955. if err != nil {
  956. t.Fatal(err)
  957. }
  958. if id1 == id2 {
  959. t.Fatal("The cache should have been invalided but hasn't.")
  960. }
  961. logDone("build - add remote file without cache")
  962. }
  963. func TestBuildADDLocalAndRemoteFilesWithCache(t *testing.T) {
  964. name := "testbuildaddlocalandremotefilewithcache"
  965. defer deleteImages(name)
  966. server, err := fakeStorage(map[string]string{
  967. "baz": "hello",
  968. })
  969. if err != nil {
  970. t.Fatal(err)
  971. }
  972. defer server.Close()
  973. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  974. MAINTAINER dockerio
  975. ADD foo /usr/lib/bla/bar
  976. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  977. map[string]string{
  978. "foo": "hello world",
  979. })
  980. if err != nil {
  981. t.Fatal(err)
  982. }
  983. defer ctx.Close()
  984. id1, err := buildImageFromContext(name, ctx, true)
  985. if err != nil {
  986. t.Fatal(err)
  987. }
  988. id2, err := buildImageFromContext(name, ctx, true)
  989. if err != nil {
  990. t.Fatal(err)
  991. }
  992. if id1 != id2 {
  993. t.Fatal("The cache should have been used but hasn't.")
  994. }
  995. logDone("build - add local and remote file with cache")
  996. }
  997. func testContextTar(t *testing.T, compression archive.Compression) {
  998. contextDirectory := filepath.Join(workingDirectory, "build_tests", "TestContextTar")
  999. context, err := archive.Tar(contextDirectory, compression)
  1000. if err != nil {
  1001. t.Fatalf("failed to build context tar: %v", err)
  1002. }
  1003. buildCmd := exec.Command(dockerBinary, "build", "-t", "contexttar", "-")
  1004. buildCmd.Stdin = context
  1005. out, exitCode, err := runCommandWithOutput(buildCmd)
  1006. if err != nil || exitCode != 0 {
  1007. t.Fatalf("build failed to complete: %v %v", out, err)
  1008. }
  1009. deleteImages("contexttar")
  1010. logDone(fmt.Sprintf("build - build an image with a context tar, compression: %v", compression))
  1011. }
  1012. func TestContextTarGzip(t *testing.T) {
  1013. testContextTar(t, archive.Gzip)
  1014. }
  1015. func TestContextTarNoCompression(t *testing.T) {
  1016. testContextTar(t, archive.Uncompressed)
  1017. }
  1018. func TestNoContext(t *testing.T) {
  1019. buildCmd := exec.Command(dockerBinary, "build", "-t", "nocontext", "-")
  1020. buildCmd.Stdin = strings.NewReader("FROM busybox\nCMD echo ok\n")
  1021. out, exitCode, err := runCommandWithOutput(buildCmd)
  1022. if err != nil || exitCode != 0 {
  1023. t.Fatalf("build failed to complete: %v %v", out, err)
  1024. }
  1025. out, exitCode, err = cmd(t, "run", "nocontext")
  1026. if out != "ok\n" {
  1027. t.Fatalf("run produced invalid output: %q, expected %q", out, "ok")
  1028. }
  1029. deleteImages("nocontext")
  1030. logDone("build - build an image with no context")
  1031. }
  1032. // TODO: TestCaching
  1033. func TestBuildADDLocalAndRemoteFilesWithoutCache(t *testing.T) {
  1034. name := "testbuildaddlocalandremotefilewithoutcache"
  1035. defer deleteImages(name)
  1036. server, err := fakeStorage(map[string]string{
  1037. "baz": "hello",
  1038. })
  1039. if err != nil {
  1040. t.Fatal(err)
  1041. }
  1042. defer server.Close()
  1043. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  1044. MAINTAINER dockerio
  1045. ADD foo /usr/lib/bla/bar
  1046. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1047. map[string]string{
  1048. "foo": "hello world",
  1049. })
  1050. if err != nil {
  1051. t.Fatal(err)
  1052. }
  1053. defer ctx.Close()
  1054. id1, err := buildImageFromContext(name, ctx, true)
  1055. if err != nil {
  1056. t.Fatal(err)
  1057. }
  1058. id2, err := buildImageFromContext(name, ctx, false)
  1059. if err != nil {
  1060. t.Fatal(err)
  1061. }
  1062. if id1 == id2 {
  1063. t.Fatal("The cache should have been invalided but hasn't.")
  1064. }
  1065. logDone("build - add local and remote file without cache")
  1066. }
  1067. func TestBuildWithVolumeOwnership(t *testing.T) {
  1068. name := "testbuildimg"
  1069. defer deleteImages(name)
  1070. _, err := buildImage(name,
  1071. `FROM busybox:latest
  1072. RUN mkdir /test && chown daemon:daemon /test && chmod 0600 /test
  1073. VOLUME /test`,
  1074. true)
  1075. if err != nil {
  1076. t.Fatal(err)
  1077. }
  1078. cmd := exec.Command(dockerBinary, "run", "--rm", "testbuildimg", "ls", "-la", "/test")
  1079. out, _, err := runCommandWithOutput(cmd)
  1080. if err != nil {
  1081. t.Fatal(err)
  1082. }
  1083. if expected := "drw-------"; !strings.Contains(out, expected) {
  1084. t.Fatalf("expected %s received %s", expected, out)
  1085. }
  1086. if expected := "daemon daemon"; !strings.Contains(out, expected) {
  1087. t.Fatalf("expected %s received %s", expected, out)
  1088. }
  1089. logDone("build - volume ownership")
  1090. }
  1091. // testing #1405 - config.Cmd does not get cleaned up if
  1092. // utilizing cache
  1093. func TestBuildEntrypointRunCleanup(t *testing.T) {
  1094. name := "testbuildcmdcleanup"
  1095. defer deleteImages(name)
  1096. if _, err := buildImage(name,
  1097. `FROM busybox
  1098. RUN echo "hello"`,
  1099. true); err != nil {
  1100. t.Fatal(err)
  1101. }
  1102. ctx, err := fakeContext(`FROM busybox
  1103. RUN echo "hello"
  1104. ADD foo /foo
  1105. ENTRYPOINT ["/bin/echo"]`,
  1106. map[string]string{
  1107. "foo": "hello",
  1108. })
  1109. defer ctx.Close()
  1110. if err != nil {
  1111. t.Fatal(err)
  1112. }
  1113. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1114. t.Fatal(err)
  1115. }
  1116. res, err := inspectField(name, "Config.Cmd")
  1117. if err != nil {
  1118. t.Fatal(err)
  1119. }
  1120. // Cmd must be cleaned up
  1121. if expected := "<no value>"; res != expected {
  1122. t.Fatalf("Cmd %s, expected %s", res, expected)
  1123. }
  1124. logDone("build - cleanup cmd after RUN")
  1125. }
  1126. func TestBuildForbiddenContextPath(t *testing.T) {
  1127. name := "testbuildforbidpath"
  1128. defer deleteImages(name)
  1129. ctx, err := fakeContext(`FROM scratch
  1130. ADD ../../ test/
  1131. `,
  1132. map[string]string{
  1133. "test.txt": "test1",
  1134. "other.txt": "other",
  1135. })
  1136. defer ctx.Close()
  1137. if err != nil {
  1138. t.Fatal(err)
  1139. }
  1140. expected := "Forbidden path outside the build context: ../../ "
  1141. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  1142. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  1143. }
  1144. logDone("build - forbidden context path")
  1145. }
  1146. func TestBuildADDFileNotFound(t *testing.T) {
  1147. name := "testbuildaddnotfound"
  1148. defer deleteImages(name)
  1149. ctx, err := fakeContext(`FROM scratch
  1150. ADD foo /usr/local/bar`,
  1151. map[string]string{"bar": "hello"})
  1152. defer ctx.Close()
  1153. if err != nil {
  1154. t.Fatal(err)
  1155. }
  1156. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1157. if !strings.Contains(err.Error(), "foo: no such file or directory") {
  1158. t.Fatalf("Wrong error %v, must be about missing foo file or directory", err)
  1159. }
  1160. } else {
  1161. t.Fatal("Error must not be nil")
  1162. }
  1163. logDone("build - add file not found")
  1164. }
  1165. func TestBuildInheritance(t *testing.T) {
  1166. name := "testbuildinheritance"
  1167. defer deleteImages(name)
  1168. _, err := buildImage(name,
  1169. `FROM scratch
  1170. EXPOSE 2375`,
  1171. true)
  1172. if err != nil {
  1173. t.Fatal(err)
  1174. }
  1175. ports1, err := inspectField(name, "Config.ExposedPorts")
  1176. if err != nil {
  1177. t.Fatal(err)
  1178. }
  1179. _, err = buildImage(name,
  1180. fmt.Sprintf(`FROM %s
  1181. ENTRYPOINT ["/bin/echo"]`, name),
  1182. true)
  1183. if err != nil {
  1184. t.Fatal(err)
  1185. }
  1186. res, err := inspectField(name, "Config.Entrypoint")
  1187. if err != nil {
  1188. t.Fatal(err)
  1189. }
  1190. if expected := "[/bin/echo]"; res != expected {
  1191. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1192. }
  1193. ports2, err := inspectField(name, "Config.ExposedPorts")
  1194. if err != nil {
  1195. t.Fatal(err)
  1196. }
  1197. if ports1 != ports2 {
  1198. t.Fatalf("Ports must be same: %s != %s", ports1, ports2)
  1199. }
  1200. logDone("build - inheritance")
  1201. }
  1202. func TestBuildFails(t *testing.T) {
  1203. name := "testbuildfails"
  1204. defer deleteImages(name)
  1205. _, err := buildImage(name,
  1206. `FROM busybox
  1207. RUN sh -c "exit 23"`,
  1208. true)
  1209. if err != nil {
  1210. if !strings.Contains(err.Error(), "returned a non-zero code: 23") {
  1211. t.Fatalf("Wrong error %v, must be about non-zero code 23", err)
  1212. }
  1213. } else {
  1214. t.Fatal("Error must not be nil")
  1215. }
  1216. logDone("build - fails")
  1217. }
  1218. func TestBuildFailsDockerfileEmpty(t *testing.T) {
  1219. name := "testbuildfails"
  1220. defer deleteImages(name)
  1221. _, err := buildImage(name, ``, true)
  1222. if err != nil {
  1223. if !strings.Contains(err.Error(), "Dockerfile cannot be empty") {
  1224. t.Fatalf("Wrong error %v, must be about empty Dockerfile", err)
  1225. }
  1226. } else {
  1227. t.Fatal("Error must not be nil")
  1228. }
  1229. logDone("build - fails with empty dockerfile")
  1230. }
  1231. func TestBuildOnBuild(t *testing.T) {
  1232. name := "testbuildonbuild"
  1233. defer deleteImages(name)
  1234. _, err := buildImage(name,
  1235. `FROM busybox
  1236. ONBUILD RUN touch foobar`,
  1237. true)
  1238. if err != nil {
  1239. t.Fatal(err)
  1240. }
  1241. _, err = buildImage(name,
  1242. fmt.Sprintf(`FROM %s
  1243. RUN [ -f foobar ]`, name),
  1244. true)
  1245. if err != nil {
  1246. t.Fatal(err)
  1247. }
  1248. logDone("build - onbuild")
  1249. }
  1250. func TestBuildOnBuildForbiddenChained(t *testing.T) {
  1251. name := "testbuildonbuildforbiddenchained"
  1252. defer deleteImages(name)
  1253. _, err := buildImage(name,
  1254. `FROM busybox
  1255. ONBUILD ONBUILD RUN touch foobar`,
  1256. true)
  1257. if err != nil {
  1258. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  1259. t.Fatalf("Wrong error %v, must be about chaining ONBUILD", err)
  1260. }
  1261. } else {
  1262. t.Fatal("Error must not be nil")
  1263. }
  1264. logDone("build - onbuild forbidden chained")
  1265. }
  1266. func TestBuildOnBuildForbiddenFrom(t *testing.T) {
  1267. name := "testbuildonbuildforbiddenfrom"
  1268. defer deleteImages(name)
  1269. _, err := buildImage(name,
  1270. `FROM busybox
  1271. ONBUILD FROM scratch`,
  1272. true)
  1273. if err != nil {
  1274. if !strings.Contains(err.Error(), "FROM isn't allowed as an ONBUILD trigger") {
  1275. t.Fatalf("Wrong error %v, must be about FROM forbidden", err)
  1276. }
  1277. } else {
  1278. t.Fatal("Error must not be nil")
  1279. }
  1280. logDone("build - onbuild forbidden from")
  1281. }
  1282. func TestBuildOnBuildForbiddenMaintainer(t *testing.T) {
  1283. name := "testbuildonbuildforbiddenmaintainer"
  1284. defer deleteImages(name)
  1285. _, err := buildImage(name,
  1286. `FROM busybox
  1287. ONBUILD MAINTAINER docker.io`,
  1288. true)
  1289. if err != nil {
  1290. if !strings.Contains(err.Error(), "MAINTAINER isn't allowed as an ONBUILD trigger") {
  1291. t.Fatalf("Wrong error %v, must be about MAINTAINER forbidden", err)
  1292. }
  1293. } else {
  1294. t.Fatal("Error must not be nil")
  1295. }
  1296. logDone("build - onbuild forbidden maintainer")
  1297. }
  1298. // gh #2446
  1299. func TestBuildAddToSymlinkDest(t *testing.T) {
  1300. name := "testbuildaddtosymlinkdest"
  1301. defer deleteImages(name)
  1302. ctx, err := fakeContext(`FROM busybox
  1303. RUN mkdir /foo
  1304. RUN ln -s /foo /bar
  1305. ADD foo /bar/
  1306. RUN [ -f /bar/foo ]
  1307. RUN [ -f /foo/foo ]`,
  1308. map[string]string{
  1309. "foo": "hello",
  1310. })
  1311. if err != nil {
  1312. t.Fatal(err)
  1313. }
  1314. defer ctx.Close()
  1315. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1316. t.Fatal(err)
  1317. }
  1318. logDone("build - add to symlink destination")
  1319. }
  1320. func TestBuildEscapeWhitespace(t *testing.T) {
  1321. name := "testbuildescaping"
  1322. defer deleteImages(name)
  1323. _, err := buildImage(name, `
  1324. FROM busybox
  1325. MAINTAINER "Docker \
  1326. IO <io@\
  1327. docker.com>"
  1328. `, true)
  1329. res, err := inspectField(name, "Author")
  1330. if err != nil {
  1331. t.Fatal(err)
  1332. }
  1333. if res != "Docker IO <io@docker.com>" {
  1334. t.Fatal("Parsed string did not match the escaped string")
  1335. }
  1336. logDone("build - validate escaping whitespace")
  1337. }
  1338. func TestDockerignore(t *testing.T) {
  1339. name := "testbuilddockerignore"
  1340. defer deleteImages(name)
  1341. dockerfile := `
  1342. FROM busybox
  1343. ADD . /bla
  1344. RUN [[ -f /bla/src/x.go ]]
  1345. RUN [[ -f /bla/Makefile ]]
  1346. RUN [[ ! -e /bla/src/_vendor ]]
  1347. RUN [[ ! -e /bla/.gitignore ]]
  1348. RUN [[ ! -e /bla/README.md ]]
  1349. RUN [[ ! -e /bla/.git ]]`
  1350. ctx, err := fakeContext(dockerfile, map[string]string{
  1351. "Makefile": "all:",
  1352. ".git/HEAD": "ref: foo",
  1353. "src/x.go": "package main",
  1354. "src/_vendor/v.go": "package main",
  1355. ".gitignore": "",
  1356. "README.md": "readme",
  1357. ".dockerignore": ".git\npkg\n.gitignore\nsrc/_vendor\n*.md",
  1358. })
  1359. defer ctx.Close()
  1360. if err != nil {
  1361. t.Fatal(err)
  1362. }
  1363. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1364. t.Fatal(err)
  1365. }
  1366. logDone("build - test .dockerignore")
  1367. }
  1368. func TestDockerignoringDockerfile(t *testing.T) {
  1369. name := "testbuilddockerignoredockerfile"
  1370. defer deleteImages(name)
  1371. dockerfile := `
  1372. FROM scratch`
  1373. ctx, err := fakeContext(dockerfile, map[string]string{
  1374. "Dockerfile": "FROM scratch",
  1375. ".dockerignore": "Dockerfile\n",
  1376. })
  1377. defer ctx.Close()
  1378. if err != nil {
  1379. t.Fatal(err)
  1380. }
  1381. if _, err = buildImageFromContext(name, ctx, true); err == nil {
  1382. t.Fatalf("Didn't get expected error from ignoring Dockerfile")
  1383. }
  1384. logDone("build - test .dockerignore of Dockerfile")
  1385. }
  1386. func TestDockerignoringWholeDir(t *testing.T) {
  1387. name := "testbuilddockerignorewholedir"
  1388. defer deleteImages(name)
  1389. dockerfile := `
  1390. FROM busybox
  1391. COPY . /
  1392. RUN [[ ! -e /.gitignore ]]
  1393. RUN [[ -f /Makefile ]]`
  1394. ctx, err := fakeContext(dockerfile, map[string]string{
  1395. "Dockerfile": "FROM scratch",
  1396. "Makefile": "all:",
  1397. ".dockerignore": ".*\n",
  1398. })
  1399. defer ctx.Close()
  1400. if err != nil {
  1401. t.Fatal(err)
  1402. }
  1403. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  1404. t.Fatal(err)
  1405. }
  1406. logDone("build - test .dockerignore whole dir with .*")
  1407. }
  1408. func TestBuildLineBreak(t *testing.T) {
  1409. name := "testbuildlinebreak"
  1410. defer deleteImages(name)
  1411. _, err := buildImage(name,
  1412. `FROM busybox
  1413. RUN sh -c 'echo root:testpass \
  1414. > /tmp/passwd'
  1415. RUN mkdir -p /var/run/sshd
  1416. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  1417. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  1418. true)
  1419. if err != nil {
  1420. t.Fatal(err)
  1421. }
  1422. logDone("build - line break with \\")
  1423. }
  1424. func TestBuildEOLInLine(t *testing.T) {
  1425. name := "testbuildeolinline"
  1426. defer deleteImages(name)
  1427. _, err := buildImage(name,
  1428. `FROM busybox
  1429. RUN sh -c 'echo root:testpass > /tmp/passwd'
  1430. RUN echo "foo \n bar"; echo "baz"
  1431. RUN mkdir -p /var/run/sshd
  1432. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  1433. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  1434. true)
  1435. if err != nil {
  1436. t.Fatal(err)
  1437. }
  1438. logDone("build - end of line in dockerfile instruction")
  1439. }
  1440. func TestBuildCommentsShebangs(t *testing.T) {
  1441. name := "testbuildcomments"
  1442. defer deleteImages(name)
  1443. _, err := buildImage(name,
  1444. `FROM busybox
  1445. # This is an ordinary comment.
  1446. RUN { echo '#!/bin/sh'; echo 'echo hello world'; } > /hello.sh
  1447. RUN [ ! -x /hello.sh ]
  1448. # comment with line break \
  1449. RUN chmod +x /hello.sh
  1450. RUN [ -x /hello.sh ]
  1451. RUN [ "$(cat /hello.sh)" = $'#!/bin/sh\necho hello world' ]
  1452. RUN [ "$(/hello.sh)" = "hello world" ]`,
  1453. true)
  1454. if err != nil {
  1455. t.Fatal(err)
  1456. }
  1457. logDone("build - comments and shebangs")
  1458. }
  1459. func TestBuildUsersAndGroups(t *testing.T) {
  1460. name := "testbuildusers"
  1461. defer deleteImages(name)
  1462. _, err := buildImage(name,
  1463. `FROM busybox
  1464. # Make sure our defaults work
  1465. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)" = '0:0/root:root' ]
  1466. # TODO decide if "args.user = strconv.Itoa(syscall.Getuid())" is acceptable behavior for changeUser in sysvinit instead of "return nil" when "USER" isn't specified (so that we get the proper group list even if that is the empty list, even in the default case of not supplying an explicit USER to run as, which implies USER 0)
  1467. USER root
  1468. RUN [ "$(id -G):$(id -Gn)" = '0 10:root wheel' ]
  1469. # Setup dockerio user and group
  1470. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1471. RUN echo 'dockerio:x:1001:' >> /etc/group
  1472. # Make sure we can switch to our user and all the information is exactly as we expect it to be
  1473. USER dockerio
  1474. RUN id -G
  1475. RUN id -Gn
  1476. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  1477. # Switch back to root and double check that worked exactly as we might expect it to
  1478. USER root
  1479. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '0:0/root:root/0 10:root wheel' ]
  1480. # Add a "supplementary" group for our dockerio user
  1481. RUN echo 'supplementary:x:1002:dockerio' >> /etc/group
  1482. # ... and then go verify that we get it like we expect
  1483. USER dockerio
  1484. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  1485. USER 1001
  1486. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  1487. # super test the new "user:group" syntax
  1488. USER dockerio:dockerio
  1489. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  1490. USER 1001:dockerio
  1491. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  1492. USER dockerio:1001
  1493. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  1494. USER 1001:1001
  1495. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  1496. USER dockerio:supplementary
  1497. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  1498. USER dockerio:1002
  1499. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  1500. USER 1001:supplementary
  1501. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  1502. USER 1001:1002
  1503. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  1504. # make sure unknown uid/gid still works properly
  1505. USER 1042:1043
  1506. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1042:1043/1042:1043/1043:1043' ]`,
  1507. true)
  1508. if err != nil {
  1509. t.Fatal(err)
  1510. }
  1511. logDone("build - users and groups")
  1512. }
  1513. func TestBuildEnvUsage(t *testing.T) {
  1514. name := "testbuildenvusage"
  1515. defer deleteImages(name)
  1516. dockerfile := `FROM busybox
  1517. ENV PATH $HOME/bin:$PATH
  1518. ENV PATH /tmp:$PATH
  1519. RUN [ "$PATH" = "/tmp:$HOME/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" ]
  1520. ENV FOO /foo/baz
  1521. ENV BAR /bar
  1522. ENV BAZ $BAR
  1523. ENV FOOPATH $PATH:$FOO
  1524. RUN [ "$BAR" = "$BAZ" ]
  1525. RUN [ "$FOOPATH" = "$PATH:/foo/baz" ]
  1526. ENV FROM hello/docker/world
  1527. ENV TO /docker/world/hello
  1528. ADD $FROM $TO
  1529. RUN [ "$(cat $TO)" = "hello" ]
  1530. `
  1531. ctx, err := fakeContext(dockerfile, map[string]string{
  1532. "hello/docker/world": "hello",
  1533. })
  1534. if err != nil {
  1535. t.Fatal(err)
  1536. }
  1537. _, err = buildImageFromContext(name, ctx, true)
  1538. if err != nil {
  1539. t.Fatal(err)
  1540. }
  1541. logDone("build - environment variables usage")
  1542. }
  1543. func TestBuildAddScript(t *testing.T) {
  1544. name := "testbuildaddscript"
  1545. defer deleteImages(name)
  1546. dockerfile := `
  1547. FROM busybox
  1548. ADD test /test
  1549. RUN ["chmod","+x","/test"]
  1550. RUN ["/test"]
  1551. RUN [ "$(cat /testfile)" = 'test!' ]`
  1552. ctx, err := fakeContext(dockerfile, map[string]string{
  1553. "test": "#!/bin/sh\necho 'test!' > /testfile",
  1554. })
  1555. if err != nil {
  1556. t.Fatal(err)
  1557. }
  1558. _, err = buildImageFromContext(name, ctx, true)
  1559. if err != nil {
  1560. t.Fatal(err)
  1561. }
  1562. logDone("build - add and run script")
  1563. }
  1564. func TestBuildAddTar(t *testing.T) {
  1565. name := "testbuildaddtar"
  1566. defer deleteImages(name)
  1567. ctx := func() *FakeContext {
  1568. dockerfile := `
  1569. FROM busybox
  1570. ADD test.tar /
  1571. RUN cat /test/foo | grep Hi
  1572. ADD test.tar /test.tar
  1573. RUN cat /test.tar/test/foo | grep Hi
  1574. ADD test.tar /unlikely-to-exist
  1575. RUN cat /unlikely-to-exist/test/foo | grep Hi
  1576. ADD test.tar /unlikely-to-exist-trailing-slash/
  1577. RUN cat /unlikely-to-exist-trailing-slash/test/foo | grep Hi
  1578. RUN mkdir /existing-directory
  1579. ADD test.tar /existing-directory
  1580. RUN cat /existing-directory/test/foo | grep Hi
  1581. ADD test.tar /existing-directory-trailing-slash/
  1582. RUN cat /existing-directory-trailing-slash/test/foo | grep Hi`
  1583. tmpDir, err := ioutil.TempDir("", "fake-context")
  1584. testTar, err := os.Create(filepath.Join(tmpDir, "test.tar"))
  1585. if err != nil {
  1586. t.Fatalf("failed to create test.tar archive: %v", err)
  1587. }
  1588. defer testTar.Close()
  1589. tw := tar.NewWriter(testTar)
  1590. if err := tw.WriteHeader(&tar.Header{
  1591. Name: "test/foo",
  1592. Size: 2,
  1593. }); err != nil {
  1594. t.Fatalf("failed to write tar file header: %v", err)
  1595. }
  1596. if _, err := tw.Write([]byte("Hi")); err != nil {
  1597. t.Fatalf("failed to write tar file content: %v", err)
  1598. }
  1599. if err := tw.Close(); err != nil {
  1600. t.Fatalf("failed to close tar archive: %v", err)
  1601. }
  1602. if err := ioutil.WriteFile(filepath.Join(tmpDir, "Dockerfile"), []byte(dockerfile), 0644); err != nil {
  1603. t.Fatalf("failed to open destination dockerfile: %v", err)
  1604. }
  1605. return &FakeContext{Dir: tmpDir}
  1606. }()
  1607. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1608. t.Fatalf("build failed to complete for TestBuildAddTar: %v", err)
  1609. }
  1610. logDone("build - ADD tar")
  1611. }
  1612. func TestBuildFromGIT(t *testing.T) {
  1613. name := "testbuildfromgit"
  1614. defer deleteImages(name)
  1615. git, err := fakeGIT("repo", map[string]string{
  1616. "Dockerfile": `FROM busybox
  1617. ADD first /first
  1618. RUN [ -f /first ]
  1619. MAINTAINER docker`,
  1620. "first": "test git data",
  1621. })
  1622. if err != nil {
  1623. t.Fatal(err)
  1624. }
  1625. defer git.Close()
  1626. _, err = buildImageFromPath(name, git.RepoURL, true)
  1627. if err != nil {
  1628. t.Fatal(err)
  1629. }
  1630. res, err := inspectField(name, "Author")
  1631. if err != nil {
  1632. t.Fatal(err)
  1633. }
  1634. if res != "docker" {
  1635. t.Fatalf("Maintainer should be docker, got %s", res)
  1636. }
  1637. logDone("build - build from GIT")
  1638. }
  1639. func TestBuildCleanupCmdOnEntrypoint(t *testing.T) {
  1640. name := "testbuildcmdcleanuponentrypoint"
  1641. defer deleteImages(name)
  1642. if _, err := buildImage(name,
  1643. `FROM scratch
  1644. CMD ["test"]
  1645. ENTRYPOINT ["echo"]`,
  1646. true); err != nil {
  1647. t.Fatal(err)
  1648. }
  1649. if _, err := buildImage(name,
  1650. fmt.Sprintf(`FROM %s
  1651. ENTRYPOINT ["cat"]`, name),
  1652. true); err != nil {
  1653. t.Fatal(err)
  1654. }
  1655. res, err := inspectField(name, "Config.Cmd")
  1656. if err != nil {
  1657. t.Fatal(err)
  1658. }
  1659. if expected := "<no value>"; res != expected {
  1660. t.Fatalf("Cmd %s, expected %s", res, expected)
  1661. }
  1662. res, err = inspectField(name, "Config.Entrypoint")
  1663. if err != nil {
  1664. t.Fatal(err)
  1665. }
  1666. if expected := "[cat]"; res != expected {
  1667. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1668. }
  1669. logDone("build - cleanup cmd on ENTRYPOINT")
  1670. }