docker_cli_build_test.go 51 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871
  1. package main
  2. import (
  3. "archive/tar"
  4. "fmt"
  5. "io/ioutil"
  6. "os"
  7. "os/exec"
  8. "path/filepath"
  9. "strings"
  10. "testing"
  11. "time"
  12. "github.com/docker/docker/archive"
  13. )
  14. func TestBuildCacheADD(t *testing.T) {
  15. name := "testbuildtwoimageswithadd"
  16. defer deleteImages(name)
  17. server, err := fakeStorage(map[string]string{
  18. "robots.txt": "hello",
  19. "index.html": "world",
  20. })
  21. if err != nil {
  22. t.Fatal(err)
  23. }
  24. defer server.Close()
  25. if _, err := buildImage(name,
  26. fmt.Sprintf(`FROM scratch
  27. ADD %s/robots.txt /`, server.URL),
  28. true); err != nil {
  29. t.Fatal(err)
  30. }
  31. out, _, err := buildImageWithOut(name,
  32. fmt.Sprintf(`FROM scratch
  33. ADD %s/index.html /`, server.URL),
  34. true)
  35. if err != nil {
  36. t.Fatal(err)
  37. }
  38. if strings.Contains(out, "Using cache") {
  39. t.Fatal("2nd build used cache on ADD, it shouldn't")
  40. }
  41. logDone("build - build two images with remote ADD")
  42. }
  43. func TestBuildSixtySteps(t *testing.T) {
  44. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildSixtySteps")
  45. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "foobuildsixtysteps", ".")
  46. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  47. if err != nil || exitCode != 0 {
  48. t.Fatal("failed to build the image")
  49. }
  50. deleteImages("foobuildsixtysteps")
  51. logDone("build - build an image with sixty build steps")
  52. }
  53. func TestAddSingleFileToRoot(t *testing.T) {
  54. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd", "SingleFileToRoot")
  55. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  56. if err != nil {
  57. t.Fatal(err)
  58. }
  59. f.Close()
  60. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", ".")
  61. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  62. if err != nil || exitCode != 0 {
  63. t.Fatal("failed to build the image")
  64. }
  65. deleteImages("testaddimg")
  66. logDone("build - add single file to root")
  67. }
  68. // Issue #3960: "ADD src ." hangs
  69. func TestAddSingleFileToWorkdir(t *testing.T) {
  70. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd", "SingleFileToWorkdir")
  71. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  72. if err != nil {
  73. t.Fatal(err)
  74. }
  75. f.Close()
  76. buildCmd := exec.Command(dockerBinary, "build", "-t", "testaddimg", ".")
  77. buildCmd.Dir = buildDirectory
  78. done := make(chan error)
  79. go func() {
  80. out, exitCode, err := runCommandWithOutput(buildCmd)
  81. if err != nil || exitCode != 0 {
  82. done <- fmt.Errorf("build failed to complete: %s %v", out, err)
  83. return
  84. }
  85. done <- nil
  86. }()
  87. select {
  88. case <-time.After(5 * time.Second):
  89. if err := buildCmd.Process.Kill(); err != nil {
  90. fmt.Printf("could not kill build (pid=%d): %v\n", buildCmd.Process.Pid, err)
  91. }
  92. t.Fatal("build timed out")
  93. case err := <-done:
  94. if err != nil {
  95. t.Fatal(err)
  96. }
  97. }
  98. deleteImages("testaddimg")
  99. logDone("build - add single file to workdir")
  100. }
  101. func TestAddSingleFileToExistDir(t *testing.T) {
  102. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
  103. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "SingleFileToExistDir")
  104. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  105. if err != nil || exitCode != 0 {
  106. t.Fatal("failed to build the image")
  107. }
  108. deleteImages("testaddimg")
  109. logDone("build - add single file to existing dir")
  110. }
  111. func TestAddSingleFileToNonExistDir(t *testing.T) {
  112. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
  113. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "SingleFileToNonExistDir")
  114. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  115. if err != nil || exitCode != 0 {
  116. t.Fatal("failed to build the image")
  117. }
  118. deleteImages("testaddimg")
  119. logDone("build - add single file to non-existing dir")
  120. }
  121. func TestAddDirContentToRoot(t *testing.T) {
  122. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
  123. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "DirContentToRoot")
  124. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  125. if err != nil || exitCode != 0 {
  126. t.Fatal("failed to build the image")
  127. }
  128. deleteImages("testaddimg")
  129. logDone("build - add directory contents to root")
  130. }
  131. func TestAddDirContentToExistDir(t *testing.T) {
  132. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
  133. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "DirContentToExistDir")
  134. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  135. if err != nil || exitCode != 0 {
  136. t.Fatal("failed to build the image")
  137. }
  138. deleteImages("testaddimg")
  139. logDone("build - add directory contents to existing dir")
  140. }
  141. func TestAddWholeDirToRoot(t *testing.T) {
  142. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd", "WholeDirToRoot")
  143. test_dir := filepath.Join(buildDirectory, "test_dir")
  144. if err := os.MkdirAll(test_dir, 0755); err != nil {
  145. t.Fatal(err)
  146. }
  147. f, err := os.OpenFile(filepath.Join(test_dir, "test_file"), os.O_CREATE, 0644)
  148. if err != nil {
  149. t.Fatal(err)
  150. }
  151. f.Close()
  152. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", ".")
  153. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  154. if err != nil || exitCode != 0 {
  155. t.Fatal("failed to build the image")
  156. }
  157. deleteImages("testaddimg")
  158. logDone("build - add whole directory to root")
  159. }
  160. func TestAddEtcToRoot(t *testing.T) {
  161. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
  162. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "EtcToRoot")
  163. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  164. if err != nil || exitCode != 0 {
  165. t.Fatal("failed to build the image")
  166. }
  167. deleteImages("testaddimg")
  168. logDone("build - add etc directory to root")
  169. }
  170. func TestCopySingleFileToRoot(t *testing.T) {
  171. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", "SingleFileToRoot")
  172. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  173. if err != nil {
  174. t.Fatal(err)
  175. }
  176. f.Close()
  177. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", ".")
  178. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  179. if err != nil || exitCode != 0 {
  180. t.Fatal("failed to build the image")
  181. }
  182. deleteImages("testcopyimg")
  183. logDone("build - copy single file to root")
  184. }
  185. // Issue #3960: "ADD src ." hangs - adapted for COPY
  186. func TestCopySingleFileToWorkdir(t *testing.T) {
  187. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", "SingleFileToWorkdir")
  188. f, err := os.OpenFile(filepath.Join(buildDirectory, "test_file"), os.O_CREATE, 0644)
  189. if err != nil {
  190. t.Fatal(err)
  191. }
  192. f.Close()
  193. buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", ".")
  194. buildCmd.Dir = buildDirectory
  195. done := make(chan error)
  196. go func() {
  197. out, exitCode, err := runCommandWithOutput(buildCmd)
  198. if err != nil || exitCode != 0 {
  199. done <- fmt.Errorf("build failed to complete: %s %v", out, err)
  200. return
  201. }
  202. done <- nil
  203. }()
  204. select {
  205. case <-time.After(5 * time.Second):
  206. if err := buildCmd.Process.Kill(); err != nil {
  207. fmt.Printf("could not kill build (pid=%d): %v\n", buildCmd.Process.Pid, err)
  208. }
  209. t.Fatal("build timed out")
  210. case err := <-done:
  211. if err != nil {
  212. t.Fatal(err)
  213. }
  214. }
  215. deleteImages("testcopyimg")
  216. logDone("build - copy single file to workdir")
  217. }
  218. func TestCopySingleFileToExistDir(t *testing.T) {
  219. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  220. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "SingleFileToExistDir")
  221. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  222. if err != nil || exitCode != 0 {
  223. t.Fatal("failed to build the image")
  224. }
  225. deleteImages("testcopyimg")
  226. logDone("build - add single file to existing dir")
  227. }
  228. func TestCopySingleFileToNonExistDir(t *testing.T) {
  229. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  230. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "SingleFileToNonExistDir")
  231. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  232. if err != nil || exitCode != 0 {
  233. t.Fatal("failed to build the image")
  234. }
  235. deleteImages("testcopyimg")
  236. logDone("build - copy single file to non-existing dir")
  237. }
  238. func TestCopyDirContentToRoot(t *testing.T) {
  239. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  240. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "DirContentToRoot")
  241. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  242. if err != nil || exitCode != 0 {
  243. t.Fatal("failed to build the image")
  244. }
  245. deleteImages("testcopyimg")
  246. logDone("build - copy directory contents to root")
  247. }
  248. func TestCopyDirContentToExistDir(t *testing.T) {
  249. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  250. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "DirContentToExistDir")
  251. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  252. if err != nil || exitCode != 0 {
  253. t.Fatal("failed to build the image")
  254. }
  255. deleteImages("testcopyimg")
  256. logDone("build - copy directory contents to existing dir")
  257. }
  258. func TestCopyWholeDirToRoot(t *testing.T) {
  259. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy", "WholeDirToRoot")
  260. test_dir := filepath.Join(buildDirectory, "test_dir")
  261. if err := os.MkdirAll(test_dir, 0755); err != nil {
  262. t.Fatal(err)
  263. }
  264. f, err := os.OpenFile(filepath.Join(test_dir, "test_file"), os.O_CREATE, 0644)
  265. if err != nil {
  266. t.Fatal(err)
  267. }
  268. f.Close()
  269. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", ".")
  270. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  271. if err != nil || exitCode != 0 {
  272. t.Fatal("failed to build the image")
  273. }
  274. deleteImages("testcopyimg")
  275. logDone("build - copy whole directory to root")
  276. }
  277. func TestCopyEtcToRoot(t *testing.T) {
  278. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  279. out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "EtcToRoot")
  280. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
  281. if err != nil || exitCode != 0 {
  282. t.Fatal("failed to build the image")
  283. }
  284. deleteImages("testcopyimg")
  285. logDone("build - copy etc directory to root")
  286. }
  287. func TestCopyDisallowRemote(t *testing.T) {
  288. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
  289. buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", "DisallowRemote")
  290. buildCmd.Dir = buildDirectory
  291. out, exitCode, err := runCommandWithOutput(buildCmd)
  292. if err == nil || exitCode == 0 {
  293. t.Fatalf("building the image should've failed; output: %s", out)
  294. }
  295. deleteImages("testcopyimg")
  296. logDone("build - copy - disallow copy from remote")
  297. }
  298. // Issue #5270 - ensure we throw a better error than "unexpected EOF"
  299. // when we can't access files in the context.
  300. func TestBuildWithInaccessibleFilesInContext(t *testing.T) {
  301. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildWithInaccessibleFilesInContext")
  302. {
  303. // This is used to ensure we detect inaccessible files early during build in the cli client
  304. pathToInaccessibleFileBuildDirectory := filepath.Join(buildDirectory, "inaccessiblefile")
  305. pathToFileWithoutReadAccess := filepath.Join(pathToInaccessibleFileBuildDirectory, "fileWithoutReadAccess")
  306. err := os.Chown(pathToFileWithoutReadAccess, 0, 0)
  307. errorOut(err, t, fmt.Sprintf("failed to chown file to root: %s", err))
  308. err = os.Chmod(pathToFileWithoutReadAccess, 0700)
  309. errorOut(err, t, fmt.Sprintf("failed to chmod file to 700: %s", err))
  310. buildCommandStatement := fmt.Sprintf("%s build -t inaccessiblefiles .", dockerBinary)
  311. buildCmd := exec.Command("su", "unprivilegeduser", "-c", buildCommandStatement)
  312. buildCmd.Dir = pathToInaccessibleFileBuildDirectory
  313. out, exitCode, err := runCommandWithOutput(buildCmd)
  314. if err == nil || exitCode == 0 {
  315. t.Fatalf("build should have failed: %s %s", err, out)
  316. }
  317. // check if we've detected the failure before we started building
  318. if !strings.Contains(out, "no permission to read from ") {
  319. t.Fatalf("output should've contained the string: no permission to read from but contained: %s", out)
  320. }
  321. if !strings.Contains(out, "Error checking context is accessible") {
  322. t.Fatalf("output should've contained the string: Error checking context is accessible")
  323. }
  324. }
  325. {
  326. // This is used to ensure we detect inaccessible directories early during build in the cli client
  327. pathToInaccessibleDirectoryBuildDirectory := filepath.Join(buildDirectory, "inaccessibledirectory")
  328. pathToDirectoryWithoutReadAccess := filepath.Join(pathToInaccessibleDirectoryBuildDirectory, "directoryWeCantStat")
  329. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  330. err := os.Chown(pathToDirectoryWithoutReadAccess, 0, 0)
  331. errorOut(err, t, fmt.Sprintf("failed to chown directory to root: %s", err))
  332. err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444)
  333. errorOut(err, t, fmt.Sprintf("failed to chmod directory to 755: %s", err))
  334. err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700)
  335. errorOut(err, t, fmt.Sprintf("failed to chmod file to 444: %s", err))
  336. buildCommandStatement := fmt.Sprintf("%s build -t inaccessiblefiles .", dockerBinary)
  337. buildCmd := exec.Command("su", "unprivilegeduser", "-c", buildCommandStatement)
  338. buildCmd.Dir = pathToInaccessibleDirectoryBuildDirectory
  339. out, exitCode, err := runCommandWithOutput(buildCmd)
  340. if err == nil || exitCode == 0 {
  341. t.Fatalf("build should have failed: %s %s", err, out)
  342. }
  343. // check if we've detected the failure before we started building
  344. if !strings.Contains(out, "can't stat") {
  345. t.Fatalf("output should've contained the string: can't access %s", out)
  346. }
  347. if !strings.Contains(out, "Error checking context is accessible") {
  348. t.Fatalf("output should've contained the string: Error checking context is accessible")
  349. }
  350. }
  351. {
  352. // This is used to ensure we don't follow links when checking if everything in the context is accessible
  353. // This test doesn't require that we run commands as an unprivileged user
  354. pathToDirectoryWhichContainsLinks := filepath.Join(buildDirectory, "linksdirectory")
  355. out, exitCode, err := dockerCmdInDir(t, pathToDirectoryWhichContainsLinks, "build", "-t", "testlinksok", ".")
  356. if err != nil || exitCode != 0 {
  357. t.Fatalf("build should have worked: %s %s", err, out)
  358. }
  359. deleteImages("testlinksok")
  360. }
  361. {
  362. // This is used to ensure we don't try to add inaccessible files when they are ignored by a .dockerignore pattern
  363. pathToInaccessibleDirectoryBuildDirectory := filepath.Join(buildDirectory, "ignoredinaccessible")
  364. pathToDirectoryWithoutReadAccess := filepath.Join(pathToInaccessibleDirectoryBuildDirectory, "directoryWeCantStat")
  365. pathToFileInDirectoryWithoutReadAccess := filepath.Join(pathToDirectoryWithoutReadAccess, "bar")
  366. err := os.Chown(pathToDirectoryWithoutReadAccess, 0, 0)
  367. errorOut(err, t, fmt.Sprintf("failed to chown directory to root: %s", err))
  368. err = os.Chmod(pathToDirectoryWithoutReadAccess, 0444)
  369. errorOut(err, t, fmt.Sprintf("failed to chmod directory to 755: %s", err))
  370. err = os.Chmod(pathToFileInDirectoryWithoutReadAccess, 0700)
  371. errorOut(err, t, fmt.Sprintf("failed to chmod file to 444: %s", err))
  372. buildCommandStatement := fmt.Sprintf("%s build -t ignoredinaccessible .", dockerBinary)
  373. buildCmd := exec.Command("su", "unprivilegeduser", "-c", buildCommandStatement)
  374. buildCmd.Dir = pathToInaccessibleDirectoryBuildDirectory
  375. out, exitCode, err := runCommandWithOutput(buildCmd)
  376. if err != nil || exitCode != 0 {
  377. t.Fatalf("build should have worked: %s %s", err, out)
  378. }
  379. deleteImages("ignoredinaccessible")
  380. }
  381. deleteImages("inaccessiblefiles")
  382. logDone("build - ADD from context with inaccessible files must fail")
  383. logDone("build - ADD from context with accessible links must work")
  384. logDone("build - ADD from context with ignored inaccessible files must work")
  385. }
  386. func TestBuildForceRm(t *testing.T) {
  387. containerCountBefore, err := getContainerCount()
  388. if err != nil {
  389. t.Fatalf("failed to get the container count: %s", err)
  390. }
  391. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildForceRm")
  392. buildCmd := exec.Command(dockerBinary, "build", "--force-rm", ".")
  393. buildCmd.Dir = buildDirectory
  394. _, exitCode, err := runCommandWithOutput(buildCmd)
  395. if err == nil || exitCode == 0 {
  396. t.Fatal("failed to build the image")
  397. }
  398. containerCountAfter, err := getContainerCount()
  399. if err != nil {
  400. t.Fatalf("failed to get the container count: %s", err)
  401. }
  402. if containerCountBefore != containerCountAfter {
  403. t.Fatalf("--force-rm shouldn't have left containers behind")
  404. }
  405. logDone("build - ensure --force-rm doesn't leave containers behind")
  406. }
  407. func TestBuildRm(t *testing.T) {
  408. {
  409. containerCountBefore, err := getContainerCount()
  410. if err != nil {
  411. t.Fatalf("failed to get the container count: %s", err)
  412. }
  413. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm")
  414. _, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "--rm", "-t", "testbuildrm", ".")
  415. if err != nil || exitCode != 0 {
  416. t.Fatal("failed to build the image")
  417. }
  418. containerCountAfter, err := getContainerCount()
  419. if err != nil {
  420. t.Fatalf("failed to get the container count: %s", err)
  421. }
  422. if containerCountBefore != containerCountAfter {
  423. t.Fatalf("-rm shouldn't have left containers behind")
  424. }
  425. deleteImages("testbuildrm")
  426. }
  427. {
  428. containerCountBefore, err := getContainerCount()
  429. if err != nil {
  430. t.Fatalf("failed to get the container count: %s", err)
  431. }
  432. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm")
  433. _, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testbuildrm", ".")
  434. if err != nil || exitCode != 0 {
  435. t.Fatal("failed to build the image")
  436. }
  437. containerCountAfter, err := getContainerCount()
  438. if err != nil {
  439. t.Fatalf("failed to get the container count: %s", err)
  440. }
  441. if containerCountBefore != containerCountAfter {
  442. t.Fatalf("--rm shouldn't have left containers behind")
  443. }
  444. deleteImages("testbuildrm")
  445. }
  446. {
  447. containerCountBefore, err := getContainerCount()
  448. if err != nil {
  449. t.Fatalf("failed to get the container count: %s", err)
  450. }
  451. buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm")
  452. _, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "--rm=false", "-t", "testbuildrm", ".")
  453. if err != nil || exitCode != 0 {
  454. t.Fatal("failed to build the image")
  455. }
  456. containerCountAfter, err := getContainerCount()
  457. if err != nil {
  458. t.Fatalf("failed to get the container count: %s", err)
  459. }
  460. if containerCountBefore == containerCountAfter {
  461. t.Fatalf("--rm=false should have left containers behind")
  462. }
  463. deleteAllContainers()
  464. deleteImages("testbuildrm")
  465. }
  466. logDone("build - ensure --rm doesn't leave containers behind and that --rm=true is the default")
  467. logDone("build - ensure --rm=false overrides the default")
  468. }
  469. func TestBuildWithVolumes(t *testing.T) {
  470. var (
  471. result map[string]map[string]struct{}
  472. name = "testbuildvolumes"
  473. emptyMap = make(map[string]struct{})
  474. expected = map[string]map[string]struct{}{"/test1": emptyMap, "/test2": emptyMap}
  475. )
  476. defer deleteImages(name)
  477. _, err := buildImage(name,
  478. `FROM scratch
  479. VOLUME /test1
  480. VOLUME /test2`,
  481. true)
  482. if err != nil {
  483. t.Fatal(err)
  484. }
  485. res, err := inspectFieldJSON(name, "Config.Volumes")
  486. if err != nil {
  487. t.Fatal(err)
  488. }
  489. err = unmarshalJSON([]byte(res), &result)
  490. if err != nil {
  491. t.Fatal(err)
  492. }
  493. equal := deepEqual(&expected, &result)
  494. if !equal {
  495. t.Fatalf("Volumes %s, expected %s", result, expected)
  496. }
  497. logDone("build - with volumes")
  498. }
  499. func TestBuildMaintainer(t *testing.T) {
  500. name := "testbuildmaintainer"
  501. expected := "dockerio"
  502. defer deleteImages(name)
  503. _, err := buildImage(name,
  504. `FROM scratch
  505. MAINTAINER dockerio`,
  506. true)
  507. if err != nil {
  508. t.Fatal(err)
  509. }
  510. res, err := inspectField(name, "Author")
  511. if err != nil {
  512. t.Fatal(err)
  513. }
  514. if res != expected {
  515. t.Fatalf("Maintainer %s, expected %s", res, expected)
  516. }
  517. logDone("build - maintainer")
  518. }
  519. func TestBuildUser(t *testing.T) {
  520. name := "testbuilduser"
  521. expected := "dockerio"
  522. defer deleteImages(name)
  523. _, err := buildImage(name,
  524. `FROM busybox
  525. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  526. USER dockerio
  527. RUN [ $(whoami) = 'dockerio' ]`,
  528. true)
  529. if err != nil {
  530. t.Fatal(err)
  531. }
  532. res, err := inspectField(name, "Config.User")
  533. if err != nil {
  534. t.Fatal(err)
  535. }
  536. if res != expected {
  537. t.Fatalf("User %s, expected %s", res, expected)
  538. }
  539. logDone("build - user")
  540. }
  541. func TestBuildRelativeWorkdir(t *testing.T) {
  542. name := "testbuildrelativeworkdir"
  543. expected := "/test2/test3"
  544. defer deleteImages(name)
  545. _, err := buildImage(name,
  546. `FROM busybox
  547. RUN [ "$PWD" = '/' ]
  548. WORKDIR test1
  549. RUN [ "$PWD" = '/test1' ]
  550. WORKDIR /test2
  551. RUN [ "$PWD" = '/test2' ]
  552. WORKDIR test3
  553. RUN [ "$PWD" = '/test2/test3' ]`,
  554. true)
  555. if err != nil {
  556. t.Fatal(err)
  557. }
  558. res, err := inspectField(name, "Config.WorkingDir")
  559. if err != nil {
  560. t.Fatal(err)
  561. }
  562. if res != expected {
  563. t.Fatalf("Workdir %s, expected %s", res, expected)
  564. }
  565. logDone("build - relative workdir")
  566. }
  567. func TestBuildEnv(t *testing.T) {
  568. name := "testbuildenv"
  569. expected := "[PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PORT=2375]"
  570. defer deleteImages(name)
  571. _, err := buildImage(name,
  572. `FROM busybox
  573. ENV PORT 2375
  574. RUN [ $(env | grep PORT) = 'PORT=2375' ]`,
  575. true)
  576. if err != nil {
  577. t.Fatal(err)
  578. }
  579. res, err := inspectField(name, "Config.Env")
  580. if err != nil {
  581. t.Fatal(err)
  582. }
  583. if res != expected {
  584. t.Fatalf("Env %s, expected %s", res, expected)
  585. }
  586. logDone("build - env")
  587. }
  588. func TestBuildCmd(t *testing.T) {
  589. name := "testbuildcmd"
  590. expected := "[/bin/echo Hello World]"
  591. defer deleteImages(name)
  592. _, err := buildImage(name,
  593. `FROM scratch
  594. CMD ["/bin/echo", "Hello World"]`,
  595. true)
  596. if err != nil {
  597. t.Fatal(err)
  598. }
  599. res, err := inspectField(name, "Config.Cmd")
  600. if err != nil {
  601. t.Fatal(err)
  602. }
  603. if res != expected {
  604. t.Fatalf("Cmd %s, expected %s", res, expected)
  605. }
  606. logDone("build - cmd")
  607. }
  608. func TestBuildExpose(t *testing.T) {
  609. name := "testbuildexpose"
  610. expected := "map[2375/tcp:map[]]"
  611. defer deleteImages(name)
  612. _, err := buildImage(name,
  613. `FROM scratch
  614. EXPOSE 2375`,
  615. true)
  616. if err != nil {
  617. t.Fatal(err)
  618. }
  619. res, err := inspectField(name, "Config.ExposedPorts")
  620. if err != nil {
  621. t.Fatal(err)
  622. }
  623. if res != expected {
  624. t.Fatalf("Exposed ports %s, expected %s", res, expected)
  625. }
  626. logDone("build - expose")
  627. }
  628. func TestBuildEntrypoint(t *testing.T) {
  629. name := "testbuildentrypoint"
  630. expected := "[/bin/echo]"
  631. defer deleteImages(name)
  632. _, err := buildImage(name,
  633. `FROM scratch
  634. ENTRYPOINT ["/bin/echo"]`,
  635. true)
  636. if err != nil {
  637. t.Fatal(err)
  638. }
  639. res, err := inspectField(name, "Config.Entrypoint")
  640. if err != nil {
  641. t.Fatal(err)
  642. }
  643. if res != expected {
  644. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  645. }
  646. logDone("build - entrypoint")
  647. }
  648. // #6445 ensure ONBUILD triggers aren't committed to grandchildren
  649. func TestBuildOnBuildLimitedInheritence(t *testing.T) {
  650. var (
  651. out2, out3 string
  652. )
  653. {
  654. name1 := "testonbuildtrigger1"
  655. dockerfile1 := `
  656. FROM busybox
  657. RUN echo "GRANDPARENT"
  658. ONBUILD RUN echo "ONBUILD PARENT"
  659. `
  660. ctx, err := fakeContext(dockerfile1, nil)
  661. if err != nil {
  662. t.Fatal(err)
  663. }
  664. out1, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name1, ".")
  665. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out1, err))
  666. defer deleteImages(name1)
  667. }
  668. {
  669. name2 := "testonbuildtrigger2"
  670. dockerfile2 := `
  671. FROM testonbuildtrigger1
  672. `
  673. ctx, err := fakeContext(dockerfile2, nil)
  674. if err != nil {
  675. t.Fatal(err)
  676. }
  677. out2, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name2, ".")
  678. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out2, err))
  679. defer deleteImages(name2)
  680. }
  681. {
  682. name3 := "testonbuildtrigger3"
  683. dockerfile3 := `
  684. FROM testonbuildtrigger2
  685. `
  686. ctx, err := fakeContext(dockerfile3, nil)
  687. if err != nil {
  688. t.Fatal(err)
  689. }
  690. out3, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name3, ".")
  691. errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out3, err))
  692. defer deleteImages(name3)
  693. }
  694. // ONBUILD should be run in second build.
  695. if !strings.Contains(out2, "ONBUILD PARENT") {
  696. t.Fatalf("ONBUILD instruction did not run in child of ONBUILD parent")
  697. }
  698. // ONBUILD should *not* be run in third build.
  699. if strings.Contains(out3, "ONBUILD PARENT") {
  700. t.Fatalf("ONBUILD instruction ran in grandchild of ONBUILD parent")
  701. }
  702. logDone("build - onbuild")
  703. }
  704. func TestBuildWithCache(t *testing.T) {
  705. name := "testbuildwithcache"
  706. defer deleteImages(name)
  707. id1, err := buildImage(name,
  708. `FROM scratch
  709. MAINTAINER dockerio
  710. EXPOSE 5432
  711. ENTRYPOINT ["/bin/echo"]`,
  712. true)
  713. if err != nil {
  714. t.Fatal(err)
  715. }
  716. id2, err := buildImage(name,
  717. `FROM scratch
  718. MAINTAINER dockerio
  719. EXPOSE 5432
  720. ENTRYPOINT ["/bin/echo"]`,
  721. true)
  722. if err != nil {
  723. t.Fatal(err)
  724. }
  725. if id1 != id2 {
  726. t.Fatal("The cache should have been used but hasn't.")
  727. }
  728. logDone("build - with cache")
  729. }
  730. func TestBuildWithoutCache(t *testing.T) {
  731. name := "testbuildwithoutcache"
  732. defer deleteImages(name)
  733. id1, err := buildImage(name,
  734. `FROM scratch
  735. MAINTAINER dockerio
  736. EXPOSE 5432
  737. ENTRYPOINT ["/bin/echo"]`,
  738. true)
  739. if err != nil {
  740. t.Fatal(err)
  741. }
  742. id2, err := buildImage(name,
  743. `FROM scratch
  744. MAINTAINER dockerio
  745. EXPOSE 5432
  746. ENTRYPOINT ["/bin/echo"]`,
  747. false)
  748. if err != nil {
  749. t.Fatal(err)
  750. }
  751. if id1 == id2 {
  752. t.Fatal("The cache should have been invalided but hasn't.")
  753. }
  754. logDone("build - without cache")
  755. }
  756. func TestBuildADDLocalFileWithCache(t *testing.T) {
  757. name := "testbuildaddlocalfilewithcache"
  758. defer deleteImages(name)
  759. dockerfile := `
  760. FROM busybox
  761. MAINTAINER dockerio
  762. ADD foo /usr/lib/bla/bar
  763. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  764. ctx, err := fakeContext(dockerfile, map[string]string{
  765. "foo": "hello",
  766. })
  767. defer ctx.Close()
  768. if err != nil {
  769. t.Fatal(err)
  770. }
  771. id1, err := buildImageFromContext(name, ctx, true)
  772. if err != nil {
  773. t.Fatal(err)
  774. }
  775. id2, err := buildImageFromContext(name, ctx, true)
  776. if err != nil {
  777. t.Fatal(err)
  778. }
  779. if id1 != id2 {
  780. t.Fatal("The cache should have been used but hasn't.")
  781. }
  782. logDone("build - add local file with cache")
  783. }
  784. func TestBuildADDLocalFileWithoutCache(t *testing.T) {
  785. name := "testbuildaddlocalfilewithoutcache"
  786. defer deleteImages(name)
  787. dockerfile := `
  788. FROM busybox
  789. MAINTAINER dockerio
  790. ADD foo /usr/lib/bla/bar
  791. RUN [ "$(cat /usr/lib/bla/bar)" = "hello" ]`
  792. ctx, err := fakeContext(dockerfile, map[string]string{
  793. "foo": "hello",
  794. })
  795. defer ctx.Close()
  796. if err != nil {
  797. t.Fatal(err)
  798. }
  799. id1, err := buildImageFromContext(name, ctx, true)
  800. if err != nil {
  801. t.Fatal(err)
  802. }
  803. id2, err := buildImageFromContext(name, ctx, false)
  804. if err != nil {
  805. t.Fatal(err)
  806. }
  807. if id1 == id2 {
  808. t.Fatal("The cache should have been invalided but hasn't.")
  809. }
  810. logDone("build - add local file without cache")
  811. }
  812. func TestBuildADDCurrentDirWithCache(t *testing.T) {
  813. name := "testbuildaddcurrentdirwithcache"
  814. defer deleteImages(name)
  815. dockerfile := `
  816. FROM scratch
  817. MAINTAINER dockerio
  818. ADD . /usr/lib/bla`
  819. ctx, err := fakeContext(dockerfile, map[string]string{
  820. "foo": "hello",
  821. })
  822. defer ctx.Close()
  823. if err != nil {
  824. t.Fatal(err)
  825. }
  826. id1, err := buildImageFromContext(name, ctx, true)
  827. if err != nil {
  828. t.Fatal(err)
  829. }
  830. // Check that adding file invalidate cache of "ADD ."
  831. if err := ctx.Add("bar", "hello2"); err != nil {
  832. t.Fatal(err)
  833. }
  834. id2, err := buildImageFromContext(name, ctx, true)
  835. if err != nil {
  836. t.Fatal(err)
  837. }
  838. if id1 == id2 {
  839. t.Fatal("The cache should have been invalided but hasn't.")
  840. }
  841. // Check that changing file invalidate cache of "ADD ."
  842. if err := ctx.Add("foo", "hello1"); err != nil {
  843. t.Fatal(err)
  844. }
  845. id3, err := buildImageFromContext(name, ctx, true)
  846. if err != nil {
  847. t.Fatal(err)
  848. }
  849. if id2 == id3 {
  850. t.Fatal("The cache should have been invalided but hasn't.")
  851. }
  852. // Check that changing file to same content invalidate cache of "ADD ."
  853. time.Sleep(1 * time.Second) // wait second because of mtime precision
  854. if err := ctx.Add("foo", "hello1"); err != nil {
  855. t.Fatal(err)
  856. }
  857. id4, err := buildImageFromContext(name, ctx, true)
  858. if err != nil {
  859. t.Fatal(err)
  860. }
  861. if id3 == id4 {
  862. t.Fatal("The cache should have been invalided but hasn't.")
  863. }
  864. id5, err := buildImageFromContext(name, ctx, true)
  865. if err != nil {
  866. t.Fatal(err)
  867. }
  868. if id4 != id5 {
  869. t.Fatal("The cache should have been used but hasn't.")
  870. }
  871. logDone("build - add current directory with cache")
  872. }
  873. func TestBuildADDCurrentDirWithoutCache(t *testing.T) {
  874. name := "testbuildaddcurrentdirwithoutcache"
  875. defer deleteImages(name)
  876. dockerfile := `
  877. FROM scratch
  878. MAINTAINER dockerio
  879. ADD . /usr/lib/bla`
  880. ctx, err := fakeContext(dockerfile, map[string]string{
  881. "foo": "hello",
  882. })
  883. defer ctx.Close()
  884. if err != nil {
  885. t.Fatal(err)
  886. }
  887. id1, err := buildImageFromContext(name, ctx, true)
  888. if err != nil {
  889. t.Fatal(err)
  890. }
  891. id2, err := buildImageFromContext(name, ctx, false)
  892. if err != nil {
  893. t.Fatal(err)
  894. }
  895. if id1 == id2 {
  896. t.Fatal("The cache should have been invalided but hasn't.")
  897. }
  898. logDone("build - add current directory without cache")
  899. }
  900. func TestBuildADDRemoteFileWithCache(t *testing.T) {
  901. name := "testbuildaddremotefilewithcache"
  902. defer deleteImages(name)
  903. server, err := fakeStorage(map[string]string{
  904. "baz": "hello",
  905. })
  906. if err != nil {
  907. t.Fatal(err)
  908. }
  909. defer server.Close()
  910. id1, err := buildImage(name,
  911. fmt.Sprintf(`FROM scratch
  912. MAINTAINER dockerio
  913. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  914. true)
  915. if err != nil {
  916. t.Fatal(err)
  917. }
  918. id2, err := buildImage(name,
  919. fmt.Sprintf(`FROM scratch
  920. MAINTAINER dockerio
  921. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  922. true)
  923. if err != nil {
  924. t.Fatal(err)
  925. }
  926. if id1 != id2 {
  927. t.Fatal("The cache should have been used but hasn't.")
  928. }
  929. logDone("build - add remote file with cache")
  930. }
  931. func TestBuildADDRemoteFileWithoutCache(t *testing.T) {
  932. name := "testbuildaddremotefilewithoutcache"
  933. defer deleteImages(name)
  934. server, err := fakeStorage(map[string]string{
  935. "baz": "hello",
  936. })
  937. if err != nil {
  938. t.Fatal(err)
  939. }
  940. defer server.Close()
  941. id1, err := buildImage(name,
  942. fmt.Sprintf(`FROM scratch
  943. MAINTAINER dockerio
  944. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  945. true)
  946. if err != nil {
  947. t.Fatal(err)
  948. }
  949. id2, err := buildImage(name,
  950. fmt.Sprintf(`FROM scratch
  951. MAINTAINER dockerio
  952. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  953. false)
  954. if err != nil {
  955. t.Fatal(err)
  956. }
  957. if id1 == id2 {
  958. t.Fatal("The cache should have been invalided but hasn't.")
  959. }
  960. logDone("build - add remote file without cache")
  961. }
  962. func TestBuildADDLocalAndRemoteFilesWithCache(t *testing.T) {
  963. name := "testbuildaddlocalandremotefilewithcache"
  964. defer deleteImages(name)
  965. server, err := fakeStorage(map[string]string{
  966. "baz": "hello",
  967. })
  968. if err != nil {
  969. t.Fatal(err)
  970. }
  971. defer server.Close()
  972. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  973. MAINTAINER dockerio
  974. ADD foo /usr/lib/bla/bar
  975. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  976. map[string]string{
  977. "foo": "hello world",
  978. })
  979. if err != nil {
  980. t.Fatal(err)
  981. }
  982. defer ctx.Close()
  983. id1, err := buildImageFromContext(name, ctx, true)
  984. if err != nil {
  985. t.Fatal(err)
  986. }
  987. id2, err := buildImageFromContext(name, ctx, true)
  988. if err != nil {
  989. t.Fatal(err)
  990. }
  991. if id1 != id2 {
  992. t.Fatal("The cache should have been used but hasn't.")
  993. }
  994. logDone("build - add local and remote file with cache")
  995. }
  996. func testContextTar(t *testing.T, compression archive.Compression) {
  997. contextDirectory := filepath.Join(workingDirectory, "build_tests", "TestContextTar")
  998. context, err := archive.Tar(contextDirectory, compression)
  999. if err != nil {
  1000. t.Fatalf("failed to build context tar: %v", err)
  1001. }
  1002. buildCmd := exec.Command(dockerBinary, "build", "-t", "contexttar", "-")
  1003. buildCmd.Stdin = context
  1004. out, exitCode, err := runCommandWithOutput(buildCmd)
  1005. if err != nil || exitCode != 0 {
  1006. t.Fatalf("build failed to complete: %v %v", out, err)
  1007. }
  1008. deleteImages("contexttar")
  1009. logDone(fmt.Sprintf("build - build an image with a context tar, compression: %v", compression))
  1010. }
  1011. func TestContextTarGzip(t *testing.T) {
  1012. testContextTar(t, archive.Gzip)
  1013. }
  1014. func TestContextTarNoCompression(t *testing.T) {
  1015. testContextTar(t, archive.Uncompressed)
  1016. }
  1017. func TestNoContext(t *testing.T) {
  1018. buildCmd := exec.Command(dockerBinary, "build", "-t", "nocontext", "-")
  1019. buildCmd.Stdin = strings.NewReader("FROM busybox\nCMD echo ok\n")
  1020. out, exitCode, err := runCommandWithOutput(buildCmd)
  1021. if err != nil || exitCode != 0 {
  1022. t.Fatalf("build failed to complete: %v %v", out, err)
  1023. }
  1024. out, exitCode, err = cmd(t, "run", "nocontext")
  1025. if out != "ok\n" {
  1026. t.Fatalf("run produced invalid output: %q, expected %q", out, "ok")
  1027. }
  1028. deleteImages("nocontext")
  1029. logDone("build - build an image with no context")
  1030. }
  1031. // TODO: TestCaching
  1032. func TestBuildADDLocalAndRemoteFilesWithoutCache(t *testing.T) {
  1033. name := "testbuildaddlocalandremotefilewithoutcache"
  1034. defer deleteImages(name)
  1035. server, err := fakeStorage(map[string]string{
  1036. "baz": "hello",
  1037. })
  1038. if err != nil {
  1039. t.Fatal(err)
  1040. }
  1041. defer server.Close()
  1042. ctx, err := fakeContext(fmt.Sprintf(`FROM scratch
  1043. MAINTAINER dockerio
  1044. ADD foo /usr/lib/bla/bar
  1045. ADD %s/baz /usr/lib/baz/quux`, server.URL),
  1046. map[string]string{
  1047. "foo": "hello world",
  1048. })
  1049. if err != nil {
  1050. t.Fatal(err)
  1051. }
  1052. defer ctx.Close()
  1053. id1, err := buildImageFromContext(name, ctx, true)
  1054. if err != nil {
  1055. t.Fatal(err)
  1056. }
  1057. id2, err := buildImageFromContext(name, ctx, false)
  1058. if err != nil {
  1059. t.Fatal(err)
  1060. }
  1061. if id1 == id2 {
  1062. t.Fatal("The cache should have been invalided but hasn't.")
  1063. }
  1064. logDone("build - add local and remote file without cache")
  1065. }
  1066. func TestBuildWithVolumeOwnership(t *testing.T) {
  1067. name := "testbuildimg"
  1068. defer deleteImages(name)
  1069. _, err := buildImage(name,
  1070. `FROM busybox:latest
  1071. RUN mkdir /test && chown daemon:daemon /test && chmod 0600 /test
  1072. VOLUME /test`,
  1073. true)
  1074. if err != nil {
  1075. t.Fatal(err)
  1076. }
  1077. cmd := exec.Command(dockerBinary, "run", "--rm", "testbuildimg", "ls", "-la", "/test")
  1078. out, _, err := runCommandWithOutput(cmd)
  1079. if err != nil {
  1080. t.Fatal(err)
  1081. }
  1082. if expected := "drw-------"; !strings.Contains(out, expected) {
  1083. t.Fatalf("expected %s received %s", expected, out)
  1084. }
  1085. if expected := "daemon daemon"; !strings.Contains(out, expected) {
  1086. t.Fatalf("expected %s received %s", expected, out)
  1087. }
  1088. logDone("build - volume ownership")
  1089. }
  1090. // testing #1405 - config.Cmd does not get cleaned up if
  1091. // utilizing cache
  1092. func TestBuildEntrypointRunCleanup(t *testing.T) {
  1093. name := "testbuildcmdcleanup"
  1094. defer deleteImages(name)
  1095. if _, err := buildImage(name,
  1096. `FROM busybox
  1097. RUN echo "hello"`,
  1098. true); err != nil {
  1099. t.Fatal(err)
  1100. }
  1101. ctx, err := fakeContext(`FROM busybox
  1102. RUN echo "hello"
  1103. ADD foo /foo
  1104. ENTRYPOINT ["/bin/echo"]`,
  1105. map[string]string{
  1106. "foo": "hello",
  1107. })
  1108. defer ctx.Close()
  1109. if err != nil {
  1110. t.Fatal(err)
  1111. }
  1112. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1113. t.Fatal(err)
  1114. }
  1115. res, err := inspectField(name, "Config.Cmd")
  1116. if err != nil {
  1117. t.Fatal(err)
  1118. }
  1119. // Cmd must be cleaned up
  1120. if expected := "<no value>"; res != expected {
  1121. t.Fatalf("Cmd %s, expected %s", res, expected)
  1122. }
  1123. logDone("build - cleanup cmd after RUN")
  1124. }
  1125. func TestBuildForbiddenContextPath(t *testing.T) {
  1126. name := "testbuildforbidpath"
  1127. defer deleteImages(name)
  1128. ctx, err := fakeContext(`FROM scratch
  1129. ADD ../../ test/
  1130. `,
  1131. map[string]string{
  1132. "test.txt": "test1",
  1133. "other.txt": "other",
  1134. })
  1135. defer ctx.Close()
  1136. if err != nil {
  1137. t.Fatal(err)
  1138. }
  1139. expected := "Forbidden path outside the build context: ../../ "
  1140. if _, err := buildImageFromContext(name, ctx, true); err == nil || !strings.Contains(err.Error(), expected) {
  1141. t.Fatalf("Wrong error: (should contain \"%s\") got:\n%v", expected, err)
  1142. }
  1143. logDone("build - forbidden context path")
  1144. }
  1145. func TestBuildADDFileNotFound(t *testing.T) {
  1146. name := "testbuildaddnotfound"
  1147. defer deleteImages(name)
  1148. ctx, err := fakeContext(`FROM scratch
  1149. ADD foo /usr/local/bar`,
  1150. map[string]string{"bar": "hello"})
  1151. defer ctx.Close()
  1152. if err != nil {
  1153. t.Fatal(err)
  1154. }
  1155. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1156. if !strings.Contains(err.Error(), "foo: no such file or directory") {
  1157. t.Fatalf("Wrong error %v, must be about missing foo file or directory", err)
  1158. }
  1159. } else {
  1160. t.Fatal("Error must not be nil")
  1161. }
  1162. logDone("build - add file not found")
  1163. }
  1164. func TestBuildInheritance(t *testing.T) {
  1165. name := "testbuildinheritance"
  1166. defer deleteImages(name)
  1167. _, err := buildImage(name,
  1168. `FROM scratch
  1169. EXPOSE 2375`,
  1170. true)
  1171. if err != nil {
  1172. t.Fatal(err)
  1173. }
  1174. ports1, err := inspectField(name, "Config.ExposedPorts")
  1175. if err != nil {
  1176. t.Fatal(err)
  1177. }
  1178. _, err = buildImage(name,
  1179. fmt.Sprintf(`FROM %s
  1180. ENTRYPOINT ["/bin/echo"]`, name),
  1181. true)
  1182. if err != nil {
  1183. t.Fatal(err)
  1184. }
  1185. res, err := inspectField(name, "Config.Entrypoint")
  1186. if err != nil {
  1187. t.Fatal(err)
  1188. }
  1189. if expected := "[/bin/echo]"; res != expected {
  1190. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1191. }
  1192. ports2, err := inspectField(name, "Config.ExposedPorts")
  1193. if err != nil {
  1194. t.Fatal(err)
  1195. }
  1196. if ports1 != ports2 {
  1197. t.Fatalf("Ports must be same: %s != %s", ports1, ports2)
  1198. }
  1199. logDone("build - inheritance")
  1200. }
  1201. func TestBuildFails(t *testing.T) {
  1202. name := "testbuildfails"
  1203. defer deleteImages(name)
  1204. _, err := buildImage(name,
  1205. `FROM busybox
  1206. RUN sh -c "exit 23"`,
  1207. true)
  1208. if err != nil {
  1209. if !strings.Contains(err.Error(), "returned a non-zero code: 23") {
  1210. t.Fatalf("Wrong error %v, must be about non-zero code 23", err)
  1211. }
  1212. } else {
  1213. t.Fatal("Error must not be nil")
  1214. }
  1215. logDone("build - fails")
  1216. }
  1217. func TestBuildFailsDockerfileEmpty(t *testing.T) {
  1218. name := "testbuildfails"
  1219. defer deleteImages(name)
  1220. _, err := buildImage(name, ``, true)
  1221. if err != nil {
  1222. if !strings.Contains(err.Error(), "Dockerfile cannot be empty") {
  1223. t.Fatalf("Wrong error %v, must be about empty Dockerfile", err)
  1224. }
  1225. } else {
  1226. t.Fatal("Error must not be nil")
  1227. }
  1228. logDone("build - fails with empty dockerfile")
  1229. }
  1230. func TestBuildOnBuild(t *testing.T) {
  1231. name := "testbuildonbuild"
  1232. defer deleteImages(name)
  1233. _, err := buildImage(name,
  1234. `FROM busybox
  1235. ONBUILD RUN touch foobar`,
  1236. true)
  1237. if err != nil {
  1238. t.Fatal(err)
  1239. }
  1240. _, err = buildImage(name,
  1241. fmt.Sprintf(`FROM %s
  1242. RUN [ -f foobar ]`, name),
  1243. true)
  1244. if err != nil {
  1245. t.Fatal(err)
  1246. }
  1247. logDone("build - onbuild")
  1248. }
  1249. func TestBuildOnBuildForbiddenChained(t *testing.T) {
  1250. name := "testbuildonbuildforbiddenchained"
  1251. defer deleteImages(name)
  1252. _, err := buildImage(name,
  1253. `FROM busybox
  1254. ONBUILD ONBUILD RUN touch foobar`,
  1255. true)
  1256. if err != nil {
  1257. if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
  1258. t.Fatalf("Wrong error %v, must be about chaining ONBUILD", err)
  1259. }
  1260. } else {
  1261. t.Fatal("Error must not be nil")
  1262. }
  1263. logDone("build - onbuild forbidden chained")
  1264. }
  1265. func TestBuildOnBuildForbiddenFrom(t *testing.T) {
  1266. name := "testbuildonbuildforbiddenfrom"
  1267. defer deleteImages(name)
  1268. _, err := buildImage(name,
  1269. `FROM busybox
  1270. ONBUILD FROM scratch`,
  1271. true)
  1272. if err != nil {
  1273. if !strings.Contains(err.Error(), "FROM isn't allowed as an ONBUILD trigger") {
  1274. t.Fatalf("Wrong error %v, must be about FROM forbidden", err)
  1275. }
  1276. } else {
  1277. t.Fatal("Error must not be nil")
  1278. }
  1279. logDone("build - onbuild forbidden from")
  1280. }
  1281. func TestBuildOnBuildForbiddenMaintainer(t *testing.T) {
  1282. name := "testbuildonbuildforbiddenmaintainer"
  1283. defer deleteImages(name)
  1284. _, err := buildImage(name,
  1285. `FROM busybox
  1286. ONBUILD MAINTAINER docker.io`,
  1287. true)
  1288. if err != nil {
  1289. if !strings.Contains(err.Error(), "MAINTAINER isn't allowed as an ONBUILD trigger") {
  1290. t.Fatalf("Wrong error %v, must be about MAINTAINER forbidden", err)
  1291. }
  1292. } else {
  1293. t.Fatal("Error must not be nil")
  1294. }
  1295. logDone("build - onbuild forbidden maintainer")
  1296. }
  1297. // gh #2446
  1298. func TestBuildAddToSymlinkDest(t *testing.T) {
  1299. name := "testbuildaddtosymlinkdest"
  1300. defer deleteImages(name)
  1301. ctx, err := fakeContext(`FROM busybox
  1302. RUN mkdir /foo
  1303. RUN ln -s /foo /bar
  1304. ADD foo /bar/
  1305. RUN [ -f /bar/foo ]
  1306. RUN [ -f /foo/foo ]`,
  1307. map[string]string{
  1308. "foo": "hello",
  1309. })
  1310. if err != nil {
  1311. t.Fatal(err)
  1312. }
  1313. defer ctx.Close()
  1314. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1315. t.Fatal(err)
  1316. }
  1317. logDone("build - add to symlink destination")
  1318. }
  1319. func TestBuildEscapeWhitespace(t *testing.T) {
  1320. name := "testbuildescaping"
  1321. defer deleteImages(name)
  1322. _, err := buildImage(name, `
  1323. FROM busybox
  1324. MAINTAINER "Docker \
  1325. IO <io@\
  1326. docker.com>"
  1327. `, true)
  1328. res, err := inspectField(name, "Author")
  1329. if err != nil {
  1330. t.Fatal(err)
  1331. }
  1332. if res != "Docker IO <io@docker.com>" {
  1333. t.Fatal("Parsed string did not match the escaped string")
  1334. }
  1335. logDone("build - validate escaping whitespace")
  1336. }
  1337. func TestDockerignore(t *testing.T) {
  1338. name := "testbuilddockerignore"
  1339. defer deleteImages(name)
  1340. dockerfile := `
  1341. FROM busybox
  1342. ADD . /bla
  1343. RUN [[ -f /bla/src/x.go ]]
  1344. RUN [[ -f /bla/Makefile ]]
  1345. RUN [[ ! -e /bla/src/_vendor ]]
  1346. RUN [[ ! -e /bla/.gitignore ]]
  1347. RUN [[ ! -e /bla/README.md ]]
  1348. RUN [[ ! -e /bla/.git ]]`
  1349. ctx, err := fakeContext(dockerfile, map[string]string{
  1350. "Makefile": "all:",
  1351. ".git/HEAD": "ref: foo",
  1352. "src/x.go": "package main",
  1353. "src/_vendor/v.go": "package main",
  1354. ".gitignore": "",
  1355. "README.md": "readme",
  1356. ".dockerignore": ".git\npkg\n.gitignore\nsrc/_vendor\n*.md",
  1357. })
  1358. defer ctx.Close()
  1359. if err != nil {
  1360. t.Fatal(err)
  1361. }
  1362. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1363. t.Fatal(err)
  1364. }
  1365. logDone("build - test .dockerignore")
  1366. }
  1367. func TestDockerignoringDockerfile(t *testing.T) {
  1368. name := "testbuilddockerignoredockerfile"
  1369. defer deleteImages(name)
  1370. dockerfile := `
  1371. FROM scratch`
  1372. ctx, err := fakeContext(dockerfile, map[string]string{
  1373. "Dockerfile": "FROM scratch",
  1374. ".dockerignore": "Dockerfile\n",
  1375. })
  1376. defer ctx.Close()
  1377. if err != nil {
  1378. t.Fatal(err)
  1379. }
  1380. if _, err = buildImageFromContext(name, ctx, true); err == nil {
  1381. t.Fatalf("Didn't get expected error from ignoring Dockerfile")
  1382. }
  1383. logDone("build - test .dockerignore of Dockerfile")
  1384. }
  1385. func TestDockerignoringWholeDir(t *testing.T) {
  1386. name := "testbuilddockerignorewholedir"
  1387. defer deleteImages(name)
  1388. dockerfile := `
  1389. FROM busybox
  1390. COPY . /
  1391. RUN [[ ! -e /.gitignore ]]
  1392. RUN [[ -f /Makefile ]]`
  1393. ctx, err := fakeContext(dockerfile, map[string]string{
  1394. "Dockerfile": "FROM scratch",
  1395. "Makefile": "all:",
  1396. ".dockerignore": ".*\n",
  1397. })
  1398. defer ctx.Close()
  1399. if err != nil {
  1400. t.Fatal(err)
  1401. }
  1402. if _, err = buildImageFromContext(name, ctx, true); err != nil {
  1403. t.Fatal(err)
  1404. }
  1405. logDone("build - test .dockerignore whole dir with .*")
  1406. }
  1407. func TestBuildLineBreak(t *testing.T) {
  1408. name := "testbuildlinebreak"
  1409. defer deleteImages(name)
  1410. _, err := buildImage(name,
  1411. `FROM busybox
  1412. RUN sh -c 'echo root:testpass \
  1413. > /tmp/passwd'
  1414. RUN mkdir -p /var/run/sshd
  1415. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  1416. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  1417. true)
  1418. if err != nil {
  1419. t.Fatal(err)
  1420. }
  1421. logDone("build - line break with \\")
  1422. }
  1423. func TestBuildEOLInLine(t *testing.T) {
  1424. name := "testbuildeolinline"
  1425. defer deleteImages(name)
  1426. _, err := buildImage(name,
  1427. `FROM busybox
  1428. RUN sh -c 'echo root:testpass > /tmp/passwd'
  1429. RUN echo "foo \n bar"; echo "baz"
  1430. RUN mkdir -p /var/run/sshd
  1431. RUN [ "$(cat /tmp/passwd)" = "root:testpass" ]
  1432. RUN [ "$(ls -d /var/run/sshd)" = "/var/run/sshd" ]`,
  1433. true)
  1434. if err != nil {
  1435. t.Fatal(err)
  1436. }
  1437. logDone("build - end of line in dockerfile instruction")
  1438. }
  1439. func TestBuildCommentsShebangs(t *testing.T) {
  1440. name := "testbuildcomments"
  1441. defer deleteImages(name)
  1442. _, err := buildImage(name,
  1443. `FROM busybox
  1444. # This is an ordinary comment.
  1445. RUN { echo '#!/bin/sh'; echo 'echo hello world'; } > /hello.sh
  1446. RUN [ ! -x /hello.sh ]
  1447. # comment with line break \
  1448. RUN chmod +x /hello.sh
  1449. RUN [ -x /hello.sh ]
  1450. RUN [ "$(cat /hello.sh)" = $'#!/bin/sh\necho hello world' ]
  1451. RUN [ "$(/hello.sh)" = "hello world" ]`,
  1452. true)
  1453. if err != nil {
  1454. t.Fatal(err)
  1455. }
  1456. logDone("build - comments and shebangs")
  1457. }
  1458. func TestBuildUsersAndGroups(t *testing.T) {
  1459. name := "testbuildusers"
  1460. defer deleteImages(name)
  1461. _, err := buildImage(name,
  1462. `FROM busybox
  1463. # Make sure our defaults work
  1464. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)" = '0:0/root:root' ]
  1465. # TODO decide if "args.user = strconv.Itoa(syscall.Getuid())" is acceptable behavior for changeUser in sysvinit instead of "return nil" when "USER" isn't specified (so that we get the proper group list even if that is the empty list, even in the default case of not supplying an explicit USER to run as, which implies USER 0)
  1466. USER root
  1467. RUN [ "$(id -G):$(id -Gn)" = '0 10:root wheel' ]
  1468. # Setup dockerio user and group
  1469. RUN echo 'dockerio:x:1001:1001::/bin:/bin/false' >> /etc/passwd
  1470. RUN echo 'dockerio:x:1001:' >> /etc/group
  1471. # Make sure we can switch to our user and all the information is exactly as we expect it to be
  1472. USER dockerio
  1473. RUN id -G
  1474. RUN id -Gn
  1475. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  1476. # Switch back to root and double check that worked exactly as we might expect it to
  1477. USER root
  1478. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '0:0/root:root/0 10:root wheel' ]
  1479. # Add a "supplementary" group for our dockerio user
  1480. RUN echo 'supplementary:x:1002:dockerio' >> /etc/group
  1481. # ... and then go verify that we get it like we expect
  1482. USER dockerio
  1483. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  1484. USER 1001
  1485. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001 1002:dockerio supplementary' ]
  1486. # super test the new "user:group" syntax
  1487. USER dockerio:dockerio
  1488. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  1489. USER 1001:dockerio
  1490. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  1491. USER dockerio:1001
  1492. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  1493. USER 1001:1001
  1494. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1001/dockerio:dockerio/1001:dockerio' ]
  1495. USER dockerio:supplementary
  1496. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  1497. USER dockerio:1002
  1498. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  1499. USER 1001:supplementary
  1500. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  1501. USER 1001:1002
  1502. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1001:1002/dockerio:supplementary/1002:supplementary' ]
  1503. # make sure unknown uid/gid still works properly
  1504. USER 1042:1043
  1505. RUN [ "$(id -u):$(id -g)/$(id -un):$(id -gn)/$(id -G):$(id -Gn)" = '1042:1043/1042:1043/1043:1043' ]`,
  1506. true)
  1507. if err != nil {
  1508. t.Fatal(err)
  1509. }
  1510. logDone("build - users and groups")
  1511. }
  1512. func TestBuildEnvUsage(t *testing.T) {
  1513. name := "testbuildenvusage"
  1514. defer deleteImages(name)
  1515. dockerfile := `FROM busybox
  1516. ENV FOO /foo/baz
  1517. ENV BAR /bar
  1518. ENV BAZ $BAR
  1519. ENV FOOPATH $PATH:$FOO
  1520. RUN [ "$BAR" = "$BAZ" ]
  1521. RUN [ "$FOOPATH" = "$PATH:/foo/baz" ]
  1522. ENV FROM hello/docker/world
  1523. ENV TO /docker/world/hello
  1524. ADD $FROM $TO
  1525. RUN [ "$(cat $TO)" = "hello" ]`
  1526. ctx, err := fakeContext(dockerfile, map[string]string{
  1527. "hello/docker/world": "hello",
  1528. })
  1529. if err != nil {
  1530. t.Fatal(err)
  1531. }
  1532. _, err = buildImageFromContext(name, ctx, true)
  1533. if err != nil {
  1534. t.Fatal(err)
  1535. }
  1536. logDone("build - environment variables usage")
  1537. }
  1538. func TestBuildAddScript(t *testing.T) {
  1539. name := "testbuildaddscript"
  1540. defer deleteImages(name)
  1541. dockerfile := `
  1542. FROM busybox
  1543. ADD test /test
  1544. RUN ["chmod","+x","/test"]
  1545. RUN ["/test"]
  1546. RUN [ "$(cat /testfile)" = 'test!' ]`
  1547. ctx, err := fakeContext(dockerfile, map[string]string{
  1548. "test": "#!/bin/sh\necho 'test!' > /testfile",
  1549. })
  1550. if err != nil {
  1551. t.Fatal(err)
  1552. }
  1553. _, err = buildImageFromContext(name, ctx, true)
  1554. if err != nil {
  1555. t.Fatal(err)
  1556. }
  1557. logDone("build - add and run script")
  1558. }
  1559. func TestBuildAddTar(t *testing.T) {
  1560. name := "testbuildaddtar"
  1561. defer deleteImages(name)
  1562. ctx := func() *FakeContext {
  1563. dockerfile := `
  1564. FROM busybox
  1565. ADD test.tar /
  1566. RUN cat /test/foo | grep Hi
  1567. ADD test.tar /test.tar
  1568. RUN cat /test.tar/test/foo | grep Hi
  1569. ADD test.tar /unlikely-to-exist
  1570. RUN cat /unlikely-to-exist/test/foo | grep Hi
  1571. ADD test.tar /unlikely-to-exist-trailing-slash/
  1572. RUN cat /unlikely-to-exist-trailing-slash/test/foo | grep Hi
  1573. RUN mkdir /existing-directory
  1574. ADD test.tar /existing-directory
  1575. RUN cat /existing-directory/test/foo | grep Hi
  1576. ADD test.tar /existing-directory-trailing-slash/
  1577. RUN cat /existing-directory-trailing-slash/test/foo | grep Hi`
  1578. tmpDir, err := ioutil.TempDir("", "fake-context")
  1579. testTar, err := os.Create(filepath.Join(tmpDir, "test.tar"))
  1580. if err != nil {
  1581. t.Fatalf("failed to create test.tar archive: %v", err)
  1582. }
  1583. defer testTar.Close()
  1584. tw := tar.NewWriter(testTar)
  1585. if err := tw.WriteHeader(&tar.Header{
  1586. Name: "test/foo",
  1587. Size: 2,
  1588. }); err != nil {
  1589. t.Fatalf("failed to write tar file header: %v", err)
  1590. }
  1591. if _, err := tw.Write([]byte("Hi")); err != nil {
  1592. t.Fatalf("failed to write tar file content: %v", err)
  1593. }
  1594. if err := tw.Close(); err != nil {
  1595. t.Fatalf("failed to close tar archive: %v", err)
  1596. }
  1597. if err := ioutil.WriteFile(filepath.Join(tmpDir, "Dockerfile"), []byte(dockerfile), 0644); err != nil {
  1598. t.Fatalf("failed to open destination dockerfile: %v", err)
  1599. }
  1600. return &FakeContext{Dir: tmpDir}
  1601. }()
  1602. if _, err := buildImageFromContext(name, ctx, true); err != nil {
  1603. t.Fatalf("build failed to complete for TestBuildAddTar: %v", err)
  1604. }
  1605. logDone("build - ADD tar")
  1606. }
  1607. func TestBuildFromGIT(t *testing.T) {
  1608. name := "testbuildfromgit"
  1609. defer deleteImages(name)
  1610. git, err := fakeGIT("repo", map[string]string{
  1611. "Dockerfile": `FROM busybox
  1612. ADD first /first
  1613. RUN [ -f /first ]
  1614. MAINTAINER docker`,
  1615. "first": "test git data",
  1616. })
  1617. if err != nil {
  1618. t.Fatal(err)
  1619. }
  1620. defer git.Close()
  1621. _, err = buildImageFromPath(name, git.RepoURL, true)
  1622. if err != nil {
  1623. t.Fatal(err)
  1624. }
  1625. res, err := inspectField(name, "Author")
  1626. if err != nil {
  1627. t.Fatal(err)
  1628. }
  1629. if res != "docker" {
  1630. t.Fatalf("Maintainer should be docker, got %s", res)
  1631. }
  1632. logDone("build - build from GIT")
  1633. }
  1634. func TestBuildCleanupCmdOnEntrypoint(t *testing.T) {
  1635. name := "testbuildcmdcleanuponentrypoint"
  1636. defer deleteImages(name)
  1637. if _, err := buildImage(name,
  1638. `FROM scratch
  1639. CMD ["test"]
  1640. ENTRYPOINT ["echo"]`,
  1641. true); err != nil {
  1642. t.Fatal(err)
  1643. }
  1644. if _, err := buildImage(name,
  1645. fmt.Sprintf(`FROM %s
  1646. ENTRYPOINT ["cat"]`, name),
  1647. true); err != nil {
  1648. t.Fatal(err)
  1649. }
  1650. res, err := inspectField(name, "Config.Cmd")
  1651. if err != nil {
  1652. t.Fatal(err)
  1653. }
  1654. if expected := "<no value>"; res != expected {
  1655. t.Fatalf("Cmd %s, expected %s", res, expected)
  1656. }
  1657. res, err = inspectField(name, "Config.Entrypoint")
  1658. if err != nil {
  1659. t.Fatal(err)
  1660. }
  1661. if expected := "[cat]"; res != expected {
  1662. t.Fatalf("Entrypoint %s, expected %s", res, expected)
  1663. }
  1664. logDone("build - cleanup cmd on ENTRYPOINT")
  1665. }