0ct0pu5/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
moby/integration-cli
History
Doug Davis cdb8ea90b0 Fix processing of unset build-args during build 
This reverts 26103.  26103 was trying to make it so that if someone did:
  docker build --build-arg FOO .
and FOO wasn't set as an env var then it would pick-up FOO from the
Dockerfile's ARG cmd.  However, it went too far and removed the ability
to specify a build arg w/o any value. Meaning it required the --build-arg
param to always be in the form "name=value", and not just "name".

This PR does the right fix - it allows just "name" and it'll grab the value
from the env vars if set. If "name" isn't set in the env then it still needs
to send "name" to the server so that a warning can be printed about an
unused --build-arg. And this is why buildArgs in the options is now a
*string instead of just a string - 'nil' == mentioned but no value.

Closes #29084

Signed-off-by: Doug Davis <dug@us.ibm.com>
2016-12-07 07:41:55 -08:00
..
fixtures Add integration test for stack deploy. 2016-11-10 11:28:18 -05:00
benchmark_test.go Windows: docker top implementation 2016-09-07 16:29:02 -07:00
check_test.go Check for valid daemon in TearDownTest. 2016-11-21 13:29:13 -08:00
daemon.go fix typo 2016-11-18 15:51:36 +08:00
daemon_swarm.go correct the http return code of secret remove 2016-11-30 19:45:45 +08:00
daemon_swarm_hack.go Remove unnecessary CmdWithArgs 2016-07-28 20:14:14 -04:00
daemon_unix.go Add support for docker run in swarm mode overlay 2016-09-07 21:20:41 -07:00
daemon_windows.go Swap usage of LazyDLL and LoadDLL to LazySystemDLL. 2016-11-22 14:57:11 -08:00
docker_api_attach_test.go Add Logs to ContainerAttachOptions 2016-10-19 11:39:00 -04:00
docker_api_auth_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_build_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_containers_test.go Fix restartpolicy max-retry validation 2016-12-02 02:39:16 +01:00
docker_api_create_test.go Fix /proc/<pid>/oom_score_adj: invalid argument error caused by empty env name 2016-11-07 08:15:26 -08:00
docker_api_events_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_exec_resize_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_exec_test.go Windows: Require REST 1.25 or later 2016-10-31 14:33:59 -07:00
docker_api_images_test.go Generate api/types:Image from the swagger spec 2016-10-20 13:24:23 -07:00
docker_api_info_test.go Windows: Require REST 1.25 or later 2016-10-31 14:33:59 -07:00
docker_api_inspect_test.go Windows: Require REST 1.25 or later 2016-10-31 14:33:59 -07:00
docker_api_inspect_unix_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_logs_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_network_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_resize_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_service_update_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_stats_test.go Rename Remote API to Engine API 2016-11-22 12:49:38 +00:00
docker_api_stats_unix_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_swarm_test.go secrets: add secret create and delete integration tests 2016-11-09 14:27:44 -05:00
docker_api_test.go always add but hide experimental cmds and flags 2016-11-08 04:55:27 -08:00
docker_api_update_unix_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_version_test.go Add engine-api types to docker 2016-09-07 11:05:58 -07:00
docker_api_volumes_test.go Use a config to generate swagger api types 2016-10-31 11:13:41 -04:00
docker_cli_attach_test.go Implement Pause Resume support for Windows 2016-10-11 16:23:35 -07:00
docker_cli_attach_unix_test.go Improve TestAttachClosedOnContainerStop 2016-10-05 15:52:09 -07:00
docker_cli_authz_plugin_v2_test.go Check for valid daemon in TearDownTest. 2016-11-21 13:29:13 -08:00
docker_cli_authz_unix_test.go Check for valid daemon in TearDownTest. 2016-11-21 13:29:13 -08:00
docker_cli_build_test.go Fix processing of unset build-args during build 2016-12-07 07:41:55 -08:00
docker_cli_build_unix_test.go Create a unified RunCommand function with Assert() 2016-08-23 15:11:46 -04:00
docker_cli_by_digest_test.go Update pull error handling 2016-11-10 17:34:12 -08:00
docker_cli_commit_test.go COPY file . after WORKDIR (now always created) 2016-11-23 09:56:02 -08:00
docker_cli_config_test.go always add but hide experimental cmds and flags 2016-11-08 04:55:27 -08:00
docker_cli_cp_from_container_test.go Windows: Enable some cp integration tests 2016-08-30 14:32:10 -07:00
docker_cli_cp_test.go Fix bunch of typos 2016-10-29 15:03:26 +08:00
docker_cli_cp_to_container_test.go Windows: Enable some cp integration tests 2016-08-30 14:32:10 -07:00
docker_cli_cp_to_container_unix_test.go Fix copy chown settings to not default to real root 2016-02-18 14:44:13 -08:00
docker_cli_cp_utils.go Use checker assert for integration-cli/docker_cli_cp_* four files. 2015-10-26 10:22:28 +08:00
docker_cli_create_test.go Add config parameter to change per-container stop timeout during daemon shutdown 2016-10-17 12:28:46 -07:00
docker_cli_daemon_plugins_test.go plugins: fix some tests 2016-11-21 16:34:10 -08:00
docker_cli_daemon_test.go Convert err description to lower 2016-11-08 14:42:54 -08:00
docker_cli_diff_test.go Windows: Port a docker diff test 2016-10-28 12:21:54 -07:00
docker_cli_events_test.go Fixes some integration-cli on userns 2016-11-23 14:03:53 +01:00
docker_cli_events_unix_test.go support insecure registry in configuration reload 2016-10-20 07:54:31 +08:00
docker_cli_exec_test.go Stop holding container lock while waiting on streams 2016-10-28 12:19:22 -07:00
docker_cli_exec_unix_test.go Add TERM env var to exec 2016-09-12 09:20:27 -07:00
docker_cli_experimental_test.go Make experimental a runtime flag 2016-10-24 15:20:01 -07:00
docker_cli_export_import_test.go Using checkers assert for integration-cli/docker_cli_export_import_test.go 2015-10-21 08:57:20 -04:00
docker_cli_external_graphdriver_unix_test.go Check for valid daemon in TearDownTest. 2016-11-21 13:29:13 -08:00
docker_cli_external_volume_driver_unix_test.go Fix out-of-band vol delete+create for same driver 2016-11-30 12:19:03 -05:00
docker_cli_health_test.go Adds container health support to docker ps filter 2016-10-28 15:43:04 -04:00
docker_cli_help_test.go fix a few golint errors 2016-11-18 18:32:02 -08:00
docker_cli_history_test.go Windows: Enable docker_cli_history_test 2016-08-30 09:31:33 -07:00
docker_cli_images_test.go all: replace loop with single append 2016-10-13 13:31:52 -07:00
docker_cli_import_test.go Fix issue in docker import -c with quoted flags 2016-09-01 16:28:22 -07:00
docker_cli_info_test.go Add expected 3rd party binaries commit ids to info 2016-11-09 07:42:44 -08:00
docker_cli_info_unix_test.go daemon: add a flag to override the default seccomp profile 2016-11-02 21:41:29 +01:00
docker_cli_inspect_test.go Disable HTML escaping for JSON strings in docker inspect 2016-09-29 18:16:36 -07:00
docker_cli_kill_test.go Add restart policy to restart policy tests 2016-11-09 17:13:42 -06:00
docker_cli_links_test.go Remove unnecessary json.Unmarshal wrapper. 2016-08-23 15:11:46 -04:00
docker_cli_links_unix_test.go use of checkers on Integration test 2015-10-18 09:00:08 +08:00
docker_cli_login_test.go Planned 1.13 deprecation: email from login 2016-11-11 17:32:46 -08:00
docker_cli_logout_test.go support legacy registries in exernal stores 2016-09-07 09:45:42 +02:00
docker_cli_logs_bench_test.go Fixes some issues with jsonfile write/read 2016-03-21 11:05:58 -04:00
docker_cli_logs_test.go Change reading order of tailfile 2016-11-13 20:08:51 -08:00
docker_cli_nat_test.go Assert error in body of function inspectField* 2016-01-29 23:39:07 +08:00
docker_cli_netmode_test.go fix typos 2016-06-02 17:17:22 +08:00
docker_cli_network_unix_test.go Merge pull request #28601 from tiborvass/plugin-misc-fixes 2016-11-22 16:12:37 -08:00
docker_cli_oom_killed_test.go Add the swapMemorySupport requirement to OOM tests 2016-05-10 11:28:00 -07:00
docker_cli_pause_test.go Implement Pause Resume support for Windows 2016-10-11 16:23:35 -07:00
docker_cli_plugins_test.go Allow docker plugin inspect to search based on ID or name 2016-12-01 10:44:17 -08:00
docker_cli_port_test.go Expose bridge IPv6 setting to docker network inspect 2016-02-11 22:13:47 +00:00
docker_cli_proxy_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_cli_prune_unix_test.go add docker network prune 2016-10-25 06:43:54 +00:00
docker_cli_ps_test.go Adds container health support to docker ps filter 2016-10-28 15:43:04 -04:00
docker_cli_pull_local_test.go support legacy registries in exernal stores 2016-09-07 09:45:42 +02:00
docker_cli_pull_test.go Update pull error handling 2016-11-10 17:34:12 -08:00
docker_cli_pull_trusted_test.go Fix API incompatibilities between notary v0.3.0 and v0.4.2: 2016-10-14 17:53:34 -07:00
docker_cli_push_test.go Update token server error test to not fail on retries 2016-09-01 15:18:15 -07:00
docker_cli_registry_user_agent_test.go Planned 1.13 deprecation: email from login 2016-11-11 17:32:46 -08:00
docker_cli_rename_test.go Refactor docker inspect to work on all types 2016-08-25 16:29:08 -07:00
docker_cli_restart_test.go Fix restartpolicy max-retry validation 2016-12-02 02:39:16 +01:00
docker_cli_rm_test.go Merge pull request #19959 from WeiZhang555/fix-cli-print-err 2016-02-03 10:56:19 -08:00
docker_cli_rmi_test.go Move some test fixtures to go 2016-09-07 17:30:35 -04:00
docker_cli_run_test.go Merge pull request #28988 from vdemeester/28985-dont-validate-hostname 2016-12-02 21:16:56 -05:00
docker_cli_run_unix_test.go Fixes some integration-cli on userns 2016-11-23 14:03:53 +01:00
docker_cli_save_load_test.go add defer file.Close to avoid potential fd leak 2016-08-10 08:36:09 +08:00
docker_cli_save_load_unix_test.go Validate docker-load receives a tar file 2016-10-31 15:30:55 +02:00
docker_cli_search_test.go Use spf13/cobra for docker search 2016-06-03 19:50:01 +02:00
docker_cli_secret_create_test.go add integration tests for secret create with labels 2016-11-09 14:27:45 -05:00
docker_cli_secret_inspect_test.go update secret inspect to support IDs 2016-11-22 16:01:16 -05:00
docker_cli_service_create_test.go Fix issue where TmpfsOptions are not sent to swarm 2016-12-02 11:43:47 -05:00
docker_cli_service_health_test.go integration: wait for task running in TestServiceHealthRun 2016-09-29 07:44:00 -07:00
docker_cli_service_logs_experimental_test.go service logs: Support no-follow mode 2016-11-21 18:02:13 -08:00
docker_cli_service_scale_test.go validate service parameter in client side to avoid api call 2016-09-26 17:18:02 +08:00
docker_cli_service_update_test.go do not force target type for secret references 2016-11-17 15:49:02 -05:00
docker_cli_sni_test.go Disable flakey TestClientSetsTLSServerName 2016-02-02 19:56:31 -08:00
docker_cli_stack_test.go Restore stack deploy integration test with dab 2016-11-10 11:28:19 -05:00
docker_cli_start_test.go Implement Pause Resume support for Windows 2016-10-11 16:23:35 -07:00
docker_cli_stats_test.go Do not remove containers from stats list on err 2016-04-13 16:36:34 -04:00
docker_cli_stop_test.go Add test case for stopping a restarting container 2016-04-10 15:39:28 +08:00
docker_cli_swarm_test.go Merge pull request #28997 from cyli/fix-flakey-test 2016-12-01 11:32:30 -08:00
docker_cli_tag_test.go Remove deprecated -f flag on docker tag 2016-06-01 09:44:25 -07:00
docker_cli_top_test.go Windows: docker top implementation 2016-09-07 16:29:02 -07:00
docker_cli_update_test.go Forbid update restart policy of container with AutoRemove flag 2016-08-16 15:36:13 +08:00
docker_cli_update_unix_test.go Add engine-api types to docker 2016-09-07 11:05:58 -07:00
docker_cli_userns_test.go Add test for checking created directories on remapped root 2016-09-05 13:02:13 +03:00
docker_cli_v2_only_test.go Login update and endpoint refactor 2016-03-01 11:52:32 -08:00
docker_cli_version_test.go Align output of docker version again 2016-11-28 11:38:58 -08:00
docker_cli_volume_test.go Show volume options for docker volume inspect 2016-10-20 05:14:27 -07:00
docker_cli_wait_test.go Better logging for errors in some tests 2016-03-25 10:02:52 -04:00
docker_deprecated_api_v124_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_deprecated_api_v124_unix_test.go remove deprecated feature of passing HostConfig at API container start 2016-06-01 22:25:17 +08:00
docker_experimental_network_test.go Make experimental a runtime flag 2016-10-24 15:20:01 -07:00
docker_hub_pull_suite_test.go Remove unnecessary CmdWithArgs 2016-07-28 20:14:14 -04:00
docker_test_vars.go Make experimental a runtime flag 2016-10-24 15:20:01 -07:00
docker_utils.go [integration-cli] fix race condition in kill tests 2016-11-09 17:00:01 -06:00
events_utils.go test: fix trivial code convention noncompliance 2016-09-12 07:36:52 +00:00
fixtures.go Move some test fixtures to go 2016-09-07 17:30:35 -04:00
fixtures_linux_daemon.go Use runc version built without ambient capabilities 2016-11-04 17:25:28 +00:00
npipe.go Windows CI: Allow npipe protocol for sock requests 2016-03-02 14:22:51 -08:00
npipe_windows.go Windows CI: Allow npipe protocol for sock requests 2016-03-02 14:22:51 -08:00
registry.go add defer file.Close to avoid potential fd leak 2016-08-10 08:36:09 +08:00
registry_mock.go integration-cli: log error when starting registry 2016-01-11 20:16:13 +01:00
requirements.go Windows: Add cpu count option 2016-11-04 13:38:50 -07:00
requirements_unix.go Add support for ambient capabilities 2016-10-10 19:29:02 +01:00
test_vars.go Windows: docker top implementation 2016-09-07 16:29:02 -07:00
test_vars_exec.go integration-cli: add test requirement ExecSupport 2015-02-20 23:24:30 -08:00
test_vars_noexec.go integration-cli: add test requirement ExecSupport 2015-02-20 23:24:30 -08:00
test_vars_noseccomp.go Allow non-seccomp platforms to pass integration-cli tests 2015-12-07 20:14:52 -05:00
test_vars_seccomp.go Allow non-seccomp platforms to pass integration-cli tests 2015-12-07 20:14:52 -05:00
test_vars_unix.go Windows: docker top implementation 2016-09-07 16:29:02 -07:00
test_vars_windows.go Windows: docker top implementation 2016-09-07 16:29:02 -07:00
trust_server.go Fix govet for go1.7 2016-09-02 19:07:54 -07:00
utils.go Create a unified RunCommand function with Assert() 2016-08-23 15:11:46 -04:00