moby/plugin
Kir Kolyshkin 7f1c6bf5a7 pkg/mount: wrap mount/umount errors
The errors returned from Mount and Unmount functions are raw
syscall.Errno errors (like EPERM or EINVAL), which provides
no context about what has happened and why.

Similar to os.PathError type, introduce mount.Error type
with some context. The error messages will now look like this:

> mount /tmp/mount-tests/source:/tmp/mount-tests/target, flags: 0x1001: operation not permitted

or

> mount tmpfs:/tmp/mount-test-source-516297835: operation not permitted

Before this patch, it was just

> operation not permitted

[v2: add Cause()]
[v3: rename MountError to Error, document Cause()]
[v4: fixes; audited all users]
[v5: make Error type private; changes after @cpuguy83 reviews]

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit 6533136961)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
2019-06-05 11:50:50 -07:00
..
executor/containerd Use assert.NilError() instead of assert.Assert() 2019-04-17 23:08:54 +02:00
v2 Move plugin client creation to the extension point 2018-05-25 15:18:53 -04:00
backend_linux.go Various code-cleanup 2018-05-23 17:50:54 +02:00
backend_linux_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
backend_unsupported.go Switch from x/net/context -> context 2018-04-23 13:52:44 -07:00
blobstore.go Close readclosers returned by DecompressStream 2018-06-07 11:16:13 -07:00
defs.go Various code-cleanup 2018-05-23 17:50:54 +02:00
errors.go Add canonical import comment 2018-02-05 16:51:57 -05:00
events.go Add canonical import comment 2018-02-05 16:51:57 -05:00
manager.go Fix panic on daemon restart with running plugin 2018-06-07 17:27:02 -07:00
manager_linux.go pkg/mount: wrap mount/umount errors 2019-06-05 11:50:50 -07:00
manager_linux_test.go Update tests to use gotest.tools 👼 2018-06-13 09:04:30 +02:00
manager_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
manager_windows.go Fix panic on daemon restart with running plugin 2018-06-07 17:27:02 -07:00
store.go Various code-cleanup 2018-05-23 17:50:54 +02:00
store_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00