moby/pkg/plugins
Brian Goff b27f70d45a Fix issue with plugin scanner going to deep
The plugin spec says that plugins can live in one of:

- /var/run/docker/plugins/<name>.sock
- /var/run/docker/plugins/<name>/<name>.sock
- /etc/docker/plugins/<name>.[json,spec]
- /etc/docker/plugins/<name>/<name>.<json,spec>
- /usr/lib/docker/plugins/<name>.<json,spec>
- /usr/lib/docker/plugins/<name>/<name>.<json,spec>

However, the plugin scanner which is used by the volume list API was
doing `filepath.Walk`, which will walk the entire tree for each of the
supported paths.
This means that even v2 plugins in
`/var/run/docker/plugins/<id>/<name>.sock` were being detected as a v1
plugin.
When the v1 plugin loader tried to load such a plugin it would log an
error that it couldn't find it because it doesn't match one of the
supported patterns... e.g. when in a subdir, the subdir name must match
the plugin name for the socket.

There is no behavior change as the error is only on the `Scan()` call,
which is passing names to the plugin registry when someone calls the
volume list API.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2018-02-02 16:49:14 -05:00
..
pluginrpc-gen Add deadcode linter 2017-08-21 18:18:50 -04:00
transport Increase the Coverage of pkg/plugins 2017-06-12 12:23:10 +05:00
client.go Add timeouts for volume plugin ops 2018-01-16 20:30:49 -05:00
client_test.go Increase the Coverage of pkg/plugins 2017-06-12 12:23:10 +05:00
discovery.go Fix issue with plugin scanner going to deep 2018-02-02 16:49:14 -05:00
discovery_test.go pkg/*: clean up a few issues 2017-03-30 16:50:46 +03:00
discovery_unix.go fix spec file support for Windows plugin discovery (#25903) 2016-08-26 22:11:58 +02:00
discovery_unix_test.go Fix issue with plugin scanner going to deep 2018-02-02 16:49:14 -05:00
discovery_windows.go fix spec file support for Windows plugin discovery (#25903) 2016-08-26 22:11:58 +02:00
errors.go Fix some typos in comments and strings 2016-02-22 20:27:15 +01:00
plugin_test.go Fix issue with plugin scanner going to deep 2018-02-02 16:49:14 -05:00
plugins.go Update logrus to v1.0.1 2017-07-31 13:16:46 -07:00
plugins_unix.go plugins: Rename plugins_linux.go to plugins_unix.go and use build tags 2017-03-29 14:06:59 -07:00
plugins_windows.go Fix pluginv1 Windows volumes 2017-01-13 17:01:48 -08:00