config_test.go 5.7 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229
  1. package daemon
  2. import (
  3. "io/ioutil"
  4. "os"
  5. "runtime"
  6. "strings"
  7. "testing"
  8. "github.com/docker/docker/opts"
  9. "github.com/docker/docker/pkg/testutil/assert"
  10. "github.com/spf13/pflag"
  11. )
  12. func TestDaemonConfigurationNotFound(t *testing.T) {
  13. _, err := MergeDaemonConfigurations(&Config{}, nil, "/tmp/foo-bar-baz-docker")
  14. if err == nil || !os.IsNotExist(err) {
  15. t.Fatalf("expected does not exist error, got %v", err)
  16. }
  17. }
  18. func TestDaemonBrokenConfiguration(t *testing.T) {
  19. f, err := ioutil.TempFile("", "docker-config-")
  20. if err != nil {
  21. t.Fatal(err)
  22. }
  23. configFile := f.Name()
  24. f.Write([]byte(`{"Debug": tru`))
  25. f.Close()
  26. _, err = MergeDaemonConfigurations(&Config{}, nil, configFile)
  27. if err == nil {
  28. t.Fatalf("expected error, got %v", err)
  29. }
  30. }
  31. func TestParseClusterAdvertiseSettings(t *testing.T) {
  32. if runtime.GOOS == "solaris" {
  33. t.Skip("ClusterSettings not supported on Solaris\n")
  34. }
  35. _, err := parseClusterAdvertiseSettings("something", "")
  36. if err != errDiscoveryDisabled {
  37. t.Fatalf("expected discovery disabled error, got %v\n", err)
  38. }
  39. _, err = parseClusterAdvertiseSettings("", "something")
  40. if err == nil {
  41. t.Fatalf("expected discovery store error, got %v\n", err)
  42. }
  43. _, err = parseClusterAdvertiseSettings("etcd", "127.0.0.1:8080")
  44. if err != nil {
  45. t.Fatal(err)
  46. }
  47. }
  48. func TestFindConfigurationConflicts(t *testing.T) {
  49. config := map[string]interface{}{"authorization-plugins": "foobar"}
  50. flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
  51. flags.String("authorization-plugins", "", "")
  52. assert.NilError(t, flags.Set("authorization-plugins", "asdf"))
  53. assert.Error(t,
  54. findConfigurationConflicts(config, flags),
  55. "authorization-plugins: (from flag: asdf, from file: foobar)")
  56. }
  57. func TestFindConfigurationConflictsWithNamedOptions(t *testing.T) {
  58. config := map[string]interface{}{"hosts": []string{"qwer"}}
  59. flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
  60. var hosts []string
  61. flags.VarP(opts.NewNamedListOptsRef("hosts", &hosts, opts.ValidateHost), "host", "H", "Daemon socket(s) to connect to")
  62. assert.NilError(t, flags.Set("host", "tcp://127.0.0.1:4444"))
  63. assert.NilError(t, flags.Set("host", "unix:///var/run/docker.sock"))
  64. assert.Error(t, findConfigurationConflicts(config, flags), "hosts")
  65. }
  66. func TestDaemonConfigurationMergeConflicts(t *testing.T) {
  67. f, err := ioutil.TempFile("", "docker-config-")
  68. if err != nil {
  69. t.Fatal(err)
  70. }
  71. configFile := f.Name()
  72. f.Write([]byte(`{"debug": true}`))
  73. f.Close()
  74. flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
  75. flags.Bool("debug", false, "")
  76. flags.Set("debug", "false")
  77. _, err = MergeDaemonConfigurations(&Config{}, flags, configFile)
  78. if err == nil {
  79. t.Fatal("expected error, got nil")
  80. }
  81. if !strings.Contains(err.Error(), "debug") {
  82. t.Fatalf("expected debug conflict, got %v", err)
  83. }
  84. }
  85. func TestDaemonConfigurationMergeConflictsWithInnerStructs(t *testing.T) {
  86. f, err := ioutil.TempFile("", "docker-config-")
  87. if err != nil {
  88. t.Fatal(err)
  89. }
  90. configFile := f.Name()
  91. f.Write([]byte(`{"tlscacert": "/etc/certificates/ca.pem"}`))
  92. f.Close()
  93. flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
  94. flags.String("tlscacert", "", "")
  95. flags.Set("tlscacert", "~/.docker/ca.pem")
  96. _, err = MergeDaemonConfigurations(&Config{}, flags, configFile)
  97. if err == nil {
  98. t.Fatal("expected error, got nil")
  99. }
  100. if !strings.Contains(err.Error(), "tlscacert") {
  101. t.Fatalf("expected tlscacert conflict, got %v", err)
  102. }
  103. }
  104. func TestFindConfigurationConflictsWithUnknownKeys(t *testing.T) {
  105. config := map[string]interface{}{"tls-verify": "true"}
  106. flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
  107. flags.Bool("tlsverify", false, "")
  108. err := findConfigurationConflicts(config, flags)
  109. if err == nil {
  110. t.Fatal("expected error, got nil")
  111. }
  112. if !strings.Contains(err.Error(), "the following directives don't match any configuration option: tls-verify") {
  113. t.Fatalf("expected tls-verify conflict, got %v", err)
  114. }
  115. }
  116. func TestFindConfigurationConflictsWithMergedValues(t *testing.T) {
  117. var hosts []string
  118. config := map[string]interface{}{"hosts": "tcp://127.0.0.1:2345"}
  119. flags := pflag.NewFlagSet("base", pflag.ContinueOnError)
  120. flags.VarP(opts.NewNamedListOptsRef("hosts", &hosts, nil), "host", "H", "")
  121. err := findConfigurationConflicts(config, flags)
  122. if err != nil {
  123. t.Fatal(err)
  124. }
  125. flags.Set("host", "unix:///var/run/docker.sock")
  126. err = findConfigurationConflicts(config, flags)
  127. if err == nil {
  128. t.Fatal("expected error, got nil")
  129. }
  130. if !strings.Contains(err.Error(), "hosts: (from flag: [unix:///var/run/docker.sock], from file: tcp://127.0.0.1:2345)") {
  131. t.Fatalf("expected hosts conflict, got %v", err)
  132. }
  133. }
  134. func TestValidateConfiguration(t *testing.T) {
  135. c1 := &Config{
  136. CommonConfig: CommonConfig{
  137. Labels: []string{"one"},
  138. },
  139. }
  140. err := ValidateConfiguration(c1)
  141. if err == nil {
  142. t.Fatal("expected error, got nil")
  143. }
  144. c2 := &Config{
  145. CommonConfig: CommonConfig{
  146. Labels: []string{"one=two"},
  147. },
  148. }
  149. err = ValidateConfiguration(c2)
  150. if err != nil {
  151. t.Fatalf("expected no error, got error %v", err)
  152. }
  153. c3 := &Config{
  154. CommonConfig: CommonConfig{
  155. DNS: []string{"1.1.1.1"},
  156. },
  157. }
  158. err = ValidateConfiguration(c3)
  159. if err != nil {
  160. t.Fatalf("expected no error, got error %v", err)
  161. }
  162. c4 := &Config{
  163. CommonConfig: CommonConfig{
  164. DNS: []string{"1.1.1.1o"},
  165. },
  166. }
  167. err = ValidateConfiguration(c4)
  168. if err == nil {
  169. t.Fatal("expected error, got nil")
  170. }
  171. c5 := &Config{
  172. CommonConfig: CommonConfig{
  173. DNSSearch: []string{"a.b.c"},
  174. },
  175. }
  176. err = ValidateConfiguration(c5)
  177. if err != nil {
  178. t.Fatalf("expected no error, got error %v", err)
  179. }
  180. c6 := &Config{
  181. CommonConfig: CommonConfig{
  182. DNSSearch: []string{"123456"},
  183. },
  184. }
  185. err = ValidateConfiguration(c6)
  186. if err == nil {
  187. t.Fatal("expected error, got nil")
  188. }
  189. }