docker_cli_by_digest_test.go 22 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585
  1. package main
  2. import (
  3. "encoding/json"
  4. "fmt"
  5. "os"
  6. "path/filepath"
  7. "regexp"
  8. "strings"
  9. "github.com/docker/distribution/digest"
  10. "github.com/docker/distribution/manifest/schema1"
  11. "github.com/docker/distribution/manifest/schema2"
  12. "github.com/docker/docker/pkg/integration/checker"
  13. "github.com/docker/docker/pkg/stringutils"
  14. "github.com/docker/engine-api/types"
  15. "github.com/go-check/check"
  16. )
  17. var (
  18. remoteRepoName = "dockercli/busybox-by-dgst"
  19. repoName = fmt.Sprintf("%s/%s", privateRegistryURL, remoteRepoName)
  20. pushDigestRegex = regexp.MustCompile("[\\S]+: digest: ([\\S]+) size: [0-9]+")
  21. digestRegex = regexp.MustCompile("Digest: ([\\S]+)")
  22. )
  23. func setupImage(c *check.C) (digest.Digest, error) {
  24. return setupImageWithTag(c, "latest")
  25. }
  26. func setupImageWithTag(c *check.C, tag string) (digest.Digest, error) {
  27. containerName := "busyboxbydigest"
  28. dockerCmd(c, "run", "-e", "digest=1", "--name", containerName, "busybox")
  29. // tag the image to upload it to the private registry
  30. repoAndTag := repoName + ":" + tag
  31. out, _, err := dockerCmdWithError("commit", containerName, repoAndTag)
  32. c.Assert(err, checker.IsNil, check.Commentf("image tagging failed: %s", out))
  33. // delete the container as we don't need it any more
  34. err = deleteContainer(containerName)
  35. c.Assert(err, checker.IsNil)
  36. // push the image
  37. out, _, err = dockerCmdWithError("push", repoAndTag)
  38. c.Assert(err, checker.IsNil, check.Commentf("pushing the image to the private registry has failed: %s", out))
  39. // delete our local repo that we previously tagged
  40. rmiout, _, err := dockerCmdWithError("rmi", repoAndTag)
  41. c.Assert(err, checker.IsNil, check.Commentf("error deleting images prior to real test: %s", rmiout))
  42. matches := pushDigestRegex.FindStringSubmatch(out)
  43. c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from push output: %s", out))
  44. pushDigest := matches[1]
  45. return digest.Digest(pushDigest), nil
  46. }
  47. func testPullByTagDisplaysDigest(c *check.C) {
  48. testRequires(c, DaemonIsLinux)
  49. pushDigest, err := setupImage(c)
  50. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  51. // pull from the registry using the tag
  52. out, _ := dockerCmd(c, "pull", repoName)
  53. // the pull output includes "Digest: <digest>", so find that
  54. matches := digestRegex.FindStringSubmatch(out)
  55. c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from pull output: %s", out))
  56. pullDigest := matches[1]
  57. // make sure the pushed and pull digests match
  58. c.Assert(pushDigest.String(), checker.Equals, pullDigest)
  59. }
  60. func (s *DockerRegistrySuite) TestPullByTagDisplaysDigest(c *check.C) {
  61. testPullByTagDisplaysDigest(c)
  62. }
  63. func (s *DockerSchema1RegistrySuite) TestPullByTagDisplaysDigest(c *check.C) {
  64. testPullByTagDisplaysDigest(c)
  65. }
  66. func testPullByDigest(c *check.C) {
  67. testRequires(c, DaemonIsLinux)
  68. pushDigest, err := setupImage(c)
  69. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  70. // pull from the registry using the <name>@<digest> reference
  71. imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
  72. out, _ := dockerCmd(c, "pull", imageReference)
  73. // the pull output includes "Digest: <digest>", so find that
  74. matches := digestRegex.FindStringSubmatch(out)
  75. c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from pull output: %s", out))
  76. pullDigest := matches[1]
  77. // make sure the pushed and pull digests match
  78. c.Assert(pushDigest.String(), checker.Equals, pullDigest)
  79. }
  80. func (s *DockerRegistrySuite) TestPullByDigest(c *check.C) {
  81. testPullByDigest(c)
  82. }
  83. func (s *DockerSchema1RegistrySuite) TestPullByDigest(c *check.C) {
  84. testPullByDigest(c)
  85. }
  86. func testPullByDigestNoFallback(c *check.C) {
  87. testRequires(c, DaemonIsLinux)
  88. // pull from the registry using the <name>@<digest> reference
  89. imageReference := fmt.Sprintf("%s@sha256:ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff", repoName)
  90. out, _, err := dockerCmdWithError("pull", imageReference)
  91. c.Assert(err, checker.NotNil, check.Commentf("expected non-zero exit status and correct error message when pulling non-existing image"))
  92. c.Assert(out, checker.Contains, "manifest unknown", check.Commentf("expected non-zero exit status and correct error message when pulling non-existing image"))
  93. }
  94. func (s *DockerRegistrySuite) TestPullByDigestNoFallback(c *check.C) {
  95. testPullByDigestNoFallback(c)
  96. }
  97. func (s *DockerSchema1RegistrySuite) TestPullByDigestNoFallback(c *check.C) {
  98. testPullByDigestNoFallback(c)
  99. }
  100. func (s *DockerRegistrySuite) TestCreateByDigest(c *check.C) {
  101. pushDigest, err := setupImage(c)
  102. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  103. imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
  104. containerName := "createByDigest"
  105. dockerCmd(c, "create", "--name", containerName, imageReference)
  106. res := inspectField(c, containerName, "Config.Image")
  107. c.Assert(res, checker.Equals, imageReference)
  108. }
  109. func (s *DockerRegistrySuite) TestRunByDigest(c *check.C) {
  110. pushDigest, err := setupImage(c)
  111. c.Assert(err, checker.IsNil)
  112. imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
  113. containerName := "runByDigest"
  114. out, _ := dockerCmd(c, "run", "--name", containerName, imageReference, "sh", "-c", "echo found=$digest")
  115. foundRegex := regexp.MustCompile("found=([^\n]+)")
  116. matches := foundRegex.FindStringSubmatch(out)
  117. c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from pull output: %s", out))
  118. c.Assert(matches[1], checker.Equals, "1", check.Commentf("Expected %q, got %q", "1", matches[1]))
  119. res := inspectField(c, containerName, "Config.Image")
  120. c.Assert(res, checker.Equals, imageReference)
  121. }
  122. func (s *DockerRegistrySuite) TestRemoveImageByDigest(c *check.C) {
  123. digest, err := setupImage(c)
  124. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  125. imageReference := fmt.Sprintf("%s@%s", repoName, digest)
  126. // pull from the registry using the <name>@<digest> reference
  127. dockerCmd(c, "pull", imageReference)
  128. // make sure inspect runs ok
  129. inspectField(c, imageReference, "Id")
  130. // do the delete
  131. err = deleteImages(imageReference)
  132. c.Assert(err, checker.IsNil, check.Commentf("unexpected error deleting image"))
  133. // try to inspect again - it should error this time
  134. _, err = inspectFieldWithError(imageReference, "Id")
  135. //unexpected nil err trying to inspect what should be a non-existent image
  136. c.Assert(err, checker.NotNil)
  137. c.Assert(err.Error(), checker.Contains, "No such image")
  138. }
  139. func (s *DockerRegistrySuite) TestBuildByDigest(c *check.C) {
  140. digest, err := setupImage(c)
  141. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  142. imageReference := fmt.Sprintf("%s@%s", repoName, digest)
  143. // pull from the registry using the <name>@<digest> reference
  144. dockerCmd(c, "pull", imageReference)
  145. // get the image id
  146. imageID := inspectField(c, imageReference, "Id")
  147. // do the build
  148. name := "buildbydigest"
  149. _, err = buildImage(name, fmt.Sprintf(
  150. `FROM %s
  151. CMD ["/bin/echo", "Hello World"]`, imageReference),
  152. true)
  153. c.Assert(err, checker.IsNil)
  154. // get the build's image id
  155. res := inspectField(c, name, "Config.Image")
  156. // make sure they match
  157. c.Assert(res, checker.Equals, imageID)
  158. }
  159. func (s *DockerRegistrySuite) TestTagByDigest(c *check.C) {
  160. digest, err := setupImage(c)
  161. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  162. imageReference := fmt.Sprintf("%s@%s", repoName, digest)
  163. // pull from the registry using the <name>@<digest> reference
  164. dockerCmd(c, "pull", imageReference)
  165. // tag it
  166. tag := "tagbydigest"
  167. dockerCmd(c, "tag", imageReference, tag)
  168. expectedID := inspectField(c, imageReference, "Id")
  169. tagID := inspectField(c, tag, "Id")
  170. c.Assert(tagID, checker.Equals, expectedID)
  171. }
  172. func (s *DockerRegistrySuite) TestListImagesWithoutDigests(c *check.C) {
  173. digest, err := setupImage(c)
  174. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  175. imageReference := fmt.Sprintf("%s@%s", repoName, digest)
  176. // pull from the registry using the <name>@<digest> reference
  177. dockerCmd(c, "pull", imageReference)
  178. out, _ := dockerCmd(c, "images")
  179. c.Assert(out, checker.Not(checker.Contains), "DIGEST", check.Commentf("list output should not have contained DIGEST header"))
  180. }
  181. func (s *DockerRegistrySuite) TestListImagesWithDigests(c *check.C) {
  182. // setup image1
  183. digest1, err := setupImageWithTag(c, "tag1")
  184. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  185. imageReference1 := fmt.Sprintf("%s@%s", repoName, digest1)
  186. c.Logf("imageReference1 = %s", imageReference1)
  187. // pull image1 by digest
  188. dockerCmd(c, "pull", imageReference1)
  189. // list images
  190. out, _ := dockerCmd(c, "images", "--digests")
  191. // make sure repo shown, tag=<none>, digest = $digest1
  192. re1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1.String() + `\s`)
  193. c.Assert(re1.MatchString(out), checker.True, check.Commentf("expected %q: %s", re1.String(), out))
  194. // setup image2
  195. digest2, err := setupImageWithTag(c, "tag2")
  196. //error setting up image
  197. c.Assert(err, checker.IsNil)
  198. imageReference2 := fmt.Sprintf("%s@%s", repoName, digest2)
  199. c.Logf("imageReference2 = %s", imageReference2)
  200. // pull image1 by digest
  201. dockerCmd(c, "pull", imageReference1)
  202. // pull image2 by digest
  203. dockerCmd(c, "pull", imageReference2)
  204. // list images
  205. out, _ = dockerCmd(c, "images", "--digests")
  206. // make sure repo shown, tag=<none>, digest = $digest1
  207. c.Assert(re1.MatchString(out), checker.True, check.Commentf("expected %q: %s", re1.String(), out))
  208. // make sure repo shown, tag=<none>, digest = $digest2
  209. re2 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest2.String() + `\s`)
  210. c.Assert(re2.MatchString(out), checker.True, check.Commentf("expected %q: %s", re2.String(), out))
  211. // pull tag1
  212. dockerCmd(c, "pull", repoName+":tag1")
  213. // list images
  214. out, _ = dockerCmd(c, "images", "--digests")
  215. // make sure image 1 has repo, tag, <none> AND repo, <none>, digest
  216. reWithTag1 := regexp.MustCompile(`\s*` + repoName + `\s*tag1\s*<none>\s`)
  217. reWithDigest1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1.String() + `\s`)
  218. c.Assert(reWithDigest1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest1.String(), out))
  219. c.Assert(reWithTag1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithTag1.String(), out))
  220. // make sure image 2 has repo, <none>, digest
  221. c.Assert(re2.MatchString(out), checker.True, check.Commentf("expected %q: %s", re2.String(), out))
  222. // pull tag 2
  223. dockerCmd(c, "pull", repoName+":tag2")
  224. // list images
  225. out, _ = dockerCmd(c, "images", "--digests")
  226. // make sure image 1 has repo, tag, digest
  227. c.Assert(reWithTag1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithTag1.String(), out))
  228. // make sure image 2 has repo, tag, digest
  229. reWithTag2 := regexp.MustCompile(`\s*` + repoName + `\s*tag2\s*<none>\s`)
  230. reWithDigest2 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest2.String() + `\s`)
  231. c.Assert(reWithTag2.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithTag2.String(), out))
  232. c.Assert(reWithDigest2.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest2.String(), out))
  233. // list images
  234. out, _ = dockerCmd(c, "images", "--digests")
  235. // make sure image 1 has repo, tag, digest
  236. c.Assert(reWithTag1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithTag1.String(), out))
  237. // make sure image 2 has repo, tag, digest
  238. c.Assert(reWithTag2.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithTag2.String(), out))
  239. // make sure busybox has tag, but not digest
  240. busyboxRe := regexp.MustCompile(`\s*busybox\s*latest\s*<none>\s`)
  241. c.Assert(busyboxRe.MatchString(out), checker.True, check.Commentf("expected %q: %s", busyboxRe.String(), out))
  242. }
  243. func (s *DockerRegistrySuite) TestInspectImageWithDigests(c *check.C) {
  244. digest, err := setupImage(c)
  245. c.Assert(err, check.IsNil, check.Commentf("error setting up image"))
  246. imageReference := fmt.Sprintf("%s@%s", repoName, digest)
  247. // pull from the registry using the <name>@<digest> reference
  248. dockerCmd(c, "pull", imageReference)
  249. out, _ := dockerCmd(c, "inspect", imageReference)
  250. var imageJSON []types.ImageInspect
  251. err = json.Unmarshal([]byte(out), &imageJSON)
  252. c.Assert(err, checker.IsNil)
  253. c.Assert(imageJSON, checker.HasLen, 1)
  254. c.Assert(imageJSON[0].RepoDigests, checker.HasLen, 1)
  255. c.Assert(stringutils.InSlice(imageJSON[0].RepoDigests, imageReference), checker.Equals, true)
  256. }
  257. func (s *DockerRegistrySuite) TestPsListContainersFilterAncestorImageByDigest(c *check.C) {
  258. digest, err := setupImage(c)
  259. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  260. imageReference := fmt.Sprintf("%s@%s", repoName, digest)
  261. // pull from the registry using the <name>@<digest> reference
  262. dockerCmd(c, "pull", imageReference)
  263. // build an image from it
  264. imageName1 := "images_ps_filter_test"
  265. _, err = buildImage(imageName1, fmt.Sprintf(
  266. `FROM %s
  267. LABEL match me 1`, imageReference), true)
  268. c.Assert(err, checker.IsNil)
  269. // run a container based on that
  270. dockerCmd(c, "run", "--name=test1", imageReference, "echo", "hello")
  271. expectedID, err := getIDByName("test1")
  272. c.Assert(err, check.IsNil)
  273. // run a container based on the a descendant of that too
  274. dockerCmd(c, "run", "--name=test2", imageName1, "echo", "hello")
  275. expectedID1, err := getIDByName("test2")
  276. c.Assert(err, check.IsNil)
  277. expectedIDs := []string{expectedID, expectedID1}
  278. // Invalid imageReference
  279. out, _ := dockerCmd(c, "ps", "-a", "-q", "--no-trunc", fmt.Sprintf("--filter=ancestor=busybox@%s", digest))
  280. // Filter container for ancestor filter should be empty
  281. c.Assert(strings.TrimSpace(out), checker.Equals, "")
  282. // Valid imageReference
  283. out, _ = dockerCmd(c, "ps", "-a", "-q", "--no-trunc", "--filter=ancestor="+imageReference)
  284. checkPsAncestorFilterOutput(c, out, imageReference, expectedIDs)
  285. }
  286. func (s *DockerRegistrySuite) TestDeleteImageByIDOnlyPulledByDigest(c *check.C) {
  287. pushDigest, err := setupImage(c)
  288. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  289. // pull from the registry using the <name>@<digest> reference
  290. imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
  291. dockerCmd(c, "pull", imageReference)
  292. // just in case...
  293. imageID := inspectField(c, imageReference, "Id")
  294. dockerCmd(c, "rmi", imageID)
  295. }
  296. func (s *DockerRegistrySuite) TestDeleteImageWithDigestAndTag(c *check.C) {
  297. pushDigest, err := setupImage(c)
  298. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  299. // pull from the registry using the <name>@<digest> reference
  300. imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
  301. dockerCmd(c, "pull", imageReference)
  302. imageID := inspectField(c, imageReference, "Id")
  303. repoTag := repoName + ":sometag"
  304. repoTag2 := repoName + ":othertag"
  305. dockerCmd(c, "tag", imageReference, repoTag)
  306. dockerCmd(c, "tag", imageReference, repoTag2)
  307. dockerCmd(c, "rmi", repoTag2)
  308. // rmi should have deleted only repoTag2, because there's another tag
  309. inspectField(c, repoTag, "Id")
  310. dockerCmd(c, "rmi", repoTag)
  311. // rmi should have deleted the tag, the digest reference, and the image itself
  312. _, err = inspectFieldWithError(imageID, "Id")
  313. c.Assert(err, checker.NotNil, check.Commentf("image should have been deleted"))
  314. }
  315. // TestPullFailsWithAlteredManifest tests that a `docker pull` fails when
  316. // we have modified a manifest blob and its digest cannot be verified.
  317. // This is the schema2 version of the test.
  318. func (s *DockerRegistrySuite) TestPullFailsWithAlteredManifest(c *check.C) {
  319. testRequires(c, DaemonIsLinux)
  320. manifestDigest, err := setupImage(c)
  321. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  322. // Load the target manifest blob.
  323. manifestBlob := s.reg.readBlobContents(c, manifestDigest)
  324. var imgManifest schema2.Manifest
  325. err = json.Unmarshal(manifestBlob, &imgManifest)
  326. c.Assert(err, checker.IsNil, check.Commentf("unable to decode image manifest from blob"))
  327. // Change a layer in the manifest.
  328. imgManifest.Layers[0].Digest = digest.Digest("sha256:0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef")
  329. // Move the existing data file aside, so that we can replace it with a
  330. // malicious blob of data. NOTE: we defer the returned undo func.
  331. undo := s.reg.tempMoveBlobData(c, manifestDigest)
  332. defer undo()
  333. alteredManifestBlob, err := json.MarshalIndent(imgManifest, "", " ")
  334. c.Assert(err, checker.IsNil, check.Commentf("unable to encode altered image manifest to JSON"))
  335. s.reg.writeBlobContents(c, manifestDigest, alteredManifestBlob)
  336. // Now try pulling that image by digest. We should get an error about
  337. // digest verification for the manifest digest.
  338. // Pull from the registry using the <name>@<digest> reference.
  339. imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
  340. out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
  341. c.Assert(exitStatus, checker.Not(check.Equals), 0)
  342. expectedErrorMsg := fmt.Sprintf("manifest verification failed for digest %s", manifestDigest)
  343. c.Assert(out, checker.Contains, expectedErrorMsg)
  344. }
  345. // TestPullFailsWithAlteredManifest tests that a `docker pull` fails when
  346. // we have modified a manifest blob and its digest cannot be verified.
  347. // This is the schema1 version of the test.
  348. func (s *DockerSchema1RegistrySuite) TestPullFailsWithAlteredManifest(c *check.C) {
  349. testRequires(c, DaemonIsLinux)
  350. manifestDigest, err := setupImage(c)
  351. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  352. // Load the target manifest blob.
  353. manifestBlob := s.reg.readBlobContents(c, manifestDigest)
  354. var imgManifest schema1.Manifest
  355. err = json.Unmarshal(manifestBlob, &imgManifest)
  356. c.Assert(err, checker.IsNil, check.Commentf("unable to decode image manifest from blob"))
  357. // Change a layer in the manifest.
  358. imgManifest.FSLayers[0] = schema1.FSLayer{
  359. BlobSum: digest.Digest("sha256:0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef"),
  360. }
  361. // Move the existing data file aside, so that we can replace it with a
  362. // malicious blob of data. NOTE: we defer the returned undo func.
  363. undo := s.reg.tempMoveBlobData(c, manifestDigest)
  364. defer undo()
  365. alteredManifestBlob, err := json.MarshalIndent(imgManifest, "", " ")
  366. c.Assert(err, checker.IsNil, check.Commentf("unable to encode altered image manifest to JSON"))
  367. s.reg.writeBlobContents(c, manifestDigest, alteredManifestBlob)
  368. // Now try pulling that image by digest. We should get an error about
  369. // digest verification for the manifest digest.
  370. // Pull from the registry using the <name>@<digest> reference.
  371. imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
  372. out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
  373. c.Assert(exitStatus, checker.Not(check.Equals), 0)
  374. expectedErrorMsg := fmt.Sprintf("image verification failed for digest %s", manifestDigest)
  375. c.Assert(out, checker.Contains, expectedErrorMsg)
  376. }
  377. // TestPullFailsWithAlteredLayer tests that a `docker pull` fails when
  378. // we have modified a layer blob and its digest cannot be verified.
  379. // This is the schema2 version of the test.
  380. func (s *DockerRegistrySuite) TestPullFailsWithAlteredLayer(c *check.C) {
  381. testRequires(c, DaemonIsLinux)
  382. manifestDigest, err := setupImage(c)
  383. c.Assert(err, checker.IsNil)
  384. // Load the target manifest blob.
  385. manifestBlob := s.reg.readBlobContents(c, manifestDigest)
  386. var imgManifest schema2.Manifest
  387. err = json.Unmarshal(manifestBlob, &imgManifest)
  388. c.Assert(err, checker.IsNil)
  389. // Next, get the digest of one of the layers from the manifest.
  390. targetLayerDigest := imgManifest.Layers[0].Digest
  391. // Move the existing data file aside, so that we can replace it with a
  392. // malicious blob of data. NOTE: we defer the returned undo func.
  393. undo := s.reg.tempMoveBlobData(c, targetLayerDigest)
  394. defer undo()
  395. // Now make a fake data blob in this directory.
  396. s.reg.writeBlobContents(c, targetLayerDigest, []byte("This is not the data you are looking for."))
  397. // Now try pulling that image by digest. We should get an error about
  398. // digest verification for the target layer digest.
  399. // Remove distribution cache to force a re-pull of the blobs
  400. if err := os.RemoveAll(filepath.Join(dockerBasePath, "image", s.d.storageDriver, "distribution")); err != nil {
  401. c.Fatalf("error clearing distribution cache: %v", err)
  402. }
  403. // Pull from the registry using the <name>@<digest> reference.
  404. imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
  405. out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
  406. c.Assert(exitStatus, checker.Not(check.Equals), 0, check.Commentf("expected a zero exit status"))
  407. expectedErrorMsg := fmt.Sprintf("filesystem layer verification failed for digest %s", targetLayerDigest)
  408. c.Assert(out, checker.Contains, expectedErrorMsg, check.Commentf("expected error message in output: %s", out))
  409. }
  410. // TestPullFailsWithAlteredLayer tests that a `docker pull` fails when
  411. // we have modified a layer blob and its digest cannot be verified.
  412. // This is the schema1 version of the test.
  413. func (s *DockerSchema1RegistrySuite) TestPullFailsWithAlteredLayer(c *check.C) {
  414. testRequires(c, DaemonIsLinux)
  415. manifestDigest, err := setupImage(c)
  416. c.Assert(err, checker.IsNil)
  417. // Load the target manifest blob.
  418. manifestBlob := s.reg.readBlobContents(c, manifestDigest)
  419. var imgManifest schema1.Manifest
  420. err = json.Unmarshal(manifestBlob, &imgManifest)
  421. c.Assert(err, checker.IsNil)
  422. // Next, get the digest of one of the layers from the manifest.
  423. targetLayerDigest := imgManifest.FSLayers[0].BlobSum
  424. // Move the existing data file aside, so that we can replace it with a
  425. // malicious blob of data. NOTE: we defer the returned undo func.
  426. undo := s.reg.tempMoveBlobData(c, targetLayerDigest)
  427. defer undo()
  428. // Now make a fake data blob in this directory.
  429. s.reg.writeBlobContents(c, targetLayerDigest, []byte("This is not the data you are looking for."))
  430. // Now try pulling that image by digest. We should get an error about
  431. // digest verification for the target layer digest.
  432. // Remove distribution cache to force a re-pull of the blobs
  433. if err := os.RemoveAll(filepath.Join(dockerBasePath, "image", s.d.storageDriver, "distribution")); err != nil {
  434. c.Fatalf("error clearing distribution cache: %v", err)
  435. }
  436. // Pull from the registry using the <name>@<digest> reference.
  437. imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
  438. out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
  439. c.Assert(exitStatus, checker.Not(check.Equals), 0, check.Commentf("expected a zero exit status"))
  440. expectedErrorMsg := fmt.Sprintf("filesystem layer verification failed for digest %s", targetLayerDigest)
  441. c.Assert(out, checker.Contains, expectedErrorMsg, check.Commentf("expected error message in output: %s", out))
  442. }