docker_cli_by_digest_test.go 23 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593
  1. package main
  2. import (
  3. "encoding/json"
  4. "fmt"
  5. "os"
  6. "path/filepath"
  7. "regexp"
  8. "strings"
  9. "github.com/docker/distribution/digest"
  10. "github.com/docker/distribution/manifest/schema1"
  11. "github.com/docker/distribution/manifest/schema2"
  12. "github.com/docker/docker/pkg/integration/checker"
  13. "github.com/docker/docker/pkg/stringutils"
  14. "github.com/docker/engine-api/types"
  15. "github.com/go-check/check"
  16. )
  17. var (
  18. remoteRepoName = "dockercli/busybox-by-dgst"
  19. repoName = fmt.Sprintf("%v/%s", privateRegistryURL, remoteRepoName)
  20. pushDigestRegex = regexp.MustCompile("[\\S]+: digest: ([\\S]+) size: [0-9]+")
  21. digestRegex = regexp.MustCompile("Digest: ([\\S]+)")
  22. )
  23. func setupImage(c *check.C) (digest.Digest, error) {
  24. return setupImageWithTag(c, "latest")
  25. }
  26. func setupImageWithTag(c *check.C, tag string) (digest.Digest, error) {
  27. containerName := "busyboxbydigest"
  28. dockerCmd(c, "run", "-d", "-e", "digest=1", "--name", containerName, "busybox")
  29. // tag the image to upload it to the private registry
  30. repoAndTag := repoName + ":" + tag
  31. out, _, err := dockerCmdWithError("commit", containerName, repoAndTag)
  32. c.Assert(err, checker.IsNil, check.Commentf("image tagging failed: %s", out))
  33. // delete the container as we don't need it any more
  34. err = deleteContainer(containerName)
  35. c.Assert(err, checker.IsNil)
  36. // push the image
  37. out, _, err = dockerCmdWithError("push", repoAndTag)
  38. c.Assert(err, checker.IsNil, check.Commentf("pushing the image to the private registry has failed: %s", out))
  39. // delete our local repo that we previously tagged
  40. rmiout, _, err := dockerCmdWithError("rmi", repoAndTag)
  41. c.Assert(err, checker.IsNil, check.Commentf("error deleting images prior to real test: %s", rmiout))
  42. matches := pushDigestRegex.FindStringSubmatch(out)
  43. c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from push output: %s", out))
  44. pushDigest := matches[1]
  45. return digest.Digest(pushDigest), nil
  46. }
  47. func testPullByTagDisplaysDigest(c *check.C) {
  48. testRequires(c, DaemonIsLinux)
  49. pushDigest, err := setupImage(c)
  50. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  51. // pull from the registry using the tag
  52. out, _ := dockerCmd(c, "pull", repoName)
  53. // the pull output includes "Digest: <digest>", so find that
  54. matches := digestRegex.FindStringSubmatch(out)
  55. c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from pull output: %s", out))
  56. pullDigest := matches[1]
  57. // make sure the pushed and pull digests match
  58. c.Assert(pushDigest.String(), checker.Equals, pullDigest)
  59. }
  60. func (s *DockerRegistrySuite) TestPullByTagDisplaysDigest(c *check.C) {
  61. testPullByTagDisplaysDigest(c)
  62. }
  63. func (s *DockerSchema1RegistrySuite) TestPullByTagDisplaysDigest(c *check.C) {
  64. testPullByTagDisplaysDigest(c)
  65. }
  66. func testPullByDigest(c *check.C) {
  67. testRequires(c, DaemonIsLinux)
  68. pushDigest, err := setupImage(c)
  69. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  70. // pull from the registry using the <name>@<digest> reference
  71. imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
  72. out, _ := dockerCmd(c, "pull", imageReference)
  73. // the pull output includes "Digest: <digest>", so find that
  74. matches := digestRegex.FindStringSubmatch(out)
  75. c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from pull output: %s", out))
  76. pullDigest := matches[1]
  77. // make sure the pushed and pull digests match
  78. c.Assert(pushDigest.String(), checker.Equals, pullDigest)
  79. }
  80. func (s *DockerRegistrySuite) TestPullByDigest(c *check.C) {
  81. testPullByDigest(c)
  82. }
  83. func (s *DockerSchema1RegistrySuite) TestPullByDigest(c *check.C) {
  84. testPullByDigest(c)
  85. }
  86. func testPullByDigestNoFallback(c *check.C) {
  87. testRequires(c, DaemonIsLinux)
  88. // pull from the registry using the <name>@<digest> reference
  89. imageReference := fmt.Sprintf("%s@sha256:ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff", repoName)
  90. out, _, err := dockerCmdWithError("pull", imageReference)
  91. c.Assert(err, checker.NotNil, check.Commentf("expected non-zero exit status and correct error message when pulling non-existing image"))
  92. c.Assert(out, checker.Contains, "manifest unknown", check.Commentf("expected non-zero exit status and correct error message when pulling non-existing image"))
  93. }
  94. func (s *DockerRegistrySuite) TestPullByDigestNoFallback(c *check.C) {
  95. testPullByDigestNoFallback(c)
  96. }
  97. func (s *DockerSchema1RegistrySuite) TestPullByDigestNoFallback(c *check.C) {
  98. testPullByDigestNoFallback(c)
  99. }
  100. func (s *DockerRegistrySuite) TestCreateByDigest(c *check.C) {
  101. pushDigest, err := setupImage(c)
  102. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  103. imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
  104. containerName := "createByDigest"
  105. out, _ := dockerCmd(c, "create", "--name", containerName, imageReference)
  106. res, err := inspectField(containerName, "Config.Image")
  107. c.Assert(err, checker.IsNil, check.Commentf("failed to get Config.Image: %s", out))
  108. c.Assert(res, checker.Equals, imageReference)
  109. }
  110. func (s *DockerRegistrySuite) TestRunByDigest(c *check.C) {
  111. pushDigest, err := setupImage(c)
  112. c.Assert(err, checker.IsNil)
  113. imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
  114. containerName := "runByDigest"
  115. out, _ := dockerCmd(c, "run", "--name", containerName, imageReference, "sh", "-c", "echo found=$digest")
  116. foundRegex := regexp.MustCompile("found=([^\n]+)")
  117. matches := foundRegex.FindStringSubmatch(out)
  118. c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from pull output: %s", out))
  119. c.Assert(matches[1], checker.Equals, "1", check.Commentf("Expected %q, got %q", "1", matches[1]))
  120. res, err := inspectField(containerName, "Config.Image")
  121. c.Assert(err, checker.IsNil, check.Commentf("failed to get Config.Image: %s", out))
  122. c.Assert(res, checker.Equals, imageReference)
  123. }
  124. func (s *DockerRegistrySuite) TestRemoveImageByDigest(c *check.C) {
  125. digest, err := setupImage(c)
  126. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  127. imageReference := fmt.Sprintf("%s@%s", repoName, digest)
  128. // pull from the registry using the <name>@<digest> reference
  129. dockerCmd(c, "pull", imageReference)
  130. // make sure inspect runs ok
  131. _, err = inspectField(imageReference, "Id")
  132. c.Assert(err, checker.IsNil, check.Commentf("failed to inspect image"))
  133. // do the delete
  134. err = deleteImages(imageReference)
  135. c.Assert(err, checker.IsNil, check.Commentf("unexpected error deleting image"))
  136. // try to inspect again - it should error this time
  137. _, err = inspectField(imageReference, "Id")
  138. //unexpected nil err trying to inspect what should be a non-existent image
  139. c.Assert(err, checker.NotNil)
  140. c.Assert(err.Error(), checker.Contains, "No such image")
  141. }
  142. func (s *DockerRegistrySuite) TestBuildByDigest(c *check.C) {
  143. digest, err := setupImage(c)
  144. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  145. imageReference := fmt.Sprintf("%s@%s", repoName, digest)
  146. // pull from the registry using the <name>@<digest> reference
  147. dockerCmd(c, "pull", imageReference)
  148. // get the image id
  149. imageID, err := inspectField(imageReference, "Id")
  150. c.Assert(err, checker.IsNil, check.Commentf("error getting image id"))
  151. // do the build
  152. name := "buildbydigest"
  153. _, err = buildImage(name, fmt.Sprintf(
  154. `FROM %s
  155. CMD ["/bin/echo", "Hello World"]`, imageReference),
  156. true)
  157. c.Assert(err, checker.IsNil)
  158. // get the build's image id
  159. res, err := inspectField(name, "Config.Image")
  160. c.Assert(err, checker.IsNil)
  161. // make sure they match
  162. c.Assert(res, checker.Equals, imageID)
  163. }
  164. func (s *DockerRegistrySuite) TestTagByDigest(c *check.C) {
  165. digest, err := setupImage(c)
  166. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  167. imageReference := fmt.Sprintf("%s@%s", repoName, digest)
  168. // pull from the registry using the <name>@<digest> reference
  169. dockerCmd(c, "pull", imageReference)
  170. // tag it
  171. tag := "tagbydigest"
  172. dockerCmd(c, "tag", imageReference, tag)
  173. expectedID, err := inspectField(imageReference, "Id")
  174. c.Assert(err, checker.IsNil, check.Commentf("error getting original image id"))
  175. tagID, err := inspectField(tag, "Id")
  176. c.Assert(err, checker.IsNil, check.Commentf("error getting tagged image id"))
  177. c.Assert(tagID, checker.Equals, expectedID)
  178. }
  179. func (s *DockerRegistrySuite) TestListImagesWithoutDigests(c *check.C) {
  180. digest, err := setupImage(c)
  181. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  182. imageReference := fmt.Sprintf("%s@%s", repoName, digest)
  183. // pull from the registry using the <name>@<digest> reference
  184. dockerCmd(c, "pull", imageReference)
  185. out, _ := dockerCmd(c, "images")
  186. c.Assert(out, checker.Not(checker.Contains), "DIGEST", check.Commentf("list output should not have contained DIGEST header"))
  187. }
  188. func (s *DockerRegistrySuite) TestListImagesWithDigests(c *check.C) {
  189. // setup image1
  190. digest1, err := setupImageWithTag(c, "tag1")
  191. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  192. imageReference1 := fmt.Sprintf("%s@%s", repoName, digest1)
  193. c.Logf("imageReference1 = %s", imageReference1)
  194. // pull image1 by digest
  195. dockerCmd(c, "pull", imageReference1)
  196. // list images
  197. out, _ := dockerCmd(c, "images", "--digests")
  198. // make sure repo shown, tag=<none>, digest = $digest1
  199. re1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1.String() + `\s`)
  200. c.Assert(re1.MatchString(out), checker.True, check.Commentf("expected %q: %s", re1.String(), out))
  201. // setup image2
  202. digest2, err := setupImageWithTag(c, "tag2")
  203. //error setting up image
  204. c.Assert(err, checker.IsNil)
  205. imageReference2 := fmt.Sprintf("%s@%s", repoName, digest2)
  206. c.Logf("imageReference2 = %s", imageReference2)
  207. // pull image1 by digest
  208. dockerCmd(c, "pull", imageReference1)
  209. // pull image2 by digest
  210. dockerCmd(c, "pull", imageReference2)
  211. // list images
  212. out, _ = dockerCmd(c, "images", "--digests")
  213. // make sure repo shown, tag=<none>, digest = $digest1
  214. c.Assert(re1.MatchString(out), checker.True, check.Commentf("expected %q: %s", re1.String(), out))
  215. // make sure repo shown, tag=<none>, digest = $digest2
  216. re2 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest2.String() + `\s`)
  217. c.Assert(re2.MatchString(out), checker.True, check.Commentf("expected %q: %s", re2.String(), out))
  218. // pull tag1
  219. dockerCmd(c, "pull", repoName+":tag1")
  220. // list images
  221. out, _ = dockerCmd(c, "images", "--digests")
  222. // make sure image 1 has repo, tag, <none> AND repo, <none>, digest
  223. reWithTag1 := regexp.MustCompile(`\s*` + repoName + `\s*tag1\s*<none>\s`)
  224. reWithDigest1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1.String() + `\s`)
  225. c.Assert(reWithDigest1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest1.String(), out))
  226. c.Assert(reWithTag1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithTag1.String(), out))
  227. // make sure image 2 has repo, <none>, digest
  228. c.Assert(re2.MatchString(out), checker.True, check.Commentf("expected %q: %s", re2.String(), out))
  229. // pull tag 2
  230. dockerCmd(c, "pull", repoName+":tag2")
  231. // list images
  232. out, _ = dockerCmd(c, "images", "--digests")
  233. // make sure image 1 has repo, tag, digest
  234. c.Assert(reWithTag1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithTag1.String(), out))
  235. // make sure image 2 has repo, tag, digest
  236. reWithTag2 := regexp.MustCompile(`\s*` + repoName + `\s*tag2\s*<none>\s`)
  237. reWithDigest2 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest2.String() + `\s`)
  238. c.Assert(reWithTag2.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithTag2.String(), out))
  239. c.Assert(reWithDigest2.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest2.String(), out))
  240. // list images
  241. out, _ = dockerCmd(c, "images", "--digests")
  242. // make sure image 1 has repo, tag, digest
  243. c.Assert(reWithTag1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithTag1.String(), out))
  244. // make sure image 2 has repo, tag, digest
  245. c.Assert(reWithTag2.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithTag2.String(), out))
  246. // make sure busybox has tag, but not digest
  247. busyboxRe := regexp.MustCompile(`\s*busybox\s*latest\s*<none>\s`)
  248. c.Assert(busyboxRe.MatchString(out), checker.True, check.Commentf("expected %q: %s", busyboxRe.String(), out))
  249. }
  250. func (s *DockerRegistrySuite) TestInspectImageWithDigests(c *check.C) {
  251. digest, err := setupImage(c)
  252. c.Assert(err, check.IsNil, check.Commentf("error setting up image"))
  253. imageReference := fmt.Sprintf("%s@%s", repoName, digest)
  254. // pull from the registry using the <name>@<digest> reference
  255. dockerCmd(c, "pull", imageReference)
  256. out, _ := dockerCmd(c, "inspect", imageReference)
  257. var imageJSON []types.ImageInspect
  258. err = json.Unmarshal([]byte(out), &imageJSON)
  259. c.Assert(err, checker.IsNil)
  260. c.Assert(imageJSON, checker.HasLen, 1)
  261. c.Assert(imageJSON[0].RepoDigests, checker.HasLen, 1)
  262. c.Assert(stringutils.InSlice(imageJSON[0].RepoDigests, imageReference), checker.Equals, true)
  263. }
  264. func (s *DockerRegistrySuite) TestPsListContainersFilterAncestorImageByDigest(c *check.C) {
  265. digest, err := setupImage(c)
  266. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  267. imageReference := fmt.Sprintf("%s@%s", repoName, digest)
  268. // pull from the registry using the <name>@<digest> reference
  269. dockerCmd(c, "pull", imageReference)
  270. // build a image from it
  271. imageName1 := "images_ps_filter_test"
  272. _, err = buildImage(imageName1, fmt.Sprintf(
  273. `FROM %s
  274. LABEL match me 1`, imageReference), true)
  275. c.Assert(err, checker.IsNil)
  276. // run a container based on that
  277. out, _ := dockerCmd(c, "run", "-d", imageReference, "echo", "hello")
  278. expectedID := strings.TrimSpace(out)
  279. // run a container based on the a descendant of that too
  280. out, _ = dockerCmd(c, "run", "-d", imageName1, "echo", "hello")
  281. expectedID1 := strings.TrimSpace(out)
  282. expectedIDs := []string{expectedID, expectedID1}
  283. // Invalid imageReference
  284. out, _ = dockerCmd(c, "ps", "-a", "-q", "--no-trunc", fmt.Sprintf("--filter=ancestor=busybox@%s", digest))
  285. // Filter container for ancestor filter should be empty
  286. c.Assert(strings.TrimSpace(out), checker.Equals, "")
  287. // Valid imageReference
  288. out, _ = dockerCmd(c, "ps", "-a", "-q", "--no-trunc", "--filter=ancestor="+imageReference)
  289. checkPsAncestorFilterOutput(c, out, imageReference, expectedIDs)
  290. }
  291. func (s *DockerRegistrySuite) TestDeleteImageByIDOnlyPulledByDigest(c *check.C) {
  292. pushDigest, err := setupImage(c)
  293. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  294. // pull from the registry using the <name>@<digest> reference
  295. imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
  296. dockerCmd(c, "pull", imageReference)
  297. // just in case...
  298. imageID, err := inspectField(imageReference, "Id")
  299. c.Assert(err, checker.IsNil, check.Commentf("error inspecting image id"))
  300. dockerCmd(c, "rmi", imageID)
  301. }
  302. func (s *DockerRegistrySuite) TestDeleteImageWithDigestAndTag(c *check.C) {
  303. pushDigest, err := setupImage(c)
  304. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  305. // pull from the registry using the <name>@<digest> reference
  306. imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
  307. dockerCmd(c, "pull", imageReference)
  308. imageID, err := inspectField(imageReference, "Id")
  309. c.Assert(err, checker.IsNil, check.Commentf("error inspecting image id"))
  310. repoTag := repoName + ":sometag"
  311. repoTag2 := repoName + ":othertag"
  312. dockerCmd(c, "tag", imageReference, repoTag)
  313. dockerCmd(c, "tag", imageReference, repoTag2)
  314. dockerCmd(c, "rmi", repoTag2)
  315. // rmi should have deleted only repoTag2, because there's another tag
  316. _, err = inspectField(repoTag, "Id")
  317. c.Assert(err, checker.IsNil, check.Commentf("repoTag should not have been removed"))
  318. dockerCmd(c, "rmi", repoTag)
  319. // rmi should have deleted the tag, the digest reference, and the image itself
  320. _, err = inspectField(imageID, "Id")
  321. c.Assert(err, checker.NotNil, check.Commentf("image should have been deleted"))
  322. }
  323. // TestPullFailsWithAlteredManifest tests that a `docker pull` fails when
  324. // we have modified a manifest blob and its digest cannot be verified.
  325. // This is the schema2 version of the test.
  326. func (s *DockerRegistrySuite) TestPullFailsWithAlteredManifest(c *check.C) {
  327. testRequires(c, DaemonIsLinux)
  328. manifestDigest, err := setupImage(c)
  329. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  330. // Load the target manifest blob.
  331. manifestBlob := s.reg.readBlobContents(c, manifestDigest)
  332. var imgManifest schema2.Manifest
  333. err = json.Unmarshal(manifestBlob, &imgManifest)
  334. c.Assert(err, checker.IsNil, check.Commentf("unable to decode image manifest from blob"))
  335. // Change a layer in the manifest.
  336. imgManifest.Layers[0].Digest = digest.Digest("sha256:0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef")
  337. // Move the existing data file aside, so that we can replace it with a
  338. // malicious blob of data. NOTE: we defer the returned undo func.
  339. undo := s.reg.tempMoveBlobData(c, manifestDigest)
  340. defer undo()
  341. alteredManifestBlob, err := json.MarshalIndent(imgManifest, "", " ")
  342. c.Assert(err, checker.IsNil, check.Commentf("unable to encode altered image manifest to JSON"))
  343. s.reg.writeBlobContents(c, manifestDigest, alteredManifestBlob)
  344. // Now try pulling that image by digest. We should get an error about
  345. // digest verification for the manifest digest.
  346. // Pull from the registry using the <name>@<digest> reference.
  347. imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
  348. out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
  349. c.Assert(exitStatus, checker.Not(check.Equals), 0)
  350. expectedErrorMsg := fmt.Sprintf("manifest verification failed for digest %s", manifestDigest)
  351. c.Assert(out, checker.Contains, expectedErrorMsg)
  352. }
  353. // TestPullFailsWithAlteredManifest tests that a `docker pull` fails when
  354. // we have modified a manifest blob and its digest cannot be verified.
  355. // This is the schema1 version of the test.
  356. func (s *DockerSchema1RegistrySuite) TestPullFailsWithAlteredManifest(c *check.C) {
  357. testRequires(c, DaemonIsLinux)
  358. manifestDigest, err := setupImage(c)
  359. c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
  360. // Load the target manifest blob.
  361. manifestBlob := s.reg.readBlobContents(c, manifestDigest)
  362. var imgManifest schema1.Manifest
  363. err = json.Unmarshal(manifestBlob, &imgManifest)
  364. c.Assert(err, checker.IsNil, check.Commentf("unable to decode image manifest from blob"))
  365. // Change a layer in the manifest.
  366. imgManifest.FSLayers[0] = schema1.FSLayer{
  367. BlobSum: digest.Digest("sha256:0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef"),
  368. }
  369. // Move the existing data file aside, so that we can replace it with a
  370. // malicious blob of data. NOTE: we defer the returned undo func.
  371. undo := s.reg.tempMoveBlobData(c, manifestDigest)
  372. defer undo()
  373. alteredManifestBlob, err := json.MarshalIndent(imgManifest, "", " ")
  374. c.Assert(err, checker.IsNil, check.Commentf("unable to encode altered image manifest to JSON"))
  375. s.reg.writeBlobContents(c, manifestDigest, alteredManifestBlob)
  376. // Now try pulling that image by digest. We should get an error about
  377. // digest verification for the manifest digest.
  378. // Pull from the registry using the <name>@<digest> reference.
  379. imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
  380. out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
  381. c.Assert(exitStatus, checker.Not(check.Equals), 0)
  382. expectedErrorMsg := fmt.Sprintf("image verification failed for digest %s", manifestDigest)
  383. c.Assert(out, checker.Contains, expectedErrorMsg)
  384. }
  385. // TestPullFailsWithAlteredLayer tests that a `docker pull` fails when
  386. // we have modified a layer blob and its digest cannot be verified.
  387. // This is the schema2 version of the test.
  388. func (s *DockerRegistrySuite) TestPullFailsWithAlteredLayer(c *check.C) {
  389. testRequires(c, DaemonIsLinux)
  390. manifestDigest, err := setupImage(c)
  391. c.Assert(err, checker.IsNil)
  392. // Load the target manifest blob.
  393. manifestBlob := s.reg.readBlobContents(c, manifestDigest)
  394. var imgManifest schema2.Manifest
  395. err = json.Unmarshal(manifestBlob, &imgManifest)
  396. c.Assert(err, checker.IsNil)
  397. // Next, get the digest of one of the layers from the manifest.
  398. targetLayerDigest := imgManifest.Layers[0].Digest
  399. // Move the existing data file aside, so that we can replace it with a
  400. // malicious blob of data. NOTE: we defer the returned undo func.
  401. undo := s.reg.tempMoveBlobData(c, targetLayerDigest)
  402. defer undo()
  403. // Now make a fake data blob in this directory.
  404. s.reg.writeBlobContents(c, targetLayerDigest, []byte("This is not the data you are looking for."))
  405. // Now try pulling that image by digest. We should get an error about
  406. // digest verification for the target layer digest.
  407. // Remove distribution cache to force a re-pull of the blobs
  408. if err := os.RemoveAll(filepath.Join(dockerBasePath, "image", s.d.storageDriver, "distribution")); err != nil {
  409. c.Fatalf("error clearing distribution cache: %v", err)
  410. }
  411. // Pull from the registry using the <name>@<digest> reference.
  412. imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
  413. out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
  414. c.Assert(exitStatus, checker.Not(check.Equals), 0, check.Commentf("expected a zero exit status"))
  415. expectedErrorMsg := fmt.Sprintf("filesystem layer verification failed for digest %s", targetLayerDigest)
  416. c.Assert(out, checker.Contains, expectedErrorMsg, check.Commentf("expected error message in output: %s", out))
  417. }
  418. // TestPullFailsWithAlteredLayer tests that a `docker pull` fails when
  419. // we have modified a layer blob and its digest cannot be verified.
  420. // This is the schema1 version of the test.
  421. func (s *DockerSchema1RegistrySuite) TestPullFailsWithAlteredLayer(c *check.C) {
  422. testRequires(c, DaemonIsLinux)
  423. manifestDigest, err := setupImage(c)
  424. c.Assert(err, checker.IsNil)
  425. // Load the target manifest blob.
  426. manifestBlob := s.reg.readBlobContents(c, manifestDigest)
  427. var imgManifest schema1.Manifest
  428. err = json.Unmarshal(manifestBlob, &imgManifest)
  429. c.Assert(err, checker.IsNil)
  430. // Next, get the digest of one of the layers from the manifest.
  431. targetLayerDigest := imgManifest.FSLayers[0].BlobSum
  432. // Move the existing data file aside, so that we can replace it with a
  433. // malicious blob of data. NOTE: we defer the returned undo func.
  434. undo := s.reg.tempMoveBlobData(c, targetLayerDigest)
  435. defer undo()
  436. // Now make a fake data blob in this directory.
  437. s.reg.writeBlobContents(c, targetLayerDigest, []byte("This is not the data you are looking for."))
  438. // Now try pulling that image by digest. We should get an error about
  439. // digest verification for the target layer digest.
  440. // Remove distribution cache to force a re-pull of the blobs
  441. if err := os.RemoveAll(filepath.Join(dockerBasePath, "image", s.d.storageDriver, "distribution")); err != nil {
  442. c.Fatalf("error clearing distribution cache: %v", err)
  443. }
  444. // Pull from the registry using the <name>@<digest> reference.
  445. imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
  446. out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
  447. c.Assert(exitStatus, checker.Not(check.Equals), 0, check.Commentf("expected a zero exit status"))
  448. expectedErrorMsg := fmt.Sprintf("filesystem layer verification failed for digest %s", targetLayerDigest)
  449. c.Assert(out, checker.Contains, expectedErrorMsg, check.Commentf("expected error message in output: %s", out))
  450. }